)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"82b23f811d9752488aabeb5ac491f79c07231452","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3f1b70b78b91bfac9af5fadb71140679b208c999"},{"line_number":15,"context_line":"Closes-bug: #1381298"},{"line_number":16,"context_line":"Related-bug: #1376562"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baa201ad_63bef6af","line":16,"updated":"2014-10-16 12:38:15.000000000","message":"If you do another iteration, we could probably make this Closes-Bug for 1376562, or mark your bug a duplicate of 1376562 if you prefer.","commit_id":"79b360cc589741d40bb0f914eb28029d12b61d54"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"7252775b27c2255ff86028e3a2d359e63c995129","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3f1b70b78b91bfac9af5fadb71140679b208c999"},{"line_number":15,"context_line":"Closes-bug: #1381298"},{"line_number":16,"context_line":"Related-bug: #1376562"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baa201ad_389ec607","line":16,"in_reply_to":"baa201ad_63bef6af","updated":"2014-10-17 06:39:54.000000000","message":"Done","commit_id":"79b360cc589741d40bb0f914eb28029d12b61d54"}],"heat/common/config.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"82b23f811d9752488aabeb5ac491f79c07231452","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to heat.\u0027"},{"line_number":110,"context_line":"                       \u0027 The default value of this option is changed\u0027"},{"line_number":111,"context_line":"                       \u0027 to [] in Kilo, which means Heat will delegate all\u0027"},{"line_number":112,"context_line":"                       \u0027 roles of trustor unless you set this option.\u0027)),"},{"line_number":113,"context_line":"    cfg.IntOpt(\u0027max_resources_per_stack\u0027,"},{"line_number":114,"context_line":"               default\u003d1000,"},{"line_number":115,"context_line":"               help\u003d_(\u0027Maximum resources allowed per top-level stack.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_837afaee","line":112,"updated":"2014-10-16 12:38:15.000000000","message":"I think the warning achieves the upgrade-to-kilo message, probably combined with something in the release notes - I\u0027m not sure if we really need it in the help string, so this could just be:\n\n\"Subset of trustor roles to be delegated to heat.  If left unset, all roles of a user will be delegated to heat when creating a stack\"","commit_id":"79b360cc589741d40bb0f914eb28029d12b61d54"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"7252775b27c2255ff86028e3a2d359e63c995129","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to heat.\u0027"},{"line_number":110,"context_line":"                       \u0027 The default value of this option is changed\u0027"},{"line_number":111,"context_line":"                       \u0027 to [] in Kilo, which means Heat will delegate all\u0027"},{"line_number":112,"context_line":"                       \u0027 roles of trustor unless you set this option.\u0027)),"},{"line_number":113,"context_line":"    cfg.IntOpt(\u0027max_resources_per_stack\u0027,"},{"line_number":114,"context_line":"               default\u003d1000,"},{"line_number":115,"context_line":"               help\u003d_(\u0027Maximum resources allowed per top-level stack.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_69b88275","line":112,"in_reply_to":"baa201ad_837afaee","updated":"2014-10-17 06:39:54.000000000","message":"Done","commit_id":"79b360cc589741d40bb0f914eb28029d12b61d54"}],"heat/common/heat_keystoneclient.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"7b497fd8a31b9a665236a14136922bc7366ab7fc","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        # for same actions(such as create instance with an external network"},{"line_number":280,"context_line":"        # which check in nova)"},{"line_number":281,"context_line":"        roles \u003d list("},{"line_number":282,"context_line":"            set(cfg.CONF.trusts_delegated_roles + self.context.roles))"},{"line_number":283,"context_line":"        try:"},{"line_number":284,"context_line":"            trust \u003d self.client.trusts.create(trustor_user\u003dtrustor_user_id,"},{"line_number":285,"context_line":"                                              trustee_user\u003dtrustee_user_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_91550b20","line":282,"updated":"2014-10-15 08:28:12.000000000","message":"I think the set part of this doesn\u0027t really achieve anything, because self.context.roles must contain trusts_delegated_roles anyway, or creating the trust will fail.\n\nWhat I was thinking is we\u0027d switch the trusts_delegated_roles to empty in the config, and unless it is set we delegate all of self.context.roles.  This would allow deployers to specify a subset of roles if they wish, but by default we delegate all of them.\n\nPossibly we should just deprecate trusts_delegated_roles, with a warning in the logs so deployers know they should remove/unset it on existing heat deployments when upgrading?","commit_id":"ba5811e2680026f7b38d24ad1a268f4cbaa003c8"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"dd1ac4cfab33d7316d5e5c7f176e71cbef000c53","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        # for same actions(such as create instance with an external network"},{"line_number":280,"context_line":"        # which check in nova)"},{"line_number":281,"context_line":"        roles \u003d list("},{"line_number":282,"context_line":"            set(cfg.CONF.trusts_delegated_roles + self.context.roles))"},{"line_number":283,"context_line":"        try:"},{"line_number":284,"context_line":"            trust \u003d self.client.trusts.create(trustor_user\u003dtrustor_user_id,"},{"line_number":285,"context_line":"                                              trustee_user\u003dtrustee_user_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_572c5799","line":282,"in_reply_to":"baa201ad_91550b20","updated":"2014-10-16 02:11:38.000000000","message":"Hi shardy, sorry for reply you late. I have been in a meeting yesterday afternoon.\nYou are right, the self.context.roles must contain trusts_delegated_roles. And your suggestion sounds good.","commit_id":"ba5811e2680026f7b38d24ad1a268f4cbaa003c8"}],"heat/tests/test_heatclient.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"82b23f811d9752488aabeb5ac491f79c07231452","unresolved":false,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        self._stubs_v3()"},{"line_number":512,"context_line":"        cfg.CONF.set_override(\u0027deferred_auth_method\u0027, \u0027trusts\u0027)"},{"line_number":513,"context_line":"        cfg.CONF.set_override(\u0027trusts_delegated_roles\u0027, delegate_roles)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        trustor_roles \u003d [\u0027heat_stack_owner\u0027, \u0027admin\u0027, \u0027__member__\u0027]"},{"line_number":516,"context_line":"        trustee_roles \u003d delegate_roles or trustor_roles"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_83ef5a86","line":513,"updated":"2014-10-16 12:38:15.000000000","message":"I\u0027d prefer we only set the override for trusts_delegated_roles when delegate_roles is set (e.g make it None and just do if delegate_roles) - this way we prove the config default is (and remains) as expected.","commit_id":"79b360cc589741d40bb0f914eb28029d12b61d54"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"7252775b27c2255ff86028e3a2d359e63c995129","unresolved":false,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        self._stubs_v3()"},{"line_number":512,"context_line":"        cfg.CONF.set_override(\u0027deferred_auth_method\u0027, \u0027trusts\u0027)"},{"line_number":513,"context_line":"        cfg.CONF.set_override(\u0027trusts_delegated_roles\u0027, delegate_roles)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        trustor_roles \u003d [\u0027heat_stack_owner\u0027, \u0027admin\u0027, \u0027__member__\u0027]"},{"line_number":516,"context_line":"        trustee_roles \u003d delegate_roles or trustor_roles"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_0477dba0","line":513,"in_reply_to":"baa201ad_83ef5a86","updated":"2014-10-17 06:39:54.000000000","message":"Done","commit_id":"79b360cc589741d40bb0f914eb28029d12b61d54"}]}
