)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"110e0b4b377ca0a0f34444ea85f19d16bc03a90c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass status reason when trove misbehaves"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pass a helpful message when the cloud database fails to initialize"},{"line_number":10,"context_line":"successfully. Initialized messages for all codes only though only"},{"line_number":11,"context_line":"3 are required for error reporting."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_98977e47","line":9,"updated":"2014-10-28 21:11:20.000000000","message":"s/cloud database/trove","commit_id":"95b0ff73a0c543546dbc187fcfe7f5495da8601b"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"110e0b4b377ca0a0f34444ea85f19d16bc03a90c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Pass status reason when trove misbehaves"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pass a helpful message when the cloud database fails to initialize"},{"line_number":10,"context_line":"successfully. Initialized messages for all codes only though only"},{"line_number":11,"context_line":"3 are required for error reporting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0c0d3b44640130b80734464af93151387d513f5a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_d89d8667","line":10,"updated":"2014-10-28 21:11:20.000000000","message":"s/only though/even though","commit_id":"95b0ff73a0c543546dbc187fcfe7f5495da8601b"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"110e0b4b377ca0a0f34444ea85f19d16bc03a90c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"3 are required for error reporting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0c0d3b44640130b80734464af93151387d513f5a"},{"line_number":14,"context_line":"Closes-bug: #763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_f86faa5d","line":14,"updated":"2014-10-28 21:11:20.000000000","message":"This isn\u0027t the correct LaunchPad bug number. Is there a LaunchPad bug for this? If not, there probably should be.","commit_id":"95b0ff73a0c543546dbc187fcfe7f5495da8601b"}],"heat/engine/resources/os_database.py":[{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"cca692041d40067b5f313a9375e0f3b0fef08427","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        if instance.status in self.BAD_STATUSES:"},{"line_number":358,"context_line":"            raise resource.ResourceInError("},{"line_number":359,"context_line":"                resource_status\u003dinstance.status,"},{"line_number":360,"context_line":"                status_reason\u003dTROVE_STATUS_REASON[instance.status])"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if instance.status !\u003d self.ACTIVE:"},{"line_number":363,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_18638e42","line":360,"updated":"2014-10-28 21:17:30.000000000","message":"Since you don\u0027t have every status covered above, you should probably use .get(instance.status, \"Unknown\") instead.","commit_id":"119cdc7e1c990e494fcdfabf98b07c63bfd3cf0e"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"47c04b934a18662c8b0d711c5db5b12cec7efa99","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED:"},{"line_number":46,"context_line":"            \u0027database instance was created, but failed to set up the datastore.\u0027"},{"line_number":47,"context_line":"            \u0027If a database instance is in the FAILED state, you should delete\u0027"},{"line_number":48,"context_line":"            \u0027it and create a new instance.\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_f246e64e","line":45,"updated":"2014-10-28 22:41:49.000000000","message":"You need to define FAILED and ERROR somewhere, maybe in TROVE_STATUS?","commit_id":"fd91c28fab4dd6ce1e4b49c35e890fe67c8ff324"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"ae80a0308c40f7c316f45d28cddfec3c0479a0b5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED:"},{"line_number":46,"context_line":"            \u0027database instance was created, but failed to set up the datastore.\u0027"},{"line_number":47,"context_line":"            \u0027If a database instance is in the FAILED state, you should delete\u0027"},{"line_number":48,"context_line":"            \u0027it and create a new instance.\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_32e14ed1","line":45,"in_reply_to":"9aa7fdbe_f246e64e","updated":"2014-10-28 22:59:40.000000000","message":"FAILED is defined above, but ERROR does seem to be missing.","commit_id":"fd91c28fab4dd6ce1e4b49c35e890fe67c8ff324"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"47c04b934a18662c8b0d711c5db5b12cec7efa99","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED:"},{"line_number":46,"context_line":"            \u0027database instance was created, but failed to set up the datastore.\u0027"},{"line_number":47,"context_line":"            \u0027If a database instance is in the FAILED state, you should delete\u0027"},{"line_number":48,"context_line":"            \u0027it and create a new instance.\u0027,"},{"line_number":49,"context_line":"        ERROR:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_8f23b5bd","line":46,"updated":"2014-10-28 22:41:49.000000000","message":"Please cut the line (79 chars max), and also add a space after the dot, as the strings will be directly concatenated.","commit_id":"fd91c28fab4dd6ce1e4b49c35e890fe67c8ff324"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"47c04b934a18662c8b0d711c5db5b12cec7efa99","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED:"},{"line_number":46,"context_line":"            \u0027database instance was created, but failed to set up the datastore.\u0027"},{"line_number":47,"context_line":"            \u0027If a database instance is in the FAILED state, you should delete\u0027"},{"line_number":48,"context_line":"            \u0027it and create a new instance.\u0027,"},{"line_number":49,"context_line":"        ERROR:"},{"line_number":50,"context_line":"            \u0027last operation for the database instance failed due to an error.\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_ef2a818f","line":47,"updated":"2014-10-28 22:41:49.000000000","message":"same here after \u0027delete\u0027, a space is needed otherwise the message will be \u0027... should deleteit and...\u0027","commit_id":"fd91c28fab4dd6ce1e4b49c35e890fe67c8ff324"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"96cf7455733ecf373300f7eb1757ea7eff9e16b2","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED:"},{"line_number":46,"context_line":"            \u0027database instance was created, but failed to set up the\u0027"},{"line_number":47,"context_line":"            \u0027datastore. If a database instance is in the FAILED state, \u0027"},{"line_number":48,"context_line":"            \u0027you should delete it and create a new instance.\u0027,"},{"line_number":49,"context_line":"        ERROR:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_01786c2a","line":46,"updated":"2014-10-29 13:06:11.000000000","message":"The space problem is still here. When concatenated, the strings will form: \u0027\u0027set up thedatastore.\n\nAlso, please use capitals at the beginning of sentences.","commit_id":"5d759c3cfaff876517830cdf58fed304085cc5d3"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"2dde63eda725b3f24e8bc0a3a3dd4e28547da324","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027RESTART_REQUIRED\u0027, \u0027SHUTDOWN\u0027, \u0027ERROR\u0027,"},{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED:"},{"line_number":46,"context_line":"            \u0027database instance was created, but failed to set up the \u0027"},{"line_number":47,"context_line":"            \u0027datastore. If a database instance is in the FAILED state, \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8c0949_3069328c","line":44,"updated":"2014-10-30 14:53:49.000000000","message":"I think this messages should be localizable, so please include them in _()","commit_id":"4665746bda20b696995e0a0f48d3b6131d7a7dfe"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"5d3b613b37f7dfdc028ad8fa935d0e8375629a1a","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED:"},{"line_number":46,"context_line":"            \u0027database instance was created, but failed to set up the \u0027"},{"line_number":47,"context_line":"            \u0027datastore. If a database instance is in the FAILED state, \u0027"},{"line_number":48,"context_line":"            \u0027you should delete it and create a new instance.\u0027,"},{"line_number":49,"context_line":"        ERROR:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa7fdbe_aa0e95e3","line":46,"updated":"2014-10-29 14:28:18.000000000","message":"\u0027database\u0027 should be capitalized.\n\n\u0027but\u0027 is being used as a conjunction, but \"failed to set up the datastore\" is not an independent clause.  It should say \"...but the datastore could not be set up\".","commit_id":"4665746bda20b696995e0a0f48d3b6131d7a7dfe"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"5d3b613b37f7dfdc028ad8fa935d0e8375629a1a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027datastore. If a database instance is in the FAILED state, \u0027"},{"line_number":48,"context_line":"            \u0027you should delete it and create a new instance.\u0027,"},{"line_number":49,"context_line":"        ERROR:"},{"line_number":50,"context_line":"            \u0027last operation for the database instance failed due to an error.\u0027,"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    BAD_STATUSES \u003d (ERROR, FAILED)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa7fdbe_8a09d1df","line":50,"updated":"2014-10-29 14:28:18.000000000","message":"\u0027last\u0027 should be capitalized.","commit_id":"4665746bda20b696995e0a0f48d3b6131d7a7dfe"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"2dde63eda725b3f24e8bc0a3a3dd4e28547da324","unresolved":false,"context_lines":[{"line_number":357,"context_line":"            raise resource.ResourceInError("},{"line_number":358,"context_line":"                resource_status\u003dinstance.status,"},{"line_number":359,"context_line":"                status_reason\u003dself.TROVE_STATUS_REASON.get(instance.status,"},{"line_number":360,"context_line":"                                                      \"Unknown\"))"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if instance.status !\u003d self.ACTIVE:"},{"line_number":363,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8c0949_b02b622f","line":360,"updated":"2014-10-30 14:53:49.000000000","message":"same here. include unknown message in _()","commit_id":"4665746bda20b696995e0a0f48d3b6131d7a7dfe"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"a397ce999b99b581de270882cac07bf9c41d37f3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027RESTART_REQUIRED\u0027, \u0027SHUTDOWN\u0027, \u0027ERROR\u0027,"},{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED: _(\u0027database instance was created, but failed to set up the \u0027"},{"line_number":46,"context_line":"                  \u0027datastore. If a database instance is in the FAILED state, \u0027"},{"line_number":47,"context_line":"                  \u0027you should delete it and create a new instance.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_a8f679d5","line":44,"updated":"2014-11-11 16:00:31.000000000","message":"Since these are complete sentences, Probably need to add \"The\" to the beginning of these messages.","commit_id":"94ae4d7439ec17fb829c957655c06a3c732197d9"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"5b8ff7c1fe4e687d2f4811d79409391a620b4743","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027RESTART_REQUIRED\u0027, \u0027SHUTDOWN\u0027, \u0027ERROR\u0027,"},{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED: _(\u0027database instance was created, but failed to set up the \u0027"},{"line_number":46,"context_line":"                  \u0027datastore. If a database instance is in the FAILED state, \u0027"},{"line_number":47,"context_line":"                  \u0027you should delete it and create a new instance.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_b2bb3f0d","line":44,"in_reply_to":"5a890539_923483df","updated":"2014-11-11 23:05:58.000000000","message":"They get inserted into quotes and should still be proper sentences IMO. If nothing else, a \"the\" at the beginning makes these read more naturally.","commit_id":"94ae4d7439ec17fb829c957655c06a3c732197d9"},{"author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"change_message_id":"7f82b0bf4497b650341c614dbdfaeef88a5657a2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027RESTART_REQUIRED\u0027, \u0027SHUTDOWN\u0027, \u0027ERROR\u0027,"},{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED: _(\u0027database instance was created, but failed to set up the \u0027"},{"line_number":46,"context_line":"                  \u0027datastore. If a database instance is in the FAILED state, \u0027"},{"line_number":47,"context_line":"                  \u0027you should delete it and create a new instance.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_923483df","line":44,"in_reply_to":"5a890539_a8f679d5","updated":"2014-11-11 22:55:35.000000000","message":"The strings here are actually inserted into an error message: https://github.com/openstack/heat/blob/master/heat%2Fengine%2Fresource.py#L59","commit_id":"94ae4d7439ec17fb829c957655c06a3c732197d9"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"e970da5449b4751ee5de0a270ba037011805941a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":45,"context_line":"        FAILED: _(\u0027database instance was created, but failed to set up the \u0027"},{"line_number":46,"context_line":"                  \u0027datastore. If a database instance is in the FAILED state, \u0027"},{"line_number":47,"context_line":"                  \u0027you should delete it and create a new instance.\u0027),"},{"line_number":48,"context_line":"        ERROR: _(\u0027last operation for the database instance failed due to \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_fff1f4cd","line":45,"updated":"2014-11-12 17:53:04.000000000","message":"As I said previously, \"failed to set up the datastore\" is not a complete sentence.  This is incorrect grammar.","commit_id":"94ae4d7439ec17fb829c957655c06a3c732197d9"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"a397ce999b99b581de270882cac07bf9c41d37f3","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            raise resource.ResourceInError("},{"line_number":357,"context_line":"                resource_status\u003dinstance.status,"},{"line_number":358,"context_line":"                status_reason\u003dself.TROVE_STATUS_REASON.get(instance.status,"},{"line_number":359,"context_line":"                                                           \"Unknown\"))"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        if instance.status !\u003d self.ACTIVE:"},{"line_number":362,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_e869618c","line":359,"updated":"2014-11-11 16:00:31.000000000","message":"\"Unknown\" should probably be _(\"Unknown\")","commit_id":"94ae4d7439ec17fb829c957655c06a3c732197d9"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"30f240ad86ae33c906af4d431c3e1210b541e3c8","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    TROVE_STATUS \u003d ("},{"line_number":37,"context_line":"        BUILD, REBOOT, ACTIVE, FAILED, BACKUP, BLOCKED, RESIZE,"},{"line_number":38,"context_line":"        RESTART_REQUIRED, SHUTDOWN, ERROR,"},{"line_number":39,"context_line":"    ) \u003d ("},{"line_number":40,"context_line":"        \u0027BUILD\u0027, \u0027REBOOT\u0027, \u0027ACTIVE\u0027, \u0027FAILED\u0027, \u0027BACKUP\u0027, \u0027BLOCKED\u0027, \u0027RESIZE\u0027,"},{"line_number":41,"context_line":"        \u0027RESTART_REQUIRED\u0027, \u0027SHUTDOWN\u0027, \u0027ERROR\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_884c2672","line":38,"updated":"2014-11-13 08:58:05.000000000","message":"Just a question: What the purpose to add these? I didn\u0027t see where you use them?","commit_id":"1665fd5a05f17bad2c72088f5fd2b258a318f9c8"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"0fd7aada96339d72d7d22a07069f4804308c0167","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":43,"context_line":"        FAILED: _(\u0027the database instance was created, but heat failed to set \u0027"},{"line_number":44,"context_line":"                  \u0027up the datastore. If a database instance is in the FAILED \u0027"},{"line_number":45,"context_line":"                  \u0027state, you should delete it and create a new instance.\u0027),"},{"line_number":46,"context_line":"        ERROR: _(\u0027the last operation for the database instance failed due to \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_ccec8bbe","line":43,"updated":"2014-12-01 18:25:58.000000000","message":"As said in patchset #7, please capitalize punctuated sentences.","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"67c95bddb437b23340744e624a77db0b1240c351","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":43,"context_line":"        FAILED: _(\u0027the database instance was created, but heat failed to set \u0027"},{"line_number":44,"context_line":"                  \u0027up the datastore. If a database instance is in the FAILED \u0027"},{"line_number":45,"context_line":"                  \u0027state, you should delete it and create a new instance.\u0027),"},{"line_number":46,"context_line":"        ERROR: _(\u0027the last operation for the database instance failed due to \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_bee68142","line":43,"in_reply_to":"5a890539_380f09e3","updated":"2014-12-01 20:41:36.000000000","message":"Agree with Jason. The sentences should still be capitalized. Especially because the string contains two sentences, and is surrounded by quotes.","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"1683c33b25a5b7a18c1fee6b35af8a09e3182456","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":43,"context_line":"        FAILED: _(\u0027the database instance was created, but heat failed to set \u0027"},{"line_number":44,"context_line":"                  \u0027up the datastore. If a database instance is in the FAILED \u0027"},{"line_number":45,"context_line":"                  \u0027state, you should delete it and create a new instance.\u0027),"},{"line_number":46,"context_line":"        ERROR: _(\u0027the last operation for the database instance failed due to \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_833ece27","line":43,"in_reply_to":"5a890539_380f09e3","updated":"2014-12-01 20:24:51.000000000","message":"There are double quotes.  We\u0027re saying it should be:\n\n ...due to \"The database instance was created, but heat failed to...\"\n\nInstead of:\n\n ...due to \"the database instance was created, but heat failed to...\"","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"},{"author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"change_message_id":"bfa28f287955101425e0cce84af055c20d76b3ea","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":43,"context_line":"        FAILED: _(\u0027the database instance was created, but heat failed to set \u0027"},{"line_number":44,"context_line":"                  \u0027up the datastore. If a database instance is in the FAILED \u0027"},{"line_number":45,"context_line":"                  \u0027state, you should delete it and create a new instance.\u0027),"},{"line_number":46,"context_line":"        ERROR: _(\u0027the last operation for the database instance failed due to \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_380f09e3","line":43,"in_reply_to":"5a890539_bdc3eb36","updated":"2014-12-01 19:54:11.000000000","message":"The sentences are not capitalized because they are meant to be inserted as part of another statement. If I capitalize here, it won\u0027t be correct english when the error statement is actually printed out.\nhttps://github.com/openstack/heat/blob/master/heat/engine/resource.py#L64.\n\nOne way to make this change might be to change the line https://github.com/openstack/heat/blob/master/heat/engine/resource.py#L64 to end with a colon, so that the full error statement would read:\n\" \u0027due to: the database instance was created, but heat failed to set up the datastore. If a database instance is in the FAILED state, you should delete it and create a new instance.\"","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"9e8048edc7915f3d536aa8bbe76822b5ded5687a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":43,"context_line":"        FAILED: _(\u0027the database instance was created, but heat failed to set \u0027"},{"line_number":44,"context_line":"                  \u0027up the datastore. If a database instance is in the FAILED \u0027"},{"line_number":45,"context_line":"                  \u0027state, you should delete it and create a new instance.\u0027),"},{"line_number":46,"context_line":"        ERROR: _(\u0027the last operation for the database instance failed due to \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_bdc3eb36","line":43,"in_reply_to":"5a890539_ccec8bbe","updated":"2014-12-01 19:22:39.000000000","message":"+1","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"0fd7aada96339d72d7d22a07069f4804308c0167","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        FAILED: _(\u0027the database instance was created, but heat failed to set \u0027"},{"line_number":44,"context_line":"                  \u0027up the datastore. If a database instance is in the FAILED \u0027"},{"line_number":45,"context_line":"                  \u0027state, you should delete it and create a new instance.\u0027),"},{"line_number":46,"context_line":"        ERROR: _(\u0027the last operation for the database instance failed due to \u0027"},{"line_number":47,"context_line":"                 \u0027an error.\u0027),"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_0c2e93fa","line":46,"updated":"2014-12-01 18:25:58.000000000","message":"same here","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"9e8048edc7915f3d536aa8bbe76822b5ded5687a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        FAILED: _(\u0027the database instance was created, but heat failed to set \u0027"},{"line_number":44,"context_line":"                  \u0027up the datastore. If a database instance is in the FAILED \u0027"},{"line_number":45,"context_line":"                  \u0027state, you should delete it and create a new instance.\u0027),"},{"line_number":46,"context_line":"        ERROR: _(\u0027the last operation for the database instance failed due to \u0027"},{"line_number":47,"context_line":"                 \u0027an error.\u0027),"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_ddbef7ad","line":46,"in_reply_to":"5a890539_0c2e93fa","updated":"2014-12-01 19:22:39.000000000","message":"+1","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"e475d01e115ad024cc00d4fe72cfca37d022c5a8","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            raise resource.ResourceInError("},{"line_number":355,"context_line":"                resource_status\u003dinstance.status,"},{"line_number":356,"context_line":"                status_reason\u003dself.TROVE_STATUS_REASON.get(instance.status,"},{"line_number":357,"context_line":"                                                           _(\"Unknown\")))"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if instance.status !\u003d self.ACTIVE:"},{"line_number":360,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a890539_a6c73c11","line":357,"updated":"2014-12-02 15:03:14.000000000","message":"This default will never be used.  I\u0027d recommend removing it.  Otherwise, we\u0027ll need to add another unit test.","commit_id":"0cad36bd0ae632449e540876753eb2d8b468acde"},{"author":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"change_message_id":"8ee9a16f25401b4e6782eb5701a6d95c33896067","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    TROVE_STATUS_REASON \u003d {"},{"line_number":43,"context_line":"        FAILED: _(\u0027The database instance was created, but heat failed to set \u0027"},{"line_number":44,"context_line":"                  \u0027up the datastore. If a database instance is in the FAILED \u0027"},{"line_number":45,"context_line":"                  \u0027state, you should delete it and create a new instance.\u0027),"},{"line_number":46,"context_line":"        ERROR: _(\u0027The last operation for the database instance failed due to \u0027"},{"line_number":47,"context_line":"                 \u0027an error.\u0027),"},{"line_number":48,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a890539_b91664f0","line":45,"updated":"2014-12-03 09:35:10.000000000","message":"The last sentence could be \u0027If a database instance is in the FAILED state, it should be deleted and a new one should be created.\u0027","commit_id":"13050e109c20ab61039ff66686f02b10c6c698ae"}],"heat/tests/test_os_database.py":[{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"0fd7aada96339d72d7d22a07069f4804308c0167","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"#    under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from troveclient.openstack.common.apiclient import exceptions as troveexc"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_efb5b9d0","line":14,"updated":"2014-12-01 18:25:58.000000000","message":"Could you place this import right after \"import six\"?\n\nAs a third party import, it should already be there, I don\u0027t understand with pep8 check doesn\u0027t complain...","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"9e8048edc7915f3d536aa8bbe76822b5ded5687a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"#    under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from troveclient.openstack.common.apiclient import exceptions as troveexc"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_5d85a705","line":14,"in_reply_to":"5a890539_efb5b9d0","updated":"2014-12-01 19:22:39.000000000","message":"+1","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"9e8048edc7915f3d536aa8bbe76822b5ded5687a","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        mock_input \u003d mock.Mock()"},{"line_number":177,"context_line":"        mock_input.status \u003d \u0027ERROR\u0027"},{"line_number":178,"context_line":"        error_string \u003d os_database.OSDBInstance.TROVE_STATUS_REASON[\u0027ERROR\u0027]"},{"line_number":179,"context_line":"        exc \u003d self.assertRaises(resource.ResourceInError,"},{"line_number":180,"context_line":"                                osdb_res.check_create_complete,"},{"line_number":181,"context_line":"                                mock_input)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_9d8f0f2e","line":178,"updated":"2014-12-01 19:22:39.000000000","message":"This test could be improved by defining the actual string you want to match here, rather than in the code being tested.  Example:\nhttps://github.com/openstack/heat/blob/master/heat/tests/test_server.py#L1923-L1925","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"1700fb92aec1fd53d219ed34b4b63bf5f10cc248","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        mock_input \u003d mock.Mock()"},{"line_number":185,"context_line":"        mock_input.status \u003d \u0027FAILED\u0027"},{"line_number":186,"context_line":"        error_string \u003d os_database.OSDBInstance.TROVE_STATUS_REASON[\u0027FAILED\u0027]"},{"line_number":187,"context_line":"        exc \u003d self.assertRaises(resource.ResourceInError,"},{"line_number":188,"context_line":"                                osdb_res.check_create_complete,"},{"line_number":189,"context_line":"                                mock_input)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_bdda0b15","line":186,"updated":"2014-12-01 19:23:03.000000000","message":"Ditto above","commit_id":"1a2f73e8789ff25fd633b73c201c03f377db5e7f"}]}