)]}'
{"heat/common/exception.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"2a63a74ce4afab47eb04203c3265c7c0020cfe92","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class InstanceNotFound(HeatException):"},{"line_number":235,"context_line":"    msg_fmt \u003d _(\"The Instance (%(instanceId)s) could not be found.\")"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"class PhysicalResourceNameAmbiguity(HeatException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_ae210ea1","line":235,"updated":"2014-11-12 09:58:07.000000000","message":"name the param as \u0027instance_id\u0027? \u0027instanceId\u0027 looks pretty weird.","commit_id":"235659697807eaaa9b90290dfe3f29dd86c34bf7"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"9bd996a761faaf890c45fb4f35e241d34b174a42","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class InstanceNotFound(HeatException):"},{"line_number":235,"context_line":"    msg_fmt \u003d _(\"The Instance (%(instanceId)s) could not be found.\")"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"class PhysicalResourceNameAmbiguity(HeatException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_b891399b","line":235,"in_reply_to":"5a890539_ae210ea1","updated":"2014-11-13 03:48:54.000000000","message":"Done","commit_id":"235659697807eaaa9b90290dfe3f29dd86c34bf7"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"7fe23c79ba5e7c31c7c039812a04b78c68da75d0","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class InstanceNotFound(HeatException):"},{"line_number":235,"context_line":"    msg_fmt \u003d _(\"The Instance (%(instance_id)s) could not be found.\")"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"class PhysicalResourceNameAmbiguity(HeatException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_954dccc6","line":235,"updated":"2014-11-16 23:49:58.000000000","message":"can you change this to ServerNotFound","commit_id":"609cebac4c01919bbce63760c96e2b4559391c44"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"ec44f206c6402b2d1e6dd36591e6739c88006852","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class InstanceNotFound(HeatException):"},{"line_number":235,"context_line":"    msg_fmt \u003d _(\"The Instance (%(instance_id)s) could not be found.\")"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"class PhysicalResourceNameAmbiguity(HeatException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_b8d55de6","line":235,"in_reply_to":"5a890539_954dccc6","updated":"2014-11-17 02:20:13.000000000","message":"Done","commit_id":"609cebac4c01919bbce63760c96e2b4559391c44"}],"heat/engine/clients/os/nova.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"2a63a74ce4afab47eb04203c3265c7c0020cfe92","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    expected_exceptions \u003d (exception.InstanceNotFound,)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def validate_with_client(self, client, value):"},{"line_number":434,"context_line":"        import pdb"},{"line_number":435,"context_line":"        pdb.set_trace()"},{"line_number":436,"context_line":"        client.client_plugin(\u0027nova\u0027).get_server(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_ae582e33","line":433,"updated":"2014-11-12 09:58:07.000000000","message":"rename \u0027value\u0027 to \u0027instance_id\u0027 to improve readability?","commit_id":"235659697807eaaa9b90290dfe3f29dd86c34bf7"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"9bd996a761faaf890c45fb4f35e241d34b174a42","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    expected_exceptions \u003d (exception.InstanceNotFound,)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def validate_with_client(self, client, value):"},{"line_number":434,"context_line":"        import pdb"},{"line_number":435,"context_line":"        pdb.set_trace()"},{"line_number":436,"context_line":"        client.client_plugin(\u0027nova\u0027).get_server(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f8eae10d","line":433,"in_reply_to":"5a890539_ae582e33","updated":"2014-11-13 03:48:54.000000000","message":"I agree with you, and will rename all places where needed.","commit_id":"235659697807eaaa9b90290dfe3f29dd86c34bf7"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"2a63a74ce4afab47eb04203c3265c7c0020cfe92","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def validate_with_client(self, client, value):"},{"line_number":434,"context_line":"        import pdb"},{"line_number":435,"context_line":"        pdb.set_trace()"},{"line_number":436,"context_line":"        client.client_plugin(\u0027nova\u0027).get_server(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_6e756697","line":435,"updated":"2014-11-12 09:58:07.000000000","message":"pdb should be removed.","commit_id":"235659697807eaaa9b90290dfe3f29dd86c34bf7"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"9bd996a761faaf890c45fb4f35e241d34b174a42","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def validate_with_client(self, client, value):"},{"line_number":434,"context_line":"        import pdb"},{"line_number":435,"context_line":"        pdb.set_trace()"},{"line_number":436,"context_line":"        client.client_plugin(\u0027nova\u0027).get_server(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_d8e36531","line":435,"in_reply_to":"5a890539_6e756697","updated":"2014-11-13 03:48:54.000000000","message":"Done","commit_id":"235659697807eaaa9b90290dfe3f29dd86c34bf7"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"7fe23c79ba5e7c31c7c039812a04b78c68da75d0","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        try:"},{"line_number":416,"context_line":"            return self.client().servers.get(instance_id)"},{"line_number":417,"context_line":"        except exceptions.NotFound as ex:"},{"line_number":418,"context_line":"            LOG.warn(_LW(\u0027Instance (%(server)s) not found: %(ex)s\u0027),"},{"line_number":419,"context_line":"                     {\u0027server\u0027: instance_id, \u0027ex\u0027: ex})"},{"line_number":420,"context_line":"            raise exception.InstanceNotFound(instance_id\u003dinstance_id)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_5557e457","line":418,"updated":"2014-11-16 23:49:58.000000000","message":"Shouldn\u0027t we be saying \"Server X not found\"? \"Instance\" is an aws\u0027ism.","commit_id":"609cebac4c01919bbce63760c96e2b4559391c44"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"ec44f206c6402b2d1e6dd36591e6739c88006852","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        try:"},{"line_number":416,"context_line":"            return self.client().servers.get(instance_id)"},{"line_number":417,"context_line":"        except exceptions.NotFound as ex:"},{"line_number":418,"context_line":"            LOG.warn(_LW(\u0027Instance (%(server)s) not found: %(ex)s\u0027),"},{"line_number":419,"context_line":"                     {\u0027server\u0027: instance_id, \u0027ex\u0027: ex})"},{"line_number":420,"context_line":"            raise exception.InstanceNotFound(instance_id\u003dinstance_id)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_98da6115","line":418,"in_reply_to":"5a890539_5557e457","updated":"2014-11-17 02:20:13.000000000","message":"Done","commit_id":"609cebac4c01919bbce63760c96e2b4559391c44"}]}