)]}'
{"heat/engine/dependencies.py":[{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"6b3a9bebd7007e1f8afc48e11affcbf7051b6b92","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def __unicode__(self):"},{"line_number":91,"context_line":"        \u0027\u0027\u0027Return a human-readable string representation of the node.\u0027\u0027\u0027"},{"line_number":92,"context_line":"        text \u003d \u0027{%s}\u0027 % \u0027, \u0027.join(six.text_type(n) for n in self)"},{"line_number":93,"context_line":"        return encodeutils.safe_decode(text)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_62ccd736","line":92,"updated":"2014-12-08 02:32:27.000000000","message":"Should leave unicode here, because this function override unicode() function.","commit_id":"bc203d4f05d99c679db51ce286eaf3a80f5c6d2f"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"343f6711274464cb0c813044372834c70f422ce8","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def __unicode__(self):"},{"line_number":91,"context_line":"        \u0027\u0027\u0027Return a human-readable string representation of the node.\u0027\u0027\u0027"},{"line_number":92,"context_line":"        text \u003d \u0027{%s}\u0027 % \u0027, \u0027.join(six.text_type(n) for n in self)"},{"line_number":93,"context_line":"        return encodeutils.safe_decode(text)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8ed45448","line":92,"in_reply_to":"3a961159_62ccd736","updated":"2014-12-09 15:07:22.000000000","message":"I made the same mistake as Ethan when I initially reviewed this. But actually `six.text_type` *is* `unicode`. The only difference is that it works in Python 3, and `unicode` does not.","commit_id":"bc203d4f05d99c679db51ce286eaf3a80f5c6d2f"},{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"6b3a9bebd7007e1f8afc48e11affcbf7051b6b92","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __unicode__(self):"},{"line_number":150,"context_line":"        \u0027\u0027\u0027Convert the graph to a human-readable string.\u0027\u0027\u0027"},{"line_number":151,"context_line":"        pairs \u003d (\u0027%s: %s\u0027 % (six.text_type(k), six.text_type(v))"},{"line_number":152,"context_line":"                 for k, v in six.iteritems(self))"},{"line_number":153,"context_line":"        text \u003d \u0027{%s}\u0027 % \u0027, \u0027.join(pairs)"},{"line_number":154,"context_line":"        return encodeutils.safe_decode(text)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_82d1c3cf","line":151,"updated":"2014-12-08 02:32:27.000000000","message":"Same as above","commit_id":"bc203d4f05d99c679db51ce286eaf3a80f5c6d2f"}],"heat/engine/scheduler.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"05724f4c256887a06c264e448351d57c3856234f","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def __str__(self):"},{"line_number":121,"context_line":"        return six.text_type([six.text_type(ex).encode(\u0027utf-8\u0027)"},{"line_number":122,"context_line":"                              for ex in self.exceptions]).encode(\u0027utf-8\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def __unicode__(self):"},{"line_number":125,"context_line":"        return six.text_type(map(six.text_type, self.exceptions))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_bfe211ff","line":122,"updated":"2014-12-09 19:28:27.000000000","message":"Hmm, this seems wrong on two counts.\n\n1) double-encoding to utf-8 is at best redundant, and at worst wrong; and\n\n2) this still won\u0027t actually run under Python 3 because it returns a bytes object from __str__() (see comment on next patch).\n\nThe best solution to 1 is to remove the inner conversion; the solution to 2 is to remove the outer one. Not sure what the best way to proceed here is. In the other files we have used encodeutils.safe_encode()... I don\u0027t know if that helps or not.","commit_id":"bb104c67db52831ecc6fffe94075506acd665a63"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"68806652f06d79840479569b48254247cd643294","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def __str__(self):"},{"line_number":121,"context_line":"        return six.text_type([six.text_type(ex).encode(\u0027utf-8\u0027)"},{"line_number":122,"context_line":"                              for ex in self.exceptions]).encode(\u0027utf-8\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def __unicode__(self):"},{"line_number":125,"context_line":"        return six.text_type(map(six.text_type, self.exceptions))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_d43885a2","line":122,"in_reply_to":"3a961159_bfe211ff","updated":"2014-12-11 08:22:28.000000000","message":"Maybe it is more adequate to use there str instead of","commit_id":"bb104c67db52831ecc6fffe94075506acd665a63"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"7a9e2d2fa7b2bb4e515bd82facdce1e2460c0b45","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def __str__(self):"},{"line_number":121,"context_line":"        return six.text_type([six.text_type(ex).encode(\u0027utf-8\u0027)"},{"line_number":122,"context_line":"                              for ex in self.exceptions]).encode(\u0027utf-8\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def __unicode__(self):"},{"line_number":125,"context_line":"        return six.text_type(map(six.text_type, self.exceptions))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_e214c0a1","line":122,"in_reply_to":"3a961159_d43885a2","updated":"2014-12-11 10:55:49.000000000","message":"Sorry, it\u0027s unfinished (and wrong) draft, which accidentally became comment.","commit_id":"bb104c67db52831ecc6fffe94075506acd665a63"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"3b6ce9d6d4b26022735c16d617dde016f85e897b","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def __str__(self):"},{"line_number":121,"context_line":"        return encodeutils.safe_encode(six.text_type([six.text_type(ex)"},{"line_number":122,"context_line":"                                       for ex in self.exceptions]))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def __unicode__(self):"},{"line_number":125,"context_line":"        return six.text_type(map(six.text_type, self.exceptions))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_ca5404cc","line":122,"updated":"2014-12-12 18:14:06.000000000","message":"This still returns a bytes object, so it will still fail in Python 3.","commit_id":"8a3946f6c1ffba2ee42116e4d6e62ea717a6c222"}]}
