)]}'
{"heat/api/aws/ec2token.py":[{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"b593a71c99495f48e7dfacbc3b8c95d57eb48501","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                       \u0027multi_cloud is enabled. At least one endpoint needs \u0027"},{"line_number":42,"context_line":"                       \u0027to be specified.\u0027)),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027certfile\u0027, default\u003dNone,"},{"line_number":44,"context_line":"               help\u003d\u0027Required if identity server requires client certificate\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027keyfile\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Required if identity server requires client certificate\u0027),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027cafile\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_cb89cecb","line":44,"updated":"2015-02-03 07:48:40.000000000","message":"Better using _(\"\") for translations.","commit_id":"a7b2933758f4bc881fc9404a259de879478e0f1c"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"4a8cbebdaf1ebd03cd38a029cda92bd6517bd86b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                       \u0027multi_cloud is enabled. At least one endpoint needs \u0027"},{"line_number":42,"context_line":"                       \u0027to be specified.\u0027)),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027certfile\u0027, default\u003dNone,"},{"line_number":44,"context_line":"               help\u003d\u0027Required if identity server requires client certificate\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027keyfile\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Required if identity server requires client certificate\u0027),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027cafile\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_9618ad1f","line":44,"in_reply_to":"da86d52c_cb89cecb","updated":"2015-02-04 05:36:24.000000000","message":"I will do this. Thanks for review.","commit_id":"a7b2933758f4bc881fc9404a259de879478e0f1c"},{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"b593a71c99495f48e7dfacbc3b8c95d57eb48501","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            cert \u003d self._conf_get(\u0027certfile\u0027)"},{"line_number":149,"context_line":"            key \u003d self._conf_get(\u0027keyfile\u0027)"},{"line_number":150,"context_line":"            self._ssl_options \u003d {"},{"line_number":151,"context_line":"                \u0027verify\u0027: cacert if cacert else not insecure,"},{"line_number":152,"context_line":"                \u0027cert\u0027: (cert, key) if cert else None"},{"line_number":153,"context_line":"            }"},{"line_number":154,"context_line":"        return self._ssl_options"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_de918e9b","line":151,"updated":"2015-02-03 07:48:40.000000000","message":"I\u0027m not very familiar with ssl, my questions is:\n\"verify\" can be three values? cafile or true or false?\n\n\"verify\" can be between string and bool here, that may cause some potential problem,\nthat\u0027s my concern.","commit_id":"a7b2933758f4bc881fc9404a259de879478e0f1c"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"4a8cbebdaf1ebd03cd38a029cda92bd6517bd86b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            cert \u003d self._conf_get(\u0027certfile\u0027)"},{"line_number":149,"context_line":"            key \u003d self._conf_get(\u0027keyfile\u0027)"},{"line_number":150,"context_line":"            self._ssl_options \u003d {"},{"line_number":151,"context_line":"                \u0027verify\u0027: cacert if cacert else not insecure,"},{"line_number":152,"context_line":"                \u0027cert\u0027: (cert, key) if cert else None"},{"line_number":153,"context_line":"            }"},{"line_number":154,"context_line":"        return self._ssl_options"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_f6c1e954","line":151,"in_reply_to":"da86d52c_de918e9b","updated":"2015-02-04 05:36:24.000000000","message":"Yes, the \u0027verify\u0027 can accept either true or false or path to CA bundle. If a CA_BUNDLE is configured, it will be passed, otherwise, just a boolean flag to verify is needed. Please see the docs in requests lib.","commit_id":"a7b2933758f4bc881fc9404a259de879478e0f1c"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"772ec1dfa313019d752f52bf6589b991ca961783","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            cert \u003d self._conf_get(\u0027certfile\u0027)"},{"line_number":149,"context_line":"            key \u003d self._conf_get(\u0027keyfile\u0027)"},{"line_number":150,"context_line":"            self._ssl_options \u003d {"},{"line_number":151,"context_line":"                \u0027verify\u0027: cacert if cacert else not insecure,"},{"line_number":152,"context_line":"                \u0027cert\u0027: (cert, key) if cert else None"},{"line_number":153,"context_line":"            }"},{"line_number":154,"context_line":"        return self._ssl_options"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_76941943","line":151,"in_reply_to":"da86d52c_f6c1e954","updated":"2015-02-04 06:02:05.000000000","message":"Ethan, you may want to check http://docs.python-requests.org/en/latest/user/advanced/#ssl-cert-verification","commit_id":"a7b2933758f4bc881fc9404a259de879478e0f1c"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"c1885e8dbdf9cf69af43e7eda01b94509600a5fe","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.StrOpt(\u0027cafile\u0027,"},{"line_number":50,"context_line":"               default\u003dNone,"},{"line_number":51,"context_line":"               help\u003d_(\u0027A PEM encoded Certificate Authority to use when \u0027"},{"line_number":52,"context_line":"                      \u0027verifying HTTPs connections. Defaults to system CAs.\u0027)),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":54,"context_line":"                default\u003dFalse,"},{"line_number":55,"context_line":"                help\u003d_(\u0027Verify HTTPS connections.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_d25d23ee","line":52,"updated":"2015-02-09 15:37:53.000000000","message":"Could you name these options \"cert_file\", \"key_file\" and \"ca_file\", so that they match the same option names defined in heat/common/config.py? The help test is also different, you may want to consider using the exact same ones, to save the translators some effort.","commit_id":"c1954bed7215d3989be7e111d3cc02a26c7e0846"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"b3e9bf566892925ce3c410aa187aace1963e553a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.StrOpt(\u0027cafile\u0027,"},{"line_number":50,"context_line":"               default\u003dNone,"},{"line_number":51,"context_line":"               help\u003d_(\u0027A PEM encoded Certificate Authority to use when \u0027"},{"line_number":52,"context_line":"                      \u0027verifying HTTPs connections. Defaults to system CAs.\u0027)),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":54,"context_line":"                default\u003dFalse,"},{"line_number":55,"context_line":"                help\u003d_(\u0027Verify HTTPS connections.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_5cd59db7","line":52,"in_reply_to":"da86d52c_d25d23ee","updated":"2015-02-12 15:22:49.000000000","message":"Done","commit_id":"c1954bed7215d3989be7e111d3cc02a26c7e0846"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"5656c23deb88257f59e7bcc5b64f5828f90ff0cb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.StrOpt(\u0027cert_file\u0027,"},{"line_number":44,"context_line":"               default\u003dNone,"},{"line_number":45,"context_line":"               help\u003d_(\u0027Optional PEM-formatted certificate chain file. \u0027"},{"line_number":46,"context_line":"                      \u0027(string value)\u0027)),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027key_file\u0027,"},{"line_number":48,"context_line":"               default\u003dNone,"},{"line_number":49,"context_line":"               help\u003d_(\u0027 Optional PEM-formatted file that contains the \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_0828a895","line":46,"updated":"2015-02-13 06:37:06.000000000","message":"Do we need to especially specify \u0027string value\u0027 in cfg.StrOpt()?","commit_id":"97cada3f734e74d41767716f7cd9377d5ff01f75"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"ef14fbc605fa0ce22966ab7f68e60044daae8e39","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.StrOpt(\u0027cert_file\u0027,"},{"line_number":44,"context_line":"               default\u003dNone,"},{"line_number":45,"context_line":"               help\u003d_(\u0027Optional PEM-formatted certificate chain file. \u0027"},{"line_number":46,"context_line":"                      \u0027(string value)\u0027)),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027key_file\u0027,"},{"line_number":48,"context_line":"               default\u003dNone,"},{"line_number":49,"context_line":"               help\u003d_(\u0027 Optional PEM-formatted file that contains the \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_cf0051ae","line":46,"in_reply_to":"da86d52c_0828a895","updated":"2015-02-13 09:28:36.000000000","message":"Thanks for review. Done","commit_id":"97cada3f734e74d41767716f7cd9377d5ff01f75"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"5656c23deb88257f59e7bcc5b64f5828f90ff0cb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                      \u0027(string value)\u0027)),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027key_file\u0027,"},{"line_number":48,"context_line":"               default\u003dNone,"},{"line_number":49,"context_line":"               help\u003d_(\u0027 Optional PEM-formatted file that contains the \u0027"},{"line_number":50,"context_line":"                      \u0027private key. (string value)\u0027)),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":52,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_63078718","line":49,"updated":"2015-02-13 06:37:06.000000000","message":"Always we don\u0027t hope empty char first.","commit_id":"97cada3f734e74d41767716f7cd9377d5ff01f75"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"5656c23deb88257f59e7bcc5b64f5828f90ff0cb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.StrOpt(\u0027key_file\u0027,"},{"line_number":48,"context_line":"               default\u003dNone,"},{"line_number":49,"context_line":"               help\u003d_(\u0027 Optional PEM-formatted file that contains the \u0027"},{"line_number":50,"context_line":"                      \u0027private key. (string value)\u0027)),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":52,"context_line":"               default\u003dNone,"},{"line_number":53,"context_line":"               help\u003d_(\u0027Optional CA cert file to use in SSL connections.  \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_830abb1d","line":50,"updated":"2015-02-13 06:37:06.000000000","message":"same.","commit_id":"97cada3f734e74d41767716f7cd9377d5ff01f75"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"5656c23deb88257f59e7bcc5b64f5828f90ff0cb","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":52,"context_line":"               default\u003dNone,"},{"line_number":53,"context_line":"               help\u003d_(\u0027Optional CA cert file to use in SSL connections.  \u0027"},{"line_number":54,"context_line":"                      \u0027(string value)\u0027)),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":56,"context_line":"                default\u003dFalse,"},{"line_number":57,"context_line":"                help\u003d_(\u0027If set, then the server\\\u0027s certificate will not \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_c30f532c","line":54,"updated":"2015-02-13 06:37:06.000000000","message":"same","commit_id":"97cada3f734e74d41767716f7cd9377d5ff01f75"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"5656c23deb88257f59e7bcc5b64f5828f90ff0cb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":56,"context_line":"                default\u003dFalse,"},{"line_number":57,"context_line":"                help\u003d_(\u0027If set, then the server\\\u0027s certificate will not \u0027"},{"line_number":58,"context_line":"                       \u0027be verified. (boolean value)\u0027)),"},{"line_number":59,"context_line":"]"},{"line_number":60,"context_line":"cfg.CONF.register_opts(opts, group\u003d\u0027ec2authtoken\u0027)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_e31a976d","line":58,"updated":"2015-02-13 06:37:06.000000000","message":"same","commit_id":"97cada3f734e74d41767716f7cd9377d5ff01f75"}]}
