)]}'
{"heat/tests/test_engine_service.py":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"8520709bb17e75167a1488fd96129a0d600d5d1e","unresolved":false,"context_lines":[{"line_number":3306,"context_line":"            target_class,"},{"line_number":3307,"context_line":"            rpc_server_method):"},{"line_number":3308,"context_line":"        cfg.CONF.set_default(\u0027convergence_engine\u0027, False)"},{"line_number":3309,"context_line":"        cfg.CONF.set_default(\u0027periodic_interval\u0027, 60)"},{"line_number":3310,"context_line":"        self._test_engine_service_start("},{"line_number":3311,"context_line":"            thread_group_class,"},{"line_number":3312,"context_line":"            None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_68f28ad3","line":3309,"updated":"2015-02-24 09:15:05.000000000","message":"This line may be defined in private test method, like it is used in stop test.","commit_id":"b235e33dc8e4082f646b1e1a1dd6435990da106d"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"8520709bb17e75167a1488fd96129a0d600d5d1e","unresolved":false,"context_lines":[{"line_number":3357,"context_line":"            rpc_server_method"},{"line_number":3358,"context_line":"        )"},{"line_number":3359,"context_line":""},{"line_number":3360,"context_line":"    def _test_engine_service_stop("},{"line_number":3361,"context_line":"            self,"},{"line_number":3362,"context_line":"            service_delete_method,"},{"line_number":3363,"context_line":"            admin_context_method,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_2896d24c","line":3360,"updated":"2015-02-24 09:15:05.000000000","message":"Why do you pass all parameters here?\nI can not find where you use them in test. AFAIK, you use self.eng for all checks.\nAlso these (passed) values is not checked anywhere.","commit_id":"b235e33dc8e4082f646b1e1a1dd6435990da106d"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"39088e114f7c4559c7743afc368ee27b012ede41","unresolved":false,"context_lines":[{"line_number":3359,"context_line":"            self,"},{"line_number":3360,"context_line":"            service_delete_method,"},{"line_number":3361,"context_line":"            admin_context_method,"},{"line_number":3362,"context_line":"            thread_group_mgr_stop,"},{"line_number":3363,"context_line":"            thread_group_stop,"},{"line_number":3364,"context_line":"            worker_service_stop,"},{"line_number":3365,"context_line":"            rpc_server_stop):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_2826d2ce","line":3362,"updated":"2015-02-24 09:28:43.000000000","message":"Still question:\nwhy do you pass parameters:\n\tthread_group_mgr_stop, thread_group_stop, worker_service_stop, rpc_server_stop? They are not used in this method.","commit_id":"38d2510e1e2ecb81e5bfa6d8fb1d77f465cfa52d"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"1a53162cc62c7463eae3ff18acf45980b9d20089","unresolved":false,"context_lines":[{"line_number":3359,"context_line":"            self,"},{"line_number":3360,"context_line":"            service_delete_method,"},{"line_number":3361,"context_line":"            admin_context_method,"},{"line_number":3362,"context_line":"            thread_group_mgr_stop,"},{"line_number":3363,"context_line":"            thread_group_stop,"},{"line_number":3364,"context_line":"            worker_service_stop,"},{"line_number":3365,"context_line":"            rpc_server_stop):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_fbe1e2fe","line":3362,"in_reply_to":"ba7be1f8_2826d2ce","updated":"2015-02-24 09:44:09.000000000","message":"Thanks for pointing out . I will remove them, i have kept with intention to check whether the required methods are called by using these mock objects. But later in time,  directly checked using self.eng instead of these mock objects.","commit_id":"38d2510e1e2ecb81e5bfa6d8fb1d77f465cfa52d"}]}