)]}'
{"heat/engine/resources/neutron/subnet.py":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"db808a01881e055b0b0c9b68bd337cd12be011e0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        GATEWAY_IP: properties.Schema("},{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address.\u0027"},{"line_number":115,"context_line":"              \"Set to [ \u0027null\u0027 | \u0027~\u0027 | \u0027\u0027 ] if the subnet have no gateway.\"),"},{"line_number":116,"context_line":"            update_allowed\u003dTrue"},{"line_number":117,"context_line":"        ),"},{"line_number":118,"context_line":"        ENABLE_DHCP: properties.Schema("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_dde1242b","line":115,"updated":"2015-02-25 18:37:23.000000000","message":"Could you please change it in the same way, like on line 143. Also I suppose, that using different quotes is not a good approach. IMO it should looks like:\n\n_(\u0027The gateway IP address. Set to [ \"null\" | \"~\" | \"\" ] if the \u0027\n  \u0027subnet have no gateway.\u0027),","commit_id":"5a83b84b0afb39948934388634083d550e1e53f1"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"a13fb374439ada15e1d51a24b83b8e269d68831e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        GATEWAY_IP: properties.Schema("},{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Set to [ \"null\" | \"~\" | \"\" ] if the\u0027"},{"line_number":115,"context_line":"              \u0027subnet have no gateway.\u0027),"},{"line_number":116,"context_line":"            update_allowed\u003dTrue"},{"line_number":117,"context_line":"        ),"},{"line_number":118,"context_line":"        ENABLE_DHCP: properties.Schema("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_b9a4764b","line":115,"updated":"2015-02-26 01:16:28.000000000","message":"Two notes:\n\n- Use \"has\" instead of \"have\"\n- I see in the neutron resource source code that an empty string is mapped to no gateway, but couldn\u0027t find anything on \"null\" and \"-\". I think you mean null and - (not as strings but as the native yaml null values). Please remove the quotes to avoid people getting confused.","commit_id":"a2d76e6a9c8ff4fe8941037b07c277336fa489f1"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"4a742974da4af4e0a9a6e9ec80fce789b545c315","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        GATEWAY_IP: properties.Schema("},{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Set to [ null | ~ | \"\" ] if the subnet\u0027"},{"line_number":115,"context_line":"              \u0027 has no gateway.\u0027),"},{"line_number":116,"context_line":"            update_allowed\u003dTrue"},{"line_number":117,"context_line":"        ),"},{"line_number":118,"context_line":"        ENABLE_DHCP: properties.Schema("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_79e648ea","line":115,"updated":"2015-02-27 01:35:41.000000000","message":"Hm, I guess the documentation is ok to specify that no gateway is present. However, from a usability perspective I find it a bit awkward.\n\nWouldn\u0027t a better solution be to just make the property optional, i.e. set required\u003dFalse?","commit_id":"f2278b8ce2402872261bb46c9822563219935a14"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"4f35634f42018466db94ee1003c63dc29979d496","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Set to [ null | ~ | \"\" ] if the subnet\u0027"},{"line_number":115,"context_line":"              \u0027 has no gateway.\u0027),"},{"line_number":116,"context_line":"            required\u003dFalse,"},{"line_number":117,"context_line":"            update_allowed\u003dTrue"},{"line_number":118,"context_line":"        ),"},{"line_number":119,"context_line":"        ENABLE_DHCP: properties.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_58b930ca","line":116,"updated":"2015-03-02 07:25:36.000000000","message":"Thanks for making the property optional. Now the question is, if the additional documentation is still required, or if the user would just not provide the property if no gateway is present. This would be what I expect.\nIn this case, could we just say something like: \u0027If no gateway is present on the subnet, this property can be ommitted.\u0027 ?\n\nOr is the explicit setting required for an update use case?","commit_id":"efcb2b3d5414d2060f39bce522e4c898f1372b81"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"a51cb03be320e1bbc22567b30a91f46fe5a81978","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Set to [ null | ~ | \"\" ] if the subnet\u0027"},{"line_number":115,"context_line":"              \u0027 has no gateway.\u0027),"},{"line_number":116,"context_line":"            required\u003dFalse,"},{"line_number":117,"context_line":"            update_allowed\u003dTrue"},{"line_number":118,"context_line":"        ),"},{"line_number":119,"context_line":"        ENABLE_DHCP: properties.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_b2c40441","line":116,"in_reply_to":"ba7be1f8_58b930ca","updated":"2015-03-02 09:54:34.000000000","message":"And may be we need transfer this null gateway_ip when handle update for this situation. Can you modify in this patch.","commit_id":"efcb2b3d5414d2060f39bce522e4c898f1372b81"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"460c2eedae185c37c56f32d773dc95a35d3511ab","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Set to [ null | ~ | \"\" ] if the subnet\u0027"},{"line_number":115,"context_line":"              \u0027 has no gateway.\u0027),"},{"line_number":116,"context_line":"            required\u003dFalse,"},{"line_number":117,"context_line":"            update_allowed\u003dTrue"},{"line_number":118,"context_line":"        ),"},{"line_number":119,"context_line":"        ENABLE_DHCP: properties.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_c87c56ee","line":116,"in_reply_to":"ba7be1f8_58b930ca","updated":"2015-03-02 17:29:08.000000000","message":"I think there is value in documenting how to set this property to not have a gateway, but I\u0027m +1 on extending the help message to also say that the property can be omitted.\n\nMaybe something like \u0027The gateway IP address. Omit or set to [ null | ~ | \"\" ] if the subnet has no gateway.\u0027","commit_id":"efcb2b3d5414d2060f39bce522e4c898f1372b81"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"5e9c55e6e7e7dfba9483a273737ee62cc6a562fa","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Set to [ null | ~ | \"\" ] if the subnet\u0027"},{"line_number":115,"context_line":"              \u0027 has no gateway.\u0027),"},{"line_number":116,"context_line":"            required\u003dFalse,"},{"line_number":117,"context_line":"            update_allowed\u003dTrue"},{"line_number":118,"context_line":"        ),"},{"line_number":119,"context_line":"        ENABLE_DHCP: properties.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_e77be7bb","line":116,"in_reply_to":"ba7be1f8_644c5843","updated":"2015-03-03 09:24:35.000000000","message":"\u003e In a create use case, should set to [ null | ~ | \"\" ] if the subnet has no gateway.\n\nI think in the create case one could also just omit the property.\n\nSo I think Miguel\u0027s proposal should completely cover what we need. And it is short and precise.","commit_id":"efcb2b3d5414d2060f39bce522e4c898f1372b81"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"b60362dd331c4658ec65f92fa59f17e48f03a680","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Set to [ null | ~ | \"\" ] if the subnet\u0027"},{"line_number":115,"context_line":"              \u0027 has no gateway.\u0027),"},{"line_number":116,"context_line":"            required\u003dFalse,"},{"line_number":117,"context_line":"            update_allowed\u003dTrue"},{"line_number":118,"context_line":"        ),"},{"line_number":119,"context_line":"        ENABLE_DHCP: properties.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_a49010ee","line":116,"in_reply_to":"ba7be1f8_c87c56ee","updated":"2015-03-03 07:39:14.000000000","message":"+1 on Miguel\u0027s wording proposal","commit_id":"efcb2b3d5414d2060f39bce522e4c898f1372b81"},{"author":{"_account_id":14850,"name":"Yoshimi Tominaga","email":"tominaga.yoshimi@tis.co.jp","username":"tominaga443"},"change_message_id":"24583f623c10b034afb966054b50635c8a006299","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Set to [ null | ~ | \"\" ] if the subnet\u0027"},{"line_number":115,"context_line":"              \u0027 has no gateway.\u0027),"},{"line_number":116,"context_line":"            required\u003dFalse,"},{"line_number":117,"context_line":"            update_allowed\u003dTrue"},{"line_number":118,"context_line":"        ),"},{"line_number":119,"context_line":"        ENABLE_DHCP: properties.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_644c5843","line":116,"in_reply_to":"ba7be1f8_c87c56ee","updated":"2015-03-03 07:59:40.000000000","message":"Thank you for your comments. I organize my thought.\n\nIn a create use case, should set to [ null | ~ | \"\" ] if the subnet has no gateway.\n\nIn an update use case, if the existing subnet has no gateway and would keep on no gateway, omit or set to [ null | ~ | \"\" ].\nI would add the documentation for this case.\n\nIf the existing subnet has gateway ip and would be updated to no gateway, we need transfer this null gateway_ip.\nAbout this case, I want to handle apart from this patch.","commit_id":"efcb2b3d5414d2060f39bce522e4c898f1372b81"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"a4908f6ce5c700e2f003987e211b8443832168bc","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        ),"},{"line_number":112,"context_line":"        GATEWAY_IP: properties.Schema("},{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Omit or set to [ null | ~ | \"\" ] if the\u0027"},{"line_number":115,"context_line":"              \u0027 subnet has no gateway.\u0027),"},{"line_number":116,"context_line":"            update_allowed\u003dTrue"},{"line_number":117,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_7b14c04c","line":114,"updated":"2015-03-04 03:03:16.000000000","message":"If omit this property, neutron will allocate the first ip address as gateway, so I think we should give this help message.","commit_id":"8f545954bbfec3bde0fc268f2fd0454f94710e00"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"99ec106f62523fb54264a00252a2f25031ad41f8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        ),"},{"line_number":112,"context_line":"        GATEWAY_IP: properties.Schema("},{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Omit or set to [ null | ~ | \"\" ] if the\u0027"},{"line_number":115,"context_line":"              \u0027 subnet has no gateway.\u0027),"},{"line_number":116,"context_line":"            update_allowed\u003dTrue"},{"line_number":117,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_16ffe202","line":114,"in_reply_to":"9a80dd14_0d2c354a","updated":"2015-03-04 08:10:12.000000000","message":"My take on the wording:\n\n \u0027The gateway IP address. Set to any of [ null | ~ | \"\" ] to create the subnet \u0027\n \u0027without a gateway. If omitted, the first IP address within the subnet is \u0027\n \u0027assigned to the gateway.\u0027","commit_id":"8f545954bbfec3bde0fc268f2fd0454f94710e00"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"1f4f5db1e9836159270e6bd0db4f1b92dddbedc8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        ),"},{"line_number":112,"context_line":"        GATEWAY_IP: properties.Schema("},{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Omit or set to [ null | ~ | \"\" ] if the\u0027"},{"line_number":115,"context_line":"              \u0027 subnet has no gateway.\u0027),"},{"line_number":116,"context_line":"            update_allowed\u003dTrue"},{"line_number":117,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_963912db","line":114,"in_reply_to":"9a80dd14_16ffe202","updated":"2015-03-04 08:12:16.000000000","message":"Sounds good:)","commit_id":"8f545954bbfec3bde0fc268f2fd0454f94710e00"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"edea747ac58ead1ddd4a7b132c4bcc6d8ef2ce7b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        ),"},{"line_number":112,"context_line":"        GATEWAY_IP: properties.Schema("},{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Omit or set to [ null | ~ | \"\" ] if the\u0027"},{"line_number":115,"context_line":"              \u0027 subnet has no gateway.\u0027),"},{"line_number":116,"context_line":"            update_allowed\u003dTrue"},{"line_number":117,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_0d2c354a","line":114,"in_reply_to":"9a80dd14_67b5d2cc","updated":"2015-03-04 06:31:28.000000000","message":"How about like this:\nSet to [ null | ~ | \"\" ] if you wish the subnet has no gateway; Omit this property, neutron will allocate the first address as gataway.","commit_id":"8f545954bbfec3bde0fc268f2fd0454f94710e00"},{"author":{"_account_id":14850,"name":"Yoshimi Tominaga","email":"tominaga.yoshimi@tis.co.jp","username":"tominaga443"},"change_message_id":"2256c5bbf334be57ab64fb86836832c9da584cda","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        ),"},{"line_number":112,"context_line":"        GATEWAY_IP: properties.Schema("},{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Omit or set to [ null | ~ | \"\" ] if the\u0027"},{"line_number":115,"context_line":"              \u0027 subnet has no gateway.\u0027),"},{"line_number":116,"context_line":"            update_allowed\u003dTrue"},{"line_number":117,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_3cbf65d2","line":114,"in_reply_to":"9a80dd14_963912db","updated":"2015-03-04 09:20:53.000000000","message":"Thank you for helping.\nI would modify to Thomas\u0027s proposal.","commit_id":"8f545954bbfec3bde0fc268f2fd0454f94710e00"},{"author":{"_account_id":14850,"name":"Yoshimi Tominaga","email":"tominaga.yoshimi@tis.co.jp","username":"tominaga443"},"change_message_id":"4b21a89916522220dcdcfd84dbb4de03be6db904","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        ),"},{"line_number":112,"context_line":"        GATEWAY_IP: properties.Schema("},{"line_number":113,"context_line":"            properties.Schema.STRING,"},{"line_number":114,"context_line":"            _(\u0027The gateway IP address. Omit or set to [ null | ~ | \"\" ] if the\u0027"},{"line_number":115,"context_line":"              \u0027 subnet has no gateway.\u0027),"},{"line_number":116,"context_line":"            update_allowed\u003dTrue"},{"line_number":117,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_67b5d2cc","line":114,"in_reply_to":"ba7be1f8_7b14c04c","updated":"2015-03-04 05:16:09.000000000","message":"How about something like;\n\"In the create case, set to  [ null | ~ | \"\" ] if the subnet has no gateway; if omit this property, the first IP address of CIDR is allocated as the subnet\u0027s gateway.\nIn the update case, can omit if would not modify the gateway Ip.\"","commit_id":"8f545954bbfec3bde0fc268f2fd0454f94710e00"}]}