)]}'
{"id":"openstack%2Fheat~210255","triplet_id":"openstack%2Fheat~master~Id62201e3a26b557a941bbd904a947f064df4aeb3","project":"openstack/heat","branch":"master","hashtags":[],"change_id":"Id62201e3a26b557a941bbd904a947f064df4aeb3","subject":"Don\u0027t use default None for params in handle_update","status":"MERGED","created":"2015-08-07 08:49:58.000000000","updated":"2015-08-08 11:20:09.000000000","submitted":"2015-08-07 14:30:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9c443f58706b9ae6de37a42df98b255d5cb4f1fe","_number":210255,"virtual_id_number":210255,"owner":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"value":0,"_account_id":13323,"name":"Tatiana Kholkina","email":"tlashchova@gmail.com","username":"tlashchova"},{"value":0,"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":0,"date":"2015-08-07 12:56:12.000000000","_account_id":9751,"name":"IBM DB2 CI","email":"scecd@cn.ibm.com","username":"ibmdb2","tags":["SERVICE_USER"]},{"value":0,"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"value":0,"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"value":2,"date":"2015-08-07 14:30:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"all":[{"value":2,"date":"2015-08-07 13:34:54.000000000","_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"value":1,"date":"2015-08-07 10:20:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13323,"name":"Tatiana Kholkina","email":"tlashchova@gmail.com","username":"tlashchova"},{"value":1,"date":"2015-08-07 12:16:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},{"value":2,"date":"2015-08-07 09:10:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":0,"_account_id":9751,"name":"IBM DB2 CI","email":"scecd@cn.ibm.com","username":"ibmdb2","tags":["SERVICE_USER"]},{"value":2,"date":"2015-08-07 09:16:26.000000000","_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"value":1,"date":"2015-08-07 09:35:11.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"all":[{"value":1,"date":"2015-08-07 13:34:54.000000000","_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"value":0,"_account_id":13323,"name":"Tatiana Kholkina","email":"tlashchova@gmail.com","username":"tlashchova"},{"value":0,"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":0,"_account_id":9751,"name":"IBM DB2 CI","email":"scecd@cn.ibm.com","username":"ibmdb2","tags":["SERVICE_USER"]},{"value":0,"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"value":0,"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"_account_id":9751,"name":"IBM DB2 CI","email":"scecd@cn.ibm.com","username":"ibmdb2","tags":["SERVICE_USER"]},{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},{"_account_id":13323,"name":"Tatiana Kholkina","email":"tlashchova@gmail.com","username":"tlashchova"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-07 09:10:37.000000000","updated_by":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"reviewer":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"state":"REVIEWER"},{"updated":"2015-08-07 09:16:26.000000000","updated_by":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"reviewer":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"state":"REVIEWER"},{"updated":"2015-08-07 09:35:11.000000000","updated_by":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"reviewer":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"state":"REVIEWER"},{"updated":"2015-08-07 10:20:29.000000000","updated_by":{"_account_id":13323,"name":"Tatiana Kholkina","email":"tlashchova@gmail.com","username":"tlashchova"},"reviewer":{"_account_id":13323,"name":"Tatiana Kholkina","email":"tlashchova@gmail.com","username":"tlashchova"},"state":"REVIEWER"},{"updated":"2015-08-07 12:16:49.000000000","updated_by":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"reviewer":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"state":"REVIEWER"},{"updated":"2015-08-07 12:56:12.000000000","updated_by":{"_account_id":9751,"name":"IBM DB2 CI","email":"scecd@cn.ibm.com","username":"ibmdb2","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9751,"name":"IBM DB2 CI","email":"scecd@cn.ibm.com","username":"ibmdb2","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-08-07 13:34:54.000000000","updated_by":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"reviewer":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"state":"REVIEWER"},{"updated":"2015-08-07 14:30:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e487c7e41b6ec81b9ad9c29b9dedc7331da64fa8","author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"date":"2015-08-07 08:49:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"00424c4d9e13f5ef1e1260bc3ea56b47aa6f1663","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2015-08-07 09:10:37.000000000","message":"Patch Set 1: Code-Review+2\n\nsome of those methods wouldn\u0027t even work with default None values (e.g. len(prop_diff))","accounts_in_message":[],"_revision_number":1},{"id":"88fd9c107589a98b2a6e02ae205506d84d701cad","author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"date":"2015-08-07 09:16:26.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"60eddbecd7fd961ec2525f6d62da321d8abff811","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2015-08-07 09:35:11.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"232c5a6262a02dfda41d35d1220662d18023c78a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-07 09:44:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-heat-pep8 http://logs.openstack.org/55/210255/1/check/gate-heat-pep8/6907ca9/ : SUCCESS in 3m 48s\n- gate-heat-docs http://docs-draft.openstack.org/55/210255/1/check/gate-heat-docs/9a24b39//doc/build/html/ : SUCCESS in 5m 31s\n- gate-heat-python27 http://logs.openstack.org/55/210255/1/check/gate-heat-python27/35c2caf/ : FAILURE in 8m 19s\n- gate-heat-python34 http://logs.openstack.org/55/210255/1/check/gate-heat-python34/5afb3bb/ : SUCCESS in 7m 33s\n- gate-heat-dsvm-functional-orig-mysql http://logs.openstack.org/55/210255/1/check/gate-heat-dsvm-functional-orig-mysql/b52550b/ : SUCCESS in 27m 45s\n- gate-heat-dsvm-functional-convg-mysql http://logs.openstack.org/55/210255/1/check/gate-heat-dsvm-functional-convg-mysql/d311e0b/ : FAILURE in 35m 40s (non-voting)\n- gate-tempest-dsvm-heat http://logs.openstack.org/55/210255/1/check/gate-tempest-dsvm-heat/a99efa8/ : SUCCESS in 24m 21s\n- gate-grenade-dsvm-heat http://logs.openstack.org/55/210255/1/check/gate-grenade-dsvm-heat/6a034d7/ : SUCCESS in 54m 23s","accounts_in_message":[],"_revision_number":1},{"id":"045adf31fa3f377b4587235d7d2034549c13632a","author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"date":"2015-08-07 09:46:09.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"99843dedcef077bacc17e68afa4b2a36c8c77d59","author":{"_account_id":13323,"name":"Tatiana Kholkina","email":"tlashchova@gmail.com","username":"tlashchova"},"date":"2015-08-07 10:20:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"df7b800c25f41875e5ba595d56700f208306679d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-07 10:42:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-heat-pep8 http://logs.openstack.org/55/210255/1/check/gate-heat-pep8/71d855c/ : SUCCESS in 3m 05s\n- gate-heat-docs http://docs-draft.openstack.org/55/210255/1/check/gate-heat-docs/d25aa8c//doc/build/html/ : SUCCESS in 4m 26s\n- gate-heat-python27 http://logs.openstack.org/55/210255/1/check/gate-heat-python27/e6fe323/ : SUCCESS in 7m 06s\n- gate-heat-python34 http://logs.openstack.org/55/210255/1/check/gate-heat-python34/f016d10/ : SUCCESS in 6m 34s\n- gate-heat-dsvm-functional-orig-mysql http://logs.openstack.org/55/210255/1/check/gate-heat-dsvm-functional-orig-mysql/46b371e/ : SUCCESS in 28m 23s\n- gate-heat-dsvm-functional-convg-mysql http://logs.openstack.org/55/210255/1/check/gate-heat-dsvm-functional-convg-mysql/4ed6594/ : SUCCESS in 35m 06s (non-voting)\n- gate-tempest-dsvm-heat http://logs.openstack.org/55/210255/1/check/gate-tempest-dsvm-heat/d92f3b6/ : SUCCESS in 25m 47s\n- gate-grenade-dsvm-heat http://logs.openstack.org/55/210255/1/check/gate-grenade-dsvm-heat/04b6ceb/ : SUCCESS in 51m 08s","accounts_in_message":[],"_revision_number":1},{"id":"7efadc3206d8f425ef37b6494c97c4da6d9f5ef3","author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"date":"2015-08-07 12:16:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"baa36e88afc0b7836f3fd9f93aedf8393fa84194","author":{"_account_id":9751,"name":"IBM DB2 CI","email":"scecd@cn.ibm.com","username":"ibmdb2","tags":["SERVICE_USER"]},"date":"2015-08-07 12:56:12.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\nPlease refer to wiki ThirdPartySystems/IBM_DB2_CI (https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_DB2_CI) for detailed DB2 CI introduction.\n\nYou can also leave a comment \u0027recheck db2-test\u0027 to re-triger this test.\n\n\n- ibm-db2-ci-heat http://dal05.objectstorage.softlayer.net/v1/AUTH_58396f85-2c60-47b9-aaf8-e03bc24a1a6f/cilog/55/210255/1/check/ibm-db2-ci-heat/2f607ab : SUCCESS in 4h 06m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f9d4c22e3c362a04ada83e5a71534659b11754a2","author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"date":"2015-08-07 13:34:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"faf01c590394f311c724f987405302149e947d82","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-07 13:34:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a6146eee4a4a669349c3ed6cc5f72861bb2e05d1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-07 14:30:59.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-heat-docs http://docs-draft.openstack.org/55/210255/1/gate/gate-heat-docs/58d8380//doc/build/html/ : SUCCESS in 3m 43s\n- gate-heat-pep8 http://logs.openstack.org/55/210255/1/gate/gate-heat-pep8/3b29776/ : SUCCESS in 3m 51s\n- gate-heat-python27 http://logs.openstack.org/55/210255/1/gate/gate-heat-python27/3e4e47e/ : SUCCESS in 6m 27s\n- gate-heat-python34 http://logs.openstack.org/55/210255/1/gate/gate-heat-python34/bbf2c65/ : SUCCESS in 8m 24s\n- gate-heat-dsvm-functional-orig-mysql http://logs.openstack.org/55/210255/1/gate/gate-heat-dsvm-functional-orig-mysql/dc59d50/ : SUCCESS in 36m 18s\n- gate-tempest-dsvm-heat http://logs.openstack.org/55/210255/1/gate/gate-tempest-dsvm-heat/d8085aa/ : SUCCESS in 30m 32s\n- gate-grenade-dsvm-heat http://logs.openstack.org/55/210255/1/gate/gate-grenade-dsvm-heat/04d2a22/ : SUCCESS in 55m 50s","accounts_in_message":[],"_revision_number":1},{"id":"442ffb3d48e0519c43a54a30ce077f7516cc7aa8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-07 14:31:01.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"9c443f58706b9ae6de37a42df98b255d5cb4f1fe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-08 11:20:09.000000000","message":"Patch Set 1:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ironic-overcloud-precise-nonha http://logs.openstack.org/55/210255/1/check-tripleo/gate-tripleo-ironic-overcloud-precise-nonha/ce7341e/ : FAILURE in 1h 42m 25s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d204c979b864dbe82e1ee269e2243775175b5749","revisions":{"d204c979b864dbe82e1ee269e2243775175b5749":{"kind":"REWORK","_number":1,"created":"2015-08-07 08:49:58.000000000","uploader":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"ref":"refs/changes/55/210255/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/heat","ref":"refs/changes/55/210255/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/heat refs/changes/55/210255/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/heat refs/changes/55/210255/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/heat refs/changes/55/210255/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/heat refs/changes/55/210255/1"}}},"commit":{"parents":[{"commit":"2a6987ea2dd898ce411019e6b82603a6c06fb2bc","subject":"Merge \"OS::Cinder::VolumeType help doc string contains redundant info\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/2a6987ea2dd898ce411019e6b82603a6c06fb2bc"}]}],"author":{"name":"Sergey Kraynev","email":"skraynev@mirantis.com","date":"2015-08-07 08:42:33.000000000","tz":-240},"committer":{"name":"Sergey Kraynev","email":"skraynev@mirantis.com","date":"2015-08-07 08:42:33.000000000","tz":-240},"subject":"Don\u0027t use default None for params in handle_update","message":"Don\u0027t use default None for params in handle_update\n\nThe main \"update\" function in resource.py call custom handle_update\nmethods of resources. handle_update method always get not None\nparameters: after, tmpl_diff, prop_diff. Where:\n - \u0027after\u0027 is not None snippet of resource\n - tmpl_diff and prop_diff - values calculated corresponding functions,\n   which return only dictionary (empty or not empty).\n\nThis patch removes default None values from handle_update method of some\nresources to make all interfaces similar.\n\nChange-Id: Id62201e3a26b557a941bbd904a947f064df4aeb3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/d204c979b864dbe82e1ee269e2243775175b5749"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/d204c979b864dbe82e1ee269e2243775175b5749"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2a6987ea2dd898ce411019e6b82603a6c06fb2bc","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}