)]}'
{"heat_integrationtests/scenario/templates/test_autoscaling_lbv2_neutron.yaml":[{"author":{"_account_id":8792,"name":"Manish Godara","email":"manishg@yahoo-inc.com","username":"manishg"},"change_message_id":"d14621ce00df33793e9ca4bdfd6a3e82f164d4a6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      listener: { get_resource: listener }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  listener:"},{"line_number":91,"context_line":"    type: OS::Neutron::LBaaS::Listener"},{"line_number":92,"context_line":"    properties:"},{"line_number":93,"context_line":"      loadbalancer: { get_resource: loadbalancer }"},{"line_number":94,"context_line":"      protocol: HTTP"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a29b11f_3ff915c9","line":91,"updated":"2015-10-26 18:13:54.000000000","message":"where is this defined?  I see a bunch of OS::Neutron::* resources in resources/neutron/loadbalancer.py but this is not included there.","commit_id":"2612377d0f2cf33b5225a1ffe0ce99f8bd94199a"},{"author":{"_account_id":8792,"name":"Manish Godara","email":"manishg@yahoo-inc.com","username":"manishg"},"change_message_id":"e098bf722a97b05682ca1d6a2b8408c6b0e228c1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      listener: { get_resource: listener }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  listener:"},{"line_number":91,"context_line":"    type: OS::Neutron::LBaaS::Listener"},{"line_number":92,"context_line":"    properties:"},{"line_number":93,"context_line":"      loadbalancer: { get_resource: loadbalancer }"},{"line_number":94,"context_line":"      protocol: HTTP"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a26ad4f_4effa401","line":91,"in_reply_to":"1a26ad4f_1a31e70b","updated":"2015-10-27 21:55:55.000000000","message":"found the link to bp! thanks.","commit_id":"2612377d0f2cf33b5225a1ffe0ce99f8bd94199a"},{"author":{"_account_id":11832,"name":"Bryan Jones","email":"jonesbr@us.ibm.com","username":"jonesbr"},"change_message_id":"9d5e6201acbf0d0d6848e6f4fdaa78ad2bb5ee59","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      listener: { get_resource: listener }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  listener:"},{"line_number":91,"context_line":"    type: OS::Neutron::LBaaS::Listener"},{"line_number":92,"context_line":"    properties:"},{"line_number":93,"context_line":"      loadbalancer: { get_resource: loadbalancer }"},{"line_number":94,"context_line":"      protocol: HTTP"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a29b11f_9fd5c9ba","line":91,"in_reply_to":"3a29b11f_3ff915c9","updated":"2015-10-26 18:39:43.000000000","message":"The OS::Neutron::LBaaS::* resources are in development right now. The loadbalancer patch can be found here: https://review.openstack.org/#/c/238612/, and more are on the way soon.","commit_id":"2612377d0f2cf33b5225a1ffe0ce99f8bd94199a"},{"author":{"_account_id":8792,"name":"Manish Godara","email":"manishg@yahoo-inc.com","username":"manishg"},"change_message_id":"971e9b49487fb7f46305eb413d2e659ab6e88e6b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      listener: { get_resource: listener }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  listener:"},{"line_number":91,"context_line":"    type: OS::Neutron::LBaaS::Listener"},{"line_number":92,"context_line":"    properties:"},{"line_number":93,"context_line":"      loadbalancer: { get_resource: loadbalancer }"},{"line_number":94,"context_line":"      protocol: HTTP"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a26ad4f_1a31e70b","line":91,"in_reply_to":"3a29b11f_9fd5c9ba","updated":"2015-10-27 21:54:09.000000000","message":"Thanks.  I think without getting the idea of what the listener or other resources are expecting exactly and without knowing what the schema is for these properties it would be difficult to review.  Is there a blueprint that has the details (even if it\u0027s not implemented)?  I see the LoadBalancer resource patch - thanks.","commit_id":"2612377d0f2cf33b5225a1ffe0ce99f8bd94199a"},{"author":{"_account_id":11832,"name":"Bryan Jones","email":"jonesbr@us.ibm.com","username":"jonesbr"},"change_message_id":"9d5e6201acbf0d0d6848e6f4fdaa78ad2bb5ee59","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  loadbalancer:"},{"line_number":98,"context_line":"    type: OS::Neutron::LBaaS::LoadBalancer"},{"line_number":99,"context_line":"    properties:"},{"line_number":100,"context_line":"      vip_subnet: { get_resource: subnet }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  floating_ip:"},{"line_number":103,"context_line":"    type: OS::Neutron::FloatingIP"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a29b11f_443d8cdb","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":32},"updated":"2015-10-26 18:39:43.000000000","message":"I think you mean get_param here","commit_id":"2612377d0f2cf33b5225a1ffe0ce99f8bd94199a"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"b3271fb50222f6f045e3c87275e7c866194d3e50","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  loadbalancer:"},{"line_number":98,"context_line":"    type: OS::Neutron::LBaaS::LoadBalancer"},{"line_number":99,"context_line":"    properties:"},{"line_number":100,"context_line":"      vip_subnet: { get_resource: subnet }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  floating_ip:"},{"line_number":103,"context_line":"    type: OS::Neutron::FloatingIP"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a29b11f_a7875b11","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":32},"in_reply_to":"3a29b11f_443d8cdb","updated":"2015-10-26 22:09:01.000000000","message":"Done","commit_id":"2612377d0f2cf33b5225a1ffe0ce99f8bd94199a"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"60ca55d84108933ebc786fcbdce917eafff117e2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"          net: { get_param: net}"},{"line_number":54,"context_line":"          sec_group: { get_resource: sec_group }"},{"line_number":55,"context_line":"          app_port: { get_param: app_port }"},{"line_number":56,"context_line":"          pool_id: { get_resource: pool }"},{"line_number":57,"context_line":"          subnet: { get_param: subnet }"},{"line_number":58,"context_line":"          timeout: { get_param: timeout }"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dae33548_82f93883","line":56,"updated":"2016-02-16 03:28:26.000000000","message":"This should be pool, not pool_id. In your app_server the parameter is named as pool.","commit_id":"aba722407c1c5e0f124ccd25230e1a8ab6c0b8b4"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"6291b31a6fed277d328182c25d44651b7a8fe015","unresolved":false,"context_lines":[{"line_number":53,"context_line":"          net: { get_param: net}"},{"line_number":54,"context_line":"          sec_group: { get_resource: sec_group }"},{"line_number":55,"context_line":"          app_port: { get_param: app_port }"},{"line_number":56,"context_line":"          pool_id: { get_resource: pool }"},{"line_number":57,"context_line":"          subnet: { get_param: subnet }"},{"line_number":58,"context_line":"          timeout: { get_param: timeout }"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dae33548_a927e1b4","line":56,"in_reply_to":"dae33548_82f93883","updated":"2016-02-16 15:37:33.000000000","message":"Done","commit_id":"aba722407c1c5e0f124ccd25230e1a8ab6c0b8b4"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"60ca55d84108933ebc786fcbdce917eafff117e2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      pool: { get_resource: pool }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  pool:"},{"line_number":84,"context_line":"    type: OS::Neutron::LBaasS::Pool"},{"line_number":85,"context_line":"    properties:"},{"line_number":86,"context_line":"      lb_algorithm: ROUND_ROBIN"},{"line_number":87,"context_line":"      protocol: HTTP"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dae33548_62d99483","line":84,"updated":"2016-02-16 03:28:26.000000000","message":"There is typo here LBaasS!","commit_id":"aba722407c1c5e0f124ccd25230e1a8ab6c0b8b4"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"6291b31a6fed277d328182c25d44651b7a8fe015","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      pool: { get_resource: pool }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  pool:"},{"line_number":84,"context_line":"    type: OS::Neutron::LBaasS::Pool"},{"line_number":85,"context_line":"    properties:"},{"line_number":86,"context_line":"      lb_algorithm: ROUND_ROBIN"},{"line_number":87,"context_line":"      protocol: HTTP"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dae33548_2943d143","line":84,"in_reply_to":"dae33548_62d99483","updated":"2016-02-16 15:37:33.000000000","message":"Done","commit_id":"aba722407c1c5e0f124ccd25230e1a8ab6c0b8b4"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"60ca55d84108933ebc786fcbdce917eafff117e2","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  floating_ip:"},{"line_number":103,"context_line":"    type: OS::Neutron::FloatingIP"},{"line_number":104,"context_line":"    properties:"},{"line_number":105,"context_line":"    floating_network: { get_param: public_net }"},{"line_number":106,"context_line":"    port_id: { get_attr: [loadbalancer, vip, \u0027port_id\u0027] }"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dae33548_82de586b","line":104,"updated":"2016-02-16 03:28:26.000000000","message":"Following two lines need to be indented.","commit_id":"aba722407c1c5e0f124ccd25230e1a8ab6c0b8b4"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"6291b31a6fed277d328182c25d44651b7a8fe015","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  floating_ip:"},{"line_number":103,"context_line":"    type: OS::Neutron::FloatingIP"},{"line_number":104,"context_line":"    properties:"},{"line_number":105,"context_line":"    floating_network: { get_param: public_net }"},{"line_number":106,"context_line":"    port_id: { get_attr: [loadbalancer, vip, \u0027port_id\u0027] }"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dae33548_4948d55b","line":104,"in_reply_to":"dae33548_82de586b","updated":"2016-02-16 15:37:33.000000000","message":"Done","commit_id":"aba722407c1c5e0f124ccd25230e1a8ab6c0b8b4"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"0c6f2bd5ae81738225dae1114a7f78d9bca8257a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    type: OS::Neutron::FloatingIP"},{"line_number":104,"context_line":"    properties:"},{"line_number":105,"context_line":"    floating_network: { get_param: public_net }"},{"line_number":106,"context_line":"    port_id: { get_attr: [loadbalancer, vip, \u0027port_id\u0027] }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"outputs:"},{"line_number":109,"context_line":"  lburl:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dae33548_02efe887","line":106,"updated":"2016-02-16 04:27:48.000000000","message":"Please change vip to vip_address, as vip_address is the attribute defined in loadbalancer.py. Also, since vip_address is a string type, assigning floating ip address to it is difficult. To do this, you must expose the vip_port_id attribute in loadbalancer.py. I have given my comment there as well.","commit_id":"aba722407c1c5e0f124ccd25230e1a8ab6c0b8b4"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"6291b31a6fed277d328182c25d44651b7a8fe015","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    type: OS::Neutron::FloatingIP"},{"line_number":104,"context_line":"    properties:"},{"line_number":105,"context_line":"    floating_network: { get_param: public_net }"},{"line_number":106,"context_line":"    port_id: { get_attr: [loadbalancer, vip, \u0027port_id\u0027] }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"outputs:"},{"line_number":109,"context_line":"  lburl:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dae33548_2998f1bf","line":106,"in_reply_to":"dae33548_02efe887","updated":"2016-02-16 15:37:33.000000000","message":"Done","commit_id":"aba722407c1c5e0f124ccd25230e1a8ab6c0b8b4"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"61678afe553abc838a200b7f6379a5eae1031316","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    type: OS::Neutron::FloatingIP"},{"line_number":104,"context_line":"    properties:"},{"line_number":105,"context_line":"      floating_network: { get_param: public_net }"},{"line_number":106,"context_line":"      port_id: { get_attr: [loadbalancer, vip_address, \u0027port_id\u0027] }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"outputs:"},{"line_number":109,"context_line":"  lburl:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dae33548_81324da5","line":106,"updated":"2016-02-18 07:39:55.000000000","message":"This will still not work, please change it to:\nport_id: { get_attr: [loadbalancer, vip_port_id] }\n\nvip_port_id is now exposed in loadbalancer resource plugin.\nPlease test once with this change.","commit_id":"4acf07d867a15d04355e8b7880b2e4a507164a27"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"bea6cb02443b1f03a7c290d97df58fe6ee9eaaa3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    type: OS::Neutron::FloatingIP"},{"line_number":104,"context_line":"    properties:"},{"line_number":105,"context_line":"      floating_network: { get_param: public_net }"},{"line_number":106,"context_line":"      port_id: { get_attr: [loadbalancer, vip_address, \u0027port_id\u0027] }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"outputs:"},{"line_number":109,"context_line":"  lburl:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dae33548_51111b51","line":106,"in_reply_to":"dae33548_81324da5","updated":"2016-02-18 15:09:06.000000000","message":"Done","commit_id":"4acf07d867a15d04355e8b7880b2e4a507164a27"}],"heat_integrationtests/scenario/test_autoscaling_lbv2.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"416e2fdb34468701cd199973ddd333512f69a0bd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        resp \u003d set()"},{"line_number":39,"context_line":"        for count in range(retries):"},{"line_number":40,"context_line":"            time.sleep(5)"},{"line_number":41,"context_line":"            r \u003d requests.get(url)"},{"line_number":42,"context_line":"            # skip unsuccessfull requests"},{"line_number":43,"context_line":"            if r.status_code \u003d\u003d 200:"},{"line_number":44,"context_line":"                resp.add(r.text)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3afc51ec_6a3cc0e2","line":41,"updated":"2016-03-14 10:27:34.000000000","message":"I strongly suggest to do what we did in the other tests, and catch connection errors. Maybe reduce the sleep time, too.","commit_id":"9d87968cf568c92248916b0593e9689b26e4e898"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"35589f2e9940634339354402eb6658d8c3c124fe","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        resp \u003d set()"},{"line_number":39,"context_line":"        for count in range(retries):"},{"line_number":40,"context_line":"            time.sleep(5)"},{"line_number":41,"context_line":"            r \u003d requests.get(url)"},{"line_number":42,"context_line":"            # skip unsuccessfull requests"},{"line_number":43,"context_line":"            if r.status_code \u003d\u003d 200:"},{"line_number":44,"context_line":"                resp.add(r.text)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3afc51ec_f2b70c84","line":41,"in_reply_to":"3afc51ec_6a3cc0e2","updated":"2016-03-14 16:41:08.000000000","message":"Thomas, could you provide a pointer to an example of this?\nAnd in this case, running locally, I only see this loop being run once, so this seems to have little to do with the test time total.","commit_id":"9d87968cf568c92248916b0593e9689b26e4e898"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"e5af44bee356f901cea5ed3921fff8545389f91b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        resp \u003d set()"},{"line_number":39,"context_line":"        for count in range(retries):"},{"line_number":40,"context_line":"            time.sleep(5)"},{"line_number":41,"context_line":"            r \u003d requests.get(url)"},{"line_number":42,"context_line":"            # skip unsuccessfull requests"},{"line_number":43,"context_line":"            if r.status_code \u003d\u003d 200:"},{"line_number":44,"context_line":"                resp.add(r.text)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3afc51ec_cd13550c","line":41,"in_reply_to":"3afc51ec_f2b70c84","updated":"2016-03-14 16:48:51.000000000","message":"https://github.com/openstack/heat/blob/master/heat_integrationtests/scenario/test_autoscaling_lb.py#L42\n\nWell if you loop only once, maybe you can shove 4 sec from the test then?","commit_id":"9d87968cf568c92248916b0593e9689b26e4e898"}]}
