)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"6acb0226c638d334d91f163fcf2050224217508a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds below networking-sfc resources"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"OS::Neutron::Portpair"},{"line_number":12,"context_line":"OS::Neutron::PortPairGroup"},{"line_number":13,"context_line":"OS::Neutron::Flowclassifier"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia51d044ccdad2595a697143ca1e9d2f9bb1dfc8e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_96e82ae4","line":12,"updated":"2015-11-25 12:13:26.000000000","message":"will add \"OS::Neutron::PortChain\"","commit_id":"291217edd4ebddca203cae349110a4a1721a6c32"}],"heat/engine/resources/openstack/neutron/sfc.py":[{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"6e1d3be4a1460099b43abb5eb5290d039552ea33","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class PortPair(neutron.NeutronResource):"},{"line_number":22,"context_line":"    \"\"\"A resource for the Port Pair resource in Neutron port pair.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    required_service_extension \u003d \u0027sfc\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    PROPERTIES \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_0646a37a","line":23,"updated":"2015-11-30 06:54:23.000000000","message":"support_status \u003d support.SupportStatus(version\u003d\u00276.0.0\u0027)","commit_id":"220faab5d084b4d772f330607397bcb760bf85fa"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"34bed98ae44d72495acdf54fbbd6c86f154c2922","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        ),"},{"line_number":56,"context_line":"        INGRESS: properties.Schema("},{"line_number":57,"context_line":"            properties.Schema.STRING,"},{"line_number":58,"context_line":"            _(\u0027Ingress neutron port id \u0027),"},{"line_number":59,"context_line":"            required\u003dTrue,"},{"line_number":60,"context_line":"        ),"},{"line_number":61,"context_line":"        EGRESS: properties.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_3dedd525","line":58,"range":{"start_line":58,"start_character":38,"end_line":58,"end_character":39},"updated":"2016-02-02 14:37:10.000000000","message":"Is there a reason why some of the strings end in a period and others in a space? I haven\u0027t spent any time looking at other Heat resource code, but the differences between string ending on lines 48 \u0026 53 vs 58 \u0026 63 vs 68 look odd.","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"34bed98ae44d72495acdf54fbbd6c86f154c2922","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    attributes_schema \u003d {"},{"line_number":73,"context_line":"        NAME: attributes.Schema("},{"line_number":74,"context_line":"            properties.Schema.STRING,"},{"line_number":75,"context_line":"            _(\u0027Name for the Port Pair.\u0027),"},{"line_number":76,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":77,"context_line":"        ),"},{"line_number":78,"context_line":"        DESCRIPTION: attributes.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_5d6bf185","line":75,"range":{"start_line":75,"start_character":37,"end_line":75,"end_character":38},"updated":"2016-02-02 14:37:10.000000000","message":"Here as above, periods at the end of two strings, spaces at the end of two other strings and the last string (line 95) has neither period nor space at the end.","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"86d03b41c71ffb0e6d6cb76aa05f97313ce9cc04","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        ),"},{"line_number":153,"context_line":"        PORT_PAIRS: properties.Schema("},{"line_number":154,"context_line":"            properties.Schema.LIST,"},{"line_number":155,"context_line":"            _(\u0027An list of port pairs to apply to the Port Pair Group..\u0027),"},{"line_number":156,"context_line":"            required\u003dTrue,"},{"line_number":157,"context_line":"            update_allowed\u003dTrue"},{"line_number":158,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_9d6c0938","line":155,"updated":"2016-02-02 14:51:02.000000000","message":"\"An list ...\" -\u003e \"A list ...\" - check throughout.\n\nCheck for consistency in the use of full stops (some are \"..\" or \" .\" and others have none) in the property/attribute descriptions throughout.","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"34bed98ae44d72495acdf54fbbd6c86f154c2922","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        ),"},{"line_number":153,"context_line":"        PORT_PAIRS: properties.Schema("},{"line_number":154,"context_line":"            properties.Schema.LIST,"},{"line_number":155,"context_line":"            _(\u0027An list of port pairs to apply to the Port Pair Group..\u0027),"},{"line_number":156,"context_line":"            required\u003dTrue,"},{"line_number":157,"context_line":"            update_allowed\u003dTrue"},{"line_number":158,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_3d2ab57f","line":155,"range":{"start_line":155,"start_character":15,"end_line":155,"end_character":17},"updated":"2016-02-02 14:37:10.000000000","message":"An -\u003e A","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"34bed98ae44d72495acdf54fbbd6c86f154c2922","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        ),"},{"line_number":153,"context_line":"        PORT_PAIRS: properties.Schema("},{"line_number":154,"context_line":"            properties.Schema.LIST,"},{"line_number":155,"context_line":"            _(\u0027An list of port pairs to apply to the Port Pair Group..\u0027),"},{"line_number":156,"context_line":"            required\u003dTrue,"},{"line_number":157,"context_line":"            update_allowed\u003dTrue"},{"line_number":158,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_5d19b121","line":155,"range":{"start_line":155,"start_character":68,"end_line":155,"end_character":70},"updated":"2016-02-02 14:37:10.000000000","message":"Does the double period mean something specific?","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"34bed98ae44d72495acdf54fbbd6c86f154c2922","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    attributes_schema \u003d {"},{"line_number":162,"context_line":"        NAME_ATTR: attributes.Schema("},{"line_number":163,"context_line":"            _(\u0027Name for the Port Pair Group..\u0027),"},{"line_number":164,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":165,"context_line":"        ),"},{"line_number":166,"context_line":"        DESCRIPTION_ATTR: attributes.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_dd97e138","line":163,"range":{"start_line":163,"start_character":43,"end_line":163,"end_character":45},"updated":"2016-02-02 14:37:10.000000000","message":"Double periods again here and on lines 167, 171, and 175. Do these have significance or are they just typos?","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"34bed98ae44d72495acdf54fbbd6c86f154c2922","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":169,"context_line":"        ),"},{"line_number":170,"context_line":"        PORT_PAIRS_ATTR: attributes.Schema("},{"line_number":171,"context_line":"            _(\u0027An list of port pairs to apply to the Port Pair Group..\u0027),"},{"line_number":172,"context_line":"            type\u003dattributes.Schema.LIST"},{"line_number":173,"context_line":"        ),"},{"line_number":174,"context_line":"        TENANT_ID: attributes.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_fd5add29","line":171,"range":{"start_line":171,"start_character":15,"end_line":171,"end_character":17},"updated":"2016-02-02 14:37:10.000000000","message":"An -\u003e A","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"34bed98ae44d72495acdf54fbbd6c86f154c2922","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        ),"},{"line_number":239,"context_line":"        PORT_PAIR_GROUPS: properties.Schema("},{"line_number":240,"context_line":"            properties.Schema.LIST,"},{"line_number":241,"context_line":"            _(\u0027An list of port pair groups to apply to the Port Chain\u0027),"},{"line_number":242,"context_line":"            required\u003dTrue,"},{"line_number":243,"context_line":"        ),"},{"line_number":244,"context_line":"        FLOW_CLASSIFIERS: properties.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_fdeaddab","line":241,"range":{"start_line":241,"start_character":15,"end_line":241,"end_character":17},"updated":"2016-02-02 14:37:10.000000000","message":"An -\u003e A","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"34bed98ae44d72495acdf54fbbd6c86f154c2922","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        ),"},{"line_number":244,"context_line":"        FLOW_CLASSIFIERS: properties.Schema("},{"line_number":245,"context_line":"            properties.Schema.LIST,"},{"line_number":246,"context_line":"            _(\u0027An list of flow classifiers to apply to the Port Chain\u0027),"},{"line_number":247,"context_line":"            required\u003dTrue,"},{"line_number":248,"context_line":"            update_allowed\u003dTrue"},{"line_number":249,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_1d033978","line":246,"range":{"start_line":246,"start_character":15,"end_line":246,"end_character":17},"updated":"2016-02-02 14:37:10.000000000","message":"An -\u003e A","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"34bed98ae44d72495acdf54fbbd6c86f154c2922","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":264,"context_line":"        ),"},{"line_number":265,"context_line":"        PORT_PAIR_GROUPS_ATTR: attributes.Schema("},{"line_number":266,"context_line":"            _(\u0027An list of port pair groups to apply to the Port Pair Group.\u0027),"},{"line_number":267,"context_line":"            type\u003dattributes.Schema.LIST"},{"line_number":268,"context_line":"        ),"},{"line_number":269,"context_line":"        TENANT_ID: attributes.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_1d2a59e8","line":266,"range":{"start_line":266,"start_character":15,"end_line":266,"end_character":17},"updated":"2016-02-02 14:37:10.000000000","message":"An -\u003e A","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"34bed98ae44d72495acdf54fbbd6c86f154c2922","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":272,"context_line":"        ),"},{"line_number":273,"context_line":"        FLOW_CLASSIFIERS_ATTR: attributes.Schema("},{"line_number":274,"context_line":"            _(\u0027An list of flow classifiers to apply to the Port Chain.\u0027),"},{"line_number":275,"context_line":"            type\u003dattributes.Schema.LIST"},{"line_number":276,"context_line":"        ),"},{"line_number":277,"context_line":"        CHAIN_PARAMETERS_ATTR: attributes.Schema("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_bd3b0538","line":274,"range":{"start_line":274,"start_character":15,"end_line":274,"end_character":17},"updated":"2016-02-02 14:37:10.000000000","message":"An -\u003e A","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"86d03b41c71ffb0e6d6cb76aa05f97313ce9cc04","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        ),"},{"line_number":381,"context_line":"        SOURCE_PORT_RANGE_MIN: properties.Schema("},{"line_number":382,"context_line":"            properties.Schema.STRING,"},{"line_number":383,"context_line":"            _(\u0027Source protocol port Minimum (allowed range [1,65535].\u0027),"},{"line_number":384,"context_line":"        ),"},{"line_number":385,"context_line":"        SOURCE_PORT_RANGE_MAX: properties.Schema("},{"line_number":386,"context_line":"            properties.Schema.STRING,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_fd017d6b","line":383,"updated":"2016-02-02 14:51:02.000000000","message":"Recc. to give these ranges (through DESTINATION_PORT_RANGE_MAX) a range constraint, e.g.:\n\nconstraints\u003d[\n    constraints.Range(min\u003d1,max\u003d65535)\n]","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"86d03b41c71ffb0e6d6cb76aa05f97313ce9cc04","unresolved":false,"context_lines":[{"line_number":477,"context_line":"        props \u003d self.prepare_properties("},{"line_number":478,"context_line":"            self.properties,"},{"line_number":479,"context_line":"            self.physical_resource_name())"},{"line_number":480,"context_line":"        if props.get(self.PROTOCOL) \u003d\u003d \u0027any\u0027:"},{"line_number":481,"context_line":"            props[self.PROTOCOL] \u003d None"},{"line_number":482,"context_line":"        flow_classifier \u003d self.client().create_ext("},{"line_number":483,"context_line":"            {\u0027flow_classifier\u0027: props})[\u0027flow_classifier\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_e8e0d9fc","line":480,"updated":"2016-02-02 14:51:02.000000000","message":"Q to make sure I understand: Why is \"any\" equivalent to \"none\" here (and elsewhere)?","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"86d03b41c71ffb0e6d6cb76aa05f97313ce9cc04","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        \u0027OS::Neutron::PortPair\u0027: PortPair,"},{"line_number":505,"context_line":"        \u0027OS::Neutron::PortPairGroup\u0027: PortPairGroup,"},{"line_number":506,"context_line":"        \u0027OS::Neutron::PortChain\u0027: PortChain,"},{"line_number":507,"context_line":"        \u0027OS::Neutron::Flowclassifier\u0027: FlowClassifier,"},{"line_number":508,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_3da5d5b4","line":507,"updated":"2016-02-02 14:51:02.000000000","message":"OS::Neutron::Flowclassifier --\u003e OS::Neutron::FlowClassifier","commit_id":"e75c8d6d58be3789f76bb751148a38924dd99663"}],"heat/engine/resources/openstack/neutron/sfc/flow_classifier.py":[{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class FlowClassifier(neutron.NeutronResource):"},{"line_number":29,"context_line":"    \"\"\"A resource for the Flow Classifier resource in SFC.\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u00276.0.0\u0027)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_a7ac0b36","line":29,"updated":"2016-02-04 11:53:41.000000000","message":"Add there detailed description for what resource is needed.","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027logical_source_port\u0027, \u0027logical_destination_port\u0027, \u0027l7_parameters\u0027,"},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    ATTRIBUTES \u003d ("},{"line_number":50,"context_line":"        NAME_ATTR, DESCRIPTION_ATTR, PROTOCOL_ATTR, ETHERTYPE_ATTR,"},{"line_number":51,"context_line":"        SOURCE_IP_PREFIX_ATTR, DESTINATION_IP_PREFIX_ATTR,"},{"line_number":52,"context_line":"        SOURCE_PORT_RANGE_MIN_ATTR, SOURCE_PORT_RANGE_MAX_ATTR,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_3a3592d9","line":49,"updated":"2016-02-04 11:53:41.000000000","message":"what the reason to return all defined in properties attributes? Think, you should return values which undefined in properties.","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        ),"},{"line_number":81,"context_line":"        ETHERTYPE: properties.Schema("},{"line_number":82,"context_line":"            properties.Schema.STRING,"},{"line_number":83,"context_line":"            _(\u0027L2 ethertype, default is IPv4.\u0027),"},{"line_number":84,"context_line":"            default\u003d\u0027IPv4\u0027,"},{"line_number":85,"context_line":"            constraints\u003d["},{"line_number":86,"context_line":"                constraints.AllowedValues([\u0027IPv4\u0027, \u0027IPv6\u0027]),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_e7476375","line":83,"range":{"start_line":83,"start_character":29,"end_line":83,"end_character":45},"updated":"2016-02-04 11:53:41.000000000","message":"unnecessary comment in case of next line.","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        ),"},{"line_number":103,"context_line":"        SOURCE_PORT_RANGE_MIN: properties.Schema("},{"line_number":104,"context_line":"            properties.Schema.STRING,"},{"line_number":105,"context_line":"            _(\u0027Source protocol port Minimum (allowed range [1,65535].\u0027),"},{"line_number":106,"context_line":"        ),"},{"line_number":107,"context_line":"        SOURCE_PORT_RANGE_MAX: properties.Schema("},{"line_number":108,"context_line":"            properties.Schema.STRING,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_27357bf6","line":105,"range":{"start_line":105,"start_character":44,"end_line":105,"end_character":69},"updated":"2016-02-04 11:53:41.000000000","message":"add there constraint for this range","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        ),"},{"line_number":107,"context_line":"        SOURCE_PORT_RANGE_MAX: properties.Schema("},{"line_number":108,"context_line":"            properties.Schema.STRING,"},{"line_number":109,"context_line":"            _(\u0027Source protocol port Maximum (allowed range [1,65535].\u0027),"},{"line_number":110,"context_line":"        ),"},{"line_number":111,"context_line":"        DESTINATION_PORT_RANGE_MIN: properties.Schema("},{"line_number":112,"context_line":"            properties.Schema.STRING,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_c73b47ea","line":109,"range":{"start_line":109,"start_character":44,"end_line":109,"end_character":68},"updated":"2016-02-04 11:53:41.000000000","message":"same","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        ),"},{"line_number":111,"context_line":"        DESTINATION_PORT_RANGE_MIN: properties.Schema("},{"line_number":112,"context_line":"            properties.Schema.STRING,"},{"line_number":113,"context_line":"            _(\u0027Destination protocol port Minimum (allowed range [1,65535].\u0027),"},{"line_number":114,"context_line":"        ),"},{"line_number":115,"context_line":"        DESTINATION_PORT_RANGE_MAX: properties.Schema("},{"line_number":116,"context_line":"            properties.Schema.STRING,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_e73e83d9","line":113,"range":{"start_line":113,"start_character":49,"end_line":113,"end_character":73},"updated":"2016-02-04 11:53:41.000000000","message":"same","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        ),"},{"line_number":115,"context_line":"        DESTINATION_PORT_RANGE_MAX: properties.Schema("},{"line_number":116,"context_line":"            properties.Schema.STRING,"},{"line_number":117,"context_line":"            _(\u0027Destination protocol port Maximum (allowed range [1,65535].\u0027),"},{"line_number":118,"context_line":"        ),"},{"line_number":119,"context_line":"        LOGICAL_SOURCE_PORT: properties.Schema("},{"line_number":120,"context_line":"            properties.Schema.STRING,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_a7216bb6","line":117,"range":{"start_line":117,"start_character":49,"end_line":117,"end_character":73},"updated":"2016-02-04 11:53:41.000000000","message":"same","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        L7_PARAMETERS: properties.Schema("},{"line_number":129,"context_line":"            properties.Schema.MAP,"},{"line_number":130,"context_line":"            _(\u0027Dictionary of L7-parameters. Currently, no value is \u0027"},{"line_number":131,"context_line":"                \u0027supported for this option.\u0027),"},{"line_number":132,"context_line":"        ),"},{"line_number":133,"context_line":"    }"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_870d4f40","line":131,"range":{"start_line":131,"start_character":14,"end_line":131,"end_character":16},"updated":"2016-02-04 11:53:41.000000000","message":"wrong indent","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"ea28e2ecf976fa585aec3e2b5a5dbc0fdf145857","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":143,"context_line":"        ),"},{"line_number":144,"context_line":"        PROTOCOL_ATTR: attributes.Schema("},{"line_number":145,"context_line":"            _(\u0027IP protocol name. Protocol name should be as per \u0027"},{"line_number":146,"context_line":"              \u0027IANA standard.\u0027),"},{"line_number":147,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":148,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_b269dd8d","line":145,"updated":"2016-02-03 15:51:45.000000000","message":"Add constraint to enforce IANA standard, or define a custom one in this module, based on https://github.com/openstack/heat/blob/master/heat/engine/constraints.py","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"ea28e2ecf976fa585aec3e2b5a5dbc0fdf145857","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":148,"context_line":"        ),"},{"line_number":149,"context_line":"        ETHERTYPE_ATTR: attributes.Schema("},{"line_number":150,"context_line":"            _(\u0027L2 ethertype, default is IPv4.\u0027),"},{"line_number":151,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":152,"context_line":"        ),"},{"line_number":153,"context_line":"        SOURCE_IP_PREFIX_ATTR: attributes.Schema("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_d2f9f9c9","line":150,"updated":"2016-02-03 15:51:45.000000000","message":"Add constraint to enforce valid ethertypes, or define a custom one in this module, based on https://github.com/openstack/heat/blob/master/heat/engine/constraints.py","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"ea28e2ecf976fa585aec3e2b5a5dbc0fdf145857","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":160,"context_line":"        ),"},{"line_number":161,"context_line":"        SOURCE_PORT_RANGE_MIN_ATTR: attributes.Schema("},{"line_number":162,"context_line":"            _(\u0027Source protocol port Minimum (allowed range [1,65535].\u0027),"},{"line_number":163,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":164,"context_line":"        ),"},{"line_number":165,"context_line":"        SOURCE_PORT_RANGE_MAX_ATTR: attributes.Schema("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_523749b0","line":162,"updated":"2016-02-03 15:51:45.000000000","message":"Recc. to give these ranges (through DESTINATION_PORT_RANGE_MAX) a range constraint, e.g.:\n\n  constraints\u003d[\n      constraints.Range(min\u003d1,max\u003d65535)\n  ]","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"ea28e2ecf976fa585aec3e2b5a5dbc0fdf145857","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        props \u003d self.prepare_properties("},{"line_number":202,"context_line":"            self.properties,"},{"line_number":203,"context_line":"            self.physical_resource_name())"},{"line_number":204,"context_line":"        if props.get(self.PROTOCOL) \u003d\u003d \u0027any\u0027:"},{"line_number":205,"context_line":"            props[self.PROTOCOL] \u003d None"},{"line_number":206,"context_line":"        flow_classifier \u003d self.client().create_ext(FLOW_CLASSIFIERS_PATH,"},{"line_number":207,"context_line":"                                                   {\u0027flow_classifier\u0027: props}"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_72d5a541","line":204,"updated":"2016-02-03 15:51:45.000000000","message":"Q to make sure I understand: Why is \"any\" equivalent to \"none\" here (and elsewhere)?","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"ea28e2ecf976fa585aec3e2b5a5dbc0fdf145857","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"def resource_mapping():"},{"line_number":231,"context_line":"    return {"},{"line_number":232,"context_line":"        \u0027OS::Neutron::Flowclassifier\u0027: FlowClassifier,"},{"line_number":233,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_92e70140","line":232,"updated":"2016-02-03 15:51:45.000000000","message":"OS::Neutron::Flowclassifier --\u003e OS::Neutron::FlowClassifier","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"}],"heat/engine/resources/openstack/neutron/sfc/port_chain.py":[{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class PortChain(neutron.NeutronResource):"},{"line_number":26,"context_line":"    \"\"\"A resource for the Port Chain resource in SFC.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u00276.0.0\u0027)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_3ac91279","line":26,"updated":"2016-02-04 11:53:41.000000000","message":"same for description","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"ea28e2ecf976fa585aec3e2b5a5dbc0fdf145857","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    properties_schema \u003d {"},{"line_number":49,"context_line":"        NAME: properties.Schema("},{"line_number":50,"context_line":"            properties.Schema.STRING,"},{"line_number":51,"context_line":"            _(\u0027Name for the Port Chain .\u0027),"},{"line_number":52,"context_line":"            required\u003dTrue,"},{"line_number":53,"context_line":"            update_allowed\u003dTrue"},{"line_number":54,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_d2f8197f","line":51,"updated":"2016-02-03 15:51:45.000000000","message":"Check for consistency in the use of full stops (some are \"..\" or \" .\" and others have none) in the property/attribute descriptions throughout.","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"ea28e2ecf976fa585aec3e2b5a5dbc0fdf145857","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ),"},{"line_number":60,"context_line":"        PORT_PAIR_GROUPS: properties.Schema("},{"line_number":61,"context_line":"            properties.Schema.LIST,"},{"line_number":62,"context_line":"            _(\u0027An list of port pair groups to apply to the Port Chain\u0027),"},{"line_number":63,"context_line":"            required\u003dTrue,"},{"line_number":64,"context_line":"        ),"},{"line_number":65,"context_line":"        FLOW_CLASSIFIERS: properties.Schema("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_72e285d7","line":62,"updated":"2016-02-03 15:51:45.000000000","message":"\"An list ...\" -\u003e \"A list ...\" - check throughout this and other patches.","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            type\u003dattributes.Schema.STRING"},{"line_number":84,"context_line":"        ),"},{"line_number":85,"context_line":"        PORT_PAIR_GROUPS_ATTR: attributes.Schema("},{"line_number":86,"context_line":"            _(\u0027An list of port pair groups to apply to the Port Pair Group.\u0027),"},{"line_number":87,"context_line":"        ),"},{"line_number":88,"context_line":"        TENANT_ID: attributes.Schema("},{"line_number":89,"context_line":"            _(\u0027Id of the tenant owning the Port Chain.\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_da855e07","line":86,"range":{"start_line":86,"start_character":15,"end_line":86,"end_character":17},"updated":"2016-02-04 11:53:41.000000000","message":"same here","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            type\u003dattributes.Schema.LIST"},{"line_number":95,"context_line":"        ),"},{"line_number":96,"context_line":"        CHAIN_PARAMETERS_ATTR: attributes.Schema("},{"line_number":97,"context_line":"            _(\u0027Chain parameter for the Port Chain\u0027),"},{"line_number":98,"context_line":"            type\u003dattributes.Schema.MAP"},{"line_number":99,"context_line":"        ),"},{"line_number":100,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_5a72ce4a","line":97,"updated":"2016-02-04 11:53:41.000000000","message":"terminator at the end","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"}],"heat/engine/resources/openstack/neutron/sfc/port_pair.py":[{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class PortPair(neutron.NeutronResource):"},{"line_number":26,"context_line":"    \"\"\"A resource for the Port Pair resource in Neutron port pair.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u00276.0.0\u0027)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_3aaef285","line":26,"updated":"2016-02-04 11:53:41.000000000","message":"same here","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ),"},{"line_number":60,"context_line":"        INGRESS: properties.Schema("},{"line_number":61,"context_line":"            properties.Schema.STRING,"},{"line_number":62,"context_line":"            _(\u0027Ingress neutron port id \u0027),"},{"line_number":63,"context_line":"            required\u003dTrue,"},{"line_number":64,"context_line":"        ),"},{"line_number":65,"context_line":"        EGRESS: properties.Schema("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_3ac5923b","line":62,"updated":"2016-02-04 11:53:41.000000000","message":"terminator at the end and maybe add constraint check for neutron port?","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        ),"},{"line_number":65,"context_line":"        EGRESS: properties.Schema("},{"line_number":66,"context_line":"            properties.Schema.STRING,"},{"line_number":67,"context_line":"            _(\u0027Egress neutron port id \u0027),"},{"line_number":68,"context_line":"            required\u003dTrue,"},{"line_number":69,"context_line":"        ),"},{"line_number":70,"context_line":"        SERVICE_FUNCTION_PARAMETERS: properties.Schema("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_bae742e3","line":67,"updated":"2016-02-04 11:53:41.000000000","message":"same and maybe add constraint check for neutron port?","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        ),"},{"line_number":70,"context_line":"        SERVICE_FUNCTION_PARAMETERS: properties.Schema("},{"line_number":71,"context_line":"            properties.Schema.STRING,"},{"line_number":72,"context_line":"            _(\u0027Details of service function parameter\u0027),"},{"line_number":73,"context_line":"        ),"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_9acda65f","line":72,"updated":"2016-02-04 11:53:41.000000000","message":"same","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        ),"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    attributes_schema \u003d {"},{"line_number":77,"context_line":"        NAME: attributes.Schema("},{"line_number":78,"context_line":"            properties.Schema.STRING,"},{"line_number":79,"context_line":"            _(\u0027Name for the Port Pair.\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_da38fe3f","line":76,"updated":"2016-02-04 11:53:41.000000000","message":"missing tenant_id","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"b58de5d7d12e8fde27fd4ba632750a539afac060","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if prop_diff:"},{"line_number":87,"context_line":"            self.client().update_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":88,"context_line":"                                     self.resource_id, {\u0027port_pair\u0027: prop_diff}"},{"line_number":89,"context_line":"                                     ).get(\u0027port_pair\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def handle_delete(self):"},{"line_number":92,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_cb406038","line":89,"updated":"2016-02-09 14:35:45.000000000","message":"why are you \u0027get\u0027ting port_pair here?","commit_id":"803e3e313b46c2a6e7f703e3c41013e9469c7764"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"b58de5d7d12e8fde27fd4ba632750a539afac060","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            self.client().delete_ext(PORT_PAIR_PATH + \u0027/%s\u0027, self.resource_id)"},{"line_number":94,"context_line":"        except Exception as ex:"},{"line_number":95,"context_line":"            self.client_plugin().ignore_not_found(ex)"},{"line_number":96,"context_line":"        else:"},{"line_number":97,"context_line":"            return True"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_a82baa93","line":95,"updated":"2016-02-09 14:35:45.000000000","message":"i think you need to return true here as well","commit_id":"803e3e313b46c2a6e7f703e3c41013e9469c7764"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"8d9267e6a8f9d828bf47773bb917a5e6cd7203fa","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            _(\u0027Description for the Port Pair.\u0027),"},{"line_number":55,"context_line":"            update_allowed\u003dTrue"},{"line_number":56,"context_line":"        ),"},{"line_number":57,"context_line":"        INGRESS: properties.Schema("},{"line_number":58,"context_line":"            properties.Schema.STRING,"},{"line_number":59,"context_line":"            _(\u0027Ingress neutron port id.\u0027),"},{"line_number":60,"context_line":"            required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_6b4d1172","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":15},"updated":"2016-02-19 19:13:44.000000000","message":"Is this just regular neutron port? If so, please add neutron.port constraint here.","commit_id":"67ca0cf1b6f9f956629b760e79951d272ac486f2"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"8d9267e6a8f9d828bf47773bb917a5e6cd7203fa","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            _(\u0027Ingress neutron port id.\u0027),"},{"line_number":60,"context_line":"            required\u003dTrue,"},{"line_number":61,"context_line":"        ),"},{"line_number":62,"context_line":"        EGRESS: properties.Schema("},{"line_number":63,"context_line":"            properties.Schema.STRING,"},{"line_number":64,"context_line":"            _(\u0027Egress neutron port id.\u0027),"},{"line_number":65,"context_line":"            required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_ab571901","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":14},"updated":"2016-02-19 19:13:44.000000000","message":"ditto","commit_id":"67ca0cf1b6f9f956629b760e79951d272ac486f2"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"8d9267e6a8f9d828bf47773bb917a5e6cd7203fa","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if prop_diff:"},{"line_number":87,"context_line":"            self.client().update_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":88,"context_line":"                                     self.resource_id, {\u0027port_pair\u0027: prop_diff}"},{"line_number":89,"context_line":"                                     ).get(\u0027port_pair\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def handle_delete(self):"},{"line_number":92,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_cb37fde1","line":89,"range":{"start_line":89,"start_character":38,"end_line":89,"end_character":55},"updated":"2016-02-19 19:13:44.000000000","message":"please remove this get() call.","commit_id":"67ca0cf1b6f9f956629b760e79951d272ac486f2"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"c9e7345bd16d3294859379b597c2452a579e8cc9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                     self.resource_id, {\u0027port_pair\u0027: prop_diff}"},{"line_number":89,"context_line":"                                     ).get(\u0027port_pair\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def handle_delete(self):"},{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            self.client().delete_ext(PORT_PAIR_PATH + \u0027/%s\u0027, self.resource_id)"},{"line_number":94,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_c93daebc","line":91,"updated":"2016-02-10 20:51:36.000000000","message":"please add check if self.resource_id is None","commit_id":"67ca0cf1b6f9f956629b760e79951d272ac486f2"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"c9e7345bd16d3294859379b597c2452a579e8cc9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                                     ).get(\u0027port_pair\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def handle_delete(self):"},{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            self.client().delete_ext(PORT_PAIR_PATH + \u0027/%s\u0027, self.resource_id)"},{"line_number":94,"context_line":"        except Exception as ex:"},{"line_number":95,"context_line":"            self.client_plugin().ignore_not_found(ex)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_8947b64a","line":92,"updated":"2016-02-10 20:51:36.000000000","message":"you can do it with \"with\" statement","commit_id":"67ca0cf1b6f9f956629b760e79951d272ac486f2"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"0cd4675de7e6a24c11968dedca3d4a23f992049b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    A Port Pair represents a service function instance. The ingress port and"},{"line_number":27,"context_line":"    the egress port of the service function may be specified. If a service"},{"line_number":28,"context_line":"    function has one bidirectional port, the ingress port has the same value"},{"line_number":29,"context_line":"    as the egress port."},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u00276.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_e3fd1ab2","line":29,"updated":"2016-02-24 05:26:47.000000000","message":"please provide details on prerequisites","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"394bd44cd49f00ed776dc796a69ac350d15dd734","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    A Port Pair represents a service function instance. The ingress port and"},{"line_number":27,"context_line":"    the egress port of the service function may be specified. If a service"},{"line_number":28,"context_line":"    function has one bidirectional port, the ingress port has the same value"},{"line_number":29,"context_line":"    as the egress port."},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u00276.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_71aa141b","line":29,"in_reply_to":"bae84128_e3fd1ab2","updated":"2016-02-25 11:58:54.000000000","message":"Done","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"0cd4675de7e6a24c11968dedca3d4a23f992049b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    as the egress port."},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u00276.0.0\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    required_service_extension \u003d \u0027sfc\u0027"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_43ecc629","line":32,"updated":"2016-02-24 05:26:47.000000000","message":"set support_status to UNSUPPORTED as its not coming under big-tent project","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"12275572ca4e24292bd4c4fbee6ff0ec334101db","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    as the egress port."},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u00276.0.0\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    required_service_extension \u003d \u0027sfc\u0027"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_7eaead2e","line":32,"in_reply_to":"bae84128_43ecc629","updated":"2016-02-24 11:53:59.000000000","message":"What does support_status mean? Supported by whom?\n\nShould this be 1.0.0 which is the current version of networking-sfc?\n\nhttps://pypi.python.org/pypi/networking-sfc/1.0.0","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b16697cc7cdae95d11bf8f78da045e967ddc5a78","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    as the egress port."},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u00276.0.0\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    required_service_extension \u003d \u0027sfc\u0027"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_91519811","line":32,"in_reply_to":"bae84128_7eaead2e","updated":"2016-02-25 11:44:38.000000000","message":"Hi Paul, This Heat support version for sfc resources . The current heat version is \"6.0.0\"","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"cd72a9f11ca2fb5d9a232b47c572b5da61a00012","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        NAME: properties.Schema("},{"line_number":46,"context_line":"            properties.Schema.STRING,"},{"line_number":47,"context_line":"            _(\u0027Name for the Port Pair.\u0027),"},{"line_number":48,"context_line":"            required\u003dTrue,"},{"line_number":49,"context_line":"            update_allowed\u003dTrue"},{"line_number":50,"context_line":"        ),"},{"line_number":51,"context_line":"        DESCRIPTION: properties.Schema("}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_0e281032","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":26},"updated":"2016-02-24 12:37:13.000000000","message":"I think you can remove the required\u003dTrue from here.","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"394bd44cd49f00ed776dc796a69ac350d15dd734","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        NAME: properties.Schema("},{"line_number":46,"context_line":"            properties.Schema.STRING,"},{"line_number":47,"context_line":"            _(\u0027Name for the Port Pair.\u0027),"},{"line_number":48,"context_line":"            required\u003dTrue,"},{"line_number":49,"context_line":"            update_allowed\u003dTrue"},{"line_number":50,"context_line":"        ),"},{"line_number":51,"context_line":"        DESCRIPTION: properties.Schema("}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_b1a01ca7","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":26},"in_reply_to":"bae84128_0e281032","updated":"2016-02-25 11:58:54.000000000","message":"@Rabi :Name made as mandatory param to create resource. Hence added \"required\u003dTrue\" flag . please let me know if my understanding is wrong , also referred some neutron resources\n\nhttps://github.com/openstack/heat/blob/2f3be6eb0727beb881e418417c3fb5deaa539f26/heat/engine/resources/openstack/neutron/qos.py#L53","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"15639921ec71c0c30dd71479134565c8fc14e33a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        NAME: properties.Schema("},{"line_number":46,"context_line":"            properties.Schema.STRING,"},{"line_number":47,"context_line":"            _(\u0027Name for the Port Pair.\u0027),"},{"line_number":48,"context_line":"            required\u003dTrue,"},{"line_number":49,"context_line":"            update_allowed\u003dTrue"},{"line_number":50,"context_line":"        ),"},{"line_number":51,"context_line":"        DESCRIPTION: properties.Schema("}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_3796bc94","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":26},"in_reply_to":"bae84128_b1a01ca7","updated":"2016-02-25 12:19:23.000000000","message":"please check this.\n\nhttps://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/neutron/net.py#L145-L147","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"cd72a9f11ca2fb5d9a232b47c572b5da61a00012","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        ),"},{"line_number":56,"context_line":"        INGRESS: properties.Schema("},{"line_number":57,"context_line":"            properties.Schema.STRING,"},{"line_number":58,"context_line":"            _(\u0027Ingress neutron port id.\u0027),"},{"line_number":59,"context_line":"            constraints\u003d[constraints.CustomConstraint(\u0027neutron.port\u0027)],"},{"line_number":60,"context_line":"            required\u003dTrue,"},{"line_number":61,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_abc75662","line":58,"range":{"start_line":58,"start_character":14,"end_line":58,"end_character":39},"updated":"2016-02-24 12:37:13.000000000","message":"I think this should be \u0027id/name of the neutron ingress neutron port\u0027.","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"394bd44cd49f00ed776dc796a69ac350d15dd734","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        ),"},{"line_number":56,"context_line":"        INGRESS: properties.Schema("},{"line_number":57,"context_line":"            properties.Schema.STRING,"},{"line_number":58,"context_line":"            _(\u0027Ingress neutron port id.\u0027),"},{"line_number":59,"context_line":"            constraints\u003d[constraints.CustomConstraint(\u0027neutron.port\u0027)],"},{"line_number":60,"context_line":"            required\u003dTrue,"},{"line_number":61,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_f19e2406","line":58,"range":{"start_line":58,"start_character":14,"end_line":58,"end_character":39},"in_reply_to":"bae84128_abc75662","updated":"2016-02-25 11:58:54.000000000","message":"Done","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"cd72a9f11ca2fb5d9a232b47c572b5da61a00012","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        ),"},{"line_number":62,"context_line":"        EGRESS: properties.Schema("},{"line_number":63,"context_line":"            properties.Schema.STRING,"},{"line_number":64,"context_line":"            _(\u0027Egress neutron port id.\u0027),"},{"line_number":65,"context_line":"            constraints\u003d[constraints.CustomConstraint(\u0027neutron.port\u0027)],"},{"line_number":66,"context_line":"            required\u003dTrue,"},{"line_number":67,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_abf11697","line":64,"range":{"start_line":64,"start_character":15,"end_line":64,"end_character":37},"updated":"2016-02-24 12:37:13.000000000","message":"Should be \u0027id/name of the neutron egress neutron port\u0027.\n\nAnd you can use \u0027find_resourceid_by_name_or_id\u0027 in handle_create/handle_update to resolve these.","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"394bd44cd49f00ed776dc796a69ac350d15dd734","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        ),"},{"line_number":62,"context_line":"        EGRESS: properties.Schema("},{"line_number":63,"context_line":"            properties.Schema.STRING,"},{"line_number":64,"context_line":"            _(\u0027Egress neutron port id.\u0027),"},{"line_number":65,"context_line":"            constraints\u003d[constraints.CustomConstraint(\u0027neutron.port\u0027)],"},{"line_number":66,"context_line":"            required\u003dTrue,"},{"line_number":67,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_d1a3204e","line":64,"range":{"start_line":64,"start_character":15,"end_line":64,"end_character":37},"in_reply_to":"bae84128_abf11697","updated":"2016-02-25 11:58:54.000000000","message":"Done","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"a3dda3df8562c35f9b280d5897a2d75550d11df3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        ),"},{"line_number":68,"context_line":"        SERVICE_FUNCTION_PARAMETERS: properties.Schema("},{"line_number":69,"context_line":"            properties.Schema.MAP,"},{"line_number":70,"context_line":"            _(\u0027Dictionary of service function parameter, Currently \u0027"},{"line_number":71,"context_line":"              \u0027only correlation\u003dNone is supported.\u0027),"},{"line_number":72,"context_line":"            default\u003d{\u0027correlation\u0027: None},"},{"line_number":73,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_4d7a90f2","line":70,"range":{"start_line":70,"start_character":56,"end_line":70,"end_character":57},"updated":"2016-02-22 16:52:24.000000000","message":"nit: the comma after parameter should probably be a period.","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"26cb9cb6bd323d667598d261bba708ad6f996ea6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        ),"},{"line_number":68,"context_line":"        SERVICE_FUNCTION_PARAMETERS: properties.Schema("},{"line_number":69,"context_line":"            properties.Schema.MAP,"},{"line_number":70,"context_line":"            _(\u0027Dictionary of service function parameter, Currently \u0027"},{"line_number":71,"context_line":"              \u0027only correlation\u003dNone is supported.\u0027),"},{"line_number":72,"context_line":"            default\u003d{\u0027correlation\u0027: None},"},{"line_number":73,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_968e352c","line":70,"range":{"start_line":70,"start_character":56,"end_line":70,"end_character":57},"in_reply_to":"bae84128_4d7a90f2","updated":"2016-02-23 13:49:32.000000000","message":"Done","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"8c89d77d2fac795cb765a15921bc351f640e5491","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _show_resource(self):"},{"line_number":77,"context_line":"        return self.client().show_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":78,"context_line":"                                      self.resource_id).get(\u0027port_pair\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def handle_create(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_f6435640","line":77,"updated":"2016-02-23 05:41:53.000000000","message":"please use below format, as its more preferable.\n\u0027%s/%s\u0027 % (PORT_PAIR_PATH, ...)","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"394bd44cd49f00ed776dc796a69ac350d15dd734","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _show_resource(self):"},{"line_number":77,"context_line":"        return self.client().show_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":78,"context_line":"                                      self.resource_id).get(\u0027port_pair\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def handle_create(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_518d507a","line":77,"in_reply_to":"bae84128_f6435640","updated":"2016-02-25 11:58:54.000000000","message":"@Kanagaraj : since i need to append \"/%s\" in client call , i did concatenation instead substitution.","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"cd72a9f11ca2fb5d9a232b47c572b5da61a00012","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.resource_id_set(port_pair[\u0027id\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":89,"context_line":"        if prop_diff:"},{"line_number":90,"context_line":"            self.client().update_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":91,"context_line":"                                     self.resource_id, {\u0027port_pair\u0027: prop_diff}"},{"line_number":92,"context_line":"                                     )"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_8ebee0ab","line":89,"updated":"2016-02-24 12:37:13.000000000","message":"here you can call \n\nself.prepare_update_properties(prop_diff). This would use the physical_resource_name for the name property, if it\u0027s removed during an update.","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"394bd44cd49f00ed776dc796a69ac350d15dd734","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.resource_id_set(port_pair[\u0027id\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":89,"context_line":"        if prop_diff:"},{"line_number":90,"context_line":"            self.client().update_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":91,"context_line":"                                     self.resource_id, {\u0027port_pair\u0027: prop_diff}"},{"line_number":92,"context_line":"                                     )"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_b1e81c18","line":89,"in_reply_to":"bae84128_8ebee0ab","updated":"2016-02-25 11:58:54.000000000","message":"Done","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"8c89d77d2fac795cb765a15921bc351f640e5491","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":89,"context_line":"        if prop_diff:"},{"line_number":90,"context_line":"            self.client().update_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":91,"context_line":"                                     self.resource_id, {\u0027port_pair\u0027: prop_diff}"},{"line_number":92,"context_line":"                                     )"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_96712aab","line":90,"updated":"2016-02-23 05:41:53.000000000","message":"here too","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"394bd44cd49f00ed776dc796a69ac350d15dd734","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":89,"context_line":"        if prop_diff:"},{"line_number":90,"context_line":"            self.client().update_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":91,"context_line":"                                     self.resource_id, {\u0027port_pair\u0027: prop_diff}"},{"line_number":92,"context_line":"                                     )"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_f1f2a405","line":90,"in_reply_to":"bae84128_96712aab","updated":"2016-02-25 11:58:54.000000000","message":"@Kanagaraj : since i need to append \"/%s\" in client call , i did concatenation instead substitution.","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"8c89d77d2fac795cb765a15921bc351f640e5491","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def handle_delete(self):"},{"line_number":95,"context_line":"        if self.resource_id is None:"},{"line_number":96,"context_line":"                return"},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            with self.client_plugin().ignore_not_found:"},{"line_number":99,"context_line":"                self.client().delete_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_f66a36b2","line":96,"updated":"2016-02-23 05:41:53.000000000","message":"return True","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"394bd44cd49f00ed776dc796a69ac350d15dd734","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def handle_delete(self):"},{"line_number":95,"context_line":"        if self.resource_id is None:"},{"line_number":96,"context_line":"                return"},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            with self.client_plugin().ignore_not_found:"},{"line_number":99,"context_line":"                self.client().delete_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_31dd2c71","line":96,"in_reply_to":"bae84128_f66a36b2","updated":"2016-02-25 11:58:54.000000000","message":"Done","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"8c89d77d2fac795cb765a15921bc351f640e5491","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                return"},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            with self.client_plugin().ignore_not_found:"},{"line_number":99,"context_line":"                self.client().delete_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":100,"context_line":"                                         self.resource_id)"},{"line_number":101,"context_line":"        except Exception as ex:"},{"line_number":102,"context_line":"            self.client_plugin().ignore_not_found(ex)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_769d86bb","line":99,"updated":"2016-02-23 05:41:53.000000000","message":"here too","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"394bd44cd49f00ed776dc796a69ac350d15dd734","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                return"},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            with self.client_plugin().ignore_not_found:"},{"line_number":99,"context_line":"                self.client().delete_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":100,"context_line":"                                         self.resource_id)"},{"line_number":101,"context_line":"        except Exception as ex:"},{"line_number":102,"context_line":"            self.client_plugin().ignore_not_found(ex)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_51e4303a","line":99,"in_reply_to":"bae84128_769d86bb","updated":"2016-02-25 11:58:54.000000000","message":"@Kanagaraj : since i need to append \"/%s\" in client call , i did concatenation instead substitution.","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"8c89d77d2fac795cb765a15921bc351f640e5491","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                self.client().delete_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":100,"context_line":"                                         self.resource_id)"},{"line_number":101,"context_line":"        except Exception as ex:"},{"line_number":102,"context_line":"            self.client_plugin().ignore_not_found(ex)"},{"line_number":103,"context_line":"            return True"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_f69876c2","line":102,"updated":"2016-02-23 05:41:53.000000000","message":"why do you want to try ... catch... while you are already handling the not_found exception using \u0027with\u0027 context mananger","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"26cb9cb6bd323d667598d261bba708ad6f996ea6","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                self.client().delete_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":100,"context_line":"                                         self.resource_id)"},{"line_number":101,"context_line":"        except Exception as ex:"},{"line_number":102,"context_line":"            self.client_plugin().ignore_not_found(ex)"},{"line_number":103,"context_line":"            return True"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_36a5a9a1","line":102,"in_reply_to":"bae84128_f69876c2","updated":"2016-02-23 13:49:32.000000000","message":"Done","commit_id":"89e50c86447d6a0675e6b0e3b4519905897aa08c"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"9b93f3e31ba07c0b547e26a213fae109f327047e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"\"\"A resource for neutron networking-sfc."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    This plug-in requires networking-sfc\u003e\u003d1.0.0. So to enable this"},{"line_number":27,"context_line":"    plug-in, install this library and restart the heat-engine"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    A Port Pair represents a service function instance. The ingress port and"},{"line_number":30,"context_line":"    the egress port of the service function may be specified. If a service"}],"source_content_type":"text/x-python","patch_set":13,"id":"7af24918_c953226a","line":27,"range":{"start_line":27,"start_character":46,"end_line":27,"end_character":61},"updated":"2016-03-03 02:46:11.000000000","message":"Missed terminator. Otherwise the custom guidelines check will failed.","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b6ed9991208a7ef02ac3da149692e24339faa7ad","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"\"\"A resource for neutron networking-sfc."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    This plug-in requires networking-sfc\u003e\u003d1.0.0. So to enable this"},{"line_number":27,"context_line":"    plug-in, install this library and restart the heat-engine"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    A Port Pair represents a service function instance. The ingress port and"},{"line_number":30,"context_line":"    the egress port of the service function may be specified. If a service"}],"source_content_type":"text/x-python","patch_set":13,"id":"5aef4532_febff85d","line":27,"range":{"start_line":27,"start_character":46,"end_line":27,"end_character":61},"in_reply_to":"7af24918_c953226a","updated":"2016-03-08 10:22:33.000000000","message":"Done","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"1d71b320ae521e31a4b2001408f738ae8baf9304","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    support_status \u003d support.SupportStatus("},{"line_number":36,"context_line":"        version\u003d\u00276.0.0\u0027,"},{"line_number":37,"context_line":"        status\u003dsupport.UNSUPPORTED)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    required_service_extension \u003d \u0027sfc\u0027"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bae84128_fbb9d3ed","line":37,"updated":"2016-02-25 15:56:56.000000000","message":"If this is referencing the Heat version with which networking-sfc is compatible then I disagree with Kanagaraj Manickam\u0027s comment about changing it to unsupported.\n\nWhat is this variable actually used for? I grepped a bit but didn\u0027t get a clear understanding of where this information about support gets used.","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b8e24e0ca608bec07ad909dd5820bb51a139a605","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    support_status \u003d support.SupportStatus("},{"line_number":36,"context_line":"        version\u003d\u00276.0.0\u0027,"},{"line_number":37,"context_line":"        status\u003dsupport.UNSUPPORTED)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    required_service_extension \u003d \u0027sfc\u0027"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5aef4532_81d28c5a","line":37,"in_reply_to":"bae84128_fbb9d3ed","updated":"2016-03-09 13:51:09.000000000","message":"@paul: As per Kanagaraj , Since sfc listed in neutron sub-project and not following official OpenStack releases, he wanted to tag it as \"Unsupported\" it means user can use this resources , but it may be broken.","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"000fae2f92b79ea6e1e20aca2a607f4549dbff96","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        NAME: properties.Schema("},{"line_number":51,"context_line":"            properties.Schema.STRING,"},{"line_number":52,"context_line":"            _(\u0027Name for the Port Pair.\u0027),"},{"line_number":53,"context_line":"            required\u003dTrue,"},{"line_number":54,"context_line":"            update_allowed\u003dTrue"},{"line_number":55,"context_line":"        ),"},{"line_number":56,"context_line":"        DESCRIPTION: properties.Schema("}],"source_content_type":"text/x-python","patch_set":13,"id":"9aed3d3a_74a8d78d","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":26},"updated":"2016-02-29 14:35:23.000000000","message":"You are using prepare_properties below, so name will be generated automatically if user doesn\u0027t specify one. It is better to remove required\u003dTrue.","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"9b93f3e31ba07c0b547e26a213fae109f327047e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        NAME: properties.Schema("},{"line_number":51,"context_line":"            properties.Schema.STRING,"},{"line_number":52,"context_line":"            _(\u0027Name for the Port Pair.\u0027),"},{"line_number":53,"context_line":"            required\u003dTrue,"},{"line_number":54,"context_line":"            update_allowed\u003dTrue"},{"line_number":55,"context_line":"        ),"},{"line_number":56,"context_line":"        DESCRIPTION: properties.Schema("}],"source_content_type":"text/x-python","patch_set":13,"id":"7af24918_09f86a48","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":26},"in_reply_to":"9aed3d3a_74a8d78d","updated":"2016-03-03 02:46:11.000000000","message":"Agree.","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b6ed9991208a7ef02ac3da149692e24339faa7ad","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        NAME: properties.Schema("},{"line_number":51,"context_line":"            properties.Schema.STRING,"},{"line_number":52,"context_line":"            _(\u0027Name for the Port Pair.\u0027),"},{"line_number":53,"context_line":"            required\u003dTrue,"},{"line_number":54,"context_line":"            update_allowed\u003dTrue"},{"line_number":55,"context_line":"        ),"},{"line_number":56,"context_line":"        DESCRIPTION: properties.Schema("}],"source_content_type":"text/x-python","patch_set":13,"id":"5aef4532_9eb19492","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":26},"in_reply_to":"9aed3d3a_74a8d78d","updated":"2016-03-08 10:22:33.000000000","message":"Done","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"10dc0a758cbea2811651631e212ef24f0944fb8d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    support_status \u003d support.SupportStatus("},{"line_number":36,"context_line":"        version\u003d\u00276.0.0\u0027,"},{"line_number":37,"context_line":"        status\u003dsupport.UNSUPPORTED)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    required_service_extension \u003d \u0027sfc\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"da0c15f0_7a5b1a55","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":24},"updated":"2016-03-25 09:37:04.000000000","message":"Newton is open, the version should be 7.0.0","commit_id":"456aab3efdf2fabd9d47a08dac056af50d0801ee"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"d8578fc62efeef49751f66e6eac97838ed0a9790","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    support_status \u003d support.SupportStatus("},{"line_number":36,"context_line":"        version\u003d\u00276.0.0\u0027,"},{"line_number":37,"context_line":"        status\u003dsupport.UNSUPPORTED)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    required_service_extension \u003d \u0027sfc\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"da0c15f0_b5b6653b","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":24},"in_reply_to":"da0c15f0_7a5b1a55","updated":"2016-03-25 09:42:06.000000000","message":"yes , I should change version","commit_id":"456aab3efdf2fabd9d47a08dac056af50d0801ee"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2ba707178d64a2e8924fbda6e927c88f36e47796","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from heat.engine.resources.openstack.neutron import neutron"},{"line_number":18,"context_line":"from heat.engine import support"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"PORT_PAIR_PATH \u003d \"/sfc/port_pairs\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class PortPair(neutron.NeutronResource):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_ba97f88e","line":20,"range":{"start_line":20,"start_character":18,"end_line":20,"end_character":32},"updated":"2016-06-23 13:29:38.000000000","message":"kindly move this to client plugin instead. thanks","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"a6d61039fa77d6fbabc84d9aca8b21a8a0301b15","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from heat.engine.resources.openstack.neutron import neutron"},{"line_number":18,"context_line":"from heat.engine import support"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"PORT_PAIR_PATH \u003d \"/sfc/port_pairs\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class PortPair(neutron.NeutronResource):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_646d3232","line":20,"range":{"start_line":20,"start_character":18,"end_line":20,"end_character":32},"in_reply_to":"3aaa91ec_ba97f88e","updated":"2016-06-28 11:48:42.000000000","message":"ok","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2ba707178d64a2e8924fbda6e927c88f36e47796","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class PortPair(neutron.NeutronResource):"},{"line_number":24,"context_line":"    \"\"\"A resource for neutron networking-sfc."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    This plug-in requires networking-sfc\u003e\u003d1.0.0. So to enable this"},{"line_number":27,"context_line":"    plug-in, install this library and restart the heat-engine."}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_f7f3599c","line":24,"updated":"2016-06-23 13:29:38.000000000","message":"nit: append Port-Pair","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"a6d61039fa77d6fbabc84d9aca8b21a8a0301b15","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class PortPair(neutron.NeutronResource):"},{"line_number":24,"context_line":"    \"\"\"A resource for neutron networking-sfc."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    This plug-in requires networking-sfc\u003e\u003d1.0.0. So to enable this"},{"line_number":27,"context_line":"    plug-in, install this library and restart the heat-engine."}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_a4771a01","line":24,"in_reply_to":"3aaa91ec_f7f3599c","updated":"2016-06-28 11:48:42.000000000","message":"ok","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2ba707178d64a2e8924fbda6e927c88f36e47796","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _show_resource(self):"},{"line_number":81,"context_line":"        return self.client().show_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":82,"context_line":"                                      self.resource_id).get(\u0027port_pair\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def handle_create(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_b7039141","line":81,"range":{"start_line":81,"start_character":38,"end_line":81,"end_character":60},"updated":"2016-06-23 13:29:38.000000000","message":"\u0027%s/%s\u0027 % (PORT_PAIR_PATH, ...)","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"a6d61039fa77d6fbabc84d9aca8b21a8a0301b15","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _show_resource(self):"},{"line_number":81,"context_line":"        return self.client().show_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":82,"context_line":"                                      self.resource_id).get(\u0027port_pair\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def handle_create(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_84e01e98","line":81,"range":{"start_line":81,"start_character":38,"end_line":81,"end_character":60},"in_reply_to":"3aaa91ec_b7039141","updated":"2016-06-28 11:48:42.000000000","message":"I tried with string format specifiers , but UT was failing with below error \n\ntesttools.matchers._impl.MismatchError: !\u003d:\nreference \u003d \u0027NeutronClientException: resources.port_pair: An unknown exception occurred.\u0027\nactual    \u003d u\u0027TypeError: resources.port_pair: not all arguments converted during string formatting\u0027","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2ba707178d64a2e8924fbda6e927c88f36e47796","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _show_resource(self):"},{"line_number":81,"context_line":"        return self.client().show_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":82,"context_line":"                                      self.resource_id).get(\u0027port_pair\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def handle_create(self):"},{"line_number":85,"context_line":"        props \u003d self.prepare_properties(self.properties,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_5a5b742e","line":82,"updated":"2016-06-23 13:29:38.000000000","message":"kindly move this function to client plugin instead. thanks","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"a6d61039fa77d6fbabc84d9aca8b21a8a0301b15","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _show_resource(self):"},{"line_number":81,"context_line":"        return self.client().show_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":82,"context_line":"                                      self.resource_id).get(\u0027port_pair\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def handle_create(self):"},{"line_number":85,"context_line":"        props \u003d self.prepare_properties(self.properties,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_a4fc3a3f","line":82,"in_reply_to":"3aaa91ec_5a5b742e","updated":"2016-06-28 11:48:42.000000000","message":"ok","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"41d55fc863455aaf370b7f252b70dd92a3209e31","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        props \u003d self.prepare_properties(self.properties,"},{"line_number":86,"context_line":"                                        self.physical_resource_name())"},{"line_number":87,"context_line":"        props[\u0027ingress\u0027] \u003d self.client_plugin("},{"line_number":88,"context_line":"            ).find_resourceid_by_name_or_id(\u0027port\u0027, props.get(self.INGRESS))"},{"line_number":89,"context_line":"        props[\u0027egress\u0027] \u003d self.client_plugin("},{"line_number":90,"context_line":"            ).find_resourceid_by_name_or_id(\u0027port\u0027, props.get(self.EGRESS))"},{"line_number":91,"context_line":"        port_pair \u003d self.client().create_ext(PORT_PAIR_PATH,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_a004c617","line":88,"range":{"start_line":88,"start_character":14,"end_line":88,"end_character":43},"updated":"2016-06-24 02:39:32.000000000","message":"We could use resolve translation rule for ingress port and egress port.","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"a6d61039fa77d6fbabc84d9aca8b21a8a0301b15","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        props \u003d self.prepare_properties(self.properties,"},{"line_number":86,"context_line":"                                        self.physical_resource_name())"},{"line_number":87,"context_line":"        props[\u0027ingress\u0027] \u003d self.client_plugin("},{"line_number":88,"context_line":"            ).find_resourceid_by_name_or_id(\u0027port\u0027, props.get(self.INGRESS))"},{"line_number":89,"context_line":"        props[\u0027egress\u0027] \u003d self.client_plugin("},{"line_number":90,"context_line":"            ).find_resourceid_by_name_or_id(\u0027port\u0027, props.get(self.EGRESS))"},{"line_number":91,"context_line":"        port_pair \u003d self.client().create_ext(PORT_PAIR_PATH,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_c497c6e9","line":88,"range":{"start_line":88,"start_character":14,"end_line":88,"end_character":43},"in_reply_to":"3aaa91ec_a004c617","updated":"2016-06-28 11:48:42.000000000","message":"ok","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2ba707178d64a2e8924fbda6e927c88f36e47796","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":97,"context_line":"        if prop_diff:"},{"line_number":98,"context_line":"            self.prepare_update_properties(prop_diff)"},{"line_number":99,"context_line":"            self.client().update_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":100,"context_line":"                                     self.resource_id, {\u0027port_pair\u0027: prop_diff}"},{"line_number":101,"context_line":"                                     )"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_f7ab591b","line":99,"range":{"start_line":99,"start_character":36,"end_line":99,"end_character":58},"updated":"2016-06-23 13:29:38.000000000","message":"same here","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"a6d61039fa77d6fbabc84d9aca8b21a8a0301b15","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":97,"context_line":"        if prop_diff:"},{"line_number":98,"context_line":"            self.prepare_update_properties(prop_diff)"},{"line_number":99,"context_line":"            self.client().update_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":100,"context_line":"                                     self.resource_id, {\u0027port_pair\u0027: prop_diff}"},{"line_number":101,"context_line":"                                     )"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_04a26e4b","line":99,"range":{"start_line":99,"start_character":36,"end_line":99,"end_character":58},"in_reply_to":"3aaa91ec_f7ab591b","updated":"2016-06-28 11:48:42.000000000","message":"ok","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2ba707178d64a2e8924fbda6e927c88f36e47796","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if self.resource_id is None:"},{"line_number":105,"context_line":"            return True"},{"line_number":106,"context_line":"        with self.client_plugin().ignore_not_found:"},{"line_number":107,"context_line":"                self.client().delete_ext(PORT_PAIR_PATH + \u0027/%s\u0027,"},{"line_number":108,"context_line":"                                         self.resource_id)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def resource_mapping():"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_9aab1cd6","line":108,"range":{"start_line":107,"start_character":30,"end_line":108,"end_character":35},"updated":"2016-06-23 13:29:38.000000000","message":"same here","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"550cd0200bcbfee48858026bd888531a1b8383da","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def translation_rules(self, props):"},{"line_number":80,"context_line":"        return ["},{"line_number":81,"context_line":"            translation.TranslationRule("},{"line_number":82,"context_line":"                props,"},{"line_number":83,"context_line":"                translation.TranslationRule.RESOLVE,"},{"line_number":84,"context_line":"                [self.INGRESS, self.EGRESS],"},{"line_number":85,"context_line":"                client_plugin\u003dself.client_plugin(),"},{"line_number":86,"context_line":"                finder\u003d\u0027find_resourceid_by_name_or_id\u0027,"},{"line_number":87,"context_line":"                entity\u003d\u0027port\u0027"},{"line_number":88,"context_line":"            )"},{"line_number":89,"context_line":"        ]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _show_resource(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_94de3a0f","line":88,"range":{"start_line":81,"start_character":0,"end_line":88,"end_character":13},"updated":"2016-06-29 16:45:34.000000000","message":"You need 2 separate rules:\n            translation.TranslationRule(\n                props,\n                translation.TranslationRule.RESOLVE,\n                [self.INGRESS],\n                client_plugin\u003dself.client_plugin(),\n                finder\u003d\u0027find_resourceid_by_name_or_id\u0027,\n                entity\u003d\u0027port\u0027\n            ),\n            translation.TranslationRule(\n                props,\n                translation.TranslationRule.RESOLVE,\n                [self.EGRESS],\n                client_plugin\u003dself.client_plugin(),\n                finder\u003d\u0027find_resourceid_by_name_or_id\u0027,\n                entity\u003d\u0027port\u0027\n            )","commit_id":"7a20d976ee1bf5b26bd926550a27cf97efca9fba"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"59444a32fbaee6225fac2dcefcd68ac36c9a0bce","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def translation_rules(self, props):"},{"line_number":80,"context_line":"        return ["},{"line_number":81,"context_line":"            translation.TranslationRule("},{"line_number":82,"context_line":"                props,"},{"line_number":83,"context_line":"                translation.TranslationRule.RESOLVE,"},{"line_number":84,"context_line":"                [self.INGRESS, self.EGRESS],"},{"line_number":85,"context_line":"                client_plugin\u003dself.client_plugin(),"},{"line_number":86,"context_line":"                finder\u003d\u0027find_resourceid_by_name_or_id\u0027,"},{"line_number":87,"context_line":"                entity\u003d\u0027port\u0027"},{"line_number":88,"context_line":"            )"},{"line_number":89,"context_line":"        ]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _show_resource(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_ab758564","line":88,"range":{"start_line":81,"start_character":0,"end_line":88,"end_character":13},"in_reply_to":"3aaa91ec_94de3a0f","updated":"2016-07-07 13:30:59.000000000","message":"Done","commit_id":"7a20d976ee1bf5b26bd926550a27cf97efca9fba"}],"heat/engine/resources/openstack/neutron/sfc/port_pair_group.py":[{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class PortPairGroup(neutron.NeutronResource):"},{"line_number":26,"context_line":"    \"\"\"A resource for the PortpairGroup resource in Neutron port pair.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u00276.0.0\u0027)"},{"line_number":29,"context_line":"    required_service_extension \u003d \u0027sfc\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_9a3b6638","line":26,"updated":"2016-02-04 11:53:41.000000000","message":"same here","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        ),"},{"line_number":55,"context_line":"        PORT_PAIRS: properties.Schema("},{"line_number":56,"context_line":"            properties.Schema.LIST,"},{"line_number":57,"context_line":"            _(\u0027An list of port pairs to apply to the Port Pair Group..\u0027),"},{"line_number":58,"context_line":"            required\u003dTrue,"},{"line_number":59,"context_line":"            update_allowed\u003dTrue"},{"line_number":60,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_fa129ab3","line":57,"range":{"start_line":57,"start_character":69,"end_line":57,"end_character":70},"updated":"2016-02-04 11:53:41.000000000","message":"exrta dot","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"e03d0f71f194ce492300269d8642801888159ef2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        ),"},{"line_number":55,"context_line":"        PORT_PAIRS: properties.Schema("},{"line_number":56,"context_line":"            properties.Schema.LIST,"},{"line_number":57,"context_line":"            _(\u0027An list of port pairs to apply to the Port Pair Group..\u0027),"},{"line_number":58,"context_line":"            required\u003dTrue,"},{"line_number":59,"context_line":"            update_allowed\u003dTrue"},{"line_number":60,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_1a1696a7","line":57,"range":{"start_line":57,"start_character":15,"end_line":57,"end_character":17},"updated":"2016-02-04 11:53:41.000000000","message":"s/An/A","commit_id":"745363848a7711ef5a98dc21fdd92cfe73f1cb54"}],"heat/tests/openstack/neutron/test_sfc/test_port_pair.py":[{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"000fae2f92b79ea6e1e20aca2a607f4549dbff96","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"#    under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import copy"},{"line_number":15,"context_line":"import mox"},{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.common import exceptions"},{"line_number":20,"context_line":"from neutronclient.v2_0 import client as neutronclient"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from heat.common import exception"},{"line_number":25,"context_line":"from heat.common import template_format"},{"line_number":26,"context_line":"from heat.engine.clients.os import neutron"},{"line_number":27,"context_line":"from heat.engine.resources.openstack.neutron.sfc import port_pair"},{"line_number":28,"context_line":"from heat.engine import scheduler"},{"line_number":29,"context_line":"from heat.tests import common"},{"line_number":30,"context_line":"from heat.tests import utils"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"port_pair_template \u003d \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aed3d3a_34512fd9","line":30,"range":{"start_line":14,"start_character":0,"end_line":30,"end_character":28},"updated":"2016-02-29 14:35:23.000000000","message":"Please reorganize this section according to http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b6ed9991208a7ef02ac3da149692e24339faa7ad","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"#    under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import copy"},{"line_number":15,"context_line":"import mox"},{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.common import exceptions"},{"line_number":20,"context_line":"from neutronclient.v2_0 import client as neutronclient"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from heat.common import exception"},{"line_number":25,"context_line":"from heat.common import template_format"},{"line_number":26,"context_line":"from heat.engine.clients.os import neutron"},{"line_number":27,"context_line":"from heat.engine.resources.openstack.neutron.sfc import port_pair"},{"line_number":28,"context_line":"from heat.engine import scheduler"},{"line_number":29,"context_line":"from heat.tests import common"},{"line_number":30,"context_line":"from heat.tests import utils"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"port_pair_template \u003d \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"5aef4532_3e5e8076","line":30,"range":{"start_line":14,"start_character":0,"end_line":30,"end_character":28},"in_reply_to":"9aed3d3a_34512fd9","updated":"2016-03-08 10:22:33.000000000","message":"Done","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"000fae2f92b79ea6e1e20aca2a607f4549dbff96","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self.assertEqual((rsrc.DELETE, rsrc.COMPLETE), rsrc.state)"},{"line_number":127,"context_line":"        self.m.VerifyAll()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_attribute_failed(self):"},{"line_number":130,"context_line":"        rsrc \u003d self.create_portpair()"},{"line_number":131,"context_line":"        self.m.ReplayAll()"},{"line_number":132,"context_line":"        scheduler.TaskRunner(rsrc.create)()"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aed3d3a_94075bc9","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":29},"updated":"2016-02-29 14:35:23.000000000","message":"You can remove this test. I don\u0027t think we need to ensure that we don\u0027t have \u0027subnet_id\u0027 attribute in this resource)","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b6ed9991208a7ef02ac3da149692e24339faa7ad","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self.assertEqual((rsrc.DELETE, rsrc.COMPLETE), rsrc.state)"},{"line_number":127,"context_line":"        self.m.VerifyAll()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_attribute_failed(self):"},{"line_number":130,"context_line":"        rsrc \u003d self.create_portpair()"},{"line_number":131,"context_line":"        self.m.ReplayAll()"},{"line_number":132,"context_line":"        scheduler.TaskRunner(rsrc.create)()"}],"source_content_type":"text/x-python","patch_set":13,"id":"5aef4532_9e551452","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":29},"in_reply_to":"9aed3d3a_94075bc9","updated":"2016-03-08 10:22:33.000000000","message":"Done","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"000fae2f92b79ea6e1e20aca2a607f4549dbff96","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            \u0027incorrect.\u0027, six.text_type(error))"},{"line_number":138,"context_line":"        self.m.VerifyAll()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_update_name(self):"},{"line_number":141,"context_line":"        rsrc \u003d self.create_portpair()"},{"line_number":142,"context_line":"        neutronclient.Client.update_ext(PP_PATH + \u0027/%s\u0027,"},{"line_number":143,"context_line":"                                        \u00271234\u0027, {\u0027port_pair\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aed3d3a_d4dba34d","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":24},"updated":"2016-02-29 14:35:23.000000000","message":"You can merge test_update_name and test_update_description into 1 test, i don\u0027t see any reason to check update separately.","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b6ed9991208a7ef02ac3da149692e24339faa7ad","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            \u0027incorrect.\u0027, six.text_type(error))"},{"line_number":138,"context_line":"        self.m.VerifyAll()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_update_name(self):"},{"line_number":141,"context_line":"        rsrc \u003d self.create_portpair()"},{"line_number":142,"context_line":"        neutronclient.Client.update_ext(PP_PATH + \u0027/%s\u0027,"},{"line_number":143,"context_line":"                                        \u00271234\u0027, {\u0027port_pair\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5aef4532_7e50085f","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":24},"in_reply_to":"9aed3d3a_d4dba34d","updated":"2016-03-08 10:22:33.000000000","message":"Done","commit_id":"69dcaed7c23df0f508322015710bf6dd143467bf"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"41d55fc863455aaf370b7f252b70dd92a3209e31","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import copy"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mox"},{"line_number":17,"context_line":"from neutronclient.common import exceptions"},{"line_number":18,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":19,"context_line":"from neutronclient.v2_0 import client as neutronclient"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_231e205f","line":16,"range":{"start_line":16,"start_character":7,"end_line":16,"end_character":10},"updated":"2016-06-24 02:39:32.000000000","message":"Will be good to use mock instead of mox for new tests.","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b5f9d9772a6c12e8ae21eb03b8034c563cba24bc","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import copy"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mox"},{"line_number":17,"context_line":"from neutronclient.common import exceptions"},{"line_number":18,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":19,"context_line":"from neutronclient.v2_0 import client as neutronclient"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_f16fb3f9","line":16,"range":{"start_line":16,"start_character":7,"end_line":16,"end_character":10},"in_reply_to":"3aaa91ec_231e205f","updated":"2016-06-24 09:18:06.000000000","message":"sure !","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2ba707178d64a2e8924fbda6e927c88f36e47796","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"port_pair_template \u003d \u0027\u0027\u0027"},{"line_number":32,"context_line":"heat_template_version: 2015-04-30"},{"line_number":33,"context_line":"description: Template to test networking-sfc port pair resource"},{"line_number":34,"context_line":"resources:"},{"line_number":35,"context_line":"   port_pair:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_dae3e431","line":32,"updated":"2016-06-23 13:29:38.000000000","message":"you may want to change to 2016-04-08","commit_id":"90f2f4e1cacf54cc4af26e0f3a7eeabedf243493"}]}
