)]}'
{"heat/common/config.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"bd1cb64baf3497cce84f4c43be23ad9fe8c4aca0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               default\u003d5,"},{"line_number":83,"context_line":"               help\u003d_(\u0027Maximum depth allowed when using nested stacks.\u0027)),"},{"line_number":84,"context_line":"    cfg.IntOpt(\u0027num_engine_workers\u0027,"},{"line_number":85,"context_line":"               default\u003dmax(4, processutils.get_worker_count()),"},{"line_number":86,"context_line":"               help\u003d_(\u0027Number of heat-engine processes to fork and run.\u0027))]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"engine_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_fd3b65cf","line":85,"updated":"2015-12-18 07:20:15.000000000","message":"I\u0027m not in favor of putting logic in config option defaults.\nWhy don\u0027t we make default None as usual and move the logic to the service launcher where it belongs? and properly document what the default is in the help string.","commit_id":"91f7cf85ae2a48a59f9035de79e5e43abf7ef479"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c4c055a3edd13893a291c2ac5f561babce402004","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               default\u003d5,"},{"line_number":83,"context_line":"               help\u003d_(\u0027Maximum depth allowed when using nested stacks.\u0027)),"},{"line_number":84,"context_line":"    cfg.IntOpt(\u0027num_engine_workers\u0027,"},{"line_number":85,"context_line":"               default\u003dmax(4, processutils.get_worker_count()),"},{"line_number":86,"context_line":"               help\u003d_(\u0027Number of heat-engine processes to fork and run.\u0027))]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"engine_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_a32d9aff","line":85,"in_reply_to":"3a7e1126_f02858e4","updated":"2015-12-18 19:42:02.000000000","message":"Oh, yeah. +1 on Pavlo\u0027s approach. I\u0027m away for 3 weeks so if nobody gets to it first I\u0027ll do it when I get back.","commit_id":"91f7cf85ae2a48a59f9035de79e5e43abf7ef479"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"fd2cc92e03f0a076593935c6c442a476c51ea010","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               default\u003d5,"},{"line_number":83,"context_line":"               help\u003d_(\u0027Maximum depth allowed when using nested stacks.\u0027)),"},{"line_number":84,"context_line":"    cfg.IntOpt(\u0027num_engine_workers\u0027,"},{"line_number":85,"context_line":"               default\u003dmax(4, processutils.get_worker_count()),"},{"line_number":86,"context_line":"               help\u003d_(\u0027Number of heat-engine processes to fork and run.\u0027))]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"engine_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_f02858e4","line":85,"in_reply_to":"3a7e1126_fd3b65cf","updated":"2015-12-18 13:49:08.000000000","message":"I agree with Pavlo because there\u0027s another side effect of this change. \n\nIf I run `tox -egenconfig` to generate a sample, the default is based on the number of cores on my dev machine (16) which makes generated configs inconsistent.","commit_id":"91f7cf85ae2a48a59f9035de79e5e43abf7ef479"}]}