)]}'
{"heat/engine/resources/openstack/cinder/volume.py":[{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"177a97eed4ae78957b5788219f121920fdec2489","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        props[self.BACKUP_ID] \u003d backup_id"},{"line_number":618,"context_line":"        return defn.freeze(properties\u003dprops)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _get_live_state(self, resource_properties\u003dNone):"},{"line_number":621,"context_line":"        super(CinderVolume, self)._get_live_state("},{"line_number":622,"context_line":"            resource_properties\u003dresource_properties)"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_01a2a7ae","line":620,"range":{"start_line":620,"start_character":50,"end_line":620,"end_character":54},"updated":"2016-01-13 13:02:39.000000000","message":"nit: remove this None","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"a241f9201ec31e3def4c50682b244386392580fc","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        props[self.BACKUP_ID] \u003d backup_id"},{"line_number":618,"context_line":"        return defn.freeze(properties\u003dprops)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _get_live_state(self, resource_properties\u003dNone):"},{"line_number":621,"context_line":"        super(CinderVolume, self)._get_live_state("},{"line_number":622,"context_line":"            resource_properties\u003dresource_properties)"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_d68d5e32","line":620,"range":{"start_line":620,"start_character":50,"end_line":620,"end_character":54},"in_reply_to":"da6ed579_01a2a7ae","updated":"2016-01-19 12:17:54.000000000","message":"Done","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"177a97eed4ae78957b5788219f121920fdec2489","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        return defn.freeze(properties\u003dprops)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _get_live_state(self, resource_properties\u003dNone):"},{"line_number":621,"context_line":"        super(CinderVolume, self)._get_live_state("},{"line_number":622,"context_line":"            resource_properties\u003dresource_properties)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        if not resource_properties:"},{"line_number":625,"context_line":"            msg \u003d _(\u0027There is no resource properties data to update \u0027"},{"line_number":626,"context_line":"                    \u0027inner properties of resource %s.\u0027) % self.name"},{"line_number":627,"context_line":"            raise ValueError(msg)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        volume_reality \u003d {}"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_21080b91","line":627,"range":{"start_line":621,"start_character":0,"end_line":627,"end_character":33},"updated":"2016-01-13 13:02:39.000000000","message":"After this commit https://review.openstack.org/#/c/264861/ this code will be unneeded. So it is better to rebase on it.","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"a241f9201ec31e3def4c50682b244386392580fc","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        return defn.freeze(properties\u003dprops)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _get_live_state(self, resource_properties\u003dNone):"},{"line_number":621,"context_line":"        super(CinderVolume, self)._get_live_state("},{"line_number":622,"context_line":"            resource_properties\u003dresource_properties)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        if not resource_properties:"},{"line_number":625,"context_line":"            msg \u003d _(\u0027There is no resource properties data to update \u0027"},{"line_number":626,"context_line":"                    \u0027inner properties of resource %s.\u0027) % self.name"},{"line_number":627,"context_line":"            raise ValueError(msg)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        volume_reality \u003d {}"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_9687e60e","line":627,"range":{"start_line":621,"start_character":0,"end_line":627,"end_character":33},"in_reply_to":"da6ed579_21080b91","updated":"2016-01-19 12:17:54.000000000","message":"Done","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"177a97eed4ae78957b5788219f121920fdec2489","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        volume_reality \u003d {}"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        try:"},{"line_number":632,"context_line":"            volume \u003d self.client().volumes.get(self.resource_id)"},{"line_number":633,"context_line":"            volume_data \u003d volume._info"},{"line_number":634,"context_line":"        except Exception as ex:"},{"line_number":635,"context_line":"            if self.client_plugin().is_not_found(ex):"},{"line_number":636,"context_line":"                raise exception.EntityNotFound(entity\u003d\u0027Resource\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_01894726","line":633,"range":{"start_line":632,"start_character":0,"end_line":633,"end_character":38},"updated":"2016-01-13 13:02:39.000000000","message":"nit: you may use _show_resource here","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"a241f9201ec31e3def4c50682b244386392580fc","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        volume_reality \u003d {}"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        try:"},{"line_number":632,"context_line":"            volume \u003d self.client().volumes.get(self.resource_id)"},{"line_number":633,"context_line":"            volume_data \u003d volume._info"},{"line_number":634,"context_line":"        except Exception as ex:"},{"line_number":635,"context_line":"            if self.client_plugin().is_not_found(ex):"},{"line_number":636,"context_line":"                raise exception.EntityNotFound(entity\u003d\u0027Resource\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_56a16e93","line":633,"range":{"start_line":632,"start_character":0,"end_line":633,"end_character":38},"in_reply_to":"da6ed579_01894726","updated":"2016-01-19 12:17:54.000000000","message":"Done","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"177a97eed4ae78957b5788219f121920fdec2489","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        az \u003d volume_data[\u0027availability_zone\u0027]"},{"line_number":643,"context_line":"        if resource_properties.get(self.AVAILABILITY_ZONE) is not None:"},{"line_number":644,"context_line":"            volume_reality.update({self.AVAILABILITY_ZONE: az})"},{"line_number":645,"context_line":"        elif (self._availability_zone is not None and"},{"line_number":646,"context_line":"              self._availability_zone !\u003d az):"},{"line_number":647,"context_line":"            volume_reality.update({self.AVAILABILITY_ZONE: az})"},{"line_number":648,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_d009b6de","line":645,"range":{"start_line":645,"start_character":14,"end_line":645,"end_character":37},"updated":"2016-01-13 13:02:39.000000000","message":"This will be always None on update. I think you just need always update reality to az.","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"a241f9201ec31e3def4c50682b244386392580fc","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        az \u003d volume_data[\u0027availability_zone\u0027]"},{"line_number":643,"context_line":"        if resource_properties.get(self.AVAILABILITY_ZONE) is not None:"},{"line_number":644,"context_line":"            volume_reality.update({self.AVAILABILITY_ZONE: az})"},{"line_number":645,"context_line":"        elif (self._availability_zone is not None and"},{"line_number":646,"context_line":"              self._availability_zone !\u003d az):"},{"line_number":647,"context_line":"            volume_reality.update({self.AVAILABILITY_ZONE: az})"},{"line_number":648,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_96ecc6c8","line":645,"range":{"start_line":645,"start_character":14,"end_line":645,"end_character":37},"in_reply_to":"da6ed579_d009b6de","updated":"2016-01-19 12:17:54.000000000","message":"Will change it with logic like in Server resource","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"177a97eed4ae78957b5788219f121920fdec2489","unresolved":false,"context_lines":[{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        # Update read_only property from resource properties in case of"},{"line_number":652,"context_line":"        # impossibility of getting it from cinder API."},{"line_number":653,"context_line":"        volume_reality.update("},{"line_number":654,"context_line":"            {self.READ_ONLY: resource_properties.get(self.READ_ONLY)})"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        # Check image and decide how to add it to resulting dict."},{"line_number":657,"context_line":"        resource_image \u003d resource_properties.get(self.IMAGE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_13ef58b1","line":654,"range":{"start_line":653,"start_character":0,"end_line":654,"end_character":70},"updated":"2016-01-13 13:02:39.000000000","message":"Seems we can get it from volume_data[\u0027metadata\u0027].","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"a241f9201ec31e3def4c50682b244386392580fc","unresolved":false,"context_lines":[{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        # Update read_only property from resource properties in case of"},{"line_number":652,"context_line":"        # impossibility of getting it from cinder API."},{"line_number":653,"context_line":"        volume_reality.update("},{"line_number":654,"context_line":"            {self.READ_ONLY: resource_properties.get(self.READ_ONLY)})"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        # Check image and decide how to add it to resulting dict."},{"line_number":657,"context_line":"        resource_image \u003d resource_properties.get(self.IMAGE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_56cf2e56","line":654,"range":{"start_line":653,"start_character":0,"end_line":654,"end_character":70},"in_reply_to":"da6ed579_13ef58b1","updated":"2016-01-19 12:17:54.000000000","message":"Will check, thanks","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"177a97eed4ae78957b5788219f121920fdec2489","unresolved":false,"context_lines":[{"line_number":654,"context_line":"            {self.READ_ONLY: resource_properties.get(self.READ_ONLY)})"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        # Check image and decide how to add it to resulting dict."},{"line_number":657,"context_line":"        resource_image \u003d resource_properties.get(self.IMAGE)"},{"line_number":658,"context_line":"        if resource_image:"},{"line_number":659,"context_line":"            data_image \u003d volume_data.get(\u0027volume_image_metadata\u0027)"},{"line_number":660,"context_line":"            if data_image is not None:"},{"line_number":661,"context_line":"                rsrc_image_id \u003d self.client_plugin("},{"line_number":662,"context_line":"                    \u0027glance\u0027).get_image_id(resource_image)"},{"line_number":663,"context_line":"                data_image_id \u003d self.client_plugin("},{"line_number":664,"context_line":"                    \u0027glance\u0027).get_image_id(data_image)"},{"line_number":665,"context_line":"                volume_reality.update({self.IMAGE: resource_image"},{"line_number":666,"context_line":"                                       if rsrc_image_id \u003d\u003d data_image_id"},{"line_number":667,"context_line":"                                       else data_image})"},{"line_number":668,"context_line":"            else:"},{"line_number":669,"context_line":"                volume_reality.update({self.IMAGE: None})"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Update reality data with scheduler hints."},{"line_number":672,"context_line":"        hints \u003d resource_properties.get(self.CINDER_SCHEDULER_HINTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_f6bf12f9","line":669,"range":{"start_line":657,"start_character":0,"end_line":669,"end_character":57},"updated":"2016-01-13 13:02:39.000000000","message":"IIUC, we need to return the *whole* reality. But you populate reality with image only if we set it on create.","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"a241f9201ec31e3def4c50682b244386392580fc","unresolved":false,"context_lines":[{"line_number":654,"context_line":"            {self.READ_ONLY: resource_properties.get(self.READ_ONLY)})"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        # Check image and decide how to add it to resulting dict."},{"line_number":657,"context_line":"        resource_image \u003d resource_properties.get(self.IMAGE)"},{"line_number":658,"context_line":"        if resource_image:"},{"line_number":659,"context_line":"            data_image \u003d volume_data.get(\u0027volume_image_metadata\u0027)"},{"line_number":660,"context_line":"            if data_image is not None:"},{"line_number":661,"context_line":"                rsrc_image_id \u003d self.client_plugin("},{"line_number":662,"context_line":"                    \u0027glance\u0027).get_image_id(resource_image)"},{"line_number":663,"context_line":"                data_image_id \u003d self.client_plugin("},{"line_number":664,"context_line":"                    \u0027glance\u0027).get_image_id(data_image)"},{"line_number":665,"context_line":"                volume_reality.update({self.IMAGE: resource_image"},{"line_number":666,"context_line":"                                       if rsrc_image_id \u003d\u003d data_image_id"},{"line_number":667,"context_line":"                                       else data_image})"},{"line_number":668,"context_line":"            else:"},{"line_number":669,"context_line":"                volume_reality.update({self.IMAGE: None})"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Update reality data with scheduler hints."},{"line_number":672,"context_line":"        hints \u003d resource_properties.get(self.CINDER_SCHEDULER_HINTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_f6dbc219","line":669,"range":{"start_line":657,"start_character":0,"end_line":669,"end_character":57},"in_reply_to":"da6ed579_f6bf12f9","updated":"2016-01-19 12:17:54.000000000","message":"Done","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"177a97eed4ae78957b5788219f121920fdec2489","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                volume_reality.update({self.IMAGE: None})"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Update reality data with scheduler hints."},{"line_number":672,"context_line":"        hints \u003d resource_properties.get(self.CINDER_SCHEDULER_HINTS)"},{"line_number":673,"context_line":"        if hints is not None:"},{"line_number":674,"context_line":"            volume_reality.update({self.CINDER_SCHEDULER_HINTS: {}})"},{"line_number":675,"context_line":"            for hint in hints:"},{"line_number":676,"context_line":"                if volume_data.get(hint) is not None:"},{"line_number":677,"context_line":"                    volume_reality[self.CINDER_SCHEDULER_HINTS].update("},{"line_number":678,"context_line":"                        {hint: volume_data.get(hint)})"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        props_keys \u003d [self.SIZE, self.SNAPSHOT_ID, self.NAME, self.DESCRIPTION,"},{"line_number":681,"context_line":"                      self.VOLUME_TYPE, self.METADATA, self.SOURCE_VOLID,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_96457618","line":678,"range":{"start_line":672,"start_character":0,"end_line":678,"end_character":54},"updated":"2016-01-13 13:02:39.000000000","message":"ditto","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"5a59e7c937204e79b6fd36d2242e42b7cc8ac68c","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                volume_reality.update({self.IMAGE: None})"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Update reality data with scheduler hints."},{"line_number":672,"context_line":"        hints \u003d resource_properties.get(self.CINDER_SCHEDULER_HINTS)"},{"line_number":673,"context_line":"        if hints is not None:"},{"line_number":674,"context_line":"            volume_reality.update({self.CINDER_SCHEDULER_HINTS: {}})"},{"line_number":675,"context_line":"            for hint in hints:"},{"line_number":676,"context_line":"                if volume_data.get(hint) is not None:"},{"line_number":677,"context_line":"                    volume_reality[self.CINDER_SCHEDULER_HINTS].update("},{"line_number":678,"context_line":"                        {hint: volume_data.get(hint)})"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        props_keys \u003d [self.SIZE, self.SNAPSHOT_ID, self.NAME, self.DESCRIPTION,"},{"line_number":681,"context_line":"                      self.VOLUME_TYPE, self.METADATA, self.SOURCE_VOLID,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_cb211e4f","line":678,"range":{"start_line":672,"start_character":0,"end_line":678,"end_character":54},"in_reply_to":"ba63e191_16d9b621","updated":"2016-01-19 20:01:54.000000000","message":"Hmm, there\u0027s not the same case like with image because we need to update only specified in hints additional properties, not all properties, because there\u0027s can be many props defined during volume creating, which we should not specify in template.","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"a241f9201ec31e3def4c50682b244386392580fc","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                volume_reality.update({self.IMAGE: None})"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Update reality data with scheduler hints."},{"line_number":672,"context_line":"        hints \u003d resource_properties.get(self.CINDER_SCHEDULER_HINTS)"},{"line_number":673,"context_line":"        if hints is not None:"},{"line_number":674,"context_line":"            volume_reality.update({self.CINDER_SCHEDULER_HINTS: {}})"},{"line_number":675,"context_line":"            for hint in hints:"},{"line_number":676,"context_line":"                if volume_data.get(hint) is not None:"},{"line_number":677,"context_line":"                    volume_reality[self.CINDER_SCHEDULER_HINTS].update("},{"line_number":678,"context_line":"                        {hint: volume_data.get(hint)})"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        props_keys \u003d [self.SIZE, self.SNAPSHOT_ID, self.NAME, self.DESCRIPTION,"},{"line_number":681,"context_line":"                      self.VOLUME_TYPE, self.METADATA, self.SOURCE_VOLID,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_16d9b621","line":678,"range":{"start_line":672,"start_character":0,"end_line":678,"end_character":54},"in_reply_to":"da6ed579_96457618","updated":"2016-01-19 12:17:54.000000000","message":"Done","commit_id":"59e3f8e6379c006dd2e417346d332c5a19910846"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"28a33283f78ea7105c518e32946bf406d45f7f06","unresolved":false,"context_lines":[{"line_number":665,"context_line":"            volume_reality.update({self.AVAILABILITY_ZONE: new_az})"},{"line_number":666,"context_line":"            self.data_set(self.AVAILABILITY_ZONE, new_az)"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"        read_only \u003d resource_data.get(self.METADATA).pop(self.READ_ONLY)"},{"line_number":669,"context_line":"        volume_reality.update({self.READ_ONLY: read_only})"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Check image and decide how to add it to resulting dict."}],"source_content_type":"text/x-python","patch_set":13,"id":"bae84128_51d4f745","line":668,"range":{"start_line":668,"start_character":53,"end_line":668,"end_character":72},"updated":"2016-02-22 12:00:53.000000000","message":"read_only can be not present in metadata.","commit_id":"9b2f7484ffdace2868656cd53901806194ece0f7"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"28a33283f78ea7105c518e32946bf406d45f7f06","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                for hint in hints:"},{"line_number":695,"context_line":"                    volume_reality[self.CINDER_SCHEDULER_HINTS].update("},{"line_number":696,"context_line":"                        {hint: resource_data.get(hint)})"},{"line_number":697,"context_line":"            old_multiattach \u003d bool(int(self.data().get(self.MULTI_ATTACH)))"},{"line_number":698,"context_line":"            new_multiattach \u003d resource_data.get(self.MULTI_ATTACH)"},{"line_number":699,"context_line":"            if (resource_properties.get(self.MULTI_ATTACH) is not None or"},{"line_number":700,"context_line":"                    new_multiattach !\u003d old_multiattach):"},{"line_number":701,"context_line":"                volume_reality.update({self.MULTI_ATTACH: new_multiattach})"},{"line_number":702,"context_line":"                self.data_set(self.MULTI_ATTACH, new_multiattach)"},{"line_number":703,"context_line":"            else:"},{"line_number":704,"context_line":"                volume_reality.update({self.MULTI_ATTACH: None})"},{"line_number":705,"context_line":"        else:"},{"line_number":706,"context_line":"            resource_data.update({self.CINDER_SCHEDULER_HINTS: {},"},{"line_number":707,"context_line":"                                  self.MULTIATTACH: None})"}],"source_content_type":"text/x-python","patch_set":13,"id":"bae84128_11170fee","line":704,"range":{"start_line":697,"start_character":0,"end_line":704,"end_character":64},"updated":"2016-02-22 12:00:53.000000000","message":"I would prefer just add default\u003dFalse to multiattach and avoid this manipulations.","commit_id":"9b2f7484ffdace2868656cd53901806194ece0f7"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"32223e5cd190c6530189e86a8ea69da5f8d37c60","unresolved":false,"context_lines":[{"line_number":707,"context_line":"                                  self.MULTIATTACH: None})"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"        props_keys \u003d [self.SIZE, self.SNAPSHOT_ID, self.NAME, self.DESCRIPTION,"},{"line_number":710,"context_line":"                      self.VOLUME_TYPE, self.METADATA, self.SOURCE_VOLID,"},{"line_number":711,"context_line":"                      self.BACKUP_ID]"},{"line_number":712,"context_line":"        for key in props_keys:"},{"line_number":713,"context_line":"            volume_reality.update({key: resource_data.get(key)})"}],"source_content_type":"text/x-python","patch_set":13,"id":"bae84128_3408412c","line":710,"range":{"start_line":710,"start_character":22,"end_line":710,"end_character":38},"updated":"2016-02-22 12:40:17.000000000","message":"It seems that cinder set some volume_type by default, if we do not pass one. In this case we are trying to update volume type to None, but cinder fails.","commit_id":"9b2f7484ffdace2868656cd53901806194ece0f7"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"bcbc326a8eb8ef4060b1752ce979e20993fa1105","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        return complete"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _store_config_default_properties(self, **kwargs):"},{"line_number":310,"context_line":"        vol \u003d self.client().volumes.get(self.resource_id)"},{"line_number":311,"context_line":"        if kwargs.get(\u0027volume_type\u0027) is not None:"},{"line_number":312,"context_line":"            self.data_set(self.VOLUME_TYPE, kwargs[\u0027volume_type\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"3ac371cc_a0297839","line":309,"range":{"start_line":309,"start_character":1,"end_line":309,"end_character":57},"updated":"2016-08-17 10:08:19.000000000","message":"Please add comment, why we need to store exactly this property to resource data.","commit_id":"cf0f390cf0d35a5fe28b962a8cfdaa7ed3bb47ee"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"41b9daadf05415bcd6b0e86368fc07e673b8cb80","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        return complete"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _store_config_default_properties(self, **kwargs):"},{"line_number":310,"context_line":"        vol \u003d self.client().volumes.get(self.resource_id)"},{"line_number":311,"context_line":"        if kwargs.get(\u0027volume_type\u0027) is not None:"},{"line_number":312,"context_line":"            self.data_set(self.VOLUME_TYPE, kwargs[\u0027volume_type\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"3ac371cc_877b52bd","line":309,"range":{"start_line":309,"start_character":1,"end_line":309,"end_character":57},"in_reply_to":"3ac371cc_a0297839","updated":"2016-08-18 15:19:23.000000000","message":"Done","commit_id":"cf0f390cf0d35a5fe28b962a8cfdaa7ed3bb47ee"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"bcbc326a8eb8ef4060b1752ce979e20993fa1105","unresolved":false,"context_lines":[{"line_number":670,"context_line":"            volume_reality.update({self.VOLUME_TYPE: new_vt})"},{"line_number":671,"context_line":"            self._store_config_default_properties(volume_type\u003dnew_vt)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        props_keys \u003d [self.SIZE, self.NAME, self.DESCRIPTION,"},{"line_number":674,"context_line":"                      self.METADATA, self.BACKUP_ID]"},{"line_number":675,"context_line":"        for key in props_keys:"},{"line_number":676,"context_line":"            volume_reality.update({key: resource_data.get(key)})"},{"line_number":677,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3ac371cc_80143ca0","line":674,"range":{"start_line":673,"start_character":0,"end_line":674,"end_character":52},"updated":"2016-08-17 10:08:19.000000000","message":"Suggestion: not the reason for -1. How about generation this list by using property schema like:\n[prop.name for prop in property_schema if prop.name not in (self.VOLUME_TYPE, self.READ_ONLY) and prop.update_allowed]","commit_id":"cf0f390cf0d35a5fe28b962a8cfdaa7ed3bb47ee"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"41b9daadf05415bcd6b0e86368fc07e673b8cb80","unresolved":false,"context_lines":[{"line_number":670,"context_line":"            volume_reality.update({self.VOLUME_TYPE: new_vt})"},{"line_number":671,"context_line":"            self._store_config_default_properties(volume_type\u003dnew_vt)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        props_keys \u003d [self.SIZE, self.NAME, self.DESCRIPTION,"},{"line_number":674,"context_line":"                      self.METADATA, self.BACKUP_ID]"},{"line_number":675,"context_line":"        for key in props_keys:"},{"line_number":676,"context_line":"            volume_reality.update({key: resource_data.get(key)})"},{"line_number":677,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3ac371cc_4775dac8","line":674,"range":{"start_line":673,"start_character":0,"end_line":674,"end_character":52},"in_reply_to":"3ac371cc_80143ca0","updated":"2016-08-18 15:19:23.000000000","message":"Need to think about your suggestion. IMO, it will be too complex than overriding parse_live_resource_data in res plugin.","commit_id":"cf0f390cf0d35a5fe28b962a8cfdaa7ed3bb47ee"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"698df35c0653a2b6289ee172e0d788dbd373b724","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            properties.Schema.BOOLEAN,"},{"line_number":163,"context_line":"            _(\u0027Whether allow the volume to be attached more than once.\u0027),"},{"line_number":164,"context_line":"            support_status\u003dsupport.SupportStatus(version\u003d\u00276.0.0\u0027),"},{"line_number":165,"context_line":"            default\u003dFalse"},{"line_number":166,"context_line":"        ),"},{"line_number":167,"context_line":"    }"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1ac06dbe_7f8ca135","line":165,"range":{"start_line":165,"start_character":12,"end_line":165,"end_character":25},"updated":"2016-08-25 01:48:18.000000000","message":"Why we have to set the default value?","commit_id":"0c02f0ca8912c1f2312f45258c3b3a96c6b88cc8"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"4012d96fc71ece0a5296ae55c313a151e5766203","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            properties.Schema.BOOLEAN,"},{"line_number":163,"context_line":"            _(\u0027Whether allow the volume to be attached more than once.\u0027),"},{"line_number":164,"context_line":"            support_status\u003dsupport.SupportStatus(version\u003d\u00276.0.0\u0027),"},{"line_number":165,"context_line":"            default\u003dFalse"},{"line_number":166,"context_line":"        ),"},{"line_number":167,"context_line":"    }"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"fa7ab95a_c4eefceb","line":165,"range":{"start_line":165,"start_character":12,"end_line":165,"end_character":25},"in_reply_to":"1ac06dbe_7f8ca135","updated":"2016-08-26 06:17:29.000000000","message":"because if there\u0027s no multiattach in args, cinder equals it to False by default. It\u0027s small fix, which relates observe reality.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L213","commit_id":"0c02f0ca8912c1f2312f45258c3b3a96c6b88cc8"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"698df35c0653a2b6289ee172e0d788dbd373b724","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        required property\u0027s value."},{"line_number":314,"context_line":"        \"\"\""},{"line_number":315,"context_line":"        vol \u003d self.client().volumes.get(self.resource_id)"},{"line_number":316,"context_line":"        if kwargs.get(\u0027volume_type\u0027) is not None:"},{"line_number":317,"context_line":"            self.data_set(self.VOLUME_TYPE, kwargs[\u0027volume_type\u0027])"},{"line_number":318,"context_line":"        elif hasattr(vol, \u0027volume_type\u0027):"},{"line_number":319,"context_line":"            self.data_set(self.VOLUME_TYPE, vol.volume_type)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ac06dbe_fff41188","line":316,"range":{"start_line":316,"start_character":11,"end_line":316,"end_character":49},"updated":"2016-08-25 01:48:18.000000000","message":"Same as the comment in line 651, if the new volume_type is None which indicates the volume has not volume type.","commit_id":"0c02f0ca8912c1f2312f45258c3b3a96c6b88cc8"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"4012d96fc71ece0a5296ae55c313a151e5766203","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        required property\u0027s value."},{"line_number":314,"context_line":"        \"\"\""},{"line_number":315,"context_line":"        vol \u003d self.client().volumes.get(self.resource_id)"},{"line_number":316,"context_line":"        if kwargs.get(\u0027volume_type\u0027) is not None:"},{"line_number":317,"context_line":"            self.data_set(self.VOLUME_TYPE, kwargs[\u0027volume_type\u0027])"},{"line_number":318,"context_line":"        elif hasattr(vol, \u0027volume_type\u0027):"},{"line_number":319,"context_line":"            self.data_set(self.VOLUME_TYPE, vol.volume_type)"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa7ab95a_64ce1085","line":316,"range":{"start_line":316,"start_character":11,"end_line":316,"end_character":49},"in_reply_to":"1ac06dbe_fff41188","updated":"2016-08-26 06:17:29.000000000","message":"Done","commit_id":"0c02f0ca8912c1f2312f45258c3b3a96c6b88cc8"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"698df35c0653a2b6289ee172e0d788dbd373b724","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        old_vt \u003d self.data().get(self.VOLUME_TYPE)"},{"line_number":650,"context_line":"        new_vt \u003d resource_data.get(self.VOLUME_TYPE)"},{"line_number":651,"context_line":"        if new_vt is not None and old_vt !\u003d new_vt:"},{"line_number":652,"context_line":"            volume_reality.update({self.VOLUME_TYPE: new_vt})"},{"line_number":653,"context_line":"            self._store_config_default_properties(volume_type\u003dnew_vt)"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1ac06dbe_1fd12dfc","line":651,"range":{"start_line":651,"start_character":11,"end_line":651,"end_character":30},"updated":"2016-08-25 01:48:18.000000000","message":"How about the case if new_vt is None? IMO, we only have to check old_vt !\u003d new_vt here.","commit_id":"0c02f0ca8912c1f2312f45258c3b3a96c6b88cc8"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"4012d96fc71ece0a5296ae55c313a151e5766203","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        old_vt \u003d self.data().get(self.VOLUME_TYPE)"},{"line_number":650,"context_line":"        new_vt \u003d resource_data.get(self.VOLUME_TYPE)"},{"line_number":651,"context_line":"        if new_vt is not None and old_vt !\u003d new_vt:"},{"line_number":652,"context_line":"            volume_reality.update({self.VOLUME_TYPE: new_vt})"},{"line_number":653,"context_line":"            self._store_config_default_properties(volume_type\u003dnew_vt)"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"fa7ab95a_e4b940ee","line":651,"range":{"start_line":651,"start_character":11,"end_line":651,"end_character":30},"in_reply_to":"1ac06dbe_1fd12dfc","updated":"2016-08-26 06:17:29.000000000","message":"you\u0027re right","commit_id":"0c02f0ca8912c1f2312f45258c3b3a96c6b88cc8"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"ccc57a2bc93f3862ce8e024dceac868fa8df453c","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        stored for further using. So need to get created resource and take"},{"line_number":313,"context_line":"        required property\u0027s value."},{"line_number":314,"context_line":"        \"\"\""},{"line_number":315,"context_line":"        vol \u003d self.client().volumes.get(self.resource_id)"},{"line_number":316,"context_line":"        if kwargs.get(\u0027volume_type\u0027) is not None:"},{"line_number":317,"context_line":"            self.data_set(self.VOLUME_TYPE, kwargs[\u0027volume_type\u0027])"},{"line_number":318,"context_line":"        elif hasattr(vol, \u0027volume_type\u0027):"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_3b20f0f6","line":315,"range":{"start_line":315,"start_character":8,"end_line":315,"end_character":57},"updated":"2016-08-30 10:40:28.000000000","message":"We don\u0027t need to call get while calling this method from parse_live_resource_data.\nAlso we can set volume_type in handle_create, this will save one call to cinder.","commit_id":"66fc9bf3e1a51ec7abbd6fabbedd59e9f3c9f39f"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"ccc57a2bc93f3862ce8e024dceac868fa8df453c","unresolved":false,"context_lines":[{"line_number":652,"context_line":"        new_vt \u003d resource_data.get(self.VOLUME_TYPE)"},{"line_number":653,"context_line":"        if old_vt !\u003d new_vt:"},{"line_number":654,"context_line":"            volume_reality.update({self.VOLUME_TYPE: new_vt})"},{"line_number":655,"context_line":"            self._store_config_default_properties(volume_type\u003dnew_vt)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        props_keys \u003d [self.SIZE, self.NAME, self.DESCRIPTION,"},{"line_number":658,"context_line":"                      self.METADATA, self.BACKUP_ID]"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_1bf7ac8b","line":655,"range":{"start_line":655,"start_character":12,"end_line":655,"end_character":69},"updated":"2016-08-30 10:40:28.000000000","message":"You are calling cinder client in this method, but we already have all needed info.","commit_id":"66fc9bf3e1a51ec7abbd6fabbedd59e9f3c9f39f"}],"heat/tests/openstack/cinder/test_volume.py":[{"author":{"_account_id":20559,"name":"Dmitriy Uvarenkov","email":"vitarcheg@gmail.com","username":"duvarenkov"},"change_message_id":"0844836d5494c5e3f2a16520d8f46c672d34890a","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"            \u0027read_only\u0027: False,"},{"line_number":1324,"context_line":"        }"},{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":"        self.assertEqual(set(expected.keys()), set(reality.keys()))"},{"line_number":1327,"context_line":"        for key in expected:"},{"line_number":1328,"context_line":"            self.assertEqual(expected[key], reality[key])"}],"source_content_type":"text/x-python","patch_set":17,"id":"3ac371cc_9b714dab","line":1328,"range":{"start_line":1326,"start_character":8,"end_line":1328,"end_character":57},"updated":"2016-08-17 10:11:04.000000000","message":"Still suggest combining it into one check by dicts.","commit_id":"cf0f390cf0d35a5fe28b962a8cfdaa7ed3bb47ee"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"41b9daadf05415bcd6b0e86368fc07e673b8cb80","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"            \u0027read_only\u0027: False,"},{"line_number":1324,"context_line":"        }"},{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":"        self.assertEqual(set(expected.keys()), set(reality.keys()))"},{"line_number":1327,"context_line":"        for key in expected:"},{"line_number":1328,"context_line":"            self.assertEqual(expected[key], reality[key])"}],"source_content_type":"text/x-python","patch_set":17,"id":"3ac371cc_0746427a","line":1328,"range":{"start_line":1326,"start_character":8,"end_line":1328,"end_character":57},"in_reply_to":"3ac371cc_9b714dab","updated":"2016-08-18 15:19:23.000000000","message":"Done","commit_id":"cf0f390cf0d35a5fe28b962a8cfdaa7ed3bb47ee"}]}
