)]}'
{"contrib/rackspace/setup.py":[{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"1f14e7a8cc6fc613350d5f19092eff43bd14401a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# THIS FILE IS MANAGED BY THE GLOBAL REQUIREMENTS REPO - DO NOT EDIT"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"import setuptools"},{"line_number":20,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_8da0e8a0","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":37},"updated":"2016-01-04 21:08:03.000000000","message":"Is this comment invalid and/or will these changes be lost the next time the global requirement job triggers?","commit_id":"9653c16749801f9953b7bd1c0dc29fea52652293"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"8fb6314aee124af794e91cf381a3dbb916264808","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# THIS FILE IS MANAGED BY THE GLOBAL REQUIREMENTS REPO - DO NOT EDIT"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"import setuptools"},{"line_number":20,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_4f0f3d88","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":37},"in_reply_to":"fa69d971_8da0e8a0","updated":"2016-01-05 01:53:58.000000000","message":"Done","commit_id":"9653c16749801f9953b7bd1c0dc29fea52652293"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"8fe4c1f61deabb3302b03fe8ae5d6855ef014928","unresolved":false,"context_lines":[{"line_number":23,"context_line":"try:"},{"line_number":24,"context_line":"    import multiprocessing  # noqa"},{"line_number":25,"context_line":"except ImportError as e:"},{"line_number":26,"context_line":"    pass"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"setuptools.setup("},{"line_number":29,"context_line":"    setup_requires\u003d[\u0027pbr\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_8be96d81","line":26,"updated":"2016-01-11 21:21:42.000000000","message":"missed logging here?","commit_id":"8215c873469d81d8d65908250930a04a93e7d479"}],"heat/common/heat_keystoneclient.py":[{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"1f14e7a8cc6fc613350d5f19092eff43bd14401a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        try:"},{"line_number":244,"context_line":"            self.client.trusts.delete(trust_id)"},{"line_number":245,"context_line":"        except kc_exception.NotFound as e:"},{"line_number":246,"context_line":"            LOG.debug(\"Ignore exception: %s\" % six.text_type(e))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def _get_username(self, username):"},{"line_number":249,"context_line":"        if(len(username) \u003e 64):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_8dc5483d","line":246,"range":{"start_line":246,"start_character":23,"end_line":246,"end_character":29},"updated":"2016-01-04 21:08:03.000000000","message":"I don\u0027t think this is something that needs to be logged. The model here seems to be just verifying the end state of the trust not existing; it\u0027s a safer way of checking if the trust exists and then deleting it. I wouldn\u0027t consider this an error, even if it is just debug logs.","commit_id":"9653c16749801f9953b7bd1c0dc29fea52652293"}],"heat/common/wsgi.py":[{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"1f14e7a8cc6fc613350d5f19092eff43bd14401a","unresolved":false,"context_lines":[{"line_number":929,"context_line":"        try:"},{"line_number":930,"context_line":"            del args[\u0027format\u0027]"},{"line_number":931,"context_line":"        except KeyError as e:"},{"line_number":932,"context_line":"            LOG.debug(\"Ignore exception: %s\" % six.text_type(e))"},{"line_number":933,"context_line":""},{"line_number":934,"context_line":"        return args"},{"line_number":935,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_add7eceb","line":932,"range":{"start_line":932,"start_character":30,"end_line":932,"end_character":39},"updated":"2016-01-04 21:08:03.000000000","message":"I\u0027m not sure either of these qualify as errors that should be noted either. It\u0027s a shortcut to checking the presence of those keys before removing them. Outputting it as an exception might be misleading.","commit_id":"9653c16749801f9953b7bd1c0dc29fea52652293"}],"heat/engine/cfn/functions.py":[{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"1f14e7a8cc6fc613350d5f19092eff43bd14401a","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        try:"},{"line_number":267,"context_line":"            index \u003d int(index)"},{"line_number":268,"context_line":"        except (ValueError, TypeError) as e:"},{"line_number":269,"context_line":"            LOG.debug(\"Ignore exception: %s\" % six.text_type(e))"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        if (isinstance(strings, collections.Sequence) and"},{"line_number":272,"context_line":"                not isinstance(strings, six.string_types)):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_ed3ba436","line":269,"range":{"start_line":269,"start_character":51,"end_line":269,"end_character":60},"updated":"2016-01-04 21:08:03.000000000","message":"I don\u0027t see a problem with this log, though the check feels stale itself since the code below will do an isinstance check again and raise a TypeError.","commit_id":"9653c16749801f9953b7bd1c0dc29fea52652293"}],"heat/engine/resource.py":[{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"1f14e7a8cc6fc613350d5f19092eff43bd14401a","unresolved":false,"context_lines":[{"line_number":1652,"context_line":"                reason_string \u003d get_string_details()"},{"line_number":1653,"context_line":"            self._add_event(\u0027SIGNAL\u0027, self.status, reason_string)"},{"line_number":1654,"context_line":"        except exception.NoActionRequired as e:"},{"line_number":1655,"context_line":"            # Don\u0027t log an event as it just spams the user."},{"line_number":1656,"context_line":"            LOG.debug(\"Ignore exception: %s\" % six.text_type(e))"},{"line_number":1657,"context_line":"        except Exception as ex:"},{"line_number":1658,"context_line":"            LOG.exception(_LE(\u0027signal %(name)s : %(msg)s\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_0dd2b8d2","line":1655,"range":{"start_line":1655,"start_character":0,"end_line":1655,"end_character":59},"updated":"2016-01-04 21:08:03.000000000","message":"If you do another revision, it might be nice to update this comment to reflect the new behavior (or remove entirely given that it\u0027ll be pretty clear since it\u0027s at the debug level).","commit_id":"9653c16749801f9953b7bd1c0dc29fea52652293"}],"heat/engine/resources/openstack/ceilometer/alarm.py":[{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"1f14e7a8cc6fc613350d5f19092eff43bd14401a","unresolved":false,"context_lines":[{"line_number":382,"context_line":"                self.context, watch_name\u003dself.physical_resource_name())"},{"line_number":383,"context_line":"            wr.destroy()"},{"line_number":384,"context_line":"        except exception.EntityNotFound as e:"},{"line_number":385,"context_line":"            LOG.debug(\"Ignore exception: %s\" % six.text_type(e))"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        return super(CeilometerAlarm, self).handle_delete()"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_0d45d86e","line":385,"updated":"2016-01-04 21:08:03.000000000","message":"I think this is another case of us not needing to log anything since the end state is still the same (the item is deleted).","commit_id":"9653c16749801f9953b7bd1c0dc29fea52652293"}],"heat/engine/resources/openstack/heat/cloud_watch.py":[{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"1f14e7a8cc6fc613350d5f19092eff43bd14401a","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                self.context, watch_name\u003dself.physical_resource_name())"},{"line_number":182,"context_line":"            wr.destroy()"},{"line_number":183,"context_line":"        except exception.EntityNotFound as e:"},{"line_number":184,"context_line":"            LOG.debug(\"Ignore exception: %s\" % six.text_type(e))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def handle_suspend(self):"},{"line_number":187,"context_line":"        wr \u003d watchrule.WatchRule.load(self.context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_6d3574f5","line":184,"updated":"2016-01-04 21:08:03.000000000","message":"Same as alarm.py, so whatever you decide should be done in both places.","commit_id":"9653c16749801f9953b7bd1c0dc29fea52652293"}],"heat/engine/update.py":[{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"3088cb0726cfd48fd3ec8df2d076f9314ab75e09","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            try:"},{"line_number":143,"context_line":"                yield self._update_in_place(existing_res,"},{"line_number":144,"context_line":"                                            new_res)"},{"line_number":145,"context_line":"            except exception.UpdateReplace as e:"},{"line_number":146,"context_line":"                LOG.debug(\"Ignore exception: %s\" % six.text_type(e))"},{"line_number":147,"context_line":"            else:"},{"line_number":148,"context_line":"                # Save updated resource definition to backup stack"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_62511a62","line":145,"range":{"start_line":145,"start_character":29,"end_line":145,"end_character":42},"updated":"2016-01-04 11:41:48.000000000","message":"I\u0027m not sure we actually ignore this exception, we have \u0027else\u0027 clause after \u0027except\u0027. So we just run self._create_resource(new_res) if this was really UpdateReplace and do another logic otherwise. May be just log it without \"Ignore exception\"?","commit_id":"7d84a6bbddca77b656c79e5049f86bf56649f51b"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"2775b064a15505d0522a7f08b9cb5bfb09eb184d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            try:"},{"line_number":143,"context_line":"                yield self._update_in_place(existing_res,"},{"line_number":144,"context_line":"                                            new_res)"},{"line_number":145,"context_line":"            except exception.UpdateReplace as e:"},{"line_number":146,"context_line":"                LOG.debug(\"Ignore exception: %s\" % six.text_type(e))"},{"line_number":147,"context_line":"            else:"},{"line_number":148,"context_line":"                # Save updated resource definition to backup stack"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_fddccf13","line":145,"range":{"start_line":145,"start_character":29,"end_line":145,"end_character":42},"in_reply_to":"fa69d971_1dbbe30f","updated":"2016-01-04 11:58:35.000000000","message":"Rico, I meant, that we don\u0027t actually ignore UpdateReplace here, because of `else` below. So it actually control the execution path. If any other exception will be raised or there will be no exception at all, we will run another code.\nIt is the same, if we put\n\nyield self._create_resource(new_res)\n\nreturn\n\nin this except branch.","commit_id":"7d84a6bbddca77b656c79e5049f86bf56649f51b"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"fb4b521be846b3d2ea7e28caaa15dc99209123ef","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            try:"},{"line_number":143,"context_line":"                yield self._update_in_place(existing_res,"},{"line_number":144,"context_line":"                                            new_res)"},{"line_number":145,"context_line":"            except exception.UpdateReplace as e:"},{"line_number":146,"context_line":"                LOG.debug(\"Ignore exception: %s\" % six.text_type(e))"},{"line_number":147,"context_line":"            else:"},{"line_number":148,"context_line":"                # Save updated resource definition to backup stack"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_1dbbe30f","line":145,"range":{"start_line":145,"start_character":29,"end_line":145,"end_character":42},"in_reply_to":"fa69d971_62511a62","updated":"2016-01-04 11:51:53.000000000","message":"Don\u0027t get it wrong, The logic of these try-catch are perfect. When we raise an exception.UpdateReplace here, it suppose to get ignored. However, when we trace the log here, for those exception who raise and written in log, the message will not be so clear to show us that this is an error meant to be ignored. And for those exception who did not product any log out, we just get log for the next step to know the previous step passed.","commit_id":"7d84a6bbddca77b656c79e5049f86bf56649f51b"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"89a0904241a1e012add9d50690f1633acf4945dd","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            try:"},{"line_number":143,"context_line":"                yield self._update_in_place(existing_res,"},{"line_number":144,"context_line":"                                            new_res)"},{"line_number":145,"context_line":"            except exception.UpdateReplace as e:"},{"line_number":146,"context_line":"                LOG.debug(\"Ignore exception: %s\" % six.text_type(e))"},{"line_number":147,"context_line":"            else:"},{"line_number":148,"context_line":"                # Save updated resource definition to backup stack"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_9ced8b27","line":145,"range":{"start_line":145,"start_character":29,"end_line":145,"end_character":42},"in_reply_to":"fa69d971_fddccf13","updated":"2016-01-04 15:51:09.000000000","message":"Agree with you, the ignore word can be confused here. Will Change it","commit_id":"7d84a6bbddca77b656c79e5049f86bf56649f51b"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"798e3b643afd2d6fa0daefb865e59264d2766250","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            try:"},{"line_number":143,"context_line":"                yield self._update_in_place(existing_res,"},{"line_number":144,"context_line":"                                            new_res)"},{"line_number":145,"context_line":"            except exception.UpdateReplace as e:"},{"line_number":146,"context_line":"                LOG.debug(six.text_type(e))"},{"line_number":147,"context_line":"            else:"},{"line_number":148,"context_line":"                # Save updated resource definition to backup stack"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_a2555751","line":145,"updated":"2016-02-16 07:30:03.000000000","message":"This is better kept as it was!","commit_id":"8215c873469d81d8d65908250930a04a93e7d479"}]}
