)]}'
{"rally-scenarios/heat-fakevirt.yaml":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7f700f7659c997f37ece3517261c182a3846c289","unresolved":false,"context_lines":[{"line_number":21,"context_line":"          tenants: 10"},{"line_number":22,"context_line":"          users_per_tenant: 3"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  HeatStacks.create_stack_and_show_output_new:"},{"line_number":25,"context_line":"    -"},{"line_number":26,"context_line":"      args:"},{"line_number":27,"context_line":"        template_path: \"extra/rg_template_with_outputs.yaml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a68dd71_0c5f7c73","line":24,"range":{"start_line":24,"start_character":2,"end_line":24,"end_character":45},"updated":"2016-01-20 20:11:23.000000000","message":"All added scenarios do not exist:)","commit_id":"1b72d5240025fd2f46f66ad2846c6e79e2531d17"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"bdd0256d39e64f7dfb356d0ff3b74f9ac7afbdc4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      runner:"},{"line_number":30,"context_line":"        type: \"constant\""},{"line_number":31,"context_line":"        times: 5"},{"line_number":32,"context_line":"        concurrency: 1"},{"line_number":33,"context_line":"      context:"},{"line_number":34,"context_line":"        users:"},{"line_number":35,"context_line":"          tenants: 1"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dae33548_4d1c266a","line":32,"updated":"2016-02-17 13:57:31.000000000","message":"Just to note: \"concurrency: 1\" takes no advantage from using constant runner since it actually becomes \"serial\" runner","commit_id":"b4b7d0b98e30f60eb4dc618b135415c17f587f54"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"59815530114b02031f6647b79f3a1c57421590d1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"          tenants: 1"},{"line_number":38,"context_line":"          users_per_tenant: 1"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  CustomHeatBenchmark.create_stack_and_show_output_new:"},{"line_number":41,"context_line":"    -"},{"line_number":42,"context_line":"      args:"},{"line_number":43,"context_line":"        template_path: \"~/.rally/extra/rg_template_with_outputs.yaml\""},{"line_number":44,"context_line":"        output_key: \"val1\""},{"line_number":45,"context_line":"      runner:"},{"line_number":46,"context_line":"        type: \"constant\""},{"line_number":47,"context_line":"        times: 5"},{"line_number":48,"context_line":"        concurrency: 1"},{"line_number":49,"context_line":"      context:"},{"line_number":50,"context_line":"        users:"},{"line_number":51,"context_line":"          tenants: 1"},{"line_number":52,"context_line":"          users_per_tenant: 1"},{"line_number":53,"context_line":"      sla:"},{"line_number":54,"context_line":"        failure_rate:"},{"line_number":55,"context_line":"          max: 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  CustomHeatBenchmark.create_stack_and_show_output_old:"},{"line_number":58,"context_line":"    -"},{"line_number":59,"context_line":"      args:"},{"line_number":60,"context_line":"        template_path: \"~/.rally/extra/rg_template_with_outputs.yaml\""},{"line_number":61,"context_line":"        output_key: \"val1\""},{"line_number":62,"context_line":"      runner:"},{"line_number":63,"context_line":"        type: \"constant\""},{"line_number":64,"context_line":"        times: 5"},{"line_number":65,"context_line":"        concurrency: 1"},{"line_number":66,"context_line":"      context:"},{"line_number":67,"context_line":"        users:"},{"line_number":68,"context_line":"          tenants: 1"},{"line_number":69,"context_line":"          users_per_tenant: 1"},{"line_number":70,"context_line":"      sla:"},{"line_number":71,"context_line":"        failure_rate:"},{"line_number":72,"context_line":"          max: 0"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  CustomHeatBenchmark.create_stack_and_list_output_new:"},{"line_number":75,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7af24918_2315ac3f","line":72,"range":{"start_line":40,"start_character":0,"end_line":72,"end_character":16},"updated":"2016-03-02 15:21:58.000000000","message":"Please use Jinja to reduce code duplication. You need to add for loop over test names. Example https://github.com/openstack/rally/blob/master/rally-jobs/rally-ironic.yaml.","commit_id":"e5db44d309d43eb3dc3b6a4675905508e2e53db0"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"59815530114b02031f6647b79f3a1c57421590d1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        failure_rate:"},{"line_number":72,"context_line":"          max: 0"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  CustomHeatBenchmark.create_stack_and_list_output_new:"},{"line_number":75,"context_line":"    -"},{"line_number":76,"context_line":"      args:"},{"line_number":77,"context_line":"        template_path: \"~/.rally/extra/rg_template_with_outputs.yaml\""},{"line_number":78,"context_line":"      runner:"},{"line_number":79,"context_line":"        type: \"constant\""},{"line_number":80,"context_line":"        times: 5"},{"line_number":81,"context_line":"        concurrency: 1"},{"line_number":82,"context_line":"      context:"},{"line_number":83,"context_line":"        users:"},{"line_number":84,"context_line":"          tenants: 1"},{"line_number":85,"context_line":"          users_per_tenant: 1"},{"line_number":86,"context_line":"      sla:"},{"line_number":87,"context_line":"        failure_rate:"},{"line_number":88,"context_line":"          max: 0"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  CustomHeatBenchmark.create_stack_and_list_output_old:"},{"line_number":91,"context_line":"    -"},{"line_number":92,"context_line":"      args:"},{"line_number":93,"context_line":"        template_path: \"~/.rally/extra/rg_template_with_outputs.yaml\""},{"line_number":94,"context_line":"      runner:"},{"line_number":95,"context_line":"        type: \"constant\""},{"line_number":96,"context_line":"        times: 5"},{"line_number":97,"context_line":"        concurrency: 1"},{"line_number":98,"context_line":"      context:"},{"line_number":99,"context_line":"        users:"},{"line_number":100,"context_line":"          tenants: 1"},{"line_number":101,"context_line":"          users_per_tenant: 1"},{"line_number":102,"context_line":"      sla:"},{"line_number":103,"context_line":"        failure_rate:"},{"line_number":104,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7af24918_a327fcb4","line":104,"range":{"start_line":74,"start_character":0,"end_line":104,"end_character":16},"updated":"2016-03-02 15:21:58.000000000","message":"ditto","commit_id":"e5db44d309d43eb3dc3b6a4675905508e2e53db0"}],"rally-scenarios/plugins/stack_output.py":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3063af75e3e688437d0af9923f29f8567b4fd6ba","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        stack \u003d self._create_stack("},{"line_number":98,"context_line":"            template_path, parameters, files, environment)"},{"line_number":99,"context_line":"        self._stack_show_output_old(stack, output_key)"},{"line_number":100,"context_line":"        self._delete_stack(stack)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @types.set(template_path\u003dtypes.FileType, files\u003dtypes.FileTypeDict)"},{"line_number":103,"context_line":"    @validation.required_services(consts.Service.HEAT)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_e8c7cb93","line":100,"updated":"2016-02-23 20:27:48.000000000","message":"Would it be necessary to put the delete stack call in the else leg of a try/except to help make sure proper cleanup is done?   Not sure if not cleaning up would effect other future tests.","commit_id":"829b9254a76230d70792067ed2a7a86611ab9ed0"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"57509a05bc92f364ccc109749b7e6820b19fabe6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        stack \u003d self._create_stack("},{"line_number":98,"context_line":"            template_path, parameters, files, environment)"},{"line_number":99,"context_line":"        self._stack_show_output_old(stack, output_key)"},{"line_number":100,"context_line":"        self._delete_stack(stack)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @types.set(template_path\u003dtypes.FileType, files\u003dtypes.FileTypeDict)"},{"line_number":103,"context_line":"    @validation.required_services(consts.Service.HEAT)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_8554f2c9","line":100,"in_reply_to":"bae84128_d528819c","updated":"2016-02-24 15:21:07.000000000","message":"yeah, just removing it and letting cleanup handle this seems cleaner to me. thx.","commit_id":"829b9254a76230d70792067ed2a7a86611ab9ed0"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"a11f65fc3bea43fcadba98f64160db9e3ddfa575","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        stack \u003d self._create_stack("},{"line_number":98,"context_line":"            template_path, parameters, files, environment)"},{"line_number":99,"context_line":"        self._stack_show_output_old(stack, output_key)"},{"line_number":100,"context_line":"        self._delete_stack(stack)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @types.set(template_path\u003dtypes.FileType, files\u003dtypes.FileTypeDict)"},{"line_number":103,"context_line":"    @validation.required_services(consts.Service.HEAT)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_d528819c","line":100,"in_reply_to":"bae84128_e8c7cb93","updated":"2016-02-24 09:29:11.000000000","message":"AFAIK, we don\u0027t need to do it in try-except logic, because cleanup will be executed anyway. \nAlso I what kind of exception you suggest to handle here?\n\nMore over I think, that we can just remove this line.\nIs it ok for you?","commit_id":"829b9254a76230d70792067ed2a7a86611ab9ed0"}]}
