)]}'
{"heat/common/exception.py":[{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2e3a22d14c5c900c6bc820a9c53910c6a6a86b44","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"class InterfaceDetachFailed(HeatException):"},{"line_number":460,"context_line":"    msg_fmt \u003d _(\"Failed to detach interface (%(port)s) \""},{"line_number":461,"context_line":"                \"from server (%(server)s)\")"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"class UnsupportedObjectError(HeatException):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_be5e1010","line":461,"updated":"2016-03-09 04:16:12.000000000","message":"kindly remove the surrounding () forf each params","commit_id":"1b2aa261730485eff360a07b852cd3911b8b84a2"}],"heat/engine/clients/os/nova.py":[{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2e3a22d14c5c900c6bc820a9c53910c6a6a86b44","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        else:"},{"line_number":685,"context_line":"            return False"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"    @retry(stop_max_attempt_number\u003d100, wait_fixed\u003d500,"},{"line_number":688,"context_line":"           retry_on_result\u003dclient_plugin.retry_if_result_is_false)"},{"line_number":689,"context_line":"    def check_interface_detach(self, server_id, port_id):"},{"line_number":690,"context_line":"        server \u003d self.fetch_server(server_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_768764d7","line":687,"updated":"2016-03-09 04:16:12.000000000","message":"why this many times, i feel 100 is big in number for retry","commit_id":"1b2aa261730485eff360a07b852cd3911b8b84a2"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"a7e481a44bdc8cff3f7ff65abd1a435a95477d35","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        else:"},{"line_number":685,"context_line":"            return False"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"    @retry(stop_max_attempt_number\u003d100, wait_fixed\u003d500,"},{"line_number":688,"context_line":"           retry_on_result\u003dclient_plugin.retry_if_result_is_false)"},{"line_number":689,"context_line":"    def check_interface_detach(self, server_id, port_id):"},{"line_number":690,"context_line":"        server \u003d self.fetch_server(server_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_84f471f2","line":687,"in_reply_to":"5aef4532_768764d7","updated":"2016-03-09 08:16:44.000000000","message":"The patchset1 I retried 3 times, then the jenkins failed, I saw the log and found it took about 6 seconds, so I think we should retry for more times. I can add a configuration for retry times, and set to 10 default?","commit_id":"1b2aa261730485eff360a07b852cd3911b8b84a2"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2e3a22d14c5c900c6bc820a9c53910c6a6a86b44","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        server \u003d self.fetch_server(server_id)"},{"line_number":691,"context_line":"        if server:"},{"line_number":692,"context_line":"            interfaces \u003d server.interface_list()"},{"line_number":693,"context_line":"            ports \u003d [iface.port_id for iface in interfaces]"},{"line_number":694,"context_line":"            if port_id not in ports:"},{"line_number":695,"context_line":"                return True"},{"line_number":696,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_f6737413","line":693,"updated":"2016-03-09 04:16:12.000000000","message":"instead of forming the list, you could return False, the moment you find the iface.port_id is same as port id,","commit_id":"1b2aa261730485eff360a07b852cd3911b8b84a2"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"a7e481a44bdc8cff3f7ff65abd1a435a95477d35","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        server \u003d self.fetch_server(server_id)"},{"line_number":691,"context_line":"        if server:"},{"line_number":692,"context_line":"            interfaces \u003d server.interface_list()"},{"line_number":693,"context_line":"            ports \u003d [iface.port_id for iface in interfaces]"},{"line_number":694,"context_line":"            if port_id not in ports:"},{"line_number":695,"context_line":"                return True"},{"line_number":696,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_4489c925","line":693,"in_reply_to":"5aef4532_f6737413","updated":"2016-03-09 08:16:44.000000000","message":"Done","commit_id":"1b2aa261730485eff360a07b852cd3911b8b84a2"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"2e3a22d14c5c900c6bc820a9c53910c6a6a86b44","unresolved":false,"context_lines":[{"line_number":703,"context_line":"        if server:"},{"line_number":704,"context_line":"            interfaces \u003d server.interface_list()"},{"line_number":705,"context_line":"            for iface in interfaces:"},{"line_number":706,"context_line":"                if iface.port_id \u003d\u003d port_id:"},{"line_number":707,"context_line":"                    return True"},{"line_number":708,"context_line":"        return False"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_965b1087","line":706,"updated":"2016-03-09 04:16:12.000000000","message":"i meant this logic in above comment","commit_id":"1b2aa261730485eff360a07b852cd3911b8b84a2"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"a7e481a44bdc8cff3f7ff65abd1a435a95477d35","unresolved":false,"context_lines":[{"line_number":703,"context_line":"        if server:"},{"line_number":704,"context_line":"            interfaces \u003d server.interface_list()"},{"line_number":705,"context_line":"            for iface in interfaces:"},{"line_number":706,"context_line":"                if iface.port_id \u003d\u003d port_id:"},{"line_number":707,"context_line":"                    return True"},{"line_number":708,"context_line":"        return False"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_248c7d34","line":706,"in_reply_to":"5aef4532_965b1087","updated":"2016-03-09 08:16:44.000000000","message":"Done","commit_id":"1b2aa261730485eff360a07b852cd3911b8b84a2"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"cad261d37a63a618880685987b109180e47ad3c7","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        else:"},{"line_number":685,"context_line":"            return False"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"    @retry(stop_max_attempt_number\u003dcfg.CONF.check_interface_retry_limit,"},{"line_number":688,"context_line":"           wait_fixed\u003d500,"},{"line_number":689,"context_line":"           retry_on_result\u003dclient_plugin.retry_if_result_is_false)"},{"line_number":690,"context_line":"    def check_interface_detach(self, server_id, port_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_47b52f2f","line":687,"range":{"start_line":687,"start_character":11,"end_line":687,"end_character":71},"updated":"2016-03-09 15:58:33.000000000","message":"AFAIK, if this number is 0, this function will be called once, if this value is 1, this function will be called once *too*. That means that we actually don\u0027t do any retry, because retries count is the number of function calls after the first unsuccessful call, i.e. if we set check_interface_retry_limit \u003d 1, we expect that function will be called twice: the first call and the second call is `retry call` (if needed).\nIt is better to write stop_max_attempt_number\u003dcfg.CONF.check_interface_retry_limit + 1 so we actually call this method expected number of tries.","commit_id":"d0779c845f3ba783a9a46492fbe251a9579937e1"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b808c1f15ade461baf15d94f90eba8fc04c4b283","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        else:"},{"line_number":685,"context_line":"            return False"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"    @retry(stop_max_attempt_number\u003dcfg.CONF.check_interface_retry_limit,"},{"line_number":688,"context_line":"           wait_fixed\u003d500,"},{"line_number":689,"context_line":"           retry_on_result\u003dclient_plugin.retry_if_result_is_false)"},{"line_number":690,"context_line":"    def check_interface_detach(self, server_id, port_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_cd377afd","line":687,"range":{"start_line":687,"start_character":11,"end_line":687,"end_character":71},"in_reply_to":"5aef4532_47b52f2f","updated":"2016-03-10 03:13:40.000000000","message":"I think changing the conf key to max_interface_check_attempts would be better and less confusing.","commit_id":"d0779c845f3ba783a9a46492fbe251a9579937e1"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"cad261d37a63a618880685987b109180e47ad3c7","unresolved":false,"context_lines":[{"line_number":686,"context_line":""},{"line_number":687,"context_line":"    @retry(stop_max_attempt_number\u003dcfg.CONF.check_interface_retry_limit,"},{"line_number":688,"context_line":"           wait_fixed\u003d500,"},{"line_number":689,"context_line":"           retry_on_result\u003dclient_plugin.retry_if_result_is_false)"},{"line_number":690,"context_line":"    def check_interface_detach(self, server_id, port_id):"},{"line_number":691,"context_line":"        server \u003d self.fetch_server(server_id)"},{"line_number":692,"context_line":"        if server:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_9dbe6863","line":689,"range":{"start_line":689,"start_character":11,"end_line":689,"end_character":65},"updated":"2016-03-09 15:58:33.000000000","message":"Will it be more clearer to pass lambda r: r is False here?","commit_id":"d0779c845f3ba783a9a46492fbe251a9579937e1"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"cad261d37a63a618880685987b109180e47ad3c7","unresolved":false,"context_lines":[{"line_number":696,"context_line":"                    return False"},{"line_number":697,"context_line":"        return True"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    @retry(stop_max_attempt_number\u003dcfg.CONF.check_interface_retry_limit,"},{"line_number":700,"context_line":"           wait_fixed\u003d500,"},{"line_number":701,"context_line":"           retry_on_result\u003dclient_plugin.retry_if_result_is_false)"},{"line_number":702,"context_line":"    def check_interface_attach(self, server_id, port_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_1db37899","line":699,"range":{"start_line":699,"start_character":11,"end_line":699,"end_character":71},"updated":"2016-03-09 15:58:33.000000000","message":"ditto","commit_id":"d0779c845f3ba783a9a46492fbe251a9579937e1"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"cad261d37a63a618880685987b109180e47ad3c7","unresolved":false,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    @retry(stop_max_attempt_number\u003dcfg.CONF.check_interface_retry_limit,"},{"line_number":700,"context_line":"           wait_fixed\u003d500,"},{"line_number":701,"context_line":"           retry_on_result\u003dclient_plugin.retry_if_result_is_false)"},{"line_number":702,"context_line":"    def check_interface_attach(self, server_id, port_id):"},{"line_number":703,"context_line":"        server \u003d self.fetch_server(server_id)"},{"line_number":704,"context_line":"        if server:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_5da98023","line":701,"range":{"start_line":701,"start_character":11,"end_line":701,"end_character":65},"updated":"2016-03-09 15:58:33.000000000","message":"ditto","commit_id":"d0779c845f3ba783a9a46492fbe251a9579937e1"}],"heat/engine/resources/openstack/nova/server_network_mixin.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"93a00b568af516c397a73c83bfa0381751e67fd8","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        for port_type, port in port_data:"},{"line_number":385,"context_line":"            self.client_plugin().interface_detach(self.resource_id,"},{"line_number":386,"context_line":"                                                  port[\u0027id\u0027])"},{"line_number":387,"context_line":"            while True:"},{"line_number":388,"context_line":"                if self.client_plugin().check_interface_detach("},{"line_number":389,"context_line":"                        self.resource_id, port[\u0027id\u0027]):"},{"line_number":390,"context_line":"                    break"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def restore_ports_after_rollback(self, convergence):"},{"line_number":393,"context_line":"        if not self.is_using_neutron():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_4deb58dc","line":390,"range":{"start_line":387,"start_character":0,"end_line":390,"end_character":25},"updated":"2016-02-02 06:29:45.000000000","message":"I think this can get into an infinite loop if there is an issue in detaching the interface. This seems like a hack to get around the time taken by nova to detach the interface","commit_id":"9890e0723fefdb5aef35897a2bc306cc6ff22cf6"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"00b03d3d91824dd5140cee70aa252cb0118b31aa","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        for port_type, port in port_data:"},{"line_number":385,"context_line":"            self.client_plugin().interface_detach(self.resource_id,"},{"line_number":386,"context_line":"                                                  port[\u0027id\u0027])"},{"line_number":387,"context_line":"            while True:"},{"line_number":388,"context_line":"                if self.client_plugin().check_interface_detach("},{"line_number":389,"context_line":"                        self.resource_id, port[\u0027id\u0027]):"},{"line_number":390,"context_line":"                    break"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def restore_ports_after_rollback(self, convergence):"},{"line_number":393,"context_line":"        if not self.is_using_neutron():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_a629c639","line":390,"range":{"start_line":387,"start_character":0,"end_line":390,"end_character":25},"in_reply_to":"7a5de9d1_4deb58dc","updated":"2016-02-02 09:06:25.000000000","message":"Perhaps, so what\u0027s your suggestion? I can\u0027t get out another way based current architecture. See other checks, e.g we did for check_detach_volume_complete(), it can get into an infinite loop.\nThis check is needed to make sure the new server can attach the same ports.","commit_id":"9890e0723fefdb5aef35897a2bc306cc6ff22cf6"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f78e3afd8a65fbb6be9d48c65dcebd756da421e8","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        for port_type, port in port_data:"},{"line_number":385,"context_line":"            self.client_plugin().interface_detach(self.resource_id,"},{"line_number":386,"context_line":"                                                  port[\u0027id\u0027])"},{"line_number":387,"context_line":"            while True:"},{"line_number":388,"context_line":"                if self.client_plugin().check_interface_detach("},{"line_number":389,"context_line":"                        self.resource_id, port[\u0027id\u0027]):"},{"line_number":390,"context_line":"                    break"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def restore_ports_after_rollback(self, convergence):"},{"line_number":393,"context_line":"        if not self.is_using_neutron():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_29420569","line":390,"range":{"start_line":387,"start_character":0,"end_line":390,"end_character":25},"in_reply_to":"7a5de9d1_a629c639","updated":"2016-02-05 03:59:46.000000000","message":"IMO, this is not the same as \u0027check_detach_volume_complete\u0027 which is called from check_delete_complete and is scheduled. Where as this would block the thread for ever(if there is an issue). I don\u0027t think this is a good solution. We\u0027ve to find some other way to do it. Unfortunately I don\u0027t have anything ready to suggest atm. I can remove my -1, if others are ok this solution.","commit_id":"9890e0723fefdb5aef35897a2bc306cc6ff22cf6"}]}
