)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"8adbc682888be93fefa3a51e35c94415c778c0eb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"without resource_id, so this situation is legal for stack preview"},{"line_number":15,"context_line":"and we shouldn\u0027t fail. Note, that we can reproduce this behaviour"},{"line_number":16,"context_line":"only with resources with hidden parameters and overrided  get_resource_id"},{"line_number":17,"context_line":"method, that returns None if resoruce creation has not been started yet."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia1097940db983721c8b5116db7ee0a2c4c45339d"},{"line_number":20,"context_line":"Closes-Bug: #1548802"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_41bd2401","line":17,"range":{"start_line":17,"start_character":29,"end_line":17,"end_character":37},"updated":"2016-03-09 14:02:06.000000000","message":"s/resoruce/resource","commit_id":"1c7d6f098c80c6b017ee2ee938d10a2a1a6e86ff"}],"heat/engine/resources/openstack/heat/resource_group.py":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"7b7ee278a26489d5bcc1d64effbc6cf0e4e2afa7","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    def handle_adopt(self, resource_data):"},{"line_number":618,"context_line":"        names \u003d self._resource_names()"},{"line_number":619,"context_line":"        if names:"},{"line_number":620,"context_line":"            return self.create_with_template(self._assemble_nested(names),"},{"line_number":621,"context_line":"                                             {},"},{"line_number":622,"context_line":"                                             adopt_data\u003dresource_data)"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_1a9a24b9","line":620,"range":{"start_line":620,"start_character":24,"end_line":620,"end_character":44},"updated":"2016-03-01 07:25:20.000000000","message":"looks like child_template also is used in this method same as in handle_create. is it expected?","commit_id":"7ba690c9bf9d360adfa97326be4944c2917deaa5"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"9be78e9281b15caa19268551810653d43d931c8a","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    def handle_adopt(self, resource_data):"},{"line_number":618,"context_line":"        names \u003d self._resource_names()"},{"line_number":619,"context_line":"        if names:"},{"line_number":620,"context_line":"            return self.create_with_template(self._assemble_nested(names),"},{"line_number":621,"context_line":"                                             {},"},{"line_number":622,"context_line":"                                             adopt_data\u003dresource_data)"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_cdd29534","line":620,"range":{"start_line":620,"start_character":24,"end_line":620,"end_character":44},"in_reply_to":"7af24918_5e69158b","updated":"2016-03-01 12:01:07.000000000","message":"child_template method called by _stack_kwargs , which is used in create_with_template. Please take a look on parent class, so as result we call new (with include_all\u003dTrue) child_template on create and on adopt","commit_id":"7ba690c9bf9d360adfa97326be4944c2917deaa5"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"daeaeb2790707f8fe8d8608faf518c9f0b728cfd","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    def handle_adopt(self, resource_data):"},{"line_number":618,"context_line":"        names \u003d self._resource_names()"},{"line_number":619,"context_line":"        if names:"},{"line_number":620,"context_line":"            return self.create_with_template(self._assemble_nested(names),"},{"line_number":621,"context_line":"                                             {},"},{"line_number":622,"context_line":"                                             adopt_data\u003dresource_data)"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_f8a911e1","line":620,"range":{"start_line":620,"start_character":24,"end_line":620,"end_character":44},"in_reply_to":"7af24918_cdd29534","updated":"2016-03-01 12:12:25.000000000","message":"We are passing child_template to create_with_template as argument, https://github.com/openstack/heat/blob/6ac4526e66427d398ad32bb5e757431c8f5b147b/heat/engine/resources/stack_resource.py#L264 and call _stack_kwargs with this argument i.e. we aren\u0027t using self.child_template().","commit_id":"7ba690c9bf9d360adfa97326be4944c2917deaa5"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"8cb2011195941e6128c327dfed3462d855c2a459","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    def handle_adopt(self, resource_data):"},{"line_number":618,"context_line":"        names \u003d self._resource_names()"},{"line_number":619,"context_line":"        if names:"},{"line_number":620,"context_line":"            return self.create_with_template(self._assemble_nested(names),"},{"line_number":621,"context_line":"                                             {},"},{"line_number":622,"context_line":"                                             adopt_data\u003dresource_data)"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_5e69158b","line":620,"range":{"start_line":620,"start_character":24,"end_line":620,"end_character":44},"in_reply_to":"9aed3d3a_1a9a24b9","updated":"2016-03-01 10:43:15.000000000","message":"I don\u0027t see any usage of child_template in this file. If you meant that we call _assemble_nested without include_all\u003dTrue in other places in this file, then this commit changes only behaviour of stack preview, not other actions.","commit_id":"7ba690c9bf9d360adfa97326be4944c2917deaa5"}],"heat/engine/translation.py":[{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"7a2748db74e15a978ade900b6852a1210786bcf6","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                    err_msg \u003d encodeutils.exception_to_unicode(ex)"},{"line_number":165,"context_line":"                    raise AttributeError("},{"line_number":166,"context_line":"                        _(\u0027Can not resolve parameter \u0027"},{"line_number":167,"context_line":"                          \u0027due to such error: %s\u0027) % err_msg)"},{"line_number":168,"context_line":"            elif isinstance(param, list):"},{"line_number":169,"context_line":"                return [resolve_param(param_item) for param_item in param]"},{"line_number":170,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_6c098c95","line":167,"updated":"2016-03-08 04:48:38.000000000","message":"please re-phrase it by stripping off \u0027such error\u0027","commit_id":"fd0320c728c18d0cdabb35c4c42c24c6337a8341"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"9e4aef97f683b4833ca07c54b23de50d99f2cb21","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                    err_msg \u003d encodeutils.exception_to_unicode(ex)"},{"line_number":165,"context_line":"                    raise AttributeError("},{"line_number":166,"context_line":"                        _(\u0027Can not resolve parameter \u0027"},{"line_number":167,"context_line":"                          \u0027due to such error: %s\u0027) % err_msg)"},{"line_number":168,"context_line":"            elif isinstance(param, list):"},{"line_number":169,"context_line":"                return [resolve_param(param_item) for param_item in param]"},{"line_number":170,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_cc31a90d","line":167,"in_reply_to":"5aef4532_6c098c95","updated":"2016-03-08 14:40:47.000000000","message":"Done","commit_id":"fd0320c728c18d0cdabb35c4c42c24c6337a8341"}],"heat/tests/test_translation_rule.py":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"bde7f4189c9d06bce4f0e1ebb51534982d9ab6b8","unresolved":false,"context_lines":[{"line_number":834,"context_line":""},{"line_number":835,"context_line":"        # ensure that translation rule was not applied"},{"line_number":836,"context_line":"        self.assertEqual({\u0027source\u0027: param, \u0027destination\u0027: \u0027\u0027},"},{"line_number":837,"context_line":"                         data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_6a4c759e","line":837,"range":{"start_line":837,"start_character":25,"end_line":837,"end_character":29},"updated":"2016-03-09 14:36:16.000000000","message":"Here we should assert equal to props.data?","commit_id":"1c7d6f098c80c6b017ee2ee938d10a2a1a6e86ff"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"eb0f39312f4053e2aee5db6fe3663988a8272e5b","unresolved":false,"context_lines":[{"line_number":834,"context_line":""},{"line_number":835,"context_line":"        # ensure that translation rule was not applied"},{"line_number":836,"context_line":"        self.assertEqual({\u0027source\u0027: param, \u0027destination\u0027: \u0027\u0027},"},{"line_number":837,"context_line":"                         data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_b5aee27e","line":837,"range":{"start_line":837,"start_character":25,"end_line":837,"end_character":29},"in_reply_to":"5aef4532_6a4c759e","updated":"2016-03-09 14:44:34.000000000","message":"props.data and data are referenced to the same place","commit_id":"1c7d6f098c80c6b017ee2ee938d10a2a1a6e86ff"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"faec3f38bab990024ab9c08f9c9f21d383999493","unresolved":false,"context_lines":[{"line_number":834,"context_line":""},{"line_number":835,"context_line":"        # ensure that translation rule was not applied"},{"line_number":836,"context_line":"        self.assertEqual({\u0027source\u0027: param, \u0027destination\u0027: \u0027\u0027},"},{"line_number":837,"context_line":"                         data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_5df18094","line":837,"range":{"start_line":837,"start_character":25,"end_line":837,"end_character":29},"in_reply_to":"5aef4532_7014689f","updated":"2016-03-09 15:45:39.000000000","message":"props \u003d properties.Properties(schema, data, resolver\u003dfunction.resolve)\nI suppose that data defined in L823 is the same as props.data, because we are passing it to properties constructor. Am i wrong?","commit_id":"1c7d6f098c80c6b017ee2ee938d10a2a1a6e86ff"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"9340b92058b309a7629ba1b80a89da28110be5d4","unresolved":false,"context_lines":[{"line_number":834,"context_line":""},{"line_number":835,"context_line":"        # ensure that translation rule was not applied"},{"line_number":836,"context_line":"        self.assertEqual({\u0027source\u0027: param, \u0027destination\u0027: \u0027\u0027},"},{"line_number":837,"context_line":"                         data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_7014689f","line":837,"range":{"start_line":837,"start_character":25,"end_line":837,"end_character":29},"in_reply_to":"5aef4532_b5aee27e","updated":"2016-03-09 15:33:41.000000000","message":"I\u0027m not prefer to use data, due we defined in line823 with {\u0027source\u0027: param, \u0027destination\u0027: \u0027\u0027}. Looks a little odd.","commit_id":"1c7d6f098c80c6b017ee2ee938d10a2a1a6e86ff"}],"heat_integrationtests/functional/test_preview.py":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"1fd9e59688106a12f01cdf4213770facabd39699","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        self.assertEqual(\u0027abc\u0027, res[\u0027properties\u0027][\u0027value\u0027])"},{"line_number":188,"context_line":"        self.assertEqual([], res[\u0027required_by\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_res_group_with_nested_template(self):"},{"line_number":191,"context_line":"        main_template \u003d \u0027\u0027\u0027"},{"line_number":192,"context_line":"heat_template_version: 2015-04-30"},{"line_number":193,"context_line":"resources:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_64194ed7","line":190,"range":{"start_line":190,"start_character":2,"end_line":190,"end_character":50},"updated":"2016-03-09 14:05:47.000000000","message":"In the original bug you mentioned issues with creation, so I think we need to add scenario, which you mentioned in bug with creation and make sure, that it now works correct","commit_id":"1c7d6f098c80c6b017ee2ee938d10a2a1a6e86ff"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"3f38ab047290df43d61f8bacbe988fc413b80296","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        self.assertEqual(\u0027abc\u0027, res[\u0027properties\u0027][\u0027value\u0027])"},{"line_number":188,"context_line":"        self.assertEqual([], res[\u0027required_by\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_res_group_with_nested_template(self):"},{"line_number":191,"context_line":"        main_template \u003d \u0027\u0027\u0027"},{"line_number":192,"context_line":"heat_template_version: 2015-04-30"},{"line_number":193,"context_line":"resources:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_1d753863","line":190,"range":{"start_line":190,"start_character":2,"end_line":190,"end_character":50},"in_reply_to":"5aef4532_5a750630","updated":"2016-03-09 15:42:40.000000000","message":"Yeah, i need to change description. Now it fails only on stack-preview. ( it failed on create before we revert my commit https://review.openstack.org/#/c/283297/)","commit_id":"1c7d6f098c80c6b017ee2ee938d10a2a1a6e86ff"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"bde7f4189c9d06bce4f0e1ebb51534982d9ab6b8","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        self.assertEqual(\u0027abc\u0027, res[\u0027properties\u0027][\u0027value\u0027])"},{"line_number":188,"context_line":"        self.assertEqual([], res[\u0027required_by\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_res_group_with_nested_template(self):"},{"line_number":191,"context_line":"        main_template \u003d \u0027\u0027\u0027"},{"line_number":192,"context_line":"heat_template_version: 2015-04-30"},{"line_number":193,"context_line":"resources:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_754f3a6b","line":190,"range":{"start_line":190,"start_character":2,"end_line":190,"end_character":50},"in_reply_to":"5aef4532_64194ed7","updated":"2016-03-09 14:36:16.000000000","message":"Agree.","commit_id":"1c7d6f098c80c6b017ee2ee938d10a2a1a6e86ff"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"eb0f39312f4053e2aee5db6fe3663988a8272e5b","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        self.assertEqual(\u0027abc\u0027, res[\u0027properties\u0027][\u0027value\u0027])"},{"line_number":188,"context_line":"        self.assertEqual([], res[\u0027required_by\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_res_group_with_nested_template(self):"},{"line_number":191,"context_line":"        main_template \u003d \u0027\u0027\u0027"},{"line_number":192,"context_line":"heat_template_version: 2015-04-30"},{"line_number":193,"context_line":"resources:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_f5d34a02","line":190,"range":{"start_line":190,"start_character":2,"end_line":190,"end_character":50},"in_reply_to":"5aef4532_754f3a6b","updated":"2016-03-09 14:44:34.000000000","message":"No, we don\u0027t have such scenario now because we don\u0027t make stack preview before create.","commit_id":"1c7d6f098c80c6b017ee2ee938d10a2a1a6e86ff"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"9340b92058b309a7629ba1b80a89da28110be5d4","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        self.assertEqual(\u0027abc\u0027, res[\u0027properties\u0027][\u0027value\u0027])"},{"line_number":188,"context_line":"        self.assertEqual([], res[\u0027required_by\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_res_group_with_nested_template(self):"},{"line_number":191,"context_line":"        main_template \u003d \u0027\u0027\u0027"},{"line_number":192,"context_line":"heat_template_version: 2015-04-30"},{"line_number":193,"context_line":"resources:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_5a750630","line":190,"range":{"start_line":190,"start_character":2,"end_line":190,"end_character":50},"in_reply_to":"5aef4532_f5d34a02","updated":"2016-03-09 15:33:41.000000000","message":"Now I\u0027m confused, your bug description said:\n\"heat stack-create abc -f outer.yaml\nHeat responses with ERROR: The Parameter (fixed_network_id) was not provided.\"\n\nWhy can\u0027t we test for stack creation case? Can you explain more clear?","commit_id":"1c7d6f098c80c6b017ee2ee938d10a2a1a6e86ff"}]}
