)]}'
{"heat/engine/clients/os/heat_plugin.py":[{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"a9a9ea20c06fda18b75d203627456e99bc24c1b4","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def get_watch_server_url(self):"},{"line_number":101,"context_line":"        cfn_url \u003d self.get_heat_cfn_url()"},{"line_number":102,"context_line":"        return cfn_url.replace(\u00278000\u0027, \u00278003\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_2fb26a94","line":102,"range":{"start_line":102,"start_character":30,"end_line":102,"end_character":46},"updated":"2016-03-03 12:50:16.000000000","message":"I don\u0027t like this constants here. We can run heat_api_cfn on different port. Can we use value from our heat.conf?","commit_id":"aa78dfb2b04a2f86aa106a3cac4529bb6eb924ea"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"d261429e1e0f732fa8bc47286c8a717adbefa7ce","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def get_watch_server_url(self):"},{"line_number":101,"context_line":"        cfn_url \u003d self.get_heat_cfn_url()"},{"line_number":102,"context_line":"        return cfn_url.replace(\u00278000\u0027, \u00278003\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_5eecc6f2","line":102,"range":{"start_line":102,"start_character":30,"end_line":102,"end_character":46},"in_reply_to":"7af24918_2fb26a94","updated":"2016-03-03 13:54:56.000000000","message":"Done","commit_id":"aa78dfb2b04a2f86aa106a3cac4529bb6eb924ea"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"841951a3a6f50f9a500241efd0c59791339bc4da","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        cfn_url \u003d self.get_heat_cfn_url()"},{"line_number":102,"context_line":"        url_parts \u003d cfn_url.split(\u0027:\u0027)"},{"line_number":103,"context_line":"        port_and_version \u003d url_parts[-1].split(\u0027/\u0027)"},{"line_number":104,"context_line":"        port_and_version[0] \u003d \u00278003\u0027"},{"line_number":105,"context_line":"        url_parts[-1] \u003d \u0027/\u0027.join(port_and_version)"},{"line_number":106,"context_line":"        return \u0027:\u0027.join(url_parts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_2626b768","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":35},"updated":"2016-03-07 10:09:06.000000000","message":"You only partially addressed the previous comment about hard-coded ports - this should use the bind_port from the heat_api_cloudwatch section in heat.conf.","commit_id":"1d0b14831a5c00ca3fd7f4d7892b0c5d7f5b0b82"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"4c73f75f27078c5a256da796269b9595dbae0150","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        cfn_url \u003d self.get_heat_cfn_url()"},{"line_number":102,"context_line":"        url_parts \u003d cfn_url.split(\u0027:\u0027)"},{"line_number":103,"context_line":"        port_and_version \u003d url_parts[-1].split(\u0027/\u0027)"},{"line_number":104,"context_line":"        port_and_version[0] \u003d \u00278003\u0027"},{"line_number":105,"context_line":"        url_parts[-1] \u003d \u0027/\u0027.join(port_and_version)"},{"line_number":106,"context_line":"        return \u0027:\u0027.join(url_parts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_0d6a41ee","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":35},"in_reply_to":"5aef4532_2626b768","updated":"2016-03-09 10:24:29.000000000","message":"Aha. Now I got it. will fix. thx","commit_id":"1d0b14831a5c00ca3fd7f4d7892b0c5d7f5b0b82"}],"heat/engine/clients/os/nova.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"5854cd6dfdd70d3f709f4361268f338981299c01","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                                \u0027cfn-init-data\u0027, \u0027x-cfninitdata\u0027))"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        watch_url \u003d cfg.CONF.heat_watch_server_url"},{"line_number":376,"context_line":"        if watch_url is None:"},{"line_number":377,"context_line":"            watch_url \u003d self.get_heat_cfn_url()"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        attachments.append((watch_url, \u0027cfn-watch-server\u0027, \u0027x-cfninitdata\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_241c6b69","line":376,"updated":"2016-03-03 02:02:23.000000000","message":"heat_watch_server_url is default \"\", maybe better that uses \"if not watch_url\"?","commit_id":"b6f4d7b4bcaba12c1231955f752521084007a135"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8b36eaedd44405f5445592b6f6c7b81c11b50014","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                                \u0027cfn-init-data\u0027, \u0027x-cfninitdata\u0027))"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        watch_url \u003d cfg.CONF.heat_watch_server_url"},{"line_number":376,"context_line":"        if watch_url is None:"},{"line_number":377,"context_line":"            watch_url \u003d self.get_heat_cfn_url()"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        attachments.append((watch_url, \u0027cfn-watch-server\u0027, \u0027x-cfninitdata\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_9f102c5b","line":376,"in_reply_to":"7af24918_241c6b69","updated":"2016-03-03 02:55:22.000000000","message":"Agree.","commit_id":"b6f4d7b4bcaba12c1231955f752521084007a135"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"4318644a8af4d77141ec670ddb9d1888d4f6c193","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                                \u0027cfn-init-data\u0027, \u0027x-cfninitdata\u0027))"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        watch_url \u003d cfg.CONF.heat_watch_server_url"},{"line_number":376,"context_line":"        if watch_url is None:"},{"line_number":377,"context_line":"            watch_url \u003d self.get_heat_cfn_url()"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        attachments.append((watch_url, \u0027cfn-watch-server\u0027, \u0027x-cfninitdata\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_d98126c5","line":376,"in_reply_to":"7af24918_9f102c5b","updated":"2016-03-03 08:48:07.000000000","message":"Done","commit_id":"b6f4d7b4bcaba12c1231955f752521084007a135"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8b36eaedd44405f5445592b6f6c7b81c11b50014","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        watch_url \u003d cfg.CONF.heat_watch_server_url"},{"line_number":376,"context_line":"        if watch_url is None:"},{"line_number":377,"context_line":"            watch_url \u003d self.get_heat_cfn_url()"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        attachments.append((watch_url, \u0027cfn-watch-server\u0027, \u0027x-cfninitdata\u0027))"},{"line_number":380,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_3f38f8ee","line":377,"range":{"start_line":377,"start_character":23,"end_line":377,"end_character":47},"updated":"2016-03-03 02:55:22.000000000","message":"The method is provided by heat client plugin, here you should get heat client plugin first, then to call the method?","commit_id":"b6f4d7b4bcaba12c1231955f752521084007a135"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"4318644a8af4d77141ec670ddb9d1888d4f6c193","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        watch_url \u003d cfg.CONF.heat_watch_server_url"},{"line_number":376,"context_line":"        if watch_url is None:"},{"line_number":377,"context_line":"            watch_url \u003d self.get_heat_cfn_url()"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        attachments.append((watch_url, \u0027cfn-watch-server\u0027, \u0027x-cfninitdata\u0027))"},{"line_number":380,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_f9f7c288","line":377,"range":{"start_line":377,"start_character":23,"end_line":377,"end_character":47},"in_reply_to":"7af24918_3f38f8ee","updated":"2016-03-03 08:48:07.000000000","message":"Done","commit_id":"b6f4d7b4bcaba12c1231955f752521084007a135"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"ee16042948e9368373927a0a021cfc0eaaff276b","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        heat_client_plugin \u003d self.context.clients.client_plugin(\u0027heat\u0027)"},{"line_number":376,"context_line":"        watch_url \u003d cfg.CONF.heat_watch_server_url"},{"line_number":377,"context_line":"        if not watch_url:"},{"line_number":378,"context_line":"            watch_url \u003d heat_client_plugin.get_heat_cfn_url()"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        attachments.append((watch_url, \u0027cfn-watch-server\u0027, \u0027x-cfninitdata\u0027))"},{"line_number":381,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_ad47b075","line":378,"range":{"start_line":378,"start_character":43,"end_line":378,"end_character":59},"updated":"2016-03-03 09:49:26.000000000","message":"AFAICS this won\u0027t work - the watch_url needs to point to the heat-api-cloudwatch service running on port 8003, and this sets the CFN API endpoint on port 8000?\n\nFalling back to assuming the cw and cfn API\u0027s are on the same host is probably OK, but we need to fix the ports if we\u0027re going to do this?","commit_id":"5b3d36a0f7589b5e9e7cc3f4643dbb505d6e74ff"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"26460ab4e9fa425e558f5bd46f3a918204c3f586","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        heat_client_plugin \u003d self.context.clients.client_plugin(\u0027heat\u0027)"},{"line_number":376,"context_line":"        watch_url \u003d cfg.CONF.heat_watch_server_url"},{"line_number":377,"context_line":"        if not watch_url:"},{"line_number":378,"context_line":"            watch_url \u003d heat_client_plugin.get_heat_cfn_url()"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        attachments.append((watch_url, \u0027cfn-watch-server\u0027, \u0027x-cfninitdata\u0027))"},{"line_number":381,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_88be2263","line":378,"range":{"start_line":378,"start_character":43,"end_line":378,"end_character":59},"in_reply_to":"7af24918_ad47b075","updated":"2016-03-03 11:12:36.000000000","message":"Yeah. you are right. I will add replace for port. thank you","commit_id":"5b3d36a0f7589b5e9e7cc3f4643dbb505d6e74ff"}]}
