)]}'
{"contrib/rackspace/rackspace/tests/test_rackspace_cloud_server.py":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"5c348eade42329bdd40d683f07dfa5d150128c1d","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        self.fc.servers.create \u003d mock_servers_create"},{"line_number":430,"context_line":"        self.patchobject(self.fc.servers, \u0027get\u0027,"},{"line_number":431,"context_line":"                         return_value\u003dreturn_server)"},{"line_number":432,"context_line":"        image_id \u003d mock.ANY"},{"line_number":433,"context_line":"        scheduler.TaskRunner(server.create)()"},{"line_number":434,"context_line":"        mock_servers_create.assert_called_with("},{"line_number":435,"context_line":"            image\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_29d72a4c","line":432,"range":{"start_line":432,"start_character":7,"end_line":432,"end_character":27},"updated":"2016-03-15 10:36:45.000000000","message":"Not blocker, we can use mock.ANY in line435 directly.","commit_id":"b1381ca6d95e57e0937e3c1d63d4b0dc441a92fa"}],"heat/tests/aws/test_instance.py":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"5c348eade42329bdd40d683f07dfa5d150128c1d","unresolved":false,"context_lines":[{"line_number":785,"context_line":"        self.patchobject(glance.GlanceClientPlugin, \u0027find_image_by_name_or_id\u0027,"},{"line_number":786,"context_line":"                         return_value\u003d1)"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        # self._stub_glance_for_update()"},{"line_number":789,"context_line":"        update_template \u003d copy.deepcopy(instance.t)"},{"line_number":790,"context_line":"        update_template[\u0027Properties\u0027][\u0027InstanceType\u0027] \u003d \u0027m1.small\u0027"},{"line_number":791,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_a91fba06","line":788,"range":{"start_line":788,"start_character":8,"end_line":788,"end_character":40},"updated":"2016-03-15 10:36:45.000000000","message":"Delete this unused line.","commit_id":"b1381ca6d95e57e0937e3c1d63d4b0dc441a92fa"}],"heat/tests/openstack/nova/test_server.py":[{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"d0c4385570919cd3bd4bdd3f04c797dd86a01ee0","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class ServersTest(common.HeatTestCase):"},{"line_number":145,"context_line":"    def setUp(self):"},{"line_number":146,"context_line":"        super(ServersTest, self).setUp()"},{"line_number":147,"context_line":"        self.fc \u003d fakes_nova.FakeClient()"},{"line_number":148,"context_line":"        self.limits \u003d self.m.CreateMockAnything()"},{"line_number":149,"context_line":"        self.limits.absolute \u003d self._limits_absolute()"},{"line_number":150,"context_line":"        self.mock_flavor \u003d mock.Mock(ram\u003d4, disk\u003d4)"},{"line_number":151,"context_line":"        self.mock_image \u003d mock.Mock(min_ram\u003d1, min_disk\u003d1, status\u003d\u0027active\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _limits_absolute(self):"},{"line_number":154,"context_line":"        max_personality \u003d self.m.CreateMockAnything()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_6b935fa4","line":151,"range":{"start_line":145,"start_character":0,"end_line":151,"end_character":75},"updated":"2016-03-07 12:40:11.000000000","message":"You can add\nself.patchobject(nova.NovaClientPlugin, \u0027find_flavor_by_name_or_id\u0027, return_value\u003d1)\nself.patchobject(glance.GlanceClientPlugin, \u0027find_image_by_name_or_id\u0027, return_value\u003d1)\nto this method and avoid usage of many mock decorators below.","commit_id":"328d748277f0f29a6319e203e9d9b6964faadd37"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"ea4125a9df3f6a3be08bb3be220c390202fffbed","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class ServersTest(common.HeatTestCase):"},{"line_number":145,"context_line":"    def setUp(self):"},{"line_number":146,"context_line":"        super(ServersTest, self).setUp()"},{"line_number":147,"context_line":"        self.fc \u003d fakes_nova.FakeClient()"},{"line_number":148,"context_line":"        self.limits \u003d self.m.CreateMockAnything()"},{"line_number":149,"context_line":"        self.limits.absolute \u003d self._limits_absolute()"},{"line_number":150,"context_line":"        self.mock_flavor \u003d mock.Mock(ram\u003d4, disk\u003d4)"},{"line_number":151,"context_line":"        self.mock_image \u003d mock.Mock(min_ram\u003d1, min_disk\u003d1, status\u003d\u0027active\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _limits_absolute(self):"},{"line_number":154,"context_line":"        max_personality \u003d self.m.CreateMockAnything()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_d19fc65d","line":151,"range":{"start_line":145,"start_character":0,"end_line":151,"end_character":75},"in_reply_to":"5aef4532_0ebaa9e1","updated":"2016-03-07 13:21:51.000000000","message":"I can\u0027t find any decorators in L1715. It seems to me that repetition of @mock.patch.object for such many methods isn\u0027t good thing. You can just move it to setUp and remove all mock *decorators*. The code inside methods don\u0027t need to be changed.","commit_id":"328d748277f0f29a6319e203e9d9b6964faadd37"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e499a7e5867e791faece3b5a351ac5f896c6202f","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class ServersTest(common.HeatTestCase):"},{"line_number":145,"context_line":"    def setUp(self):"},{"line_number":146,"context_line":"        super(ServersTest, self).setUp()"},{"line_number":147,"context_line":"        self.fc \u003d fakes_nova.FakeClient()"},{"line_number":148,"context_line":"        self.limits \u003d self.m.CreateMockAnything()"},{"line_number":149,"context_line":"        self.limits.absolute \u003d self._limits_absolute()"},{"line_number":150,"context_line":"        self.mock_flavor \u003d mock.Mock(ram\u003d4, disk\u003d4)"},{"line_number":151,"context_line":"        self.mock_image \u003d mock.Mock(min_ram\u003d1, min_disk\u003d1, status\u003d\u0027active\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _limits_absolute(self):"},{"line_number":154,"context_line":"        max_personality \u003d self.m.CreateMockAnything()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_0ebaa9e1","line":151,"range":{"start_line":145,"start_character":0,"end_line":151,"end_character":75},"in_reply_to":"5aef4532_6b935fa4","updated":"2016-03-07 13:07:14.000000000","message":"I don\u0027t think that\u0027s the case for all tests. check L1715 and the tests that do create and update where we need all kinds of side_effects.\n\nI also think this can be further improved later when we split them into multiple test modules.","commit_id":"328d748277f0f29a6319e203e9d9b6964faadd37"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"ef3c048728f4a5e46c6bc24fc6ae521e9e049e61","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class ServersTest(common.HeatTestCase):"},{"line_number":145,"context_line":"    def setUp(self):"},{"line_number":146,"context_line":"        super(ServersTest, self).setUp()"},{"line_number":147,"context_line":"        self.fc \u003d fakes_nova.FakeClient()"},{"line_number":148,"context_line":"        self.limits \u003d self.m.CreateMockAnything()"},{"line_number":149,"context_line":"        self.limits.absolute \u003d self._limits_absolute()"},{"line_number":150,"context_line":"        self.mock_flavor \u003d mock.Mock(ram\u003d4, disk\u003d4)"},{"line_number":151,"context_line":"        self.mock_image \u003d mock.Mock(min_ram\u003d1, min_disk\u003d1, status\u003d\u0027active\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _limits_absolute(self):"},{"line_number":154,"context_line":"        max_personality \u003d self.m.CreateMockAnything()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_a35e2343","line":151,"range":{"start_line":145,"start_character":0,"end_line":151,"end_character":75},"in_reply_to":"5aef4532_c3740fff","updated":"2016-03-07 16:23:41.000000000","message":"Because we need to add decorators to *many* methods instead of mock in one place without any hurt.","commit_id":"328d748277f0f29a6319e203e9d9b6964faadd37"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6dd56b675d12e8bdead2d8ea79f65d7e1a9d2f81","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class ServersTest(common.HeatTestCase):"},{"line_number":145,"context_line":"    def setUp(self):"},{"line_number":146,"context_line":"        super(ServersTest, self).setUp()"},{"line_number":147,"context_line":"        self.fc \u003d fakes_nova.FakeClient()"},{"line_number":148,"context_line":"        self.limits \u003d self.m.CreateMockAnything()"},{"line_number":149,"context_line":"        self.limits.absolute \u003d self._limits_absolute()"},{"line_number":150,"context_line":"        self.mock_flavor \u003d mock.Mock(ram\u003d4, disk\u003d4)"},{"line_number":151,"context_line":"        self.mock_image \u003d mock.Mock(min_ram\u003d1, min_disk\u003d1, status\u003d\u0027active\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _limits_absolute(self):"},{"line_number":154,"context_line":"        max_personality \u003d self.m.CreateMockAnything()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_c3740fff","line":151,"range":{"start_line":145,"start_character":0,"end_line":151,"end_character":75},"in_reply_to":"5aef4532_d19fc65d","updated":"2016-03-07 16:20:40.000000000","message":"There are no decorators but there is patchobject fixture used in L1729 with side_effects.\n\nWe\u0027ve serveral tests that don\u0027t require some of these mocks ex. test_server_validate_with_bootable_vol does not require mocking image finder as it uses boot volume.\n\nwhy do you say it\u0027s not a good thing? IMO, these are separate tests and we use mocks as per requirement rather than mocking everything without understanding, if they are required or not.","commit_id":"328d748277f0f29a6319e203e9d9b6964faadd37"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"d0c4385570919cd3bd4bdd3f04c797dd86a01ee0","unresolved":false,"context_lines":[{"line_number":3733,"context_line":""},{"line_number":3734,"context_line":""},{"line_number":3735,"context_line":"class ServerInternalPortTest(common.HeatTestCase):"},{"line_number":3736,"context_line":"    def setUp(self):"},{"line_number":3737,"context_line":"        super(ServerInternalPortTest, self).setUp()"},{"line_number":3738,"context_line":"        self.resolve \u003d self.patchobject(neutron.NeutronClientPlugin,"},{"line_number":3739,"context_line":"                                        \u0027find_resourceid_by_name_or_id\u0027)"},{"line_number":3740,"context_line":"        self.port_create \u003d self.patchobject(neutronclient.Client,"},{"line_number":3741,"context_line":"                                            \u0027create_port\u0027)"},{"line_number":3742,"context_line":"        self.port_delete \u003d self.patchobject(neutronclient.Client,"},{"line_number":3743,"context_line":"                                            \u0027delete_port\u0027)"},{"line_number":3744,"context_line":"        self.port_show \u003d self.patchobject(neutronclient.Client,"},{"line_number":3745,"context_line":"                                          \u0027show_port\u0027)"},{"line_number":3746,"context_line":"        self.port_update \u003d self.patchobject(neutronclient.Client,"},{"line_number":3747,"context_line":"                                            \u0027update_port\u0027)"},{"line_number":3748,"context_line":""},{"line_number":3749,"context_line":"    def _return_template_stack_and_rsrc_defn(self, stack_name, temp):"},{"line_number":3750,"context_line":"        templ \u003d template.Template(template_format.parse(temp),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_cbbef3fe","line":3747,"range":{"start_line":3736,"start_character":0,"end_line":3747,"end_character":58},"updated":"2016-03-07 12:40:11.000000000","message":"and here.","commit_id":"328d748277f0f29a6319e203e9d9b6964faadd37"}],"heat/tests/test_metadata_refresh.py":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"5c348eade42329bdd40d683f07dfa5d150128c1d","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        self.stub_KeypairConstraint_validate()"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        #"},{"line_number":168,"context_line":"        # Configure FnGetAtt to return different values on subsequent calls"},{"line_number":169,"context_line":"        mock_get.side_effect \u003d ["},{"line_number":170,"context_line":"            \u002710.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_c9d04622","line":167,"range":{"start_line":167,"start_character":8,"end_line":167,"end_character":9},"updated":"2016-03-15 10:36:45.000000000","message":"Delete this.","commit_id":"b1381ca6d95e57e0937e3c1d63d4b0dc441a92fa"}]}
