)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"cb9c24a6eb39ad5edf929efb81522a9332002772","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitriy Uvarenkov \u003cduvarenkov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-04 13:05:40 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Manila recieved only net ids and couldn\u0027t - net names"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added network names resolving."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_9670b541","line":7,"updated":"2016-03-04 12:52:22.000000000","message":"There is a typo in received, and overall it doesn\u0027t make any sense.\n\nMaybe \"Handle network names in Manila resources\" ?","commit_id":"d2ee75da974a5360d6b5212316536c538a987d97"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"56816b7395e71f2d98c32eb09e46c439d83cb346","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle network names in Manila resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added network names resolving."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I037deaf27caf2fbd2808b9e55fa91e83c4d17a83"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5aef4532_5f51fd61","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":30},"updated":"2016-03-07 13:53:25.000000000","message":"Please add a note here that manila successfully receives nova_network even if we use neutron, so we need to translate nova_network in any case.","commit_id":"f6722f4b600a1dae49c4e4ca88d7819b22cf7e40"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"132bfd73d9e5a44ccd7357741a5f184afa2ecbaf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle network names in Manila resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added network names resolving. Manila successfully"},{"line_number":10,"context_line":"receives nova_network even if we use neutron, so"},{"line_number":11,"context_line":"we need to translate nova_network in any case"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I037deaf27caf2fbd2808b9e55fa91e83c4d17a83"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5aef4532_08466f4e","line":10,"range":{"start_line":9,"start_character":31,"end_line":10,"end_character":44},"updated":"2016-03-10 04:09:34.000000000","message":"I\u0027m not sure I understand the above statement. Neutron or nova-networking is either or right in a deployment and not both. This seems to contradict the validation in another patch[1]\n\n[1] https://review.openstack.org/#/c/288488/3/heat/engine/resources/openstack/manila/share_network.py","commit_id":"a40d8ebc2dd610278b65c885b62c1eae6f91264e"}],"heat/engine/resources/openstack/manila/share_network.py":[{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"8d383b2a00221dd291200350a609daad928a7871","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        nova_net_id \u003d self.properties[self.NOVA_NETWORK]"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if neutron_net_id is not None:"},{"line_number":136,"context_line":"            neutron_net_id \u003d self.client_plugin(\u0027neutron\u0027).\\"},{"line_number":137,"context_line":"                find_resourceid_by_name_or_id(\u0027network\u0027, neutron_net_id)"},{"line_number":138,"context_line":"        if neutron_subnet_id is not None:"},{"line_number":139,"context_line":"            neutron_subnet_id \u003d self.client_plugin(\u0027neutron\u0027).\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_af5781c8","line":136,"range":{"start_line":136,"start_character":59,"end_line":136,"end_character":60},"updated":"2016-03-03 18:45:27.000000000","message":"Can we avoid usage of this backslash?","commit_id":"398d455dd3b8ce989a016f00f18159f71cc53768"},{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"0cf8fb9719e1198f0c88d7dc7b6d118b9d4d0519","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        nova_net_id \u003d self.properties[self.NOVA_NETWORK]"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if neutron_net_id is not None:"},{"line_number":136,"context_line":"            neutron_net_id \u003d self.client_plugin(\u0027neutron\u0027).\\"},{"line_number":137,"context_line":"                find_resourceid_by_name_or_id(\u0027network\u0027, neutron_net_id)"},{"line_number":138,"context_line":"        if neutron_subnet_id is not None:"},{"line_number":139,"context_line":"            neutron_subnet_id \u003d self.client_plugin(\u0027neutron\u0027).\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_3ed9d057","line":136,"range":{"start_line":136,"start_character":59,"end_line":136,"end_character":60},"in_reply_to":"7af24918_af5781c8","updated":"2016-03-04 02:26:24.000000000","message":"Agree, it\u0027s better avoid using \u0027\\\u0027 in codes.","commit_id":"398d455dd3b8ce989a016f00f18159f71cc53768"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"8d383b2a00221dd291200350a609daad928a7871","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            neutron_net_id \u003d self.client_plugin(\u0027neutron\u0027).\\"},{"line_number":137,"context_line":"                find_resourceid_by_name_or_id(\u0027network\u0027, neutron_net_id)"},{"line_number":138,"context_line":"        if neutron_subnet_id is not None:"},{"line_number":139,"context_line":"            neutron_subnet_id \u003d self.client_plugin(\u0027neutron\u0027).\\"},{"line_number":140,"context_line":"                find_resourceid_by_name_or_id(\u0027subnet\u0027, neutron_subnet_id)"},{"line_number":141,"context_line":"        if nova_net_id is not None:"},{"line_number":142,"context_line":"            nova_net_id \u003d self.client_plugin(\u0027nova\u0027).\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_cf700d75","line":139,"range":{"start_line":139,"start_character":62,"end_line":139,"end_character":63},"updated":"2016-03-03 18:45:27.000000000","message":"ditto","commit_id":"398d455dd3b8ce989a016f00f18159f71cc53768"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"8d383b2a00221dd291200350a609daad928a7871","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            neutron_subnet_id \u003d self.client_plugin(\u0027neutron\u0027).\\"},{"line_number":140,"context_line":"                find_resourceid_by_name_or_id(\u0027subnet\u0027, neutron_subnet_id)"},{"line_number":141,"context_line":"        if nova_net_id is not None:"},{"line_number":142,"context_line":"            nova_net_id \u003d self.client_plugin(\u0027nova\u0027).\\"},{"line_number":143,"context_line":"                get_nova_network_id(nova_net_id)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        network \u003d self.client().share_networks.create("}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_0f6795b7","line":142,"range":{"start_line":142,"start_character":53,"end_line":142,"end_character":54},"updated":"2016-03-03 18:45:27.000000000","message":"ditto","commit_id":"398d455dd3b8ce989a016f00f18159f71cc53768"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"8d383b2a00221dd291200350a609daad928a7871","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            nova_net_id \u003d prop_diff.get(self.NOVA_NETWORK)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            if neutron_net_id is not None:"},{"line_number":179,"context_line":"                neutron_net_id \u003d self.client_plugin(\u0027neutron\u0027).\\"},{"line_number":180,"context_line":"                    find_resourceid_by_name_or_id(\u0027network\u0027, neutron_net_id)"},{"line_number":181,"context_line":"            if neutron_subnet_id is not None:"},{"line_number":182,"context_line":"                neutron_subnet_id \u003d self.client_plugin(\u0027neutron\u0027).\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_af0e61e2","line":179,"range":{"start_line":179,"start_character":63,"end_line":179,"end_character":64},"updated":"2016-03-03 18:45:27.000000000","message":"ditto","commit_id":"398d455dd3b8ce989a016f00f18159f71cc53768"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"8d383b2a00221dd291200350a609daad928a7871","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                neutron_net_id \u003d self.client_plugin(\u0027neutron\u0027).\\"},{"line_number":180,"context_line":"                    find_resourceid_by_name_or_id(\u0027network\u0027, neutron_net_id)"},{"line_number":181,"context_line":"            if neutron_subnet_id is not None:"},{"line_number":182,"context_line":"                neutron_subnet_id \u003d self.client_plugin(\u0027neutron\u0027).\\"},{"line_number":183,"context_line":"                    find_resourceid_by_name_or_id(\u0027subnet\u0027, neutron_subnet_id)"},{"line_number":184,"context_line":"            if nova_net_id is not None:"},{"line_number":185,"context_line":"                nova_net_id \u003d self.client_plugin(\u0027nova\u0027).\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_2f0371b9","line":182,"range":{"start_line":182,"start_character":66,"end_line":182,"end_character":67},"updated":"2016-03-03 18:45:27.000000000","message":"ditto","commit_id":"398d455dd3b8ce989a016f00f18159f71cc53768"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"8d383b2a00221dd291200350a609daad928a7871","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                neutron_subnet_id \u003d self.client_plugin(\u0027neutron\u0027).\\"},{"line_number":183,"context_line":"                    find_resourceid_by_name_or_id(\u0027subnet\u0027, neutron_subnet_id)"},{"line_number":184,"context_line":"            if nova_net_id is not None:"},{"line_number":185,"context_line":"                nova_net_id \u003d self.client_plugin(\u0027nova\u0027).\\"},{"line_number":186,"context_line":"                    get_nova_network_id(nova_net_id)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"            self.client().share_networks.update("}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_0ffe75ad","line":185,"range":{"start_line":185,"start_character":57,"end_line":185,"end_character":58},"updated":"2016-03-03 18:45:27.000000000","message":"ditto","commit_id":"398d455dd3b8ce989a016f00f18159f71cc53768"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"4845cd92aa6b371ce7aac87c568d5b2cc5e0ff3d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                                                     self.NOVA_NETWORK)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def handle_create(self):"},{"line_number":131,"context_line":"        neutron_net_id \u003d self.properties[self.NEUTRON_NETWORK]"},{"line_number":132,"context_line":"        neutron_subnet_id \u003d self.properties[self.NEUTRON_SUBNET]"},{"line_number":133,"context_line":"        nova_net_id \u003d self.properties[self.NOVA_NETWORK]"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if neutron_net_id is not None:"},{"line_number":136,"context_line":"            neutron_net_id \u003d self.client_plugin("},{"line_number":137,"context_line":"                \u0027neutron\u0027).find_resourceid_by_name_or_id(\u0027network\u0027,"},{"line_number":138,"context_line":"                                                         neutron_net_id)"},{"line_number":139,"context_line":"        if neutron_subnet_id is not None:"},{"line_number":140,"context_line":"            neutron_subnet_id \u003d self.client_plugin("},{"line_number":141,"context_line":"                \u0027neutron\u0027).find_resourceid_by_name_or_id(\u0027subnet\u0027,"},{"line_number":142,"context_line":"                                                         neutron_subnet_id)"},{"line_number":143,"context_line":"        if nova_net_id is not None:"},{"line_number":144,"context_line":"            nova_net_id \u003d self.client_plugin("},{"line_number":145,"context_line":"                \u0027nova\u0027).get_nova_network_id(nova_net_id)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        network \u003d self.client().share_networks.create("},{"line_number":148,"context_line":"            name\u003dself.properties[self.NAME],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_536c8a07","line":145,"range":{"start_line":131,"start_character":0,"end_line":145,"end_character":56},"updated":"2016-03-04 09:14:12.000000000","message":"how about using resolve translation rule for this purposes ?\nlike it is done here https://review.openstack.org/#/c/280045/7","commit_id":"3b5fb0ae5dec1ca7caed8e8cfa82d09c7685749d"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"b88deb187bd5ef5bfb0dd8838a3e0e2b33558098","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    def handle_create(self):"},{"line_number":159,"context_line":"        network \u003d self.client().share_networks.create("},{"line_number":160,"context_line":"            name\u003dself.properties[self.NAME],"},{"line_number":161,"context_line":"            neutron_net_id\u003ddict(self.properties).get(self.NEUTRON_NETWORK),"},{"line_number":162,"context_line":"            neutron_subnet_id\u003ddict(self.properties).get(self.NEUTRON_SUBNET),"},{"line_number":163,"context_line":"            nova_net_id\u003ddict(self.properties).get(self.NOVA_NETWORK),"},{"line_number":164,"context_line":"            description\u003dself.properties[self.DESCRIPTION])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_94fd55b3","line":161,"range":{"start_line":161,"start_character":27,"end_line":161,"end_character":48},"updated":"2016-03-04 10:55:42.000000000","message":"Why we need convert properties to dict?","commit_id":"e042866bc395228971b4680787befae2a1b1b1f2"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"928c34dddd561a01ad5e12d38efddea350d640cd","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                                                     self.NOVA_NETWORK)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def translation_rules(self, props):"},{"line_number":132,"context_line":"        return ["},{"line_number":133,"context_line":"            translation.TranslationRule("},{"line_number":134,"context_line":"                props,"},{"line_number":135,"context_line":"                translation.TranslationRule.RESOLVE,"},{"line_number":136,"context_line":"                [self.NEUTRON_NETWORK],"},{"line_number":137,"context_line":"                client_plugin\u003dself.client_plugin(\u0027neutron\u0027),"},{"line_number":138,"context_line":"                finder\u003d\u0027find_resourceid_by_name_or_id\u0027,"},{"line_number":139,"context_line":"                entity\u003d\u0027network\u0027"},{"line_number":140,"context_line":"            ),"},{"line_number":141,"context_line":"            translation.TranslationRule("},{"line_number":142,"context_line":"                props,"},{"line_number":143,"context_line":"                translation.TranslationRule.RESOLVE,"},{"line_number":144,"context_line":"                [self.NEUTRON_SUBNET],"},{"line_number":145,"context_line":"                client_plugin\u003dself.client_plugin(\u0027neutron\u0027),"},{"line_number":146,"context_line":"                finder\u003d\u0027find_resourceid_by_name_or_id\u0027,"},{"line_number":147,"context_line":"                entity\u003d\u0027subnet\u0027"},{"line_number":148,"context_line":"            ),"},{"line_number":149,"context_line":"            translation.TranslationRule("},{"line_number":150,"context_line":"                props,"},{"line_number":151,"context_line":"                translation.TranslationRule.RESOLVE,"},{"line_number":152,"context_line":"                [self.NOVA_NETWORK],"},{"line_number":153,"context_line":"                client_plugin\u003dself.client_plugin(\u0027nova\u0027),"},{"line_number":154,"context_line":"                finder\u003d\u0027get_nova_network_id\u0027"},{"line_number":155,"context_line":"            )"},{"line_number":156,"context_line":"        ]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def handle_create(self):"},{"line_number":159,"context_line":"        network \u003d self.client().share_networks.create("}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_0aeabc73","line":156,"range":{"start_line":132,"start_character":0,"end_line":156,"end_character":9},"updated":"2016-03-04 11:44:11.000000000","message":"I think you should use  self.is_using_neutron() to translate neutron and nova properties.","commit_id":"d2ee75da974a5360d6b5212316536c538a987d97"}],"heat/tests/openstack/manila/test_share_network.py":[{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"27ca35b5cf374f57b2d54b367f29c6448b41cc46","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            calls, any_order\u003dTrue)"},{"line_number":113,"context_line":"        self.assertEqual(\u0027share_networks\u0027, net.entity)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        t \u003d template_format.parse(stack_template)"},{"line_number":116,"context_line":"        t[\u0027resources\u0027][\u0027share_network\u0027][\u0027properties\u0027][\u0027nova_network\u0027] \u003d \u0027n\u0027"},{"line_number":117,"context_line":"        del t[\u0027resources\u0027][\u0027share_network\u0027][\u0027properties\u0027][\u0027neutron_network\u0027]"},{"line_number":118,"context_line":"        del t[\u0027resources\u0027][\u0027share_network\u0027][\u0027properties\u0027][\u0027neutron_subnet\u0027]"},{"line_number":119,"context_line":"        stack \u003d utils.parse_stack(t)"},{"line_number":120,"context_line":"        rsrc_defn \u003d stack.t.resource_definitions(stack)[\u0027share_network\u0027]"},{"line_number":121,"context_line":"        net \u003d self._create_network(\u0027share_network\u0027, rsrc_defn, stack)"},{"line_number":122,"context_line":"        self.assertEqual((net.CREATE, net.COMPLETE), net.state)"},{"line_number":123,"context_line":"        self.assertEqual(\u002742\u0027, net.resource_id)"},{"line_number":124,"context_line":"        net.client().share_networks.create.assert_called_with("},{"line_number":125,"context_line":"            name\u003d\u00271\u0027, description\u003d\u00272\u0027, neutron_net_id\u003dNone,"},{"line_number":126,"context_line":"            neutron_subnet_id\u003dNone, nova_net_id\u003d\u0027n\u0027)"},{"line_number":127,"context_line":"        calls \u003d [mock.call(\u002742\u0027, \u00276\u0027), mock.call(\u002742\u0027, \u00277\u0027)]"},{"line_number":128,"context_line":"        net.client().share_networks.add_security_service.assert_has_calls("},{"line_number":129,"context_line":"            calls, any_order\u003dTrue)"},{"line_number":130,"context_line":"        self.assertEqual(\u0027share_networks\u0027, net.entity)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_create_fail(self):"},{"line_number":133,"context_line":"        self.client.share_networks.add_security_service.side_effect \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_c7027472","line":130,"range":{"start_line":115,"start_character":0,"end_line":130,"end_character":54},"updated":"2016-03-04 18:15:06.000000000","message":"This code should be in separate test.","commit_id":"8744bea35b471b9755f034f8cffd08ad78f8ade7"}]}
