)]}'
{"heat_integrationtests/functional/test_reload_on_sighup.py":[{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"0a235f750e03cd213461cb2e58ccdfd0ccba1f7f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # NoSectionError raised. So, should wait until first thread writes to"},{"line_number":39,"context_line":"        # config_file."},{"line_number":40,"context_line":"        is_busy \u003d True"},{"line_number":41,"context_line":"        retries_count \u003d 10"},{"line_number":42,"context_line":"        while is_busy:"},{"line_number":43,"context_line":"            is_busy \u003d False"},{"line_number":44,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_5a10eb4e","line":41,"range":{"start_line":41,"start_character":24,"end_line":41,"end_character":26},"updated":"2016-03-07 14:12:39.000000000","message":"Is it better to create config option for this value instead of hardcode it?","commit_id":"aa0bb938a4bbabda9951868969bd0b1379a95c13"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"5c352d5652ef944dc0ffc243bdea801695087fb1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # NoSectionError raised. So, should wait until first thread writes to"},{"line_number":39,"context_line":"        # config_file."},{"line_number":40,"context_line":"        is_busy \u003d True"},{"line_number":41,"context_line":"        retries_count \u003d 10"},{"line_number":42,"context_line":"        while is_busy:"},{"line_number":43,"context_line":"            is_busy \u003d False"},{"line_number":44,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_a2a23497","line":41,"range":{"start_line":41,"start_character":24,"end_line":41,"end_character":26},"in_reply_to":"5aef4532_5a10eb4e","updated":"2016-03-09 11:15:28.000000000","message":"think, you\u0027re right","commit_id":"aa0bb938a4bbabda9951868969bd0b1379a95c13"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"d607be5a69c096424ca05d675cccaeb87bee1572","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                retries_count -\u003d 1"},{"line_number":51,"context_line":"                eventlet.sleep(1)"},{"line_number":52,"context_line":"                config.read(self.config_file)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        with open(self.config_file, \u0027wb\u0027) as f:"},{"line_number":55,"context_line":"            config.write(f)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_564cd19d","line":53,"updated":"2016-03-15 10:17:37.000000000","message":"I\u0027d rewrite it slightly differently:\n\nwhile True:\n   config.read(self.config_file)\n   try:\n       config.set(service, key, value)\n   except configparser.NoSectionError:\n       if retries_count \u003c\u003d 0:\n           raise\n       retries_count -\u003d 1\n       eventlet.sleep(1)\n   else:\n       break","commit_id":"19bcff447b4061df9bdf3062d3cd4baab8059f6b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"71fe87a882dfde3af30a44d79b3b16b686cc07e8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # write to file, which is already erased by first thread, so,"},{"line_number":37,"context_line":"        # NoSectionError raised. So, should wait until first thread writes to"},{"line_number":38,"context_line":"        # config_file."},{"line_number":39,"context_line":"        retries_count \u003d self.conf.sighup_config_edit_retries"},{"line_number":40,"context_line":"        while True:"},{"line_number":41,"context_line":"            config.read(self.config_file)"},{"line_number":42,"context_line":"            try:"},{"line_number":43,"context_line":"                config.set(service, key, value)"},{"line_number":44,"context_line":"            except configparser.NoSectionError:"},{"line_number":45,"context_line":"                if retries_count \u003c\u003d 0:"},{"line_number":46,"context_line":"                    raise"},{"line_number":47,"context_line":"                retries_count -\u003d 1"},{"line_number":48,"context_line":"                eventlet.sleep(1)"},{"line_number":49,"context_line":"            else:"},{"line_number":50,"context_line":"                break"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        with open(self.config_file, \u0027wb\u0027) as f:"},{"line_number":53,"context_line":"            config.write(f)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_5a01ebad","line":50,"range":{"start_line":39,"start_character":0,"end_line":50,"end_character":21},"updated":"2016-03-16 06:42:52.000000000","message":"Can we not use retrying library here?","commit_id":"48387e92a09effbae0b8c925ca5ba615cb112b76"}]}
