)]}'
{"heat/engine/hot/functions.py":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"2aab2c7f5fad39495b539e21d94b57269deb0b51","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        for_each \u003d function.resolve(self.args[\u0027for_each\u0027])"},{"line_number":574,"context_line":"        keys \u003d list(six.iterkeys(for_each))"},{"line_number":575,"context_line":"        lists \u003d [for_each[key] for key in keys]"},{"line_number":576,"context_line":"        if not all(self._valid_list(l) for l in lists):"},{"line_number":577,"context_line":"            raise TypeError(_(\u0027The values of the \"for_each\" argument to \u0027"},{"line_number":578,"context_line":"                              \u0027\"%s\" must be lists\u0027) % self.fn_name)"},{"line_number":579,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_fe220f51","line":576,"range":{"start_line":576,"start_character":19,"end_line":576,"end_character":38},"updated":"2016-03-09 13:39:09.000000000","message":"Is it expected change, previously it checked, that l is a list, now it also allows to be a Function?\n\nI suppose, that it\u0027s expected and \"fix\" this missed case from previous patch, but want to make sure, that it\u0027s?","commit_id":"37ebb3ce4e79ece810d50058087adc7752bc6f8b"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"58018446c2e181654a860ce347d45cc07c4ecfb8","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        for_each \u003d function.resolve(self.args[\u0027for_each\u0027])"},{"line_number":574,"context_line":"        keys \u003d list(six.iterkeys(for_each))"},{"line_number":575,"context_line":"        lists \u003d [for_each[key] for key in keys]"},{"line_number":576,"context_line":"        if not all(self._valid_list(l) for l in lists):"},{"line_number":577,"context_line":"            raise TypeError(_(\u0027The values of the \"for_each\" argument to \u0027"},{"line_number":578,"context_line":"                              \u0027\"%s\" must be lists\u0027) % self.fn_name)"},{"line_number":579,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_04814fc3","line":576,"range":{"start_line":576,"start_character":19,"end_line":576,"end_character":38},"in_reply_to":"5aef4532_fe220f51","updated":"2016-03-09 23:41:08.000000000","message":"Sergey - we already called function.resolve() on this data, so there are no Functions left in it. So in practice this change should make no difference.","commit_id":"37ebb3ce4e79ece810d50058087adc7752bc6f8b"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"965f46e42bab916991ae04f80a6c08661bc5714e","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        for_each \u003d function.resolve(self.args[\u0027for_each\u0027])"},{"line_number":574,"context_line":"        keys \u003d list(six.iterkeys(for_each))"},{"line_number":575,"context_line":"        lists \u003d [for_each[key] for key in keys]"},{"line_number":576,"context_line":"        if not all(self._valid_list(l) for l in lists):"},{"line_number":577,"context_line":"            raise TypeError(_(\u0027The values of the \"for_each\" argument to \u0027"},{"line_number":578,"context_line":"                              \u0027\"%s\" must be lists\u0027) % self.fn_name)"},{"line_number":579,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_61f5c055","line":576,"range":{"start_line":576,"start_character":19,"end_line":576,"end_character":38},"in_reply_to":"5aef4532_fe220f51","updated":"2016-03-09 13:57:01.000000000","message":"two previous lines could be refactored to [v for v in six.itervalues(for_each)], IMO","commit_id":"37ebb3ce4e79ece810d50058087adc7752bc6f8b"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"2aab2c7f5fad39495b539e21d94b57269deb0b51","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        lists \u003d [for_each[key] for key in keys]"},{"line_number":576,"context_line":"        if not all(self._valid_list(l) for l in lists):"},{"line_number":577,"context_line":"            raise TypeError(_(\u0027The values of the \"for_each\" argument to \u0027"},{"line_number":578,"context_line":"                              \u0027\"%s\" must be lists\u0027) % self.fn_name)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        template \u003d function.resolve(self.args[\u0027template\u0027])"},{"line_number":581,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_beb24704","line":578,"range":{"start_line":578,"start_character":36,"end_line":578,"end_character":40},"updated":"2016-03-09 13:39:09.000000000","message":"P.s. also according this change we need to fix message here too about using Functions","commit_id":"37ebb3ce4e79ece810d50058087adc7752bc6f8b"}]}
