)]}'
{"heat/engine/resources/openstack/neutron/extraroute.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e35d4cf359a26fb41b5c913130b7233137ac475b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            # router_id as this router_id"},{"line_number":68,"context_line":"            if resource.has_interface(\u0027OS::Neutron::RouterInterface\u0027):"},{"line_number":69,"context_line":"                dep_router_id \u003d None"},{"line_number":70,"context_line":"                with self.client_plugin().ignore_not_found:"},{"line_number":71,"context_line":"                    dep_router_id \u003d self.client_plugin().resolve_router({"},{"line_number":72,"context_line":"                        \u0027router\u0027: resource.properties.get(\u0027router\u0027),"},{"line_number":73,"context_line":"                        \u0027router_id\u0027: None}, \u0027router\u0027, \u0027router_id\u0027)"},{"line_number":74,"context_line":"                router_id \u003d self.properties[self.ROUTER_ID]"},{"line_number":75,"context_line":"                if dep_router_id \u003d\u003d router_id:"},{"line_number":76,"context_line":"                    deps +\u003d (self, resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_b4e3d132","line":73,"range":{"start_line":70,"start_character":16,"end_line":73,"end_character":66},"updated":"2016-03-08 10:57:59.000000000","message":"As we\u0027re already doing property translation[1] for RouterInterface, probably the lookup is not needed.\n\nYou can possibly just do dep_router_id \u003d resource.properties.get(RouterInterface.ROUTER)\n\n[1] https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/neutron/router.py#L444-L448","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"78178de6761eecc2387c243d19366bfbb6cf0502","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            # router_id as this router_id"},{"line_number":68,"context_line":"            if resource.has_interface(\u0027OS::Neutron::RouterInterface\u0027):"},{"line_number":69,"context_line":"                dep_router_id \u003d None"},{"line_number":70,"context_line":"                with self.client_plugin().ignore_not_found:"},{"line_number":71,"context_line":"                    dep_router_id \u003d self.client_plugin().resolve_router({"},{"line_number":72,"context_line":"                        \u0027router\u0027: resource.properties.get(\u0027router\u0027),"},{"line_number":73,"context_line":"                        \u0027router_id\u0027: None}, \u0027router\u0027, \u0027router_id\u0027)"},{"line_number":74,"context_line":"                router_id \u003d self.properties[self.ROUTER_ID]"},{"line_number":75,"context_line":"                if dep_router_id \u003d\u003d router_id:"},{"line_number":76,"context_line":"                    deps +\u003d (self, resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_e2c61b48","line":73,"range":{"start_line":70,"start_character":16,"end_line":73,"end_character":66},"in_reply_to":"5aef4532_16b557ed","updated":"2016-03-08 22:38:08.000000000","message":"The real aim here should be to never ever make REST API calls in get_dependencies. All we\u0027re doing here is resolving a router name/ID to an ID.\n\nLooking at the RouterInterface implementation this particular call can be removed by calling:\n\n  dep_router_id \u003d resource.resource_id.split(\u0027:\u0027)[0]","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7d1923f2582e2b33ebd44ed951178c622e531786","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            # router_id as this router_id"},{"line_number":68,"context_line":"            if resource.has_interface(\u0027OS::Neutron::RouterInterface\u0027):"},{"line_number":69,"context_line":"                dep_router_id \u003d None"},{"line_number":70,"context_line":"                with self.client_plugin().ignore_not_found:"},{"line_number":71,"context_line":"                    dep_router_id \u003d self.client_plugin().resolve_router({"},{"line_number":72,"context_line":"                        \u0027router\u0027: resource.properties.get(\u0027router\u0027),"},{"line_number":73,"context_line":"                        \u0027router_id\u0027: None}, \u0027router\u0027, \u0027router_id\u0027)"},{"line_number":74,"context_line":"                router_id \u003d self.properties[self.ROUTER_ID]"},{"line_number":75,"context_line":"                if dep_router_id \u003d\u003d router_id:"},{"line_number":76,"context_line":"                    deps +\u003d (self, resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_d7c93f7a","line":73,"range":{"start_line":70,"start_character":16,"end_line":73,"end_character":66},"in_reply_to":"5aef4532_b4e3d132","updated":"2016-03-08 11:28:35.000000000","message":"May be this would be an issue with stack delete, as we don\u0027t translate resources when loading from the db.","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"8a866b989aa6bee7df34ea4d9e4525ab848dc226","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            # router_id as this router_id"},{"line_number":68,"context_line":"            if resource.has_interface(\u0027OS::Neutron::RouterInterface\u0027):"},{"line_number":69,"context_line":"                dep_router_id \u003d None"},{"line_number":70,"context_line":"                with self.client_plugin().ignore_not_found:"},{"line_number":71,"context_line":"                    dep_router_id \u003d self.client_plugin().resolve_router({"},{"line_number":72,"context_line":"                        \u0027router\u0027: resource.properties.get(\u0027router\u0027),"},{"line_number":73,"context_line":"                        \u0027router_id\u0027: None}, \u0027router\u0027, \u0027router_id\u0027)"},{"line_number":74,"context_line":"                router_id \u003d self.properties[self.ROUTER_ID]"},{"line_number":75,"context_line":"                if dep_router_id \u003d\u003d router_id:"},{"line_number":76,"context_line":"                    deps +\u003d (self, resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_16b557ed","line":73,"range":{"start_line":70,"start_character":16,"end_line":73,"end_character":66},"in_reply_to":"5aef4532_d7c93f7a","updated":"2016-03-08 17:39:28.000000000","message":"Judging by the commit where this code was added (I60e5ba28e89333faff263915a568a5e4d8f09505) I assume it would be an issue.","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"141017f3baa5ca9d9f33f015bbd718118e4739d1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            # router_id as this router_id"},{"line_number":68,"context_line":"            if resource.has_interface(\u0027OS::Neutron::RouterInterface\u0027):"},{"line_number":69,"context_line":"                dep_router_id \u003d None"},{"line_number":70,"context_line":"                with self.client_plugin().ignore_not_found:"},{"line_number":71,"context_line":"                    dep_router_id \u003d self.client_plugin().resolve_router({"},{"line_number":72,"context_line":"                        \u0027router\u0027: resource.properties.get(\u0027router\u0027),"},{"line_number":73,"context_line":"                        \u0027router_id\u0027: None}, \u0027router\u0027, \u0027router_id\u0027)"},{"line_number":74,"context_line":"                router_id \u003d self.properties[self.ROUTER_ID]"},{"line_number":75,"context_line":"                if dep_router_id \u003d\u003d router_id:"},{"line_number":76,"context_line":"                    deps +\u003d (self, resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_361aee7d","line":73,"range":{"start_line":70,"start_character":16,"end_line":73,"end_character":66},"in_reply_to":"5aef4532_e2c61b48","updated":"2016-03-10 11:03:38.000000000","message":"Ah, that\u0027s much better thanks! Done.","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"69d97244181d0803ddb22f5cce68c6c60c83d27b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            # router_id as this router_id"},{"line_number":68,"context_line":"            if resource.has_interface(\u0027OS::Neutron::RouterInterface\u0027):"},{"line_number":69,"context_line":"                dep_router_id \u003d None"},{"line_number":70,"context_line":"                with self.client_plugin().ignore_not_found:"},{"line_number":71,"context_line":"                    dep_router_id \u003d self.client_plugin().resolve_router({"},{"line_number":72,"context_line":"                        \u0027router\u0027: resource.properties.get(\u0027router\u0027),"},{"line_number":73,"context_line":"                        \u0027router_id\u0027: None}, \u0027router\u0027, \u0027router_id\u0027)"},{"line_number":74,"context_line":"                router_id \u003d self.properties[self.ROUTER_ID]"},{"line_number":75,"context_line":"                if dep_router_id \u003d\u003d router_id:"},{"line_number":76,"context_line":"                    deps +\u003d (self, resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_f69ffd4d","line":73,"range":{"start_line":70,"start_character":16,"end_line":73,"end_character":66},"in_reply_to":"5aef4532_e2c61b48","updated":"2016-03-08 22:52:35.000000000","message":"RouterGateway.add_dependencies will need the same fix","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"141017f3baa5ca9d9f33f015bbd718118e4739d1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            # router_id as this router_id"},{"line_number":68,"context_line":"            if resource.has_interface(\u0027OS::Neutron::RouterInterface\u0027):"},{"line_number":69,"context_line":"                dep_router_id \u003d None"},{"line_number":70,"context_line":"                with self.client_plugin().ignore_not_found:"},{"line_number":71,"context_line":"                    dep_router_id \u003d self.client_plugin().resolve_router({"},{"line_number":72,"context_line":"                        \u0027router\u0027: resource.properties.get(\u0027router\u0027),"},{"line_number":73,"context_line":"                        \u0027router_id\u0027: None}, \u0027router\u0027, \u0027router_id\u0027)"},{"line_number":74,"context_line":"                router_id \u003d self.properties[self.ROUTER_ID]"},{"line_number":75,"context_line":"                if dep_router_id \u003d\u003d router_id:"},{"line_number":76,"context_line":"                    deps +\u003d (self, resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_7610f659","line":73,"range":{"start_line":70,"start_character":16,"end_line":73,"end_character":66},"in_reply_to":"5aef4532_f69ffd4d","updated":"2016-03-10 11:03:38.000000000","message":"Done","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"8a866b989aa6bee7df34ea4d9e4525ab848dc226","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    dep_router_id \u003d self.client_plugin().resolve_router({"},{"line_number":72,"context_line":"                        \u0027router\u0027: resource.properties.get(\u0027router\u0027),"},{"line_number":73,"context_line":"                        \u0027router_id\u0027: None}, \u0027router\u0027, \u0027router_id\u0027)"},{"line_number":74,"context_line":"                router_id \u003d self.properties[self.ROUTER_ID]"},{"line_number":75,"context_line":"                if dep_router_id \u003d\u003d router_id:"},{"line_number":76,"context_line":"                    deps +\u003d (self, resource)"},{"line_number":77,"context_line":"            # depend on any RouterGateway in this template with the same"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_b6d3c35e","line":74,"updated":"2016-03-08 17:39:28.000000000","message":"Nothing to do with this change, but why are we doing this inside the loop? Twice. Using string literals in one case.","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"8a866b989aa6bee7df34ea4d9e4525ab848dc226","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                        \u0027router\u0027: resource.properties.get(\u0027router\u0027),"},{"line_number":73,"context_line":"                        \u0027router_id\u0027: None}, \u0027router\u0027, \u0027router_id\u0027)"},{"line_number":74,"context_line":"                router_id \u003d self.properties[self.ROUTER_ID]"},{"line_number":75,"context_line":"                if dep_router_id \u003d\u003d router_id:"},{"line_number":76,"context_line":"                    deps +\u003d (self, resource)"},{"line_number":77,"context_line":"            # depend on any RouterGateway in this template with the same"},{"line_number":78,"context_line":"            # router_id as this router_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_f6a8abdd","line":75,"updated":"2016-03-08 17:39:28.000000000","message":"I think I\u0027d be more comfortable if there was a\n\n  if dep_router_id is None:\n    continue\n\nafter the with block (or, alternately, if this code were inside the block). It\u0027s true that the router_id property is required so in theory it can\u0027t be None... but it still makes me nervous.","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"141017f3baa5ca9d9f33f015bbd718118e4739d1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                        \u0027router\u0027: resource.properties.get(\u0027router\u0027),"},{"line_number":73,"context_line":"                        \u0027router_id\u0027: None}, \u0027router\u0027, \u0027router_id\u0027)"},{"line_number":74,"context_line":"                router_id \u003d self.properties[self.ROUTER_ID]"},{"line_number":75,"context_line":"                if dep_router_id \u003d\u003d router_id:"},{"line_number":76,"context_line":"                    deps +\u003d (self, resource)"},{"line_number":77,"context_line":"            # depend on any RouterGateway in this template with the same"},{"line_number":78,"context_line":"            # router_id as this router_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_843423fc","line":75,"in_reply_to":"5aef4532_f6a8abdd","updated":"2016-03-10 11:03:38.000000000","message":"Done","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"}],"heat/engine/resources/openstack/neutron/floatingip.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"7223b07a2b127094dcc094b61c61184748321df5","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                            # graph. This situation can come about due to an"},{"line_number":187,"context_line":"                            # operator/user deleting resources without"},{"line_number":188,"context_line":"                            # awareness of heat."},{"line_number":189,"context_line":"                            except neutron_exceptions.NetworkNotFoundClient:"},{"line_number":190,"context_line":"                                return False"},{"line_number":191,"context_line":"                    else:"},{"line_number":192,"context_line":"                        for fixed_ip in resource.properties.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_6a20709c","line":189,"updated":"2016-03-07 15:30:30.000000000","message":"We could avoid having to have knowledge of the neutron client here by making use of the abstractions in the client_plugin:\n\n  with self.client_plugin().ignore_not_found:\n    subnets \u003d self.client().show_network(p_net)[\u0027network\u0027][\u0027subnets\u0027]\n    return subnet in subnets\n  return False","commit_id":"56d6d1e4d2ef5c436d465a8477a1b898e59c5b5a"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"af4c16946da4ce3f245ab505c3b65a64cc2cdde4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                            # graph. This situation can come about due to an"},{"line_number":187,"context_line":"                            # operator/user deleting resources without"},{"line_number":188,"context_line":"                            # awareness of heat."},{"line_number":189,"context_line":"                            except neutron_exceptions.NetworkNotFoundClient:"},{"line_number":190,"context_line":"                                return False"},{"line_number":191,"context_line":"                    else:"},{"line_number":192,"context_line":"                        for fixed_ip in resource.properties.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_ea812091","line":189,"in_reply_to":"5aef4532_6a20709c","updated":"2016-03-07 16:48:31.000000000","message":"That\u0027s a lot cleaner, than what I did. Thanks :-)\n\nI\u0027ll use ignore_not_found then.","commit_id":"56d6d1e4d2ef5c436d465a8477a1b898e59c5b5a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"78178de6761eecc2387c243d19366bfbb6cf0502","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            # depend on any RouterInterface in this template which interfaces"},{"line_number":167,"context_line":"            # with the same subnet that this floating IP\u0027s port is assigned"},{"line_number":168,"context_line":"            # to"},{"line_number":169,"context_line":"            elif resource.has_interface(\u0027OS::Neutron::RouterInterface\u0027):"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"                def port_on_subnet(resource, subnet):"},{"line_number":172,"context_line":"                    if not resource.has_interface(\u0027OS::Neutron::Port\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_9887c8d6","line":169,"updated":"2016-03-08 22:38:08.000000000","message":"Again we really need to eliminate the show_network REST call entirely. I think this whole block needs a change of approach. I\u0027ll comment with some ideas","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"78178de6761eecc2387c243d19366bfbb6cf0502","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"                interface_subnet \u003d ("},{"line_number":200,"context_line":"                    resource.properties.get(router.RouterInterface.SUBNET) or"},{"line_number":201,"context_line":"                    resource.properties.get(router.RouterInterface.SUBNET_ID))"},{"line_number":202,"context_line":"                # during create we have only unresolved value for functions, so"},{"line_number":203,"context_line":"                # can not use None value for building correct dependencies"},{"line_number":204,"context_line":"                if interface_subnet:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_f80d2c3f","line":201,"updated":"2016-03-08 22:38:08.000000000","message":"lets get the actual subnet ID from resource.resource_id\n\n  interface_subnet \u003d resource.resource_id.split(\u0027subnet_id\u003d\u0027)[1] # catch and pass IndexError","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"141017f3baa5ca9d9f33f015bbd718118e4739d1","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"                interface_subnet \u003d ("},{"line_number":200,"context_line":"                    resource.properties.get(router.RouterInterface.SUBNET) or"},{"line_number":201,"context_line":"                    resource.properties.get(router.RouterInterface.SUBNET_ID))"},{"line_number":202,"context_line":"                # during create we have only unresolved value for functions, so"},{"line_number":203,"context_line":"                # can not use None value for building correct dependencies"},{"line_number":204,"context_line":"                if interface_subnet:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_01616ad3","line":201,"in_reply_to":"5aef4532_f80d2c3f","updated":"2016-03-10 11:03:38.000000000","message":"Done","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"78178de6761eecc2387c243d19366bfbb6cf0502","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                # can not use None value for building correct dependencies"},{"line_number":204,"context_line":"                if interface_subnet:"},{"line_number":205,"context_line":"                    for d in deps.graph()[self]:"},{"line_number":206,"context_line":"                        if port_on_subnet(d, interface_subnet):"},{"line_number":207,"context_line":"                            deps +\u003d (self, resource)"},{"line_number":208,"context_line":"                            break"},{"line_number":209,"context_line":"            # depend on Router with EXTERNAL_GATEWAY_NETWORK property"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_fb69a6bf","line":206,"updated":"2016-03-08 22:38:08.000000000","message":"Aren\u0027t we only interested in the port for this floating ip, not every port resource? I think this loop and port_on_subnet can be replaced with the below suggestion and this conditional:\n\n  if interface_subnet in self._get_subnets():","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"78178de6761eecc2387c243d19366bfbb6cf0502","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        self.client_plugin().resolve_network(props, self.FLOATING_NETWORK,"},{"line_number":235,"context_line":"                                             \u0027floating_network_id\u0027)"},{"line_number":236,"context_line":"        fip \u003d self.client().create_floatingip({"},{"line_number":237,"context_line":"            \u0027floatingip\u0027: props})[\u0027floatingip\u0027]"},{"line_number":238,"context_line":"        self.resource_id_set(fip[\u0027id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _show_resource(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_3b4b0ecb","line":237,"updated":"2016-03-08 22:38:08.000000000","message":"There is now a port created which knows what subnets it belongs to, so lets look them up now and store them in resource data, something like\n\n  port_id \u003d fip[\u0027port_id\u0027]\n  port \u003d self.client().show_port(port_id)\n  subnets \u003d # extract from port[\u0027fixed_ips\u0027]\n  self.data_set(\u0027subnets\u0027), \u0027,\u0027.join(subnet)","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"141017f3baa5ca9d9f33f015bbd718118e4739d1","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        self.client_plugin().resolve_network(props, self.FLOATING_NETWORK,"},{"line_number":235,"context_line":"                                             \u0027floating_network_id\u0027)"},{"line_number":236,"context_line":"        fip \u003d self.client().create_floatingip({"},{"line_number":237,"context_line":"            \u0027floatingip\u0027: props})[\u0027floatingip\u0027]"},{"line_number":238,"context_line":"        self.resource_id_set(fip[\u0027id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _show_resource(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_44069b20","line":237,"in_reply_to":"5aef4532_3b4b0ecb","updated":"2016-03-10 11:03:38.000000000","message":"Done","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"78178de6761eecc2387c243d19366bfbb6cf0502","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        fip \u003d self.client().create_floatingip({"},{"line_number":237,"context_line":"            \u0027floatingip\u0027: props})[\u0027floatingip\u0027]"},{"line_number":238,"context_line":"        self.resource_id_set(fip[\u0027id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _show_resource(self):"},{"line_number":241,"context_line":"        return self.client().show_floatingip(self.resource_id)[\u0027floatingip\u0027]"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_3bfe6e37","line":239,"updated":"2016-03-08 22:38:08.000000000","message":"The handle_create logic is fine for newly created resources after this fix lands, but we also need to handle old stacks, so lets implement a _get_subnets method which add_dependencies calls. If self.data(\u0027subnets\u0027) then lookup the fip and populate it with the above handle_create logic.\n\nThen in the very worst case there is one REST API call from add_dependencies and from then on none.","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"141017f3baa5ca9d9f33f015bbd718118e4739d1","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        fip \u003d self.client().create_floatingip({"},{"line_number":237,"context_line":"            \u0027floatingip\u0027: props})[\u0027floatingip\u0027]"},{"line_number":238,"context_line":"        self.resource_id_set(fip[\u0027id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _show_resource(self):"},{"line_number":241,"context_line":"        return self.client().show_floatingip(self.resource_id)[\u0027floatingip\u0027]"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_6705990f","line":239,"in_reply_to":"5aef4532_3bfe6e37","updated":"2016-03-10 11:03:38.000000000","message":"Done","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"78178de6761eecc2387c243d19366bfbb6cf0502","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                    \u0027port_id\u0027: port_id,"},{"line_number":259,"context_line":"                    \u0027fixed_ip_address\u0027: fixed_ip_address}}"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            self.client().update_floatingip(self.resource_id, request_body)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"class FloatingIPAssociation(neutron.NeutronResource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_db3b0a37","line":261,"updated":"2016-03-08 22:38:08.000000000","message":"subnets may have changed, so repeat handle_create logic here","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"141017f3baa5ca9d9f33f015bbd718118e4739d1","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                    \u0027port_id\u0027: port_id,"},{"line_number":259,"context_line":"                    \u0027fixed_ip_address\u0027: fixed_ip_address}}"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            self.client().update_floatingip(self.resource_id, request_body)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"class FloatingIPAssociation(neutron.NeutronResource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a70b2123","line":261,"in_reply_to":"5aef4532_db3b0a37","updated":"2016-03-10 11:03:38.000000000","message":"Done","commit_id":"f37c24df694bad14742768071b5093a88e27d94e"}]}
