)]}'
{"heat/engine/resource.py":[{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"6c41268b79231322064e630b96d5f5a2cb30d92d","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        return self.t.dep_attrs(resource_name)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def add_explicit_dependencies(self, deps):"},{"line_number":564,"context_line":"        \"\"\"Add all dependencies explicitly specified in the template.\"\"\""},{"line_number":565,"context_line":"        for dep in self.t.dependencies(self.stack):"},{"line_number":566,"context_line":"            deps +\u003d (self, dep)"},{"line_number":567,"context_line":"        deps +\u003d (self, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_5caffd80","line":564,"updated":"2016-03-08 18:45:03.000000000","message":"Glad to see docstrings added, but can you add an entry for deps too? On signature alone, this looks like you\u0027re adding deps to the running list of dependencies, but it\u0027s actually the running list to add to.","commit_id":"3615390ae6bc6770a6b931f5020b079f8b92bdde"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"6c41268b79231322064e630b96d5f5a2cb30d92d","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        be set using get_resource or get_attr for example, thus creating an"},{"line_number":575,"context_line":"        explicit dependency). Such dependencies are opaque to the user and"},{"line_number":576,"context_line":"        should be avoided wherever possible, however in some circumstances they"},{"line_number":577,"context_line":"        are required due to magic in the underlying API."},{"line_number":578,"context_line":"        \"\"\""},{"line_number":579,"context_line":"        return"},{"line_number":580,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_3cc1512f","line":577,"updated":"2016-03-08 18:45:03.000000000","message":"Same here, especially if this is the one that is meant to be overridden by a plugin.","commit_id":"3615390ae6bc6770a6b931f5020b079f8b92bdde"}],"heat/engine/stack.py":[{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"6c41268b79231322064e630b96d5f5a2cb30d92d","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                if not ignore_errors:"},{"line_number":426,"context_line":"                    raise"},{"line_number":427,"context_line":"                else:"},{"line_number":428,"context_line":"                    LOG.warning(_(\u0027Ignoring error adding implicit \u0027"},{"line_number":429,"context_line":"                                  \u0027dependencies for %(resource)s: %(err)s\u0027) %"},{"line_number":430,"context_line":"                                {\u0027resource\u0027: six.text_type(res),"},{"line_number":431,"context_line":"                                 \u0027err\u0027: six.text_type(exc)})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_7c2f59f6","line":428,"updated":"2016-03-08 18:45:03.000000000","message":"This should be _LW as per http://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"3615390ae6bc6770a6b931f5020b079f8b92bdde"}]}