)]}'
{"heat/engine/resource.py":[{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"05c35a42c1a5e70eb9ce11d07b93590336981c19","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"            self.needed_by \u003d list(set(v for v in input_data.values()"},{"line_number":1362,"context_line":"                                      if v is not None))"},{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"            if self.current_template_id !\u003d template_id:"},{"line_number":1365,"context_line":"                runner \u003d scheduler.TaskRunner(self.destroy)"},{"line_number":1366,"context_line":"                runner(timeout\u003dtimeout)"},{"line_number":1367,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_39c3faee","line":1364,"updated":"2016-03-09 11:51:51.000000000","message":"Please take care of this in convergence also :)\nIt\u0027s simple, add something like following lines here:\n\ndeletion_policy \u003d None\nif self.replaced_by is not None:\n    deletion_policy \u003d self.t.DELETE\n\nAnd update the task runner to have new argument (on line 1365):\n\nrunner \u003d scheduler.TaskRunner(self.destroy,\n                              deletion_policy\u003ddeletion_policy)\n\nBasically, if this resource has a replaced_by (replaced by something), then this should be deleted.","commit_id":"ec351346bb3e0c0251e8381c79426bc266fb4685"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"ca338c4e83d6e0364de7584dbaf36c41bf82f49c","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"            self.needed_by \u003d list(set(v for v in input_data.values()"},{"line_number":1362,"context_line":"                                      if v is not None))"},{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"            if self.current_template_id !\u003d template_id:"},{"line_number":1365,"context_line":"                runner \u003d scheduler.TaskRunner(self.destroy)"},{"line_number":1366,"context_line":"                runner(timeout\u003dtimeout)"},{"line_number":1367,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_64678e4d","line":1364,"in_reply_to":"5aef4532_39c3faee","updated":"2016-03-09 14:06:59.000000000","message":"Done","commit_id":"ec351346bb3e0c0251e8381c79426bc266fb4685"},{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"05c35a42c1a5e70eb9ce11d07b93590336981c19","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"                deletion_policy \u003d self.t.RETAIN"},{"line_number":1422,"context_line":"            else:"},{"line_number":1423,"context_line":"                deletion_policy \u003d (deletion_policy if deletion_policy"},{"line_number":1424,"context_line":"                                   else self.t.deletion_policy())"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"            if deletion_policy !\u003d self.t.RETAIN:"},{"line_number":1427,"context_line":"                if deletion_policy \u003d\u003d self.t.SNAPSHOT:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_6cf65efa","line":1424,"updated":"2016-03-09 11:51:51.000000000","message":"Can be simplified to \n\ndeletion_policy or self.t.deletion_policy()\n?","commit_id":"ec351346bb3e0c0251e8381c79426bc266fb4685"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"ca338c4e83d6e0364de7584dbaf36c41bf82f49c","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"                deletion_policy \u003d self.t.RETAIN"},{"line_number":1422,"context_line":"            else:"},{"line_number":1423,"context_line":"                deletion_policy \u003d (deletion_policy if deletion_policy"},{"line_number":1424,"context_line":"                                   else self.t.deletion_policy())"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"            if deletion_policy !\u003d self.t.RETAIN:"},{"line_number":1427,"context_line":"                if deletion_policy \u003d\u003d self.t.SNAPSHOT:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_44f1b294","line":1424,"in_reply_to":"5aef4532_6cf65efa","updated":"2016-03-09 14:06:59.000000000","message":"Done","commit_id":"ec351346bb3e0c0251e8381c79426bc266fb4685"}],"heat/engine/update.py":[{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"05c35a42c1a5e70eb9ce11d07b93590336981c19","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if res_name in self.previous_stack:"},{"line_number":200,"context_line":"            yield self._remove_backup_resource("},{"line_number":201,"context_line":"                self.previous_stack[res_name], deletion_policy\u003d\u0027DELETE\u0027)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        if res_name in self.new_stack:"},{"line_number":204,"context_line":"            new_res \u003d self.new_stack[res_name]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_ec18ae77","line":201,"updated":"2016-03-09 11:51:51.000000000","message":"Just to be consistent in using constants instead of their literal values, please use existing_resource.t.DELETE instead of \u0027DELETE\u0027.","commit_id":"ec351346bb3e0c0251e8381c79426bc266fb4685"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"ca338c4e83d6e0364de7584dbaf36c41bf82f49c","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if res_name in self.previous_stack:"},{"line_number":200,"context_line":"            yield self._remove_backup_resource("},{"line_number":201,"context_line":"                self.previous_stack[res_name], deletion_policy\u003d\u0027DELETE\u0027)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        if res_name in self.new_stack:"},{"line_number":204,"context_line":"            new_res \u003d self.new_stack[res_name]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_6432ee60","line":201,"in_reply_to":"5aef4532_ec18ae77","updated":"2016-03-09 14:06:59.000000000","message":"Done","commit_id":"ec351346bb3e0c0251e8381c79426bc266fb4685"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"33f9260dd23970b7140b0d065fb0cd6b825fb7dc","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        if res_name in self.previous_stack:"},{"line_number":200,"context_line":"            yield self._remove_backup_resource("},{"line_number":201,"context_line":"                self.previous_stack[res_name],"},{"line_number":202,"context_line":"                deletion_policy\u003dexisting_res.t.DELETE)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if res_name in self.new_stack:"},{"line_number":205,"context_line":"            new_res \u003d self.new_stack[res_name]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_6e64b448","line":202,"updated":"2016-03-14 18:26:17.000000000","message":"This feels really dangerous to hard code in delete as a policy, especially given that the spec also offers an update_policy flag [1]. IMO, if the user explicitly sets a resource to retain, it shouldn\u0027t be deleted. I\u0027d rather us raise an error telling the user and have docs that explain for an update to temporarily, but explicitly, remove the deletion policy.\n\n[1] http://docs.openstack.org/developer/heat/template_guide/hot_spec.html#resources-section","commit_id":"60eafd0d5598f57447c7a6baca4a4990d945acc3"}]}
