)]}'
{"heat/engine/resources/aws/autoscaling/autoscaling_group.py":[{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"96762b909e6bb2b8a758ea40d3ca8ea99d0200ce","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        done \u003d super(AutoScalingGroup, self).check_update_complete(cookie)"},{"line_number":238,"context_line":"        cooldown \u003d self.properties[self.COOLDOWN]"},{"line_number":239,"context_line":"        if done:"},{"line_number":240,"context_line":"            self._finished_scaling(cooldown,"},{"line_number":241,"context_line":"                                   \"%s : %s\" % (sc_util.CFN_EXACT_CAPACITY,"},{"line_number":242,"context_line":"                                                grouputils.get_size(self)))"},{"line_number":243,"context_line":"        return done"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_473f8ab3","line":240,"range":{"start_line":240,"start_character":12,"end_line":240,"end_character":44},"updated":"2016-04-01 15:29:01.000000000","message":"This can potentially erase some huge cooldown_end that are set by some policy i.e. set older date. We can add a check for such situation, that will set the later time.","commit_id":"3a1b3a0fb99adb9632506c92ef5dbfd4dc05907c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"1c6e5bf8531a4ad57c973c3670f9be0a97f8f9d8","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        done \u003d super(AutoScalingGroup, self).check_update_complete(cookie)"},{"line_number":238,"context_line":"        cooldown \u003d self.properties[self.COOLDOWN]"},{"line_number":239,"context_line":"        if done:"},{"line_number":240,"context_line":"            self._finished_scaling(cooldown,"},{"line_number":241,"context_line":"                                   \"%s : %s\" % (sc_util.CFN_EXACT_CAPACITY,"},{"line_number":242,"context_line":"                                                grouputils.get_size(self)))"},{"line_number":243,"context_line":"        return done"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_e57df36d","line":240,"range":{"start_line":240,"start_character":12,"end_line":240,"end_character":44},"in_reply_to":"ba0121b8_473f8ab3","updated":"2016-04-01 15:50:16.000000000","message":"Not really,  as update is allowed irrespective of the state of the cooldown now, this should be fine. There is no meaning of an earlier cooldown when you\u0027re updating the group.","commit_id":"3a1b3a0fb99adb9632506c92ef5dbfd4dc05907c"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"a4f751c01d7e03a57e1ffad2be089a1de9a1bbc0","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        done \u003d super(AutoScalingGroup, self).check_update_complete(cookie)"},{"line_number":238,"context_line":"        cooldown \u003d self.properties[self.COOLDOWN]"},{"line_number":239,"context_line":"        if done:"},{"line_number":240,"context_line":"            self._finished_scaling(cooldown,"},{"line_number":241,"context_line":"                                   \"%s : %s\" % (sc_util.CFN_EXACT_CAPACITY,"},{"line_number":242,"context_line":"                                                grouputils.get_size(self)))"},{"line_number":243,"context_line":"        return done"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_a5a65bbe","line":240,"range":{"start_line":240,"start_character":12,"end_line":240,"end_character":44},"in_reply_to":"ba0121b8_e57df36d","updated":"2016-04-01 16:01:59.000000000","message":"Yes, you can do update in any time you want, but you *should* not override timestamp with lesser value. Assume you have scaling policy with cooldown 200 and asg with cooldown 0 and then just update min_size. I this case you set cooldown_end \u003d now, so subsequent scaling will be allowed. It is wrong, imho and it\u0027s work differently in current master.","commit_id":"3a1b3a0fb99adb9632506c92ef5dbfd4dc05907c"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"96762b909e6bb2b8a758ea40d3ca8ea99d0200ce","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                         \"as there is no change in capacity.\") % self.name)"},{"line_number":298,"context_line":"            raise exception.NoActionRequired()"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        cooldown \u003d cooldown or self.properties[self.COOLDOWN]"},{"line_number":301,"context_line":"        if not self._is_scaling_allowed(cooldown):"},{"line_number":302,"context_line":"            LOG.info(_LI(\"%(name)s NOT performing scaling adjustment, \""},{"line_number":303,"context_line":"                         \"cooldown %(cooldown)s\") % {"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_b2d50244","line":300,"range":{"start_line":300,"start_character":8,"end_line":300,"end_character":61},"updated":"2016-04-01 15:29:01.000000000","message":"This seems wrong to me. self.cooldown can be greater then cooldown from scaling policy, so we ignore own cooldown.\nBetter to write:\ncooldown \u003d max(cooldown, self.properties[self.COOLDOWN])\nIt seems logical to take into account the biggest, but it is backward incompatible as well as your current implementation.","commit_id":"3a1b3a0fb99adb9632506c92ef5dbfd4dc05907c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"1c6e5bf8531a4ad57c973c3670f9be0a97f8f9d8","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                         \"as there is no change in capacity.\") % self.name)"},{"line_number":298,"context_line":"            raise exception.NoActionRequired()"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        cooldown \u003d cooldown or self.properties[self.COOLDOWN]"},{"line_number":301,"context_line":"        if not self._is_scaling_allowed(cooldown):"},{"line_number":302,"context_line":"            LOG.info(_LI(\"%(name)s NOT performing scaling adjustment, \""},{"line_number":303,"context_line":"                         \"cooldown %(cooldown)s\") % {"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_e5585333","line":300,"range":{"start_line":300,"start_character":8,"end_line":300,"end_character":61},"in_reply_to":"ba0121b8_b2d50244","updated":"2016-04-01 15:50:16.000000000","message":"The assumption here is cooldown set in policy overrides the cooldown set in the scaling group. Check the aws docs on the same.\n\nhttp://docs.aws.amazon.com/AutoScaling/latest/DeveloperGuide/Cooldown.html#cooldowns-scaling-specific","commit_id":"3a1b3a0fb99adb9632506c92ef5dbfd4dc05907c"}]}