)]}'
{"heat/engine/resources/openstack/keystone/project.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f37344bbb6664727389c50e18cc74cd2a482681d","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            description \u003d prop_diff.get(self.DESCRIPTION)"},{"line_number":126,"context_line":"            enabled \u003d prop_diff.get(self.ENABLED)"},{"line_number":127,"context_line":"            domain_id \u003d (prop_diff.get(self.DOMAIN) or"},{"line_number":128,"context_line":"                         self.properties[self.DOMAIN])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            self.client().projects.update("},{"line_number":131,"context_line":"                project\u003dself.resource_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_6723a556","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":54},"updated":"2017-01-24 13:12:31.000000000","message":"This seems incorrect, if \u0027domain\u0027 is removed while updating it would pick the old domain.\n\nI think it would be better to check if the key exists in prop_diff, else use self.properties[self.DOMAIN]","commit_id":"4bf0cd2c3e014e549caa1cae96c2eca276aa31a7"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"d627e93d9d6f9b494a35c5061d33548ba435b674","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            description \u003d prop_diff.get(self.DESCRIPTION)"},{"line_number":126,"context_line":"            enabled \u003d prop_diff.get(self.ENABLED)"},{"line_number":127,"context_line":"            domain_id \u003d (prop_diff.get(self.DOMAIN) or"},{"line_number":128,"context_line":"                         self.properties[self.DOMAIN])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            self.client().projects.update("},{"line_number":131,"context_line":"                project\u003dself.resource_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_ca7b7df3","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":54},"in_reply_to":"5a3905b3_6723a556","updated":"2017-01-24 13:42:12.000000000","message":"think, we can just get prop_diff value, because if you remove domain from properties, it updates with \"default\" domain.","commit_id":"4bf0cd2c3e014e549caa1cae96c2eca276aa31a7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f37344bbb6664727389c50e18cc74cd2a482681d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                domain\u003ddomain_id"},{"line_number":136,"context_line":"            )"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def parse_live_resource_data(self, resource_properties, resource_data):"},{"line_number":139,"context_line":"        return {"},{"line_number":140,"context_line":"            self.NAME: resource_data.get(self.NAME),"},{"line_number":141,"context_line":"            self.DESCRIPTION: resource_data.get(self.DESCRIPTION),"},{"line_number":142,"context_line":"            self.ENABLED: resource_data.get(self.ENABLED),"},{"line_number":143,"context_line":"            self.DOMAIN: resource_data.get(\u0027domain_id\u0027)"},{"line_number":144,"context_line":"        }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"def resource_mapping():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_67056544","line":144,"range":{"start_line":138,"start_character":0,"end_line":144,"end_character":9},"updated":"2017-01-24 13:12:31.000000000","message":"I assume we can avoid implementing for all resources and make it leverage id/name stuff in the translation rule?","commit_id":"4bf0cd2c3e014e549caa1cae96c2eca276aa31a7"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"d627e93d9d6f9b494a35c5061d33548ba435b674","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                domain\u003ddomain_id"},{"line_number":136,"context_line":"            )"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def parse_live_resource_data(self, resource_properties, resource_data):"},{"line_number":139,"context_line":"        return {"},{"line_number":140,"context_line":"            self.NAME: resource_data.get(self.NAME),"},{"line_number":141,"context_line":"            self.DESCRIPTION: resource_data.get(self.DESCRIPTION),"},{"line_number":142,"context_line":"            self.ENABLED: resource_data.get(self.ENABLED),"},{"line_number":143,"context_line":"            self.DOMAIN: resource_data.get(\u0027domain_id\u0027)"},{"line_number":144,"context_line":"        }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"def resource_mapping():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_ea303958","line":144,"range":{"start_line":138,"start_character":0,"end_line":144,"end_character":9},"in_reply_to":"5a3905b3_67056544","updated":"2017-01-24 13:42:12.000000000","message":"Done","commit_id":"4bf0cd2c3e014e549caa1cae96c2eca276aa31a7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"872a797f46437f19545dcd6c895bd9f24eef4b4e","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            description \u003d prop_diff.get(self.DESCRIPTION)"},{"line_number":126,"context_line":"            enabled \u003d prop_diff.get(self.ENABLED)"},{"line_number":127,"context_line":"            domain_id \u003d prop_diff.get(self.DOMAIN)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            self.client().projects.update("},{"line_number":130,"context_line":"                project\u003dself.resource_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_fbdbad4c","line":127,"range":{"start_line":127,"start_character":12,"end_line":127,"end_character":50},"updated":"2017-01-24 14:31:06.000000000","message":"I think this would not work. If there is no change to domain, then domain_id\u003dNone and update would probably change it to default domain which is not desired behaviour.","commit_id":"98bb7fbf268bc5bd7d9a5dacec1f4f4821d03505"},{"author":{"_account_id":13009,"name":"Peter Razumovsky","email":"prazumovsky@mirantis.com","username":"prazumovsky"},"change_message_id":"9fea5ba10bd807f4f8992e69c2a1bbdea65812d2","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            description \u003d prop_diff.get(self.DESCRIPTION)"},{"line_number":126,"context_line":"            enabled \u003d prop_diff.get(self.ENABLED)"},{"line_number":127,"context_line":"            domain_id \u003d prop_diff.get(self.DOMAIN)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            self.client().projects.update("},{"line_number":130,"context_line":"                project\u003dself.resource_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_8e223c00","line":127,"range":{"start_line":127,"start_character":12,"end_line":127,"end_character":50},"in_reply_to":"5a3905b3_d0778c06","updated":"2017-01-25 07:18:42.000000000","message":"Or, sorry, i forgot to write check if domain_id is None. Thanks for the catch.","commit_id":"98bb7fbf268bc5bd7d9a5dacec1f4f4821d03505"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8d05f07dfd72a2bbd04bea28410a91375b246ea6","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            description \u003d prop_diff.get(self.DESCRIPTION)"},{"line_number":126,"context_line":"            enabled \u003d prop_diff.get(self.ENABLED)"},{"line_number":127,"context_line":"            domain_id \u003d prop_diff.get(self.DOMAIN)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            self.client().projects.update("},{"line_number":130,"context_line":"                project\u003dself.resource_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_d0778c06","line":127,"range":{"start_line":127,"start_character":12,"end_line":127,"end_character":50},"in_reply_to":"5a3905b3_fbdbad4c","updated":"2017-01-25 02:50:11.000000000","message":"Probably you can do\n\nprop_diff.get(self.DOMAIN, self.properties[self.DOMAIN])","commit_id":"98bb7fbf268bc5bd7d9a5dacec1f4f4821d03505"}],"heat/tests/openstack/keystone/test_project.py":[{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"436d93ed1f1c20829044b0292518ef892865304a","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            \"domain\": \"default\","},{"line_number":375,"context_line":"            \"name\": \"fake\""},{"line_number":376,"context_line":"        }"},{"line_number":377,"context_line":"        self.assertEqual(set(expected.keys()), set(reality.keys()))"},{"line_number":378,"context_line":"        for key in expected:"},{"line_number":379,"context_line":"            self.assertEqual(expected[key], reality[key])"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_51c1afe3","line":377,"range":{"start_line":377,"start_character":8,"end_line":377,"end_character":67},"updated":"2016-10-11 16:05:15.000000000","message":"just self.assertEqual(expected, reality)","commit_id":"4788ad8a3a0e74c18a7fc974c0a2fd7cf05bb4f2"}]}