)]}'
{"heat/engine/resource.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"40ee9e03729d7d42ca79df0ea97281014ff87149","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"        \"\"\"Method for resolving all attributes."},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"        This method uses basic _resolve_attribute method for resolving"},{"line_number":1854,"context_line":"        specific attributes. Base attributes will be resolved with"},{"line_number":1855,"context_line":"        corresponding method, which should be defined in each resource"},{"line_number":1856,"context_line":"        class."},{"line_number":1857,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_4b70680b","line":1854,"updated":"2016-09-27 12:21:22.000000000","message":"What does this even mean? Does it resolve all attributes or specific attributes? (Clearly the latter, but... ???)","commit_id":"ce5f43f50335752b6dfebd472393e7acc532deb3"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"5d101fdfa316d542741305733e76cdddff312a2d","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"        \"\"\"Method for resolving all attributes."},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"        This method uses basic _resolve_attribute method for resolving"},{"line_number":1854,"context_line":"        specific attributes. Base attributes will be resolved with"},{"line_number":1855,"context_line":"        corresponding method, which should be defined in each resource"},{"line_number":1856,"context_line":"        class."},{"line_number":1857,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_061817d2","line":1854,"in_reply_to":"5a8bc5a2_4b70680b","updated":"2016-09-27 12:34:58.000000000","message":"It\u0027s related to the \"_show_resource\" method.","commit_id":"ce5f43f50335752b6dfebd472393e7acc532deb3"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"40ee9e03729d7d42ca79df0ea97281014ff87149","unresolved":false,"context_lines":[{"line_number":2270,"context_line":"            return False"},{"line_number":2271,"context_line":"        return True"},{"line_number":2272,"context_line":""},{"line_number":2273,"context_line":"    def _make_resolver(self, ref):"},{"line_number":2274,"context_line":"        \"\"\"Return an attribute resolution method."},{"line_number":2275,"context_line":""},{"line_number":2276,"context_line":"        This builds a resolver without a strong reference to this resource, to"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_8b76f003","line":2273,"updated":"2016-09-27 12:21:22.000000000","message":"I think this needs to be a staticmethod, otherwise the closure will still hold a reference to self.","commit_id":"ce5f43f50335752b6dfebd472393e7acc532deb3"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"5d101fdfa316d542741305733e76cdddff312a2d","unresolved":false,"context_lines":[{"line_number":2270,"context_line":"            return False"},{"line_number":2271,"context_line":"        return True"},{"line_number":2272,"context_line":""},{"line_number":2273,"context_line":"    def _make_resolver(self, ref):"},{"line_number":2274,"context_line":"        \"\"\"Return an attribute resolution method."},{"line_number":2275,"context_line":""},{"line_number":2276,"context_line":"        This builds a resolver without a strong reference to this resource, to"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_6629dbe5","line":2273,"in_reply_to":"5a8bc5a2_8b76f003","updated":"2016-09-27 12:34:58.000000000","message":"I don\u0027t think so, but it doesn\u0027t hurt.","commit_id":"ce5f43f50335752b6dfebd472393e7acc532deb3"}]}
