)]}'
{"heat/engine/service.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"14220355d31383df606ddd38fdf9c4ae4bab3c33","unresolved":false,"context_lines":[{"line_number":2377,"context_line":"        stack.state_set(stack.action, stack.FAILED, six.text_type(reason))"},{"line_number":2378,"context_line":""},{"line_number":2379,"context_line":"    @context.request_context"},{"line_number":2380,"context_line":"    def reset_single_stack_status(self, ctxt, stack_id):"},{"line_number":2381,"context_line":"        lock \u003d stack_lock.StackLock(ctxt,"},{"line_number":2382,"context_line":"                                    stack_id,"},{"line_number":2383,"context_line":"                                    self.engine_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_51611ca8","line":2380,"updated":"2016-12-15 23:15:08.000000000","message":"This diff would be *much* easier to review if this method were below reset_stack_status().","commit_id":"0f77bc88f5677db54b88b032426422fc731dfef7"},{"author":{"_account_id":22785,"name":"Tanvir Talukder","email":"tanvirt16@gmail.com","username":"tanvirt16"},"change_message_id":"287434a618bdae619dbd138b946af3ecee2a46cf","unresolved":false,"context_lines":[{"line_number":2377,"context_line":"        stack.state_set(stack.action, stack.FAILED, six.text_type(reason))"},{"line_number":2378,"context_line":""},{"line_number":2379,"context_line":"    @context.request_context"},{"line_number":2380,"context_line":"    def reset_single_stack_status(self, ctxt, stack_id):"},{"line_number":2381,"context_line":"        lock \u003d stack_lock.StackLock(ctxt,"},{"line_number":2382,"context_line":"                                    stack_id,"},{"line_number":2383,"context_line":"                                    self.engine_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_43fdb26c","line":2380,"in_reply_to":"1a6eadb0_51611ca8","updated":"2016-12-16 15:07:13.000000000","message":"Done","commit_id":"0f77bc88f5677db54b88b032426422fc731dfef7"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"14220355d31383df606ddd38fdf9c4ae4bab3c33","unresolved":false,"context_lines":[{"line_number":2396,"context_line":"                stk \u003d parser.Stack.load(ctxt, stack\u003ds,"},{"line_number":2397,"context_line":"                                        service_check_defer\u003dTrue,"},{"line_number":2398,"context_line":"                                        resource_validate\u003dFalse,"},{"line_number":2399,"context_line":"                                        resolve_data\u003dFalse)"},{"line_number":2400,"context_line":"                LOG.info(_LI(\u0027Engine %(engine)s went down when stack \u0027"},{"line_number":2401,"context_line":"                             \u0027%(stack_id)s was in action %(action)s\u0027),"},{"line_number":2402,"context_line":"                         {\u0027engine\u0027: engine_id, \u0027action\u0027: stk.action,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_910e54e3","line":2399,"updated":"2016-12-15 23:15:08.000000000","message":"Good catch.","commit_id":"0f77bc88f5677db54b88b032426422fc731dfef7"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"14220355d31383df606ddd38fdf9c4ae4bab3c33","unresolved":false,"context_lines":[{"line_number":2416,"context_line":"                          % stack_id)"},{"line_number":2417,"context_line":""},{"line_number":2418,"context_line":"    def reset_stack_status(self):"},{"line_number":2419,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":2420,"context_line":"        filters \u003d {"},{"line_number":2421,"context_line":"            \u0027status\u0027: parser.Stack.IN_PROGRESS,"},{"line_number":2422,"context_line":"            \u0027convergence\u0027: False"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_116c049b","line":2419,"updated":"2016-12-15 23:15:08.000000000","message":"cnxt is the standard spelling in this file. Let\u0027s not change it.","commit_id":"0f77bc88f5677db54b88b032426422fc731dfef7"},{"author":{"_account_id":22785,"name":"Tanvir Talukder","email":"tanvirt16@gmail.com","username":"tanvirt16"},"change_message_id":"287434a618bdae619dbd138b946af3ecee2a46cf","unresolved":false,"context_lines":[{"line_number":2416,"context_line":"                          % stack_id)"},{"line_number":2417,"context_line":""},{"line_number":2418,"context_line":"    def reset_stack_status(self):"},{"line_number":2419,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":2420,"context_line":"        filters \u003d {"},{"line_number":2421,"context_line":"            \u0027status\u0027: parser.Stack.IN_PROGRESS,"},{"line_number":2422,"context_line":"            \u0027convergence\u0027: False"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_230a768a","line":2419,"in_reply_to":"1a6eadb0_116c049b","updated":"2016-12-16 15:07:13.000000000","message":"Done","commit_id":"0f77bc88f5677db54b88b032426422fc731dfef7"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"a9dcaa6ee8959593474c538f1bc3bce825e4f19b","unresolved":false,"context_lines":[{"line_number":2365,"context_line":"                LOG.debug(\u0027Service %s was aborted\u0027 % service_ref[\u0027id\u0027])"},{"line_number":2366,"context_line":"                service_objects.Service.delete(cnxt, service_ref[\u0027id\u0027])"},{"line_number":2367,"context_line":""},{"line_number":2368,"context_line":"    def set_stack_and_resource_to_failed(self, stack):"},{"line_number":2369,"context_line":"        for name, rsrc in six.iteritems(stack.resources):"},{"line_number":2370,"context_line":"            if rsrc.status \u003d\u003d rsrc.IN_PROGRESS:"},{"line_number":2371,"context_line":"                status_reason \u003d (\u0027Engine went down \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_b52eaa40","line":2368,"updated":"2016-12-16 22:29:48.000000000","message":"Couldn\u0027t this be a method of stack.Stack? It doesn\u0027t reference self at all. Wouldn\u0027t having it there eliminate the need to call anything over RPC?","commit_id":"2671eb913d125f19b1bd614e8016ab2158c24738"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"a9dcaa6ee8959593474c538f1bc3bce825e4f19b","unresolved":false,"context_lines":[{"line_number":2393,"context_line":"    def reset_single_stack_status(self, cnxt, stack_id):"},{"line_number":2394,"context_line":"        lock \u003d stack_lock.StackLock(cnxt,"},{"line_number":2395,"context_line":"                                    stack_id,"},{"line_number":2396,"context_line":"                                    self.engine_id)"},{"line_number":2397,"context_line":"        engine_id \u003d lock.get_engine_id()"},{"line_number":2398,"context_line":"        try:"},{"line_number":2399,"context_line":"            with lock.thread_lock(retry\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_f55582f9","line":2396,"updated":"2016-12-16 22:29:48.000000000","message":"Gratuitous formatting change.","commit_id":"2671eb913d125f19b1bd614e8016ab2158c24738"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"a9dcaa6ee8959593474c538f1bc3bce825e4f19b","unresolved":false,"context_lines":[{"line_number":2396,"context_line":"                                    self.engine_id)"},{"line_number":2397,"context_line":"        engine_id \u003d lock.get_engine_id()"},{"line_number":2398,"context_line":"        try:"},{"line_number":2399,"context_line":"            with lock.thread_lock(retry\u003dFalse):"},{"line_number":2400,"context_line":""},{"line_number":2401,"context_line":"                # refetch stack and confirm it is still IN_PROGRESS"},{"line_number":2402,"context_line":"                s \u003d stack_object.Stack.get_by_id("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_35161a4c","line":2399,"updated":"2016-12-16 22:29:48.000000000","message":"At the point where we\u0027re calling this (over RPC), we\u0027re still holding the lock in the calling engine, so this will fail.","commit_id":"2671eb913d125f19b1bd614e8016ab2158c24738"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"a9dcaa6ee8959593474c538f1bc3bce825e4f19b","unresolved":false,"context_lines":[{"line_number":2402,"context_line":"                s \u003d stack_object.Stack.get_by_id("},{"line_number":2403,"context_line":"                    cnxt,"},{"line_number":2404,"context_line":"                    stack_id)"},{"line_number":2405,"context_line":"                if s.status !\u003d parser.Stack.IN_PROGRESS:"},{"line_number":2406,"context_line":"                    lock.release()"},{"line_number":2407,"context_line":"                    return"},{"line_number":2408,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_1522fea2","line":2405,"updated":"2016-12-16 22:29:48.000000000","message":"Also, at the point where we call this we\u0027ve just set the stack status to FAILED. So this code will never do anything.","commit_id":"2671eb913d125f19b1bd614e8016ab2158c24738"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"12a21175d83a0ee4dbb0b9455b65efbac59b22d0","unresolved":false,"context_lines":[{"line_number":2429,"context_line":"                             {\u0027engine\u0027: engine_id, \u0027action\u0027: stk.action,"},{"line_number":2430,"context_line":"                              \u0027stack_id\u0027: stk.id})"},{"line_number":2431,"context_line":""},{"line_number":2432,"context_line":"                    reason \u003d (\u0027Engine went down during stack %s\u0027 % stk.action)"},{"line_number":2433,"context_line":""},{"line_number":2434,"context_line":"                    # Set stack and resources status to FAILED in sub thread"},{"line_number":2435,"context_line":"                    self.thread_group_mgr.start_with_acquired_lock("}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_3764ee20","line":2432,"updated":"2017-01-20 18:41:12.000000000","message":"I expect whoever originally wrote this intended for the reason to be localisable, and just forgot the underscore before the opening parenthesis. This would be a convenient time to add it.","commit_id":"87596d0d90fb19025eb2f6f94987ff44494321a5"}],"heat/engine/stack.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"14220355d31383df606ddd38fdf9c4ae4bab3c33","unresolved":false,"context_lines":[{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"        return self._convg_deps"},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"    def reset_status(self):"},{"line_number":1429,"context_line":"        messaging.setup()"},{"line_number":1430,"context_line":"        client \u003d rpc_client.EngineClient()"},{"line_number":1431,"context_line":"        client.reset_single_stack_status(self.context, self.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_91dc9447","line":1428,"updated":"2016-12-15 23:15:08.000000000","message":"Can we call this _send_status_reset() or something?","commit_id":"0f77bc88f5677db54b88b032426422fc731dfef7"},{"author":{"_account_id":22785,"name":"Tanvir Talukder","email":"tanvirt16@gmail.com","username":"tanvirt16"},"change_message_id":"287434a618bdae619dbd138b946af3ecee2a46cf","unresolved":false,"context_lines":[{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"        return self._convg_deps"},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"    def reset_status(self):"},{"line_number":1429,"context_line":"        messaging.setup()"},{"line_number":1430,"context_line":"        client \u003d rpc_client.EngineClient()"},{"line_number":1431,"context_line":"        client.reset_single_stack_status(self.context, self.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_c3f1c296","line":1428,"in_reply_to":"1a6eadb0_91dc9447","updated":"2016-12-16 15:07:13.000000000","message":"Done","commit_id":"0f77bc88f5677db54b88b032426422fc731dfef7"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"14220355d31383df606ddd38fdf9c4ae4bab3c33","unresolved":false,"context_lines":[{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"    def reset_status(self):"},{"line_number":1429,"context_line":"        messaging.setup()"},{"line_number":1430,"context_line":"        client \u003d rpc_client.EngineClient()"},{"line_number":1431,"context_line":"        client.reset_single_stack_status(self.context, self.id)"},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"    @scheduler.wrappertask"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_31fe60ae","line":1430,"updated":"2016-12-15 23:15:08.000000000","message":"It\u0027d be nice to only have to do this stuff once instead of every time we want to reset a stack.","commit_id":"0f77bc88f5677db54b88b032426422fc731dfef7"},{"author":{"_account_id":22785,"name":"Tanvir Talukder","email":"tanvirt16@gmail.com","username":"tanvirt16"},"change_message_id":"287434a618bdae619dbd138b946af3ecee2a46cf","unresolved":false,"context_lines":[{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"    def reset_status(self):"},{"line_number":1429,"context_line":"        messaging.setup()"},{"line_number":1430,"context_line":"        client \u003d rpc_client.EngineClient()"},{"line_number":1431,"context_line":"        client.reset_single_stack_status(self.context, self.id)"},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"    @scheduler.wrappertask"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_e3ecfebc","line":1430,"in_reply_to":"1a6eadb0_31fe60ae","updated":"2016-12-16 15:07:13.000000000","message":"Done","commit_id":"0f77bc88f5677db54b88b032426422fc731dfef7"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"a9dcaa6ee8959593474c538f1bc3bce825e4f19b","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        self.clients \u003d self.context.clients"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        messaging.setup()"},{"line_number":221,"context_line":"        self._rpc_client \u003d rpc_client.EngineClient()"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        # This will use the provided tenant ID when loading the stack"},{"line_number":224,"context_line":"        # from the DB or get it from the context for new stacks."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_8a926df4","line":221,"updated":"2016-12-16 22:29:48.000000000","message":"Do we really need one of these for every stack? Putting this in __init__ is even worse than having it inside reset_status(), since each Stack will have reset_status() called only either 0 or 1 times.\n\nCan\u0027t we just setup messaging once at startup and have a global EngineClient object?","commit_id":"2671eb913d125f19b1bd614e8016ab2158c24738"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"4cd87e6f5430447db88475574b3bd9539ce6be57","unresolved":false,"context_lines":[{"line_number":1435,"context_line":"                               rsrc.FAILED,"},{"line_number":1436,"context_line":"                               six.text_type(status_reason))"},{"line_number":1437,"context_line":"        reason \u003d (\u0027Engine went down during stack %s\u0027 % self.action)"},{"line_number":1438,"context_line":"        self.state_set(self.action, self.FAILED, six.text_type(reason))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    @scheduler.wrappertask"},{"line_number":1441,"context_line":"    def update_task(self, newstack, action\u003dUPDATE, msg_queue\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_77f41087","line":1438,"updated":"2017-01-09 17:27:45.000000000","message":"It might be easier to leave these last two lines out of the method, since we want to call it with a different reason in this case. So just rename this to reset_inprogress_resources or something.","commit_id":"21d79a9ed0def73cb4a6e242133995bc4cf6e080"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"9c7b530a8ebfb6a8fb47fb75d0a319d6478ec180","unresolved":false,"context_lines":[{"line_number":1435,"context_line":"                               rsrc.FAILED,"},{"line_number":1436,"context_line":"                               six.text_type(status_reason))"},{"line_number":1437,"context_line":"        reason \u003d (\u0027Engine went down during stack %s\u0027 % self.action)"},{"line_number":1438,"context_line":"        self.state_set(self.action, self.FAILED, six.text_type(reason))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    @scheduler.wrappertask"},{"line_number":1441,"context_line":"    def update_task(self, newstack, action\u003dUPDATE, msg_queue\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a57fde8_fb7d4de8","line":1438,"in_reply_to":"9a57fde8_4af849e6","updated":"2017-01-12 15:26:50.000000000","message":"Yeah, that\u0027s better than what I said.","commit_id":"21d79a9ed0def73cb4a6e242133995bc4cf6e080"},{"author":{"_account_id":22785,"name":"Tanvir Talukder","email":"tanvirt16@gmail.com","username":"tanvirt16"},"change_message_id":"e06bd1c764fb646ec4346e8d72e83d6fd66382a2","unresolved":false,"context_lines":[{"line_number":1435,"context_line":"                               rsrc.FAILED,"},{"line_number":1436,"context_line":"                               six.text_type(status_reason))"},{"line_number":1437,"context_line":"        reason \u003d (\u0027Engine went down during stack %s\u0027 % self.action)"},{"line_number":1438,"context_line":"        self.state_set(self.action, self.FAILED, six.text_type(reason))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    @scheduler.wrappertask"},{"line_number":1441,"context_line":"    def update_task(self, newstack, action\u003dUPDATE, msg_queue\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a57fde8_4af849e6","line":1438,"in_reply_to":"ba5201f7_77f41087","updated":"2017-01-12 14:30:46.000000000","message":"But since we want service.py to use this, wouldn\u0027t we want the stack and resources statuses to be modified in one function for the thread? How about changing it to reset_stack_and_resources(reason)?","commit_id":"21d79a9ed0def73cb4a6e242133995bc4cf6e080"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"12a21175d83a0ee4dbb0b9455b65efbac59b22d0","unresolved":false,"context_lines":[{"line_number":1454,"context_line":"                LOG.debug(\"Starting update rollback for %s\" % self.name)"},{"line_number":1455,"context_line":"            else:"},{"line_number":1456,"context_line":"                reason \u003d (\u0027Attempted to %s an IN_PROGRESS \u0027"},{"line_number":1457,"context_line":"                          \u0027stack\u0027 % action)"},{"line_number":1458,"context_line":"                self.reset_stack_and_resources_in_progress(reason)"},{"line_number":1459,"context_line":"                return"},{"line_number":1460,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_172c52aa","line":1457,"updated":"2017-01-20 18:41:12.000000000","message":"Would be great to internationalise this too.","commit_id":"87596d0d90fb19025eb2f6f94987ff44494321a5"}]}
