)]}'
{"heat/engine/resource.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"3146e522567f314c51a571af552e2e618dadbe2f","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"        \"\"\"Needs replace based on tmpl_diff.\"\"\""},{"line_number":1067,"context_line":"        return False"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"    def _needs_replace_failed(self):"},{"line_number":1070,"context_line":"        \"\"\"Needs replace if resource is in *_FAILED.\"\"\""},{"line_number":1071,"context_line":"        if self.status \u003d\u003d self.FAILED:"},{"line_number":1072,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_c50401c2","line":1069,"range":{"start_line":1069,"start_character":8,"end_line":1069,"end_character":29},"updated":"2016-11-16 04:23:37.000000000","message":"Please remove the \u0027_\u0027 from method name to be in sync with the existing ones.","commit_id":"b0ce5d7fad46ddbd0686cd38163c6cce569fbfb7"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"f8432c3e08840123b4b6f824592c43364b1dc420","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"        \"\"\"Needs replace based on tmpl_diff.\"\"\""},{"line_number":1067,"context_line":"        return False"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"    def _needs_replace_failed(self):"},{"line_number":1070,"context_line":"        \"\"\"Needs replace if resource is in *_FAILED.\"\"\""},{"line_number":1071,"context_line":"        if self.status \u003d\u003d self.FAILED:"},{"line_number":1072,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_febc2e6e","line":1069,"range":{"start_line":1069,"start_character":8,"end_line":1069,"end_character":29},"in_reply_to":"7a77a97e_c50401c2","updated":"2016-11-16 06:24:50.000000000","message":"Done","commit_id":"b0ce5d7fad46ddbd0686cd38163c6cce569fbfb7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"3146e522567f314c51a571af552e2e618dadbe2f","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"        if self.status \u003d\u003d self.FAILED:"},{"line_number":1072,"context_line":"            return True"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"    def _needs_replace_init(self):"},{"line_number":1075,"context_line":"        \"\"\"Needs replace if resource is in INIT_COMPLETE.\"\"\""},{"line_number":1076,"context_line":"        if self.state \u003d\u003d (self.INIT, self.COMPLETE):"},{"line_number":1077,"context_line":"            return True"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"    def _needs_replace_delete_complete(self):"},{"line_number":1080,"context_line":"        \"\"\"Needs replace if resource is in DELETE_COMPLETE.\"\"\""},{"line_number":1081,"context_line":"        if (self.stack.convergence and"},{"line_number":1082,"context_line":"                (self.action, self.status) \u003d\u003d (self.DELETE, self.COMPLETE)):"},{"line_number":1083,"context_line":"            return True"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def _needs_update(self, after, before, after_props, before_props,"},{"line_number":1086,"context_line":"                      prev_resource, check_init_complete\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_0506f9cd","line":1083,"range":{"start_line":1074,"start_character":0,"end_line":1083,"end_character":23},"updated":"2016-11-16 04:23:37.000000000","message":"Why do we need these interfaces? I don\u0027t see any scenario where they would be overridden?","commit_id":"b0ce5d7fad46ddbd0686cd38163c6cce569fbfb7"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"f8432c3e08840123b4b6f824592c43364b1dc420","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"        if self.status \u003d\u003d self.FAILED:"},{"line_number":1072,"context_line":"            return True"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"    def _needs_replace_init(self):"},{"line_number":1075,"context_line":"        \"\"\"Needs replace if resource is in INIT_COMPLETE.\"\"\""},{"line_number":1076,"context_line":"        if self.state \u003d\u003d (self.INIT, self.COMPLETE):"},{"line_number":1077,"context_line":"            return True"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"    def _needs_replace_delete_complete(self):"},{"line_number":1080,"context_line":"        \"\"\"Needs replace if resource is in DELETE_COMPLETE.\"\"\""},{"line_number":1081,"context_line":"        if (self.stack.convergence and"},{"line_number":1082,"context_line":"                (self.action, self.status) \u003d\u003d (self.DELETE, self.COMPLETE)):"},{"line_number":1083,"context_line":"            return True"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def _needs_update(self, after, before, after_props, before_props,"},{"line_number":1086,"context_line":"                      prev_resource, check_init_complete\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_7e5f3e41","line":1083,"range":{"start_line":1074,"start_character":0,"end_line":1083,"end_character":23},"in_reply_to":"7a77a97e_0506f9cd","updated":"2016-11-16 06:24:50.000000000","message":"My original thought is to abstract the needs_replace_failed() method to allow user to override it instead of replace a resource if it\u0027s in *_FAILED. You can see my patchset1 the example of cinder volume resource.","commit_id":"b0ce5d7fad46ddbd0686cd38163c6cce569fbfb7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f48c9ceb01227b037bdda4818e8113281af4dd83","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"        if self.status \u003d\u003d self.FAILED:"},{"line_number":1072,"context_line":"            return True"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"    def _needs_replace_init(self):"},{"line_number":1075,"context_line":"        \"\"\"Needs replace if resource is in INIT_COMPLETE.\"\"\""},{"line_number":1076,"context_line":"        if self.state \u003d\u003d (self.INIT, self.COMPLETE):"},{"line_number":1077,"context_line":"            return True"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"    def _needs_replace_delete_complete(self):"},{"line_number":1080,"context_line":"        \"\"\"Needs replace if resource is in DELETE_COMPLETE.\"\"\""},{"line_number":1081,"context_line":"        if (self.stack.convergence and"},{"line_number":1082,"context_line":"                (self.action, self.status) \u003d\u003d (self.DELETE, self.COMPLETE)):"},{"line_number":1083,"context_line":"            return True"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def _needs_update(self, after, before, after_props, before_props,"},{"line_number":1086,"context_line":"                      prev_resource, check_init_complete\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_f5a89279","line":1083,"range":{"start_line":1074,"start_character":0,"end_line":1083,"end_character":23},"in_reply_to":"7a77a97e_7e5f3e41","updated":"2016-11-17 03:47:26.000000000","message":"Yeah, I did not comment about needs_replace_failed. My question is about needs_replace_init and needs_replace_delete_complete. I don\u0027t any use of these interfaces atm or in the future.","commit_id":"b0ce5d7fad46ddbd0686cd38163c6cce569fbfb7"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"1504966d90cc3ab1fc2a41b869e3908e85e0c3b6","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"        if self.status \u003d\u003d self.FAILED:"},{"line_number":1072,"context_line":"            return True"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"    def _needs_replace_init(self):"},{"line_number":1075,"context_line":"        \"\"\"Needs replace if resource is in INIT_COMPLETE.\"\"\""},{"line_number":1076,"context_line":"        if self.state \u003d\u003d (self.INIT, self.COMPLETE):"},{"line_number":1077,"context_line":"            return True"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"    def _needs_replace_delete_complete(self):"},{"line_number":1080,"context_line":"        \"\"\"Needs replace if resource is in DELETE_COMPLETE.\"\"\""},{"line_number":1081,"context_line":"        if (self.stack.convergence and"},{"line_number":1082,"context_line":"                (self.action, self.status) \u003d\u003d (self.DELETE, self.COMPLETE)):"},{"line_number":1083,"context_line":"            return True"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def _needs_update(self, after, before, after_props, before_props,"},{"line_number":1086,"context_line":"                      prev_resource, check_init_complete\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_bb4a8b24","line":1083,"range":{"start_line":1074,"start_character":0,"end_line":1083,"end_character":23},"in_reply_to":"7a77a97e_f5a89279","updated":"2016-11-17 04:57:02.000000000","message":"OK, maybe abstract them if needed in the future.","commit_id":"b0ce5d7fad46ddbd0686cd38163c6cce569fbfb7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b1ca668cf0d06a949a6716c86711c1659c3204b6","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"                resource_data.get(\u0027resource_data\u0027),"},{"line_number":1054,"context_line":"                resource_data.get(\u0027metadata\u0027))"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"    def needs_replace_with_after_props(self, after_props):"},{"line_number":1057,"context_line":"        \"\"\"Mandatory replace based on certain properties.\"\"\""},{"line_number":1058,"context_line":"        return False"},{"line_number":1059,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_5b3ac037","line":1056,"range":{"start_line":1056,"start_character":21,"end_line":1056,"end_character":38},"updated":"2016-11-23 13:18:45.000000000","message":"I don\u0027t think we should change this. May be third-party resource plugins would be using it(Though it could be rare).","commit_id":"300c92223df544e4bb4182dda08c5830539cf8fb"}]}
