)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"35cef54179c531c4bd70846b2d69266a1d31b548","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Backported from parts of:"},{"line_number":15,"context_line":" - Ic5c838d406313bca6c36d1106a53ad458dd12aa6"},{"line_number":16,"context_line":" - I83ea2f3f0c417eb9e97abdf27a9eaffd441cb070"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ibb297365d18e087c2af8575461d162f6f2ea1405"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAQn%2F%2FM9E%3D","line":17,"updated":"2013-08-05 15:24:57.000000000","message":"Reference to the bug 1206276 is missing","commit_id":"3a7b0020f43a9b5b88ba7b0753ded8a5f934cbb2"}],"heat/engine/resources/volume.py":[{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"49d9f8304259207f93757da2f015fede2a88bfe7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        if self.properties[\u0027AvailabilityZone\u0027] is not None:"},{"line_number":37,"context_line":"            vol \u003d self.cinder().volumes.create("},{"line_number":38,"context_line":"                self.properties[\u0027Size\u0027],"},{"line_number":39,"context_line":"                availability_zone\u003dself.properties[\u0027AvailabilityZone\u0027],"},{"line_number":40,"context_line":"                display_name\u003dself.physical_resource_name(),"},{"line_number":41,"context_line":"                display_description\u003dself.physical_resource_name())"},{"line_number":42,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FYzg%3D","line":39,"updated":"2013-07-31 23:19:46.000000000","message":"The default going into create is None, so I don\u0027t think we need the if statement.\n https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/volumes.py#L123","commit_id":"7573c2af5b24b236a996157fba5ff4c82be04e02"}],"heat/tests/test_volume.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"046afda3b30f79d8b96075fdac6cd3572eb7fc5e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        # create script"},{"line_number":94,"context_line":"        clients.OpenStackClients.cinder().MultipleTimes().AndReturn(self.fc)"},{"line_number":95,"context_line":"        self.fc.volumes.create("},{"line_number":96,"context_line":"            u\u00271\u0027, availability_zone\u003du\u0027None\u0027,"},{"line_number":97,"context_line":"            display_description\u003d\u0027%s.DataVolume\u0027 % stack_name,"},{"line_number":98,"context_line":"            display_name\u003d\u0027%s.DataVolume\u0027 % stack_name).AndReturn(fv)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FWt0%3D","line":96,"updated":"2013-08-01 14:31:44.000000000","message":"This part is definitely a problem, I think.\n\nHow this is supposed to work is:\n- In the template, the user uses { \"Fn::GetAtt\" : [ \"WikiDatabase\", \"AvailabilityZone\" ]} to grab the AvailabilityZone attribute of the Instance.\n- The AvailabilityZone property of the Instance is optional, so since it is not set it should return None.\n- However, it looks like at some point in the chain, None is being converted into a string u\u0027None\u0027.\n\nSo this could break existing users templates where the AZ isn\u0027t specified (which will be almost all of them). Instead of creating the volume in the default AZ, it will try to create it in the non-existent AZ \u0027None\u0027.","commit_id":"0d9c857865ccecbe739aab2c342c18281d620595"}]}