)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"377d4c6cdd2530aa8bcd6266ecfa9929bf2d1f62","unresolved":false,"context_lines":[{"line_number":10,"context_line":"that allow triggering observe on reality. This will be"},{"line_number":11,"context_line":"triggered by API call with converge argument (with True"},{"line_number":12,"context_line":"or False value) within. This flag also works for resources"},{"line_number":13,"context_line":"within nested stack. This only works for convergence stack."},{"line_number":14,"context_line":"implements bp get-reality-for-resources"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I151b575b714dcc9a5971a1573c126152ecd7ea93"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df3967d1_1752e5de","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":58},"updated":"2017-08-07 04:29:24.000000000","message":"Now this is not correct I suppose.","commit_id":"df9b122201c412375745ffaa75d9fc7760eb016c"}],"api-ref/source/v1/stacks.inc":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"65ad442f5a994d5bff38af7a04089aa8a483eb7d","unresolved":false,"context_lines":[{"line_number":506,"context_line":"   - tags: tags"},{"line_number":507,"context_line":"   - template: template"},{"line_number":508,"context_line":"   - template_url: template_url"},{"line_number":509,"context_line":"   - timeout_mins: timeout_mins"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"Request Example"},{"line_number":512,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"ff346bd7_1d15ad9c","line":509,"range":{"start_line":509,"start_character":2,"end_line":509,"end_character":31},"updated":"2017-07-26 08:02:11.000000000","message":"Seems we support the parameter \u0027converge\u0027 for this API?","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"312cb1d8de1ce73624b6107287d30c8dc809e82f","unresolved":false,"context_lines":[{"line_number":506,"context_line":"   - tags: tags"},{"line_number":507,"context_line":"   - template: template"},{"line_number":508,"context_line":"   - template_url: template_url"},{"line_number":509,"context_line":"   - timeout_mins: timeout_mins"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"Request Example"},{"line_number":512,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"ff346bd7_707b97f4","line":509,"range":{"start_line":509,"start_character":2,"end_line":509,"end_character":31},"in_reply_to":"ff346bd7_1d15ad9c","updated":"2017-07-27 18:38:39.000000000","message":"Done","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"65ad442f5a994d5bff38af7a04089aa8a483eb7d","unresolved":false,"context_lines":[{"line_number":576,"context_line":"   - tags: tags"},{"line_number":577,"context_line":"   - template: template"},{"line_number":578,"context_line":"   - template_url: template_url"},{"line_number":579,"context_line":"   - timeout_mins: timeout_mins"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"Request Example"},{"line_number":582,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"ff346bd7_1d7a4df0","line":579,"range":{"start_line":579,"start_character":3,"end_line":579,"end_character":31},"updated":"2017-07-26 08:02:11.000000000","message":"Same","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"312cb1d8de1ce73624b6107287d30c8dc809e82f","unresolved":false,"context_lines":[{"line_number":576,"context_line":"   - tags: tags"},{"line_number":577,"context_line":"   - template: template"},{"line_number":578,"context_line":"   - template_url: template_url"},{"line_number":579,"context_line":"   - timeout_mins: timeout_mins"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"Request Example"},{"line_number":582,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"ff346bd7_10868bdc","line":579,"range":{"start_line":579,"start_character":3,"end_line":579,"end_character":31},"in_reply_to":"ff346bd7_1d7a4df0","updated":"2017-07-27 18:38:39.000000000","message":"Done","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"}],"heat/api/openstack/v1/stacks.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d31902b0180a15da35229c1d60856f5bf8ac19fa","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \u0027environment\u0027,"},{"line_number":60,"context_line":"        \u0027files\u0027,"},{"line_number":61,"context_line":"        \u0027environment_files\u0027,"},{"line_number":62,"context_line":"        \u0027converge\u0027,"},{"line_number":63,"context_line":"    )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, data, patch\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_91bec0d2","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":19},"updated":"2017-07-07 07:12:14.000000000","message":"Is there any reason to add to InstatiationData?","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"206edcafca5d8885033d67a1e9f58c2e73966066","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \u0027environment\u0027,"},{"line_number":60,"context_line":"        \u0027files\u0027,"},{"line_number":61,"context_line":"        \u0027environment_files\u0027,"},{"line_number":62,"context_line":"        \u0027converge\u0027,"},{"line_number":63,"context_line":"    )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, data, patch\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_8262edac","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":19},"in_reply_to":"3f1d235d_91bec0d2","updated":"2017-07-07 09:13:12.000000000","message":"same reason below","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d31902b0180a15da35229c1d60856f5bf8ac19fa","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    def environment_files(self):"},{"line_number":160,"context_line":"        return self.data.get(self.PARAM_ENVIRONMENT_FILES, None)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def converge(self):"},{"line_number":163,"context_line":"        return param_utils.extract_bool("},{"line_number":164,"context_line":"            self.PARAM_CONVERGE, self.data.get(self.PARAM_CONVERGE, False))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def args(self):"},{"line_number":167,"context_line":"        \"\"\"Get any additional arguments supplied by the user.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_515828f8","line":164,"range":{"start_line":162,"start_character":0,"end_line":164,"end_character":75},"updated":"2017-07-07 07:12:14.000000000","message":"Do we need this? It can be part of args below and then we can  extract it using extract_args[1]\n\n[1] https://github.com/openstack/heat/blob/master/heat/engine/api.py#L30","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"206edcafca5d8885033d67a1e9f58c2e73966066","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    def environment_files(self):"},{"line_number":160,"context_line":"        return self.data.get(self.PARAM_ENVIRONMENT_FILES, None)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def converge(self):"},{"line_number":163,"context_line":"        return param_utils.extract_bool("},{"line_number":164,"context_line":"            self.PARAM_CONVERGE, self.data.get(self.PARAM_CONVERGE, False))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def args(self):"},{"line_number":167,"context_line":"        \"\"\"Get any additional arguments supplied by the user.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_a2df2964","line":164,"range":{"start_line":162,"start_character":0,"end_line":164,"end_character":75},"in_reply_to":"3f1d235d_515828f8","updated":"2017-07-07 09:13:12.000000000","message":"Rabi that\u0027s the design in the previous patch:) to put it in args which will not be limited as update stack only parameter(unless we pop it out for all others), so if we have to make it update only, I think here will be a better place","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e864b15ab44ff751c68121cc7b79b53fc4f2916c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    def environment_files(self):"},{"line_number":160,"context_line":"        return self.data.get(self.PARAM_ENVIRONMENT_FILES, None)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def converge(self):"},{"line_number":163,"context_line":"        return param_utils.extract_bool("},{"line_number":164,"context_line":"            self.PARAM_CONVERGE, self.data.get(self.PARAM_CONVERGE, False))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def args(self):"},{"line_number":167,"context_line":"        \"\"\"Get any additional arguments supplied by the user.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_18b76cf7","line":164,"range":{"start_line":162,"start_character":0,"end_line":164,"end_character":75},"in_reply_to":"3f1d235d_a2df2964","updated":"2017-07-07 10:29:52.000000000","message":"Sorry for the confusion, I did not read it carefully.\n\nCan it not be in \u0027data.args()? You can possibly modify \u0027prepare_args[1] with a flag to include this in \u0027args\u0027 for update related rpc calls and then add it explicitly after adding \u0027common_params\u0027 to \u0027cuurent_kwargs\u0027[1]?\n\n\nIt looks little odd to me to include a flag in InstantiationData PARAMS though.\n\n[1] https://github.com/openstack/heat/blob/master/heat/api/openstack/v1/stacks.py#L377\n\n[2] https://github.com/openstack/heat/blob/master/heat/engine/service.py#L946","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"65ad442f5a994d5bff38af7a04089aa8a483eb7d","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            args[key] \u003d self._extract_tags_param(args[key])"},{"line_number":385,"context_line":"        key \u003d rpc_api.PARAM_CONVERGE"},{"line_number":386,"context_line":"        if not is_update and key in args:"},{"line_number":387,"context_line":"            del args[key]"},{"line_number":388,"context_line":"        return args"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    @util.policy_enforce"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_1d96cdf1","line":387,"range":{"start_line":387,"start_character":12,"end_line":387,"end_character":25},"updated":"2017-07-26 08:02:11.000000000","message":"Should we raise error if there is an unexpected arg in API?","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"312cb1d8de1ce73624b6107287d30c8dc809e82f","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            args[key] \u003d self._extract_tags_param(args[key])"},{"line_number":385,"context_line":"        key \u003d rpc_api.PARAM_CONVERGE"},{"line_number":386,"context_line":"        if not is_update and key in args:"},{"line_number":387,"context_line":"            del args[key]"},{"line_number":388,"context_line":"        return args"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    @util.policy_enforce"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_30398ff1","line":387,"range":{"start_line":387,"start_character":12,"end_line":387,"end_character":25},"in_reply_to":"ff346bd7_1d96cdf1","updated":"2017-07-27 18:38:39.000000000","message":"Done","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"}],"heat/engine/api.py":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"65ad442f5a994d5bff38af7a04089aa8a483eb7d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            bool_value \u003d param_utils.extract_bool(name, params[name])"},{"line_number":52,"context_line":"            kwargs[name] \u003d bool_value"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    name \u003d rpc_api.PARAM_SHOW_DELETED"},{"line_number":55,"context_line":"    if name in params:"},{"line_number":56,"context_line":"        params[name] \u003d param_utils.extract_bool(name, params[name])"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_48ac9133","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":37},"updated":"2017-07-26 08:02:11.000000000","message":"Not related: will be good to move this boolean param checking to line49.","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"312cb1d8de1ce73624b6107287d30c8dc809e82f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            bool_value \u003d param_utils.extract_bool(name, params[name])"},{"line_number":52,"context_line":"            kwargs[name] \u003d bool_value"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    name \u003d rpc_api.PARAM_SHOW_DELETED"},{"line_number":55,"context_line":"    if name in params:"},{"line_number":56,"context_line":"        params[name] \u003d param_utils.extract_bool(name, params[name])"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_0b5adc28","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":37},"in_reply_to":"ff346bd7_48ac9133","updated":"2017-07-27 18:38:39.000000000","message":"this value actually goes back to params not kwargs, so can\u0027t adding in to above for loop.\nAnd actually I think we don\u0027t need this here [1].\n\n[1] https://review.openstack.org/487712","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"}],"heat/engine/resource.py":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"65ad442f5a994d5bff38af7a04089aa8a483eb7d","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"        self.translate_properties(after_props)"},{"line_number":1380,"context_line":"        self.translate_properties(before_props)"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"        if (cfg.CONF.observe_on_update or self.converge) and before_props:"},{"line_number":1383,"context_line":"            if not self.resource_id:"},{"line_number":1384,"context_line":"                raise UpdateReplace(self)"},{"line_number":1385,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_63f53683","line":1382,"range":{"start_line":1382,"start_character":8,"end_line":1382,"end_character":56},"updated":"2017-07-26 08:02:11.000000000","message":"So for legacy, we keep the ability using config option \u0027observe_on_update\u0027? Or we will remove the config option later? Once we implemented getting reality for resources, user hope to use it even if in legacy.","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"312cb1d8de1ce73624b6107287d30c8dc809e82f","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"        self.translate_properties(after_props)"},{"line_number":1380,"context_line":"        self.translate_properties(before_props)"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"        if (cfg.CONF.observe_on_update or self.converge) and before_props:"},{"line_number":1383,"context_line":"            if not self.resource_id:"},{"line_number":1384,"context_line":"                raise UpdateReplace(self)"},{"line_number":1385,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_dccdbc66","line":1382,"range":{"start_line":1382,"start_character":8,"end_line":1382,"end_character":56},"in_reply_to":"ff346bd7_31777505","updated":"2017-07-27 18:38:39.000000000","message":"yep, we should open it for legacy:) and we only deprecate the `observe_on_update` config after converge landed.\nWe can discuss what we want to do with `converge`, we can always change the type once we try to put more in, but right now, I think a flag will do.","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"42a3a08df0537b6a9de2464defaf9e1f75d369c5","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"        self.translate_properties(after_props)"},{"line_number":1380,"context_line":"        self.translate_properties(before_props)"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"        if (cfg.CONF.observe_on_update or self.converge) and before_props:"},{"line_number":1383,"context_line":"            if not self.resource_id:"},{"line_number":1384,"context_line":"                raise UpdateReplace(self)"},{"line_number":1385,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_31777505","line":1382,"range":{"start_line":1382,"start_character":8,"end_line":1382,"end_character":56},"in_reply_to":"ff346bd7_63f53683","updated":"2017-07-26 10:44:02.000000000","message":"Yeah I was also wondering why this has to be only limited to convergence, other than the fact we just use \u0027converge\u0027 as the flag?\n\nI\u0027m not sure if we would ever go to convergence 2.x (converging stacks without user issuing an update)","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"}],"heat/engine/service.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d31902b0180a15da35229c1d60856f5bf8ac19fa","unresolved":false,"context_lines":[{"line_number":941,"context_line":""},{"line_number":942,"context_line":"        common_params \u003d api.extract_args(args)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        common_params.setdefault(stack_api.InstantiationData.PARAM_CONVERGE,"},{"line_number":945,"context_line":"                                 converge)"},{"line_number":946,"context_line":"        common_params.setdefault(rpc_api.PARAM_TIMEOUT,"},{"line_number":947,"context_line":"                                 current_stack.timeout_mins)"},{"line_number":948,"context_line":"        common_params.setdefault(rpc_api.PARAM_DISABLE_ROLLBACK,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_1124f05c","line":945,"range":{"start_line":944,"start_character":0,"end_line":945,"end_character":42},"updated":"2017-07-07 07:12:14.000000000","message":"I don\u0027t think you would need this. you change extract_args to set it in common_params.","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"206edcafca5d8885033d67a1e9f58c2e73966066","unresolved":false,"context_lines":[{"line_number":941,"context_line":""},{"line_number":942,"context_line":"        common_params \u003d api.extract_args(args)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        common_params.setdefault(stack_api.InstantiationData.PARAM_CONVERGE,"},{"line_number":945,"context_line":"                                 converge)"},{"line_number":946,"context_line":"        common_params.setdefault(rpc_api.PARAM_TIMEOUT,"},{"line_number":947,"context_line":"                                 current_stack.timeout_mins)"},{"line_number":948,"context_line":"        common_params.setdefault(rpc_api.PARAM_DISABLE_ROLLBACK,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_42dbb54d","line":945,"range":{"start_line":944,"start_character":0,"end_line":945,"end_character":42},"in_reply_to":"3f1d235d_1124f05c","updated":"2017-07-07 09:13:12.000000000","message":"same reason as in https://review.openstack.org/#/c/461302/7/heat/api/openstack/v1/stacks.py","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"42a3a08df0537b6a9de2464defaf9e1f75d369c5","unresolved":false,"context_lines":[{"line_number":939,"context_line":"                                 current_stack.timeout_mins)"},{"line_number":940,"context_line":"        common_params.setdefault(rpc_api.PARAM_DISABLE_ROLLBACK,"},{"line_number":941,"context_line":"                                 current_stack.disable_rollback)"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"        current_kwargs.update(common_params)"},{"line_number":944,"context_line":"        updated_stack \u003d parser.Stack(cnxt, stack_name, tmpl,"},{"line_number":945,"context_line":"                                     **current_kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_97285ce2","line":942,"updated":"2017-07-26 10:44:02.000000000","message":"I think you probably have to use from current_stack for patch update.\n\ncommon_params.setdefault(rpc_api.PARAM_CONVERGE,\n                         current_stack.converge)","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"312cb1d8de1ce73624b6107287d30c8dc809e82f","unresolved":false,"context_lines":[{"line_number":939,"context_line":"                                 current_stack.timeout_mins)"},{"line_number":940,"context_line":"        common_params.setdefault(rpc_api.PARAM_DISABLE_ROLLBACK,"},{"line_number":941,"context_line":"                                 current_stack.disable_rollback)"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"        current_kwargs.update(common_params)"},{"line_number":944,"context_line":"        updated_stack \u003d parser.Stack(cnxt, stack_name, tmpl,"},{"line_number":945,"context_line":"                                     **current_kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_5c7b0cf4","line":942,"in_reply_to":"ff346bd7_97285ce2","updated":"2017-07-27 18:38:39.000000000","message":"Done","commit_id":"a6a02fb27373819109cb2e94bef2c661f6fe36a7"}],"heat/engine/stack.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d31902b0180a15da35229c1d60856f5bf8ac19fa","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self._worker_client \u003d None"},{"line_number":184,"context_line":"        self._convg_deps \u003d None"},{"line_number":185,"context_line":"        self.thread_group_mgr \u003d None"},{"line_number":186,"context_line":"        self.converge \u003d converge"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # strict_validate can be used to disable value validation"},{"line_number":189,"context_line":"        # in the resource properties schema, this is useful when"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_f7c84455","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":32},"updated":"2017-07-07 07:12:14.000000000","message":"I would probably liked not to keep it in stack/resource as it\u0027s specific to only convergence. But not sure if there is a better way to do it.\n\nIf it\u0027s there for legacy, it would be ignored, which is ok for me.","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"206edcafca5d8885033d67a1e9f58c2e73966066","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self._worker_client \u003d None"},{"line_number":184,"context_line":"        self._convg_deps \u003d None"},{"line_number":185,"context_line":"        self.thread_group_mgr \u003d None"},{"line_number":186,"context_line":"        self.converge \u003d converge"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # strict_validate can be used to disable value validation"},{"line_number":189,"context_line":"        # in the resource properties schema, this is useful when"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_4226156a","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":32},"in_reply_to":"3f1d235d_f7c84455","updated":"2017-07-07 09:13:12.000000000","message":"yep, to put it in init is for both nested or not.","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"}],"heat/tests/test_stack_resource.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d31902b0180a15da35229c1d60856f5bf8ac19fa","unresolved":false,"context_lines":[{"line_number":931,"context_line":"        rpcc.return_value._create_stack.assert_called_once_with("},{"line_number":932,"context_line":"            self.ctx,"},{"line_number":933,"context_line":"            stack_name\u003dres_name,"},{"line_number":934,"context_line":"            args\u003d{rpc_api.PARAM_DISABLE_ROLLBACK: True,"},{"line_number":935,"context_line":"                  rpc_api.PARAM_ADOPT_STACK_DATA: adopt_data_str,"},{"line_number":936,"context_line":"                  rpc_api.PARAM_TIMEOUT: self.timeout_mins},"},{"line_number":937,"context_line":"            environment_files\u003dNone,"},{"line_number":938,"context_line":"            stack_user_project_id\u003d\u0027aprojectid\u0027,"},{"line_number":939,"context_line":"            parent_resource_name\u003d\u0027test\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_770b148d","line":936,"range":{"start_line":934,"start_character":0,"end_line":936,"end_character":60},"updated":"2017-07-07 07:12:14.000000000","message":"These are not related to this change;)","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"206edcafca5d8885033d67a1e9f58c2e73966066","unresolved":false,"context_lines":[{"line_number":931,"context_line":"        rpcc.return_value._create_stack.assert_called_once_with("},{"line_number":932,"context_line":"            self.ctx,"},{"line_number":933,"context_line":"            stack_name\u003dres_name,"},{"line_number":934,"context_line":"            args\u003d{rpc_api.PARAM_DISABLE_ROLLBACK: True,"},{"line_number":935,"context_line":"                  rpc_api.PARAM_ADOPT_STACK_DATA: adopt_data_str,"},{"line_number":936,"context_line":"                  rpc_api.PARAM_TIMEOUT: self.timeout_mins},"},{"line_number":937,"context_line":"            environment_files\u003dNone,"},{"line_number":938,"context_line":"            stack_user_project_id\u003d\u0027aprojectid\u0027,"},{"line_number":939,"context_line":"            parent_resource_name\u003d\u0027test\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_42a9758d","line":936,"range":{"start_line":934,"start_character":0,"end_line":936,"end_character":60},"in_reply_to":"3f1d235d_770b148d","updated":"2017-07-07 09:13:12.000000000","message":"Yep, I can change it back if that\u0027s not a good way to do it:)","commit_id":"2196eec899490a9710a9bb3a295023d11e125536"}],"releasenotes/notes/converge-flag-for-stack-update-e0e92a7fe232f10f.yaml":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"5f6e451fa743e2b217f4c0df9c63416e5aa0a53d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add `converge` argument for stack update API and `--converge` for CLI,"},{"line_number":4,"context_line":"    this argument will force resources to observe the reality of resources"},{"line_number":5,"context_line":"    before actually update it. This only works with convergence."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f044301_d252c667","line":3,"range":{"start_line":3,"start_character":49,"end_line":3,"end_character":73},"updated":"2017-05-05 03:39:31.000000000","message":"maybe we should add this to heatclient\u0027s releasenote","commit_id":"2d6bd219273e5c2485879a0356faa0107f31b0fc"}]}