)]}'
{"heat/common/config.py":[{"author":{"_account_id":6800,"name":"Christopher Armstrong","email":"chris.armstrong@rackspace.com","username":"radix"},"change_message_id":"c84f413b9a020f017134ae0c97ed6ea64cee23fa","unresolved":false,"context_lines":[{"line_number":103,"context_line":"               help\u003d\u0027Maximum resources allowed per top-level stack.\u0027),"},{"line_number":104,"context_line":"    cfg.IntOpt(\u0027event_purge_batch_size\u0027,"},{"line_number":105,"context_line":"               default\u003d10,"},{"line_number":106,"context_line":"               help\u003d\u0027Controls how many events will be pruned whenever a \u0027"},{"line_number":107,"context_line":"                    \u0027 stack\\\u0027s events exceed max_events_per_stack. Set this\u0027"},{"line_number":108,"context_line":"                    \u0027 lower to keep more events at the expense of more\u0027"},{"line_number":109,"context_line":"                    \u0027 frequent purges.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FfFo%3D","line":106,"updated":"2013-09-25 21:50:20.000000000","message":"I see other help strings using _(). If that\u0027s the way we should do it then new ones should too.","commit_id":"7b4dde58af5f96543a621b1603938e3e1f4b81b2"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"0635dbb664ea1bcdf8e457b61aa86a459abbd55b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"               help\u003d\u0027Maximum resources allowed per top-level stack.\u0027),"},{"line_number":104,"context_line":"    cfg.IntOpt(\u0027event_purge_batch_size\u0027,"},{"line_number":105,"context_line":"               default\u003d10,"},{"line_number":106,"context_line":"               help\u003d\u0027Controls how many events will be pruned whenever a \u0027"},{"line_number":107,"context_line":"                    \u0027 stack\\\u0027s events exceed max_events_per_stack. Set this\u0027"},{"line_number":108,"context_line":"                    \u0027 lower to keep more events at the expense of more\u0027"},{"line_number":109,"context_line":"                    \u0027 frequent purges.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FcAY%3D","line":106,"in_reply_to":"AAAAS3%2F%2FfFo%3D","updated":"2013-09-26 17:04:14.000000000","message":"Done","commit_id":"7b4dde58af5f96543a621b1603938e3e1f4b81b2"}],"heat/db/sqlalchemy/api.py":[{"author":{"_account_id":6800,"name":"Christopher Armstrong","email":"chris.armstrong@rackspace.com","username":"radix"},"change_message_id":"c84f413b9a020f017134ae0c97ed6ea64cee23fa","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    # sqlite does not support JOIN in DELETE."},{"line_number":348,"context_line":"    # So we must manually supply the IN() values."},{"line_number":349,"context_line":"    # pgsql SHOULD work with the pure DELETE/JOIN below but that must be"},{"line_number":350,"context_line":"    # confirmed via integration tests."},{"line_number":351,"context_line":"    query \u003d _query_all_by_stack(context, stack_id)"},{"line_number":352,"context_line":"    session \u003d _session(context)"},{"line_number":353,"context_line":"    if \u0027postgres\u0027 not in session.connection().dialect.name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FfE4%3D","line":350,"updated":"2013-09-25 21:50:20.000000000","message":"I don\u0027t think I understand this.\n\nNow that the gate tests have run, has this behavior been confirmed? should this comment be deleted?","commit_id":"7b4dde58af5f96543a621b1603938e3e1f4b81b2"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"0635dbb664ea1bcdf8e457b61aa86a459abbd55b","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    # sqlite does not support JOIN in DELETE."},{"line_number":348,"context_line":"    # So we must manually supply the IN() values."},{"line_number":349,"context_line":"    # pgsql SHOULD work with the pure DELETE/JOIN below but that must be"},{"line_number":350,"context_line":"    # confirmed via integration tests."},{"line_number":351,"context_line":"    query \u003d _query_all_by_stack(context, stack_id)"},{"line_number":352,"context_line":"    session \u003d _session(context)"},{"line_number":353,"context_line":"    if \u0027postgres\u0027 not in session.connection().dialect.name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FeZs%3D","line":350,"in_reply_to":"AAAAS3%2F%2FfE4%3D","updated":"2013-09-26 17:04:14.000000000","message":"Unfortunately no, the gate won\u0027t hit this until a tempest test is added that creates more events than this configuration item.\n\nI plan to handle it like we did with the template size limit. Set devstack\u0027s limit lower, then have tempest default to the devstack limit.","commit_id":"7b4dde58af5f96543a621b1603938e3e1f4b81b2"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"70a4bd3a0c357b93642de649d4a7028310c009b8","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                stack_id\u003dstack_id).order_by("},{"line_number":362,"context_line":"                    models.Event.id).limit(limit).subquery()"},{"line_number":363,"context_line":"        q \u003d query.join(stmt, models.Event.id \u003d\u003d stmt.c.id)"},{"line_number":364,"context_line":"    return q.delete(synchronize_session\u003d\u0027fetch\u0027)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"def event_create(context, values):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FaBk%3D","line":364,"updated":"2013-09-27 10:12:02.000000000","message":"Not sure if we need to perform a select query before the delete. Some deleted event objects present in the session seems not a bad thing, and that would not cause much memory consumption as those objects are weakly referenced.","commit_id":"32260776443fd5d6cbb8dd2af3fd4c2fea2c1a6d"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"6110cc4c9534982ee3247f8007d3efc85ffaa287","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                stack_id\u003dstack_id).order_by("},{"line_number":362,"context_line":"                    models.Event.id).limit(limit).subquery()"},{"line_number":363,"context_line":"        q \u003d query.join(stmt, models.Event.id \u003d\u003d stmt.c.id)"},{"line_number":364,"context_line":"    return q.delete(synchronize_session\u003d\u0027fetch\u0027)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"def event_create(context, values):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FZZs%3D","line":364,"in_reply_to":"AAAAS3%2F%2FaBk%3D","updated":"2013-09-27 14:59:23.000000000","message":"I think I am taking the safer approach with fetch. I agree, I think we can probably optimize it away. Given that it is a select by primary key I think we\u0027ll find we have other areas to focus optimization on.","commit_id":"32260776443fd5d6cbb8dd2af3fd4c2fea2c1a6d"}]}