)]}'
{"heat/engine/clients/os/monasca.py":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"e7729c4624c7f2edc3e64adc65401f3e24277bdf","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return isinstance(ex, monasca_exc.NotFound)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def is_un_processable(self, ex):"},{"line_number":49,"context_line":"        return isinstance(ex, monasca_exc.UnprocessableEntity)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_notification(self, notification):"},{"line_number":52,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_f52ae229","line":49,"range":{"start_line":49,"start_character":30,"end_line":49,"end_character":62},"updated":"2017-08-03 06:27:22.000000000","message":"monascaclient changes the exception in 1.7.0?\nSo we should bump up the monascaclient to 1.7.0?","commit_id":"c988e947191b2e7c798d0e2851a69067efa70979"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"677ce74278484c8da40dab1970997327d12a9fdc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return isinstance(ex, monasca_exc.NotFound)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def is_un_processable(self, ex):"},{"line_number":49,"context_line":"        return isinstance(ex, monasca_exc.UnprocessableEntity)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_notification(self, notification):"},{"line_number":52,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_466a0fed","line":49,"range":{"start_line":49,"start_character":30,"end_line":49,"end_character":62},"in_reply_to":"df3967d1_15fe866a","updated":"2017-08-03 17:25:33.000000000","message":"you could write something like\ntry:\n    exc_type \u003d monasca_exc.HTTPUnProcessable\nexception AttributeError:\n    exc_type \u003d monasca_exc.UnprocessableEntity\nreturn isinstance(ex, getattr(monasca_exc, exc_type)\n\nSo we can make sure it works for both version\nAlso make sure you put a TODO here so others can understand when we can throw out this logic","commit_id":"c988e947191b2e7c798d0e2851a69067efa70979"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"0a204a622173cedbc124505cb5ec44a9a0a68d71","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return isinstance(ex, monasca_exc.NotFound)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def is_un_processable(self, ex):"},{"line_number":49,"context_line":"        return isinstance(ex, monasca_exc.UnprocessableEntity)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_notification(self, notification):"},{"line_number":52,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_15fe866a","line":49,"range":{"start_line":49,"start_character":30,"end_line":49,"end_character":62},"in_reply_to":"df3967d1_f52ae229","updated":"2017-08-03 06:39:54.000000000","message":"yes, osc lib was introduced and the old exception is gone. The client you have that is installed is 1.7.0 at the moment, but prior to updating the version in constraints we want to ensure that nothing will break. That\u0027s the background of this change. Once we have this one merged we will proceed with openstack/requirements change.","commit_id":"c988e947191b2e7c798d0e2851a69067efa70979"}]}
