)]}'
{"heat/engine/resources/random_string.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"7ba40054071dc235e72cff84a8af5eb6edfe4697","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from heat.engine import resource"},{"line_number":18,"context_line":"from heat.engine import properties"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import random"},{"line_number":21,"context_line":"import string"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F1%2FE%3D","line":20,"updated":"2013-10-09 03:58:06.000000000","message":"Knee jerk reaction is \"this is pseudo-random!\".\n\nRisk: tenant1 wants to guess the passwords that tenant2 is using for their SSH service. tenant1 starts generating many random password resources, looking for the psuedo-random pattern and trying to find the seed.\n\nGiven the tiny amount of randomness needed for even thousands of passwords, perhaps we can use os.urandom instead? I\u0027m on the fence with this though, it is just a thought.","commit_id":"1b0a05ce3f4c60e3835609229d6601018adc0b56"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"653a578fac93ced1560054a6cfd1b0bf0b0becea","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from heat.engine import resource"},{"line_number":18,"context_line":"from heat.engine import properties"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import random"},{"line_number":21,"context_line":"import string"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F148%3D","line":20,"in_reply_to":"AAAATH%2F%2F1%2FE%3D","updated":"2013-10-09 19:10:29.000000000","message":"Done","commit_id":"1b0a05ce3f4c60e3835609229d6601018adc0b56"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"7ba40054071dc235e72cff84a8af5eb6edfe4697","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class RandomString(resource.Resource):"},{"line_number":25,"context_line":"    \u0027\u0027\u0027"},{"line_number":26,"context_line":"    A resource which generates a random string."},{"line_number":27,"context_line":"    "},{"line_number":28,"context_line":"    This is useful for configuring passwords and secrets on services."},{"line_number":29,"context_line":"    \u0027\u0027\u0027"},{"line_number":30,"context_line":"    properties_schema \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F1%2FI%3D","line":27,"updated":"2013-10-09 03:58:06.000000000","message":"Ooops, whitespace. Surprised pep8 didn\u0027t catch this.","commit_id":"1b0a05ce3f4c60e3835609229d6601018adc0b56"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"653a578fac93ced1560054a6cfd1b0bf0b0becea","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class RandomString(resource.Resource):"},{"line_number":25,"context_line":"    \u0027\u0027\u0027"},{"line_number":26,"context_line":"    A resource which generates a random string."},{"line_number":27,"context_line":"    "},{"line_number":28,"context_line":"    This is useful for configuring passwords and secrets on services."},{"line_number":29,"context_line":"    \u0027\u0027\u0027"},{"line_number":30,"context_line":"    properties_schema \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F140%3D","line":27,"in_reply_to":"AAAATH%2F%2F1%2FI%3D","updated":"2013-10-09 19:10:29.000000000","message":"Done","commit_id":"1b0a05ce3f4c60e3835609229d6601018adc0b56"}],"heat/tests/test_random_string.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"7ba40054071dc235e72cff84a8af5eb6edfe4697","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    ]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_generate_random_string(self):"},{"line_number":107,"context_line":"        # run each test multiple times to check random generator"},{"line_number":108,"context_line":"        for i in range(1, 64):"},{"line_number":109,"context_line":"            sequence \u003d RandomString._sequences[self.seq]"},{"line_number":110,"context_line":"            r \u003d RandomString._generate_random_string(sequence, self.length)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F1%2FU%3D","line":107,"updated":"2013-10-09 03:58:06.000000000","message":"I don\u0027t see anything that makes sure there were no repeats. If we\u0027re not looking for that, what are we looking for with 64 iterations?","commit_id":"1b0a05ce3f4c60e3835609229d6601018adc0b56"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"653a578fac93ced1560054a6cfd1b0bf0b0becea","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    ]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_generate_random_string(self):"},{"line_number":107,"context_line":"        # run each test multiple times to check random generator"},{"line_number":108,"context_line":"        for i in range(1, 64):"},{"line_number":109,"context_line":"            sequence \u003d RandomString._sequences[self.seq]"},{"line_number":110,"context_line":"            r \u003d RandomString._generate_random_string(sequence, self.length)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F14k%3D","line":107,"in_reply_to":"AAAATH%2F%2F1%2FU%3D","updated":"2013-10-09 19:10:29.000000000","message":"Just that a single random generation might produce a string which matches the test pattern by chance.","commit_id":"1b0a05ce3f4c60e3835609229d6601018adc0b56"}]}
