)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84f509169412ef68b01f8307a54688bfb6708637","unresolved":false,"context_lines":[{"line_number":11,"context_line":"a DB restart or simply a temp connection issue due to network"},{"line_number":12,"context_line":"glitches. At the moment only mysql is enabled with this feature. This"},{"line_number":13,"context_line":"patch enables db2 as well."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib89de07f004975528baffdfd19aae689b089a324"},{"line_number":16,"context_line":"Partial-Bug: #1231657"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATH%2F%2FzxA%3D","line":14,"updated":"2013-10-09 14:54:30.000000000","message":"You should be referencing the oslo-incubator change that this should have been synched from:\n\nhttps://review.openstack.org/#/c/48733/\n\nBut it looks like you actually copied the change from the keystone patch:\n\nhttps://review.openstack.org/#/c/49272/\n\nEither way, one of those should be referenced since that\u0027s where this code is coming from.","commit_id":"61c0e2dddbb87c489050285aa0fd8d0d3197984f"},{"author":{"_account_id":6526,"name":"David Geng","email":"gengjh@cn.ibm.com","username":"genggjh"},"change_message_id":"4e3726ecf349344f98f8618b645fafe2e9b437f1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(Sync from oslo module db.sqlalchemy in commit 20d25c8)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib89de07f004975528baffdfd19aae689b089a324"},{"line_number":18,"context_line":"Partial-Bug: #1231657"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F9XFI%3D","line":18,"updated":"2013-12-12 09:05:31.000000000","message":"Partial-Bug should be placed before the Change-Id.\n\nCould you provide the full commit id from the oslo? I can not find the commit with your id.","commit_id":"1127a547c3455b45c8269787eb6a0a9f52c8b5a5"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"e9ef1b774656f700f71c9cbffb99e0e1c78422ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(Sync from oslo module db.sqlalchemy in commit 20d25c8)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib89de07f004975528baffdfd19aae689b089a324"},{"line_number":18,"context_line":"Partial-Bug: #1231657"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F9XE4%3D","line":18,"in_reply_to":"AAAATn%2F9XFI%3D","updated":"2013-12-12 09:06:20.000000000","message":"Done","commit_id":"1127a547c3455b45c8269787eb6a0a9f52c8b5a5"}],"heat/db/sqlalchemy/session.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84f509169412ef68b01f8307a54688bfb6708637","unresolved":false,"context_lines":[{"line_number":69,"context_line":"class DB2PingListener(object):"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":"    Ensures that DB2 connections checked out of the"},{"line_number":73,"context_line":"    pool are alive."},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FzwE%3D","line":72,"updated":"2013-10-09 14:54:30.000000000","message":"This can fit on a single line right?","commit_id":"61c0e2dddbb87c489050285aa0fd8d0d3197984f"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"becb7740e670c34af0580b76f5ca16d1e2d8b5a5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"class DB2PingListener(object):"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":"    Ensures that DB2 connections checked out of the"},{"line_number":73,"context_line":"    pool are alive."},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FxBQ%3D","line":72,"in_reply_to":"AAAATH%2F%2FzwE%3D","updated":"2013-10-10 06:06:18.000000000","message":"Done","commit_id":"61c0e2dddbb87c489050285aa0fd8d0d3197984f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f36e563f5570c985a730f98271260f2881937362","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class DB2PingListener(object):"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":"    Ensures that DB2 connections checked out of the pool are alive."},{"line_number":73,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FvZs%3D","line":70,"updated":"2013-10-10 13:11:32.000000000","message":"Delete this blank line.","commit_id":"143d729ed8e8feaf5c525ba85833be903db3fffb"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dcb048c0318324b4dd96494e95276154575f1b61","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            dbapi_con_cursor.execute(\u0027select 1 from (values (1)) AS t1\u0027)"},{"line_number":79,"context_line":"        except Exception as ex:"},{"line_number":80,"context_line":"            engine \u003d get_engine()"},{"line_number":81,"context_line":"            if engine.dialect.is_disconnect(ex, dbapi_con, dbapi_con_cursor):"},{"line_number":82,"context_line":"                logger.warn(\u0027Got DB2 server has gone away: %s\u0027, ex)"},{"line_number":83,"context_line":"                raise DisconnectionError(\"Database server went away\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FvOI%3D","line":80,"updated":"2013-10-10 13:55:17.000000000","message":"This is a little scary because get_engine() uses this function and potentially returns a new engine. Suggest remove this line and just use _ENGINE.","commit_id":"143d729ed8e8feaf5c525ba85833be903db3fffb"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0c48a59e313415019a83482620aba059f691833e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            dbapi_con_cursor.execute(\u0027select 1 from (values (1)) AS t1\u0027)"},{"line_number":78,"context_line":"        except Exception as ex:"},{"line_number":79,"context_line":"            global _ENGINE"},{"line_number":80,"context_line":"            if not _ENGINE and _ENGINE.dialect.is_disconnect(ex, dbapi_con,"},{"line_number":81,"context_line":"                                                             dbapi_con_cursor):"},{"line_number":82,"context_line":"                logger.warn(\u0027Got DB2 server has gone away: %s\u0027, ex)"},{"line_number":83,"context_line":"                raise DisconnectionError(\"Database server went away\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FmCg%3D","line":80,"updated":"2013-10-14 01:15:53.000000000","message":"Needs a unit test, because I don\u0027t think this works (If _ENGINE is None then would get an error, and if _ENGINE is not None then doesn\u0027t do is_disconnect.","commit_id":"49070a3d8282abef159914ff1d6e2933221c5662"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"2b06cff6e21b7d621faf4f0db042e074c68d11fa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            dbapi_con_cursor.execute(\u0027select 1 from (values (1)) AS t1\u0027)"},{"line_number":78,"context_line":"        except Exception as ex:"},{"line_number":79,"context_line":"            global _ENGINE"},{"line_number":80,"context_line":"            if not _ENGINE and _ENGINE.dialect.is_disconnect(ex, dbapi_con,"},{"line_number":81,"context_line":"                                                             dbapi_con_cursor):"},{"line_number":82,"context_line":"                logger.warn(\u0027Got DB2 server has gone away: %s\u0027, ex)"},{"line_number":83,"context_line":"                raise DisconnectionError(\"Database server went away\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FUTM%3D","line":80,"in_reply_to":"AAAATH%2F%2Flpc%3D","updated":"2013-10-17 20:23:56.000000000","message":"Agree with Brant.","commit_id":"49070a3d8282abef159914ff1d6e2933221c5662"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"98361f775c3ceff36cea8bd3575db24a9bfbd00c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            dbapi_con_cursor.execute(\u0027select 1 from (values (1)) AS t1\u0027)"},{"line_number":78,"context_line":"        except Exception as ex:"},{"line_number":79,"context_line":"            global _ENGINE"},{"line_number":80,"context_line":"            if not _ENGINE and _ENGINE.dialect.is_disconnect(ex, dbapi_con,"},{"line_number":81,"context_line":"                                                             dbapi_con_cursor):"},{"line_number":82,"context_line":"                logger.warn(\u0027Got DB2 server has gone away: %s\u0027, ex)"},{"line_number":83,"context_line":"                raise DisconnectionError(\"Database server went away\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Flpc%3D","line":80,"in_reply_to":"AAAATH%2F%2FmCg%3D","updated":"2013-10-14 06:53:24.000000000","message":"Agree with Brant.","commit_id":"49070a3d8282abef159914ff1d6e2933221c5662"}]}