)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"76f05304600dd0eb6226b285d727342610bcf7c4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"floating ip not exists. Heat should catch this exception"},{"line_number":11,"context_line":"to continue delete stack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"closes-Bug #1237271"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifd9d34de37cc5dd57804787d8b1455f0321fc86f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATH%2F%2FuiA%3D","line":13,"updated":"2013-10-10 16:15:29.000000000","message":"Should be Closes-Bug: #nnn","commit_id":"a2baf5d202b4408f3adc07d40d6454c259ead440"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"5107570f115d4d05f8575373fcf08f5cfb58e77f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"floating ip not exists. Heat should catch this exception"},{"line_number":11,"context_line":"to continue delete stack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"closes-Bug #1237271"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifd9d34de37cc5dd57804787d8b1455f0321fc86f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATH%2F%2Fr2w%3D","line":13,"in_reply_to":"AAAATH%2F%2FuiA%3D","updated":"2013-10-11 08:18:11.000000000","message":"Done","commit_id":"a2baf5d202b4408f3adc07d40d6454c259ead440"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"bd157c4f8157b075f3b029bfbdbf2c1bd88bdf4e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"floating ip not exists. Heat should catch this exception"},{"line_number":11,"context_line":"to continue to delete the stack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"closes-Bug #1234593"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifd9d34de37cc5dd57804787d8b1455f0321fc86f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2Fuh0%3D","line":13,"updated":"2013-10-10 16:16:53.000000000","message":"See comment on patchset 1","commit_id":"280312639353e5a58a7e789a869ad42e8213011d"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"cbe991294ba76df7d3a32809c6309e34b64c6d3e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"floating ip not exists. Heat should catch this exception"},{"line_number":11,"context_line":"to continue to delete the stack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"closes-Bug #1234593"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifd9d34de37cc5dd57804787d8b1455f0321fc86f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2Fr2o%3D","line":13,"in_reply_to":"AAAATH%2F%2Fuh0%3D","updated":"2013-10-11 08:15:38.000000000","message":"Done","commit_id":"280312639353e5a58a7e789a869ad42e8213011d"}],"heat/engine/resources/eip.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c2c86509ca09f2c7e18ce241669f0f28b3768176","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                try:"},{"line_number":122,"context_line":"                    self.nova().floating_ips.delete(self.resource_id)"},{"line_number":123,"context_line":"                except clients.novaclient.exceptions.NotFound:"},{"line_number":124,"context_line":"                    logger.error(\"Floating ip not found.\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def FnGetRefId(self):"},{"line_number":127,"context_line":"        return unicode(self._ipaddress())"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Ft2w%3D","line":124,"updated":"2013-10-10 19:23:35.000000000","message":"All other resources that do a NotFound check on delete do not log anything, they just pass","commit_id":"280312639353e5a58a7e789a869ad42e8213011d"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"cbe991294ba76df7d3a32809c6309e34b64c6d3e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                try:"},{"line_number":122,"context_line":"                    self.nova().floating_ips.delete(self.resource_id)"},{"line_number":123,"context_line":"                except clients.novaclient.exceptions.NotFound:"},{"line_number":124,"context_line":"                    logger.error(\"Floating ip not found.\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def FnGetRefId(self):"},{"line_number":127,"context_line":"        return unicode(self._ipaddress())"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fr2k%3D","line":124,"in_reply_to":"AAAATH%2F%2Ft2w%3D","updated":"2013-10-11 08:15:38.000000000","message":"Done","commit_id":"280312639353e5a58a7e789a869ad42e8213011d"}],"heat/tests/test_eip.py":[{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"cac8a96a3e78727ffb4a714daebbab4566097fec","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             stack)"},{"line_number":243,"context_line":"        rsrc.resource_id \u003d \u0027fake_id\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        with mock.patch.object(eip, \u0027logger\u0027) as log:"},{"line_number":246,"context_line":"            rsrc.handle_delete()"},{"line_number":247,"context_line":"            msg \u003d \u0027Floating ip not found.\u0027"},{"line_number":248,"context_line":"            log.error.assert_called_once_with(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F04Y%3D","line":245,"updated":"2013-10-09 10:39:58.000000000","message":"Any particular reason we need to use mox and mock together? Seems this can simply be mocked with mox by something like,          \n\nself.m.StubOutWithMock(eip.logger, \u0027error\u0027,)\n\neip.logger.error(\u0027Floating ip not found.\u0027)","commit_id":"a2baf5d202b4408f3adc07d40d6454c259ead440"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"68374683895d7b98e8a0cd988b0f25f5e0780a99","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             stack)"},{"line_number":243,"context_line":"        rsrc.resource_id \u003d \u0027fake_id\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        with mock.patch.object(eip, \u0027logger\u0027) as log:"},{"line_number":246,"context_line":"            rsrc.handle_delete()"},{"line_number":247,"context_line":"            msg \u003d \u0027Floating ip not found.\u0027"},{"line_number":248,"context_line":"            log.error.assert_called_once_with(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F0WU%3D","line":245,"in_reply_to":"AAAATH%2F%2F04Y%3D","updated":"2013-10-09 13:10:50.000000000","message":"I am not sure about your suggestion, because my intention is to assert log.error(\u0027Floating ip not found\u0027) has been called onc with the exact msg by setting mock this way.","commit_id":"a2baf5d202b4408f3adc07d40d6454c259ead440"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"b22ce141921625c3b4c5d19836f781b83433cc5d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             stack)"},{"line_number":243,"context_line":"        rsrc.resource_id \u003d \u0027fake_id\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        with mock.patch.object(eip, \u0027logger\u0027) as log:"},{"line_number":246,"context_line":"            rsrc.handle_delete()"},{"line_number":247,"context_line":"            msg \u003d \u0027Floating ip not found.\u0027"},{"line_number":248,"context_line":"            log.error.assert_called_once_with(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FxPk%3D","line":245,"in_reply_to":"AAAATH%2F%2F04Y%3D","updated":"2013-10-10 03:43:09.000000000","message":"Pls refer this commit, It is fine to write this way in neutron. : )\nhttps://review.openstack.org/#/c/47799/4/neutron/tests/unit/test_l3_agent.py","commit_id":"a2baf5d202b4408f3adc07d40d6454c259ead440"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"76f05304600dd0eb6226b285d727342610bcf7c4","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             stack)"},{"line_number":243,"context_line":"        rsrc.resource_id \u003d \u0027fake_id\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        with mock.patch.object(eip, \u0027logger\u0027) as log:"},{"line_number":246,"context_line":"            rsrc.handle_delete()"},{"line_number":247,"context_line":"            msg \u003d \u0027Floating ip not found.\u0027"},{"line_number":248,"context_line":"            log.error.assert_called_once_with(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FuiI%3D","line":245,"in_reply_to":"AAAATH%2F%2Fu8c%3D","updated":"2013-10-10 16:15:29.000000000","message":"I agree, lets use one or the other, not a mixture of both - the neutron example you link only uses mock","commit_id":"a2baf5d202b4408f3adc07d40d6454c259ead440"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"5107570f115d4d05f8575373fcf08f5cfb58e77f","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             stack)"},{"line_number":243,"context_line":"        rsrc.resource_id \u003d \u0027fake_id\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        with mock.patch.object(eip, \u0027logger\u0027) as log:"},{"line_number":246,"context_line":"            rsrc.handle_delete()"},{"line_number":247,"context_line":"            msg \u003d \u0027Floating ip not found.\u0027"},{"line_number":248,"context_line":"            log.error.assert_called_once_with(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fr2s%3D","line":245,"in_reply_to":"AAAATH%2F%2FuiI%3D","updated":"2013-10-11 08:18:11.000000000","message":"Done","commit_id":"a2baf5d202b4408f3adc07d40d6454c259ead440"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"2238c44393ee03b8c5b581164b52dbc0f75d8658","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             stack)"},{"line_number":243,"context_line":"        rsrc.resource_id \u003d \u0027fake_id\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        with mock.patch.object(eip, \u0027logger\u0027) as log:"},{"line_number":246,"context_line":"            rsrc.handle_delete()"},{"line_number":247,"context_line":"            msg \u003d \u0027Floating ip not found.\u0027"},{"line_number":248,"context_line":"            log.error.assert_called_once_with(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fu8c%3D","line":245,"in_reply_to":"AAAATH%2F%2FxPk%3D","updated":"2013-10-10 14:50:30.000000000","message":"Yeah, it is perfectly fine to use the mock library. I just wonder why we cannot stick with one library for a single test case.","commit_id":"a2baf5d202b4408f3adc07d40d6454c259ead440"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"bd157c4f8157b075f3b029bfbdbf2c1bd88bdf4e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             stack)"},{"line_number":243,"context_line":"        rsrc.resource_id \u003d \u0027fake_id\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        with mock.patch.object(eip, \u0027logger\u0027) as log:"},{"line_number":246,"context_line":"            rsrc.handle_delete()"},{"line_number":247,"context_line":"            msg \u003d \u0027Floating ip not found.\u0027"},{"line_number":248,"context_line":"            log.error.assert_called_once_with(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fuhk%3D","line":245,"updated":"2013-10-10 16:16:53.000000000","message":"I agree with Liang\u0027s comment on the previous patchset, we shouldn\u0027t be mixing mox and mock calls in a single testcase, please use one or the other.","commit_id":"280312639353e5a58a7e789a869ad42e8213011d"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"cbe991294ba76df7d3a32809c6309e34b64c6d3e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             stack)"},{"line_number":243,"context_line":"        rsrc.resource_id \u003d \u0027fake_id\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        with mock.patch.object(eip, \u0027logger\u0027) as log:"},{"line_number":246,"context_line":"            rsrc.handle_delete()"},{"line_number":247,"context_line":"            msg \u003d \u0027Floating ip not found.\u0027"},{"line_number":248,"context_line":"            log.error.assert_called_once_with(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fr3E%3D","line":245,"in_reply_to":"AAAATH%2F%2Fr%2BY%3D","updated":"2013-10-11 08:15:38.000000000","message":"OK, got it, will be updated, pls feel free to be picky : ).","commit_id":"280312639353e5a58a7e789a869ad42e8213011d"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"c1bd0454e7c8818b51f51b8a3755f55adaab49f8","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             stack)"},{"line_number":243,"context_line":"        rsrc.resource_id \u003d \u0027fake_id\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        with mock.patch.object(eip, \u0027logger\u0027) as log:"},{"line_number":246,"context_line":"            rsrc.handle_delete()"},{"line_number":247,"context_line":"            msg \u003d \u0027Floating ip not found.\u0027"},{"line_number":248,"context_line":"            log.error.assert_called_once_with(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fr%2BY%3D","line":245,"in_reply_to":"AAAATH%2F%2Fuhk%3D","updated":"2013-10-11 07:33:41.000000000","message":"Still think so.  Hui, I might be being a bit picky here ;) But switching to mox should be quite easy as I demonstrated in my previous comment.","commit_id":"280312639353e5a58a7e789a869ad42e8213011d"}]}
