)]}'
{"heat/engine/parameters.py":[{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"fa21b02b6646f77210d504cd4a4d657bd0054eab","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        self.schema.validate(self.name, val)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def value(self):"},{"line_number":228,"context_line":"        return self.__int__()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"class StringParam(Parameter):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FuxY%3D","line":228,"updated":"2013-10-10 15:21:49.000000000","message":"This would round a float number param to an integer, e.g. \n\nschema \u003d {\u0027Type\u0027: \u0027Number\u0027}\n\np \u003d self.new_parameter(\u0027p\u0027, schema, 3.3)\n\np.value() will return 3. Not sure if this will break any existing code. Is this really what we want?","commit_id":"972c2b55d3563677c0c6e6905eb38044d796c7a6"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"ec3a6a88824965a2b524331995ea1030fb8a38f7","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        self.schema.validate(self.name, val)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def value(self):"},{"line_number":228,"context_line":"        return self.__int__()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"class StringParam(Parameter):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FsNA%3D","line":228,"in_reply_to":"AAAATH%2F%2FsRw%3D","updated":"2013-10-11 06:00:00.000000000","message":"Sure. Thanks!","commit_id":"972c2b55d3563677c0c6e6905eb38044d796c7a6"},{"author":{"_account_id":8844,"name":"Mitsuru Kanabuchi","email":"kanabuchi.mitsuru@po.ntts.co.jp","username":"kanabuchi"},"change_message_id":"f6ff2b090ff64e5170f3f5f0dbde5bab7d1e5c6f","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        self.schema.validate(self.name, val)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def value(self):"},{"line_number":228,"context_line":"        return self.__int__()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"class StringParam(Parameter):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FsRw%3D","line":228,"in_reply_to":"AAAATH%2F%2FuxY%3D","updated":"2013-10-11 05:36:45.000000000","message":"Thank you for your comment.\n\nIn my understand, \"Integer\" property value need Integer casted parameter.\nCurrently NumberParam implementation assign String parameter to Integer property.\nI think Integer/Float conversion is necessary at NumberParam.value.\n\nIn your comment said, Float conversion lacked in PatchSet1.\nI fixed it. Would you like to re-check?","commit_id":"972c2b55d3563677c0c6e6905eb38044d796c7a6"}]}
