)]}'
{"heat/engine/resources/os_dbinstance.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \"Required\": False,"},{"line_number":42,"context_line":"            \"Description\": _(\"Set of rules for comparing characters in a \""},{"line_number":43,"context_line":"                             \"character set.\")"},{"line_number":44,"context_line":"        },"},{"line_number":45,"context_line":"        \"name\": {"},{"line_number":46,"context_line":"            \"Type\": \"String\","},{"line_number":47,"context_line":"            \"Required\": True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeFw%3D","line":44,"updated":"2013-11-05 11:02:38.000000000","message":"Trove as multi-database-service could create databases for all datastore, if database supports it, so, collate and charset is mysql specific, it would be better to remove them from current resource implementation.","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    properties_schema \u003d {"},{"line_number":99,"context_line":"        \"name\": {"},{"line_number":100,"context_line":"            \"Type\": \"String\","},{"line_number":101,"context_line":"            \"Required\": True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeFU%3D","line":98,"updated":"2013-11-05 11:02:38.000000000","message":"DB provisioning requires(and they are not optional) datastore type(mysql, cassandra, mongo, etc.), datastore version (mysql-server-5.5, cassandra\u003d1.2.10, etc.)","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e8298a5b47cff4484c2a215e6517d50772cb56bb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    properties_schema \u003d {"},{"line_number":99,"context_line":"        \"name\": {"},{"line_number":100,"context_line":"            \"Type\": \"String\","},{"line_number":101,"context_line":"            \"Required\": True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FT%2Bw%3D","line":98,"updated":"2013-10-17 22:05:42.000000000","message":"New resource should define their schema using properties.Schema for added type-safety. See RandomString resource for an example.","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    @property"},{"line_number":155,"context_line":"    def dbinstance(self):"},{"line_number":156,"context_line":"        \"\"\"Get the trove dbinstance.\"\"\""},{"line_number":157,"context_line":"        if not self._dbinstance and self.resource_id is not None:"},{"line_number":158,"context_line":"            self._dbinstance \u003d self.trove().instances.get(self.resource_id)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        return self._dbinstance"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeE8%3D","line":157,"updated":"2013-11-05 11:02:38.000000000","message":"if not self._dbinstance and not self.resource_id","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        Create cloud Dbaas Instance."},{"line_number":165,"context_line":"        \u0027\u0027\u0027"},{"line_number":166,"context_line":"        logger.debug(\"Cloud DB instance handle_create called\")"},{"line_number":167,"context_line":"        self.sqlinstancename \u003d self.properties[\u0027name\u0027]"},{"line_number":168,"context_line":"        self.flavor \u003d nova_utils.get_flavor_id(self.trove(),"},{"line_number":169,"context_line":"                                               self.properties[\u0027flavor\u0027])"},{"line_number":170,"context_line":"        self.volume \u003d {\u0027size\u0027: self.properties[\u0027size\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeBc%3D","line":167,"updated":"2013-11-05 11:02:38.000000000","message":"same","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self.sqlinstancename \u003d self.properties[\u0027name\u0027]"},{"line_number":168,"context_line":"        self.flavor \u003d nova_utils.get_flavor_id(self.trove(),"},{"line_number":169,"context_line":"                                               self.properties[\u0027flavor\u0027])"},{"line_number":170,"context_line":"        self.volume \u003d {\u0027size\u0027: self.properties[\u0027size\u0027]}"},{"line_number":171,"context_line":"        self.databases \u003d self.properties.get(\"databases\", [])"},{"line_number":172,"context_line":"        self.users \u003d self.properties.get(\"users\", [])"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeC8%3D","line":170,"updated":"2013-11-05 11:02:38.000000000","message":"self.properties.get(\u0027size\u0027, 1)","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.users \u003d self.properties.get(\"users\", [])"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # create db instance"},{"line_number":175,"context_line":"        logger.info(\"Creating Cloud DB instance %s\" % self.sqlinstancename)"},{"line_number":176,"context_line":"        instance \u003d self.trove().instances.create("},{"line_number":177,"context_line":"            self.sqlinstancename,"},{"line_number":178,"context_line":"            self.flavor,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeBk%3D","line":175,"updated":"2013-11-05 11:02:38.000000000","message":"sqlinstance is a bad name. Why not dbinstance ?","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        instance \u003d self.trove().instances.create("},{"line_number":177,"context_line":"            self.sqlinstancename,"},{"line_number":178,"context_line":"            self.flavor,"},{"line_number":179,"context_line":"            self.volume,"},{"line_number":180,"context_line":"            self.databases,"},{"line_number":181,"context_line":"            self.users)"},{"line_number":182,"context_line":"        if instance is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeDE%3D","line":179,"updated":"2013-11-05 11:02:38.000000000","message":"it would be better to pass parameters via volume\u003dself.volume, databases\u003dself.databases, etc.","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            self.volume,"},{"line_number":180,"context_line":"            self.databases,"},{"line_number":181,"context_line":"            self.users)"},{"line_number":182,"context_line":"        if instance is not None:"},{"line_number":183,"context_line":"            self.resource_id_set(instance.id)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeE0%3D","line":182,"updated":"2013-11-05 11:02:38.000000000","message":"if instance:","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e8298a5b47cff4484c2a215e6517d50772cb56bb","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self.databases,"},{"line_number":181,"context_line":"            self.users)"},{"line_number":182,"context_line":"        if instance is not None:"},{"line_number":183,"context_line":"            self.resource_id_set(instance.id)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return instance"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FT%2BQ%3D","line":183,"updated":"2013-10-17 22:05:42.000000000","message":"else an exception should probably be raised if instance is None","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self.databases,"},{"line_number":181,"context_line":"            self.users)"},{"line_number":182,"context_line":"        if instance is not None:"},{"line_number":183,"context_line":"            self.resource_id_set(instance.id)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return instance"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeEs%3D","line":183,"in_reply_to":"AAAATH%2F%2FT%2BQ%3D","updated":"2013-11-05 11:02:38.000000000","message":"agreed","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"42bef3d0c2470d3a7c853e008a186ed2b76e8aba","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self.databases,"},{"line_number":181,"context_line":"            self.users)"},{"line_number":182,"context_line":"        if instance is not None:"},{"line_number":183,"context_line":"            self.resource_id_set(instance.id)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return instance"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FMFI%3D","line":183,"in_reply_to":"AAAATH%2F%2FT%2BQ%3D","updated":"2013-10-21 18:07:58.000000000","message":"ok","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return instance"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def check_create_complete(self, instance):"},{"line_number":188,"context_line":"        \u0027\u0027\u0027"},{"line_number":189,"context_line":"        Check if cloud DB instance creation is complete."},{"line_number":190,"context_line":"        \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeEg%3D","line":187,"updated":"2013-11-05 11:02:38.000000000","message":"i suppose here should be presented poll_until method with specific timeout.","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        Delete a cloud Dbaas Instance."},{"line_number":205,"context_line":"        \u0027\u0027\u0027"},{"line_number":206,"context_line":"        logger.info(\"OSDBInstance handle_delete called.\")"},{"line_number":207,"context_line":"        if self.resource_id is None:"},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        instance \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeEY%3D","line":207,"updated":"2013-11-05 11:02:38.000000000","message":"if not self.resource_id","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e8298a5b47cff4484c2a215e6517d50772cb56bb","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        try:"},{"line_number":228,"context_line":"            instance.get()"},{"line_number":229,"context_line":"        except NotFound:"},{"line_number":230,"context_line":"            logger.info(\"OSDBInstance %s deleted.\" % self.resource_id)"},{"line_number":231,"context_line":"            self.resource_id \u003d None"},{"line_number":232,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FT9o%3D","line":229,"updated":"2013-10-17 22:05:42.000000000","message":"Just a check, does a trove resource go into some kind of DELETED state before it returns a 404? Checking for that would speed stack delete.","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        try:"},{"line_number":228,"context_line":"            instance.get()"},{"line_number":229,"context_line":"        except NotFound:"},{"line_number":230,"context_line":"            logger.info(\"OSDBInstance %s deleted.\" % self.resource_id)"},{"line_number":231,"context_line":"            self.resource_id \u003d None"},{"line_number":232,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeEQ%3D","line":229,"in_reply_to":"AAAATH%2F%2FMFY%3D","updated":"2013-11-05 11:02:38.000000000","message":"That is true. But you have forgot ERROR status.","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"42bef3d0c2470d3a7c853e008a186ed2b76e8aba","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        try:"},{"line_number":228,"context_line":"            instance.get()"},{"line_number":229,"context_line":"        except NotFound:"},{"line_number":230,"context_line":"            logger.info(\"OSDBInstance %s deleted.\" % self.resource_id)"},{"line_number":231,"context_line":"            self.resource_id \u003d None"},{"line_number":232,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FMFY%3D","line":229,"in_reply_to":"AAAATH%2F%2FT9o%3D","updated":"2013-10-21 18:07:58.000000000","message":"DELETED state does not exist. Following are valid states\nBUILD, REBOOT, ACTIVE, BACKUP, BLOCKED, RESIZE, SHUTDOWN","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            return res"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        # check validity of user and databases"},{"line_number":244,"context_line":"        users \u003d self.properties.get(\u0027users\u0027, None)"},{"line_number":245,"context_line":"        if not users:"},{"line_number":246,"context_line":"            return"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeEM%3D","line":244,"updated":"2013-11-05 11:02:38.000000000","message":"users \u003d self.properties.get(\u0027users\u0027, [])","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        # check validity of user and databases"},{"line_number":244,"context_line":"        users \u003d self.properties.get(\u0027users\u0027, None)"},{"line_number":245,"context_line":"        if not users:"},{"line_number":246,"context_line":"            return"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        databases \u003d self.properties.get(\u0027databases\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd9g%3D","line":245,"updated":"2013-11-05 11:02:38.000000000","message":"i suppose we should raise if users are not valid","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e8298a5b47cff4484c2a215e6517d50772cb56bb","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        # check validity of user and databases"},{"line_number":244,"context_line":"        users \u003d self.properties.get(\u0027users\u0027, None)"},{"line_number":245,"context_line":"        if not users:"},{"line_number":246,"context_line":"            return"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        databases \u003d self.properties.get(\u0027databases\u0027, None)"},{"line_number":249,"context_line":"        if not databases:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FT98%3D","line":246,"updated":"2013-10-17 22:05:42.000000000","message":"Why does validation cease if users is empty?","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"42bef3d0c2470d3a7c853e008a186ed2b76e8aba","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        # check validity of user and databases"},{"line_number":244,"context_line":"        users \u003d self.properties.get(\u0027users\u0027, None)"},{"line_number":245,"context_line":"        if not users:"},{"line_number":246,"context_line":"            return"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        databases \u003d self.properties.get(\u0027databases\u0027, None)"},{"line_number":249,"context_line":"        if not databases:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FMms%3D","line":246,"in_reply_to":"AAAATH%2F%2FT98%3D","updated":"2013-10-21 18:07:58.000000000","message":"Here we are validating if the database name given for a user exists in given databases or not. (given users will be created with access to given database)","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        if not users:"},{"line_number":246,"context_line":"            return"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        databases \u003d self.properties.get(\u0027databases\u0027, None)"},{"line_number":249,"context_line":"        if not databases:"},{"line_number":250,"context_line":"            return {\u0027Error\u0027:"},{"line_number":251,"context_line":"                    _(\u0027Databases property is required if Users property\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeEI%3D","line":248,"updated":"2013-11-05 11:02:38.000000000","message":"databases \u003d self.properties.get(\u0027databases\u0027, [])","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                    \u0027 is provided\u0027)}"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        for user in users:"},{"line_number":255,"context_line":"            if not user[\u0027databases\u0027]:"},{"line_number":256,"context_line":"                return {\u0027Error\u0027:"},{"line_number":257,"context_line":"                        _(\u0027Must provide access to at least one database for \u0027"},{"line_number":258,"context_line":"                        \u0027user %s\u0027) % user[\u0027name\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeEE%3D","line":255,"updated":"2013-11-05 11:02:38.000000000","message":"i suppose dict.get() would be better to use instead of [\u0027key\u0027]","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            if not user[\u0027databases\u0027]:"},{"line_number":256,"context_line":"                return {\u0027Error\u0027:"},{"line_number":257,"context_line":"                        _(\u0027Must provide access to at least one database for \u0027"},{"line_number":258,"context_line":"                        \u0027user %s\u0027) % user[\u0027name\u0027]}"},{"line_number":259,"context_line":"            missing_db \u003d [db_name[\u0027name\u0027] for db_name in user[\u0027databases\u0027]"},{"line_number":260,"context_line":"                          if db_name[\u0027name\u0027] not in"},{"line_number":261,"context_line":"                          [db[\u0027name\u0027] for db in databases]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeEA%3D","line":258,"updated":"2013-11-05 11:02:38.000000000","message":"same","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                return {\u0027Error\u0027:"},{"line_number":257,"context_line":"                        _(\u0027Must provide access to at least one database for \u0027"},{"line_number":258,"context_line":"                        \u0027user %s\u0027) % user[\u0027name\u0027]}"},{"line_number":259,"context_line":"            missing_db \u003d [db_name[\u0027name\u0027] for db_name in user[\u0027databases\u0027]"},{"line_number":260,"context_line":"                          if db_name[\u0027name\u0027] not in"},{"line_number":261,"context_line":"                          [db[\u0027name\u0027] for db in databases]]"},{"line_number":262,"context_line":"            if missing_db:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeD8%3D","line":259,"updated":"2013-11-05 11:02:38.000000000","message":"same","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                        _(\u0027Must provide access to at least one database for \u0027"},{"line_number":258,"context_line":"                        \u0027user %s\u0027) % user[\u0027name\u0027]}"},{"line_number":259,"context_line":"            missing_db \u003d [db_name[\u0027name\u0027] for db_name in user[\u0027databases\u0027]"},{"line_number":260,"context_line":"                          if db_name[\u0027name\u0027] not in"},{"line_number":261,"context_line":"                          [db[\u0027name\u0027] for db in databases]]"},{"line_number":262,"context_line":"            if missing_db:"},{"line_number":263,"context_line":"                return {\u0027Error\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeD4%3D","line":260,"updated":"2013-11-05 11:02:38.000000000","message":"same","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                        \u0027user %s\u0027) % user[\u0027name\u0027]}"},{"line_number":259,"context_line":"            missing_db \u003d [db_name[\u0027name\u0027] for db_name in user[\u0027databases\u0027]"},{"line_number":260,"context_line":"                          if db_name[\u0027name\u0027] not in"},{"line_number":261,"context_line":"                          [db[\u0027name\u0027] for db in databases]]"},{"line_number":262,"context_line":"            if missing_db:"},{"line_number":263,"context_line":"                return {\u0027Error\u0027:"},{"line_number":264,"context_line":"                        _(\u0027Database %s specified for user does not exist in \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeD0%3D","line":261,"updated":"2013-11-05 11:02:38.000000000","message":"same","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e8298a5b47cff4484c2a215e6517d50772cb56bb","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                return {\u0027Error\u0027:"},{"line_number":264,"context_line":"                        _(\u0027Database %s specified for user does not exist in \u0027"},{"line_number":265,"context_line":"                        \u0027databases.\u0027) % missing_db}"},{"line_number":266,"context_line":"        return"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def hostname(self):"},{"line_number":269,"context_line":"        if self._hostname is None and self.dbinstance:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FT94%3D","line":266,"updated":"2013-10-17 22:05:42.000000000","message":"Don\u0027t need this last return","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                return {\u0027Error\u0027:"},{"line_number":264,"context_line":"                        _(\u0027Database %s specified for user does not exist in \u0027"},{"line_number":265,"context_line":"                        \u0027databases.\u0027) % missing_db}"},{"line_number":266,"context_line":"        return"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def hostname(self):"},{"line_number":269,"context_line":"        if self._hostname is None and self.dbinstance:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeDo%3D","line":266,"in_reply_to":"AAAATH%2F%2FT94%3D","updated":"2013-11-05 11:02:38.000000000","message":"agreed","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"42bef3d0c2470d3a7c853e008a186ed2b76e8aba","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                return {\u0027Error\u0027:"},{"line_number":264,"context_line":"                        _(\u0027Database %s specified for user does not exist in \u0027"},{"line_number":265,"context_line":"                        \u0027databases.\u0027) % missing_db}"},{"line_number":266,"context_line":"        return"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def hostname(self):"},{"line_number":269,"context_line":"        if self._hostname is None and self.dbinstance:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FMp4%3D","line":266,"in_reply_to":"AAAATH%2F%2FT94%3D","updated":"2013-10-21 18:07:58.000000000","message":"will remove this.","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        return"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def hostname(self):"},{"line_number":269,"context_line":"        if self._hostname is None and self.dbinstance:"},{"line_number":270,"context_line":"            self._hostname \u003d self.dbinstance.hostname"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        return self._hostname"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd9w%3D","line":269,"updated":"2013-11-05 11:02:38.000000000","message":"if not self._hostname and self.dbinstance:","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        return self._hostname"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def href(self):"},{"line_number":275,"context_line":"        if self._href is None and self.dbinstance:"},{"line_number":276,"context_line":"            if self.dbinstance.links is None:"},{"line_number":277,"context_line":"                self._href \u003d None"},{"line_number":278,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeDc%3D","line":275,"updated":"2013-11-05 11:02:38.000000000","message":"if not self._href and self.dbinstance:","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def href(self):"},{"line_number":275,"context_line":"        if self._href is None and self.dbinstance:"},{"line_number":276,"context_line":"            if self.dbinstance.links is None:"},{"line_number":277,"context_line":"                self._href \u003d None"},{"line_number":278,"context_line":"            else:"},{"line_number":279,"context_line":"                for link in self.dbinstance.links:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd9o%3D","line":276,"updated":"2013-11-05 11:02:38.000000000","message":"if not self.dbinstance.links:","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"def resource_mapping():"},{"line_number":293,"context_line":"    return {"},{"line_number":294,"context_line":"        \u0027OS::Trove::DBInstance\u0027: OSDBInstance,"},{"line_number":295,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeDI%3D","line":294,"updated":"2013-11-05 11:02:38.000000000","message":"i suppose we should name it with better name such as Database, because word DBInstance telling us that we have whole instance to be manageable. But we could only interact with database.","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"}],"heat/tests/test_os_dbinstance.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      \"Description\" : \"The volume size\","},{"line_number":42,"context_line":"      \"Type\": \"Number\","},{"line_number":43,"context_line":"      \"MinValue\" : \"1\","},{"line_number":44,"context_line":"      \"MaxValue\" : \"1024\","},{"line_number":45,"context_line":"      \"Default\": \u002730\u0027"},{"line_number":46,"context_line":"    },"},{"line_number":47,"context_line":"    \"name\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd8s%3D","line":44,"updated":"2013-11-05 11:02:38.000000000","message":"i would like not to have limits","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  },"},{"line_number":53,"context_line":"  \"Resources\" : {"},{"line_number":54,"context_line":"    \"MySqlCloudDB\": {"},{"line_number":55,"context_line":"      \"Type\": \"OS::Trove::DBInstance\","},{"line_number":56,"context_line":"      \"Properties\" : {"},{"line_number":57,"context_line":"        \"name\" : \"test\","},{"line_number":58,"context_line":"        \"flavor\" : \"1GB\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd8k%3D","line":55,"updated":"2013-11-05 11:02:38.000000000","message":"as i said, \"OS::Trove::Database\"","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def __init__(self):"},{"line_number":73,"context_line":"        self.id \u003d 12345"},{"line_number":74,"context_line":"        self.hostname \u003d \"testhost\""},{"line_number":75,"context_line":"        self.links \u003d \\"},{"line_number":76,"context_line":"            [{\"href\": \"https://adga23dd432a.rackspacecloud.com/132345245\","},{"line_number":77,"context_line":"              \"rel\": \"self\"}]"},{"line_number":78,"context_line":"        self.resource_id \u003d 12345"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd8M%3D","line":75,"updated":"2013-11-05 11:02:38.000000000","message":"It would be nice to see code written with Google Pythonic Code Style (do not use \\)","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e8298a5b47cff4484c2a215e6517d50772cb56bb","unresolved":false,"context_lines":[{"line_number":124,"context_line":"             FakeFlavor(2, \u00272GB\u0027)])"},{"line_number":125,"context_line":"        self.m.StubOutWithMock(self.fc, \u0027instances\u0027)"},{"line_number":126,"context_line":"        self.m.StubOutWithMock(self.fc.instances, \u0027create\u0027)"},{"line_number":127,"context_line":"        self.fc.instances.create(mox.IgnoreArg(), mox.IgnoreArg(),"},{"line_number":128,"context_line":"                                 mox.IgnoreArg(), mox.IgnoreArg(),"},{"line_number":129,"context_line":"                                 mox.IgnoreArg()).AndReturn(fake_dbinstance)"},{"line_number":130,"context_line":"        self.m.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FT9A%3D","line":127,"updated":"2013-10-17 22:05:42.000000000","message":"You could ignore less (or none) of these args for some extra test validation","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"             FakeFlavor(2, \u00272GB\u0027)])"},{"line_number":125,"context_line":"        self.m.StubOutWithMock(self.fc, \u0027instances\u0027)"},{"line_number":126,"context_line":"        self.m.StubOutWithMock(self.fc.instances, \u0027create\u0027)"},{"line_number":127,"context_line":"        self.fc.instances.create(mox.IgnoreArg(), mox.IgnoreArg(),"},{"line_number":128,"context_line":"                                 mox.IgnoreArg(), mox.IgnoreArg(),"},{"line_number":129,"context_line":"                                 mox.IgnoreArg()).AndReturn(fake_dbinstance)"},{"line_number":130,"context_line":"        self.m.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd8A%3D","line":127,"in_reply_to":"AAAATH%2F%2FT9A%3D","updated":"2013-11-05 11:02:38.000000000","message":"Agreed","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"42bef3d0c2470d3a7c853e008a186ed2b76e8aba","unresolved":false,"context_lines":[{"line_number":124,"context_line":"             FakeFlavor(2, \u00272GB\u0027)])"},{"line_number":125,"context_line":"        self.m.StubOutWithMock(self.fc, \u0027instances\u0027)"},{"line_number":126,"context_line":"        self.m.StubOutWithMock(self.fc.instances, \u0027create\u0027)"},{"line_number":127,"context_line":"        self.fc.instances.create(mox.IgnoreArg(), mox.IgnoreArg(),"},{"line_number":128,"context_line":"                                 mox.IgnoreArg(), mox.IgnoreArg(),"},{"line_number":129,"context_line":"                                 mox.IgnoreArg()).AndReturn(fake_dbinstance)"},{"line_number":130,"context_line":"        self.m.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FMFA%3D","line":127,"in_reply_to":"AAAATH%2F%2FT9A%3D","updated":"2013-10-21 18:07:58.000000000","message":"going to remove ignores.","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_osdbinstance_prop_validation_invaliddb(self):"},{"line_number":256,"context_line":"        t \u003d template_format.parse(wp_template)"},{"line_number":257,"context_line":"        t[\u0027Resources\u0027][\u0027MySqlCloudDB\u0027][\u0027Properties\u0027][\u0027databases\u0027] \u003d \\"},{"line_number":258,"context_line":"            [{\"name\": \"onedb\"}]"},{"line_number":259,"context_line":"        t[\u0027Resources\u0027][\u0027MySqlCloudDB\u0027][\u0027Properties\u0027][\u0027users\u0027] \u003d \\"},{"line_number":260,"context_line":"            [{\"name\": \"testuser\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd7s%3D","line":257,"updated":"2013-11-05 11:02:38.000000000","message":"same","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        t \u003d template_format.parse(wp_template)"},{"line_number":257,"context_line":"        t[\u0027Resources\u0027][\u0027MySqlCloudDB\u0027][\u0027Properties\u0027][\u0027databases\u0027] \u003d \\"},{"line_number":258,"context_line":"            [{\"name\": \"onedb\"}]"},{"line_number":259,"context_line":"        t[\u0027Resources\u0027][\u0027MySqlCloudDB\u0027][\u0027Properties\u0027][\u0027users\u0027] \u003d \\"},{"line_number":260,"context_line":"            [{\"name\": \"testuser\","},{"line_number":261,"context_line":"              \"password\": \"pass\","},{"line_number":262,"context_line":"              \"databases\": [{\"name\": \"invaliddb\"}]}]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd7w%3D","line":259,"updated":"2013-11-05 11:02:38.000000000","message":"same","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    def test_osdbinstance_prop_validation_databases_none(self):"},{"line_number":277,"context_line":"        t \u003d template_format.parse(wp_template)"},{"line_number":278,"context_line":"        t[\u0027Resources\u0027][\u0027MySqlCloudDB\u0027][\u0027Properties\u0027][\u0027databases\u0027] \u003d []"},{"line_number":279,"context_line":"        t[\u0027Resources\u0027][\u0027MySqlCloudDB\u0027][\u0027Properties\u0027][\u0027users\u0027] \u003d \\"},{"line_number":280,"context_line":"            [{\"name\": \"testuser\","},{"line_number":281,"context_line":"              \"password\": \"pass\","},{"line_number":282,"context_line":"              \"databases\": [{\"name\": \"invaliddb\"}]}]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd70%3D","line":279,"updated":"2013-11-05 11:02:38.000000000","message":"same","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def test_osdbinstance_prop_validation_user_no_db(self):"},{"line_number":290,"context_line":"        t \u003d template_format.parse(wp_template)"},{"line_number":291,"context_line":"        t[\u0027Resources\u0027][\u0027MySqlCloudDB\u0027][\u0027Properties\u0027][\u0027databases\u0027] \u003d \\"},{"line_number":292,"context_line":"            [{\"name\": \"validdb\"}]"},{"line_number":293,"context_line":"        t[\u0027Resources\u0027][\u0027MySqlCloudDB\u0027][\u0027Properties\u0027][\u0027users\u0027] \u003d \\"},{"line_number":294,"context_line":"            [{\"name\": \"testuser\", \"password\": \"pass\", \"databases\": []}]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd78%3D","line":291,"updated":"2013-11-05 11:02:38.000000000","message":"same","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a1783a9be1ed74440062263d797b890b2520932b","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        t \u003d template_format.parse(wp_template)"},{"line_number":291,"context_line":"        t[\u0027Resources\u0027][\u0027MySqlCloudDB\u0027][\u0027Properties\u0027][\u0027databases\u0027] \u003d \\"},{"line_number":292,"context_line":"            [{\"name\": \"validdb\"}]"},{"line_number":293,"context_line":"        t[\u0027Resources\u0027][\u0027MySqlCloudDB\u0027][\u0027Properties\u0027][\u0027users\u0027] \u003d \\"},{"line_number":294,"context_line":"            [{\"name\": \"testuser\", \"password\": \"pass\", \"databases\": []}]"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        instance \u003d self._setup_test_clouddbinstance(\u0027dbinstance_test\u0027, t)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fd74%3D","line":293,"updated":"2013-11-05 11:02:38.000000000","message":"same","commit_id":"df78f1c8a25479510ba665f16b866c93937bad91"}]}
