)]}'
{"heat/engine/resources/server.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"a576a20133ac2fde21ca3651aca93ad4f23de979","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                             \u0027or less\u0027)},"},{"line_number":135,"context_line":"        \u0027user_data_format\u0027: {"},{"line_number":136,"context_line":"            \u0027Type\u0027: \u0027String\u0027,"},{"line_number":137,"context_line":"            \u0027Default\u0027: \u0027CLOUD_INIT\u0027,"},{"line_number":138,"context_line":"            \u0027Description\u0027: _(\u0027How the user_data should be formatted for the \u0027"},{"line_number":139,"context_line":"                             \u0027server. For CLOUD_INIT, the user_data is \u0027"},{"line_number":140,"context_line":"                             \u0027bundled as part of the Heat cloud-init boot \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FNls%3D","line":137,"updated":"2013-10-21 11:11:38.000000000","message":"So I really like this new parameter, but I don\u0027t think we should call the default CLOUD_INIT, because we don\u0027t actually allow arbitrary cloud-config sections to be specified, we hard-code a cloud-config, and use a custom part_handler to package the userdata for heat-cfntools.\n\nSo I think the current behaviour would be better called \"heat-cfntools\" or something.\n\nUsing RAW actually provides *more* flexibility when using cloud-init, as now you should be able to specify any cloud-config data you want, just by starting the user-data with \"#cloud-config\".  I think this is great btw, I\u0027ve been meaning to look into doing something similar, but you beat me to it ;)\n\nStylistic nit - I don\u0027t like the CAPS_VALUES, imo lower-case hyphen-delimited is more readable.","commit_id":"0d5e07869a0a99f9d92dd2c76ee8a9a8e987842c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"947e2ee4aebc725204a92400583b0c8f601eb359","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                             \u0027or less\u0027)},"},{"line_number":135,"context_line":"        \u0027user_data_format\u0027: {"},{"line_number":136,"context_line":"            \u0027Type\u0027: \u0027String\u0027,"},{"line_number":137,"context_line":"            \u0027Default\u0027: \u0027CLOUD_INIT\u0027,"},{"line_number":138,"context_line":"            \u0027Description\u0027: _(\u0027How the user_data should be formatted for the \u0027"},{"line_number":139,"context_line":"                             \u0027server. For CLOUD_INIT, the user_data is \u0027"},{"line_number":140,"context_line":"                             \u0027bundled as part of the Heat cloud-init boot \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FLcc%3D","line":137,"in_reply_to":"AAAATH%2F%2FNls%3D","updated":"2013-10-21 21:46:43.000000000","message":"\u003e So I really like this new parameter, but I don\u0027t think we should call the default CLOUD_INIT, because we don\u0027t actually allow arbitrary cloud-config sections to be specified, we hard-code a cloud-config, and use a custom part_handler to package the userdata for heat-cfntools.\n\u003eSo I think the current behaviour would be better called \"heat-cfntools\" or something.\n\nAgreed, the name CLOUD_INIT doesn\u0027t best describe the mode. Maybe HEAT_CFNTOOLS.\n\n\u003e Using RAW actually provides *more* flexibility when using cloud-init, as now you should be able to specify any cloud-config data you want, just by starting the user-data with \"#cloud-config\". I think this is great btw, I\u0027ve been meaning to look into doing something similar, but you beat me to it ;)\n\ncool\n\n\u003e Stylistic nit - I don\u0027t like the CAPS_VALUES, imo lower-case hyphen-delimited is more readable.\n\nPossibly, but as much as we have a convention now for enum-type values, its ALL_CAPS (see flavor_update_policy, diskConfig) and it is a common convention in other languages.","commit_id":"0d5e07869a0a99f9d92dd2c76ee8a9a8e987842c"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e67a504c2cfee5dd02ab13d83d7cc35bce8630ba","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                             \u0027or less\u0027)},"},{"line_number":135,"context_line":"        \u0027user_data_format\u0027: {"},{"line_number":136,"context_line":"            \u0027Type\u0027: \u0027String\u0027,"},{"line_number":137,"context_line":"            \u0027Default\u0027: \u0027CLOUD_INIT\u0027,"},{"line_number":138,"context_line":"            \u0027Description\u0027: _(\u0027How the user_data should be formatted for the \u0027"},{"line_number":139,"context_line":"                             \u0027server. For CLOUD_INIT, the user_data is \u0027"},{"line_number":140,"context_line":"                             \u0027bundled as part of the Heat cloud-init boot \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FNlM%3D","line":137,"in_reply_to":"AAAATH%2F%2FNls%3D","updated":"2013-10-21 11:12:28.000000000","message":"s/hyphen/hypen or underscore","commit_id":"0d5e07869a0a99f9d92dd2c76ee8a9a8e987842c"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"31fb904d0737607827af6c9f8eada33403a1d9f1","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        security_groups \u003d self.properties.get(\u0027security_groups\u0027, [])"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        user_data_format \u003d self.properties.get(\u0027user_data_format\u0027)"},{"line_number":208,"context_line":"        if user_data_format \u003d\u003d \u0027CLOUD_INIT\u0027:"},{"line_number":209,"context_line":"            userdata \u003d self.get_mime_string("},{"line_number":210,"context_line":"                self.properties.get(\u0027user_data\u0027, \u0027\u0027))"},{"line_number":211,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FLBE%3D","line":208,"updated":"2013-10-22 01:15:41.000000000","message":"This shouldn\u0027t ever be true with the allowed values change.","commit_id":"a54db62f37febc9394fdba08c89e2945dfdb7cea"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"a7c8ef516e10c71a175a864522486cd72b874ec0","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        security_groups \u003d self.properties.get(\u0027security_groups\u0027, [])"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        user_data_format \u003d self.properties.get(\u0027user_data_format\u0027)"},{"line_number":208,"context_line":"        if user_data_format \u003d\u003d \u0027CLOUD_INIT\u0027:"},{"line_number":209,"context_line":"            userdata \u003d self.get_mime_string("},{"line_number":210,"context_line":"                self.properties.get(\u0027user_data\u0027, \u0027\u0027))"},{"line_number":211,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FK9I%3D","line":208,"in_reply_to":"AAAATH%2F%2FLBE%3D","updated":"2013-10-22 02:18:36.000000000","message":"Done","commit_id":"a54db62f37febc9394fdba08c89e2945dfdb7cea"},{"author":{"_account_id":6917,"name":"Bartosz Górski","email":"bartosz@codilime.com","username":"bartosz-gorski"},"change_message_id":"dfa135c743b67ca049c20ecddb92829a5bf23a8f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            \u0027Description\u0027: _(\u0027How the user_data should be formatted for the \u0027"},{"line_number":139,"context_line":"                             \u0027server. For HEAT_CFNTOOLS, the user_data is \u0027"},{"line_number":140,"context_line":"                             \u0027bundled as part of the heat-cfntools \u0027"},{"line_number":141,"context_line":"                             \u0027cloud-init boot configuration data. For RAW, \u0027"},{"line_number":142,"context_line":"                             \u0027the user_data is passed to Nova unmodified\u0027),"},{"line_number":143,"context_line":"            \u0027AllowedValues\u0027: [\u0027HEAT_CFNTOOLS\u0027, \u0027RAW\u0027]},"},{"line_number":144,"context_line":"        \u0027user_data\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FKNM%3D","line":141,"updated":"2013-10-22 09:50:13.000000000","message":"\u0027heat-cfntools cloud-init boot configuration\u0027 or just \u0027heat-cfntools boot configuration\u0027?","commit_id":"21c511f9febdecb0c2a8c6f83d2f74f6f37fcf76"},{"author":{"_account_id":6917,"name":"Bartosz Górski","email":"bartosz@codilime.com","username":"bartosz-gorski"},"change_message_id":"a30b31f31401faa2893985503cfbd0ccf8cf6187","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            \u0027Description\u0027: _(\u0027How the user_data should be formatted for the \u0027"},{"line_number":139,"context_line":"                             \u0027server. For HEAT_CFNTOOLS, the user_data is \u0027"},{"line_number":140,"context_line":"                             \u0027bundled as part of the heat-cfntools \u0027"},{"line_number":141,"context_line":"                             \u0027cloud-init boot configuration data. For RAW, \u0027"},{"line_number":142,"context_line":"                             \u0027the user_data is passed to Nova unmodified\u0027),"},{"line_number":143,"context_line":"            \u0027AllowedValues\u0027: [\u0027HEAT_CFNTOOLS\u0027, \u0027RAW\u0027]},"},{"line_number":144,"context_line":"        \u0027user_data\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FH%2FU%3D","line":141,"in_reply_to":"AAAATH%2F%2FIA4%3D","updated":"2013-10-22 20:17:21.000000000","message":"Ok. My bad. You convinced me that it is as it should.","commit_id":"21c511f9febdecb0c2a8c6f83d2f74f6f37fcf76"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"4a9b994fa16591bff3157e72c93c4f4d7c30d5ca","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            \u0027Description\u0027: _(\u0027How the user_data should be formatted for the \u0027"},{"line_number":139,"context_line":"                             \u0027server. For HEAT_CFNTOOLS, the user_data is \u0027"},{"line_number":140,"context_line":"                             \u0027bundled as part of the heat-cfntools \u0027"},{"line_number":141,"context_line":"                             \u0027cloud-init boot configuration data. For RAW, \u0027"},{"line_number":142,"context_line":"                             \u0027the user_data is passed to Nova unmodified\u0027),"},{"line_number":143,"context_line":"            \u0027AllowedValues\u0027: [\u0027HEAT_CFNTOOLS\u0027, \u0027RAW\u0027]},"},{"line_number":144,"context_line":"        \u0027user_data\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FIA4%3D","line":141,"in_reply_to":"AAAATH%2F%2FIEo%3D","updated":"2013-10-22 20:11:59.000000000","message":"agreed, this reads as it shoudl I think. The point is that it uses cloud-init to configure the system the way heat-cfntools expects it to be. Note that this is also how os-collect-config expects it to be (in its heat_local and cfn collectors).","commit_id":"21c511f9febdecb0c2a8c6f83d2f74f6f37fcf76"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"68b805efae01820f790a3c2d3c1edf62a75c8e75","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            \u0027Description\u0027: _(\u0027How the user_data should be formatted for the \u0027"},{"line_number":139,"context_line":"                             \u0027server. For HEAT_CFNTOOLS, the user_data is \u0027"},{"line_number":140,"context_line":"                             \u0027bundled as part of the heat-cfntools \u0027"},{"line_number":141,"context_line":"                             \u0027cloud-init boot configuration data. For RAW, \u0027"},{"line_number":142,"context_line":"                             \u0027the user_data is passed to Nova unmodified\u0027),"},{"line_number":143,"context_line":"            \u0027AllowedValues\u0027: [\u0027HEAT_CFNTOOLS\u0027, \u0027RAW\u0027]},"},{"line_number":144,"context_line":"        \u0027user_data\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FIEo%3D","line":141,"in_reply_to":"AAAATH%2F%2FKNM%3D","updated":"2013-10-22 19:55:23.000000000","message":"cloud-init definitely needs to be mentioned here","commit_id":"21c511f9febdecb0c2a8c6f83d2f74f6f37fcf76"}]}