)]}'
{"heat/engine/resources/wait_condition.py":[{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"e544b77710e22b39cfb81432c8ae859b1aaa8fde","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \u0027Count\u0027: {"},{"line_number":152,"context_line":"            \u0027Type\u0027: \u0027Number\u0027,"},{"line_number":153,"context_line":"            \u0027MinValue\u0027: \u00271\u0027,"},{"line_number":154,"context_line":"            \u0027Description\u0027: _(\u0027The number of success signals that must received\u0027"},{"line_number":155,"context_line":"                             \u0027 before it continues the stack creation process.\u0027"},{"line_number":156,"context_line":"                             \u0027 When the wait condition receives the requisite\u0027"},{"line_number":157,"context_line":"                             \u0027 number of success signals, stack creation will\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fk6U%3D","line":154,"updated":"2013-11-01 02:26:56.000000000","message":"be received?","commit_id":"536625185c2efff1c6d52b7d7cdf00706faa3908"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"e544b77710e22b39cfb81432c8ae859b1aaa8fde","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            \u0027Type\u0027: \u0027Number\u0027,"},{"line_number":153,"context_line":"            \u0027MinValue\u0027: \u00271\u0027,"},{"line_number":154,"context_line":"            \u0027Description\u0027: _(\u0027The number of success signals that must received\u0027"},{"line_number":155,"context_line":"                             \u0027 before it continues the stack creation process.\u0027"},{"line_number":156,"context_line":"                             \u0027 When the wait condition receives the requisite\u0027"},{"line_number":157,"context_line":"                             \u0027 number of success signals, stack creation will\u0027"},{"line_number":158,"context_line":"                             \u0027 resume. If the wait condition does not receive\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fk6M%3D","line":155,"updated":"2013-11-01 02:26:56.000000000","message":"it \u003d\u003e heat engine, since no obviously ref","commit_id":"536625185c2efff1c6d52b7d7cdf00706faa3908"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"e544b77710e22b39cfb81432c8ae859b1aaa8fde","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                             \u0027 before it continues the stack creation process.\u0027"},{"line_number":156,"context_line":"                             \u0027 When the wait condition receives the requisite\u0027"},{"line_number":157,"context_line":"                             \u0027 number of success signals, stack creation will\u0027"},{"line_number":158,"context_line":"                             \u0027 resume. If the wait condition does not receive\u0027"},{"line_number":159,"context_line":"                             \u0027 the specified number of success signals before\u0027"},{"line_number":160,"context_line":"                             \u0027 the Timeout period expires, the Waitcondition\u0027"},{"line_number":161,"context_line":"                             \u0027 will be marked as failed.\u0027)}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fk5w%3D","line":158,"updated":"2013-11-01 02:26:56.000000000","message":"We can remove the sentence(When....resume.) since it\u0027s duplicated with the sentence before.","commit_id":"536625185c2efff1c6d52b7d7cdf00706faa3908"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"700f9e4c204271f43f20660d0acf1d1867c2d1e3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                             \u0027 meaning the timeout occurs no sooner than the\u0027"},{"line_number":148,"context_line":"                             \u0027 time you specify, but can occur shortly there\u0027"},{"line_number":149,"context_line":"                             \u0027 after. The maximum time that can be specified\u0027"},{"line_number":150,"context_line":"                             \u0027 is 12 hours (43200 seconds).\u0027)},"},{"line_number":151,"context_line":"        \u0027Count\u0027: {"},{"line_number":152,"context_line":"            \u0027Type\u0027: \u0027Number\u0027,"},{"line_number":153,"context_line":"            \u0027MinValue\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fj%2BE%3D","line":150,"updated":"2013-11-01 09:54:52.000000000","message":"Actually, we won\u0027t handle anything more than 60mins unless the user explicitly overrides the default stack timeout will we?\n\nhttps://github.com/openstack/heat/blob/master/heat/engine/parser.py#L67","commit_id":"d19d5e5905fa4971ceeb30d71916aa0bd9baa517"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"22c9b4c971a54144dcaec5c5aac990ac282bf593","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                             \u0027 meaning the timeout occurs no sooner than the\u0027"},{"line_number":148,"context_line":"                             \u0027 time you specify, but can occur shortly there\u0027"},{"line_number":149,"context_line":"                             \u0027 after. The maximum time that can be specified\u0027"},{"line_number":150,"context_line":"                             \u0027 is 12 hours (43200 seconds).\u0027)},"},{"line_number":151,"context_line":"        \u0027Count\u0027: {"},{"line_number":152,"context_line":"            \u0027Type\u0027: \u0027Number\u0027,"},{"line_number":153,"context_line":"            \u0027MinValue\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fj6M%3D","line":150,"in_reply_to":"AAAATn%2F%2Fj%2BE%3D","updated":"2013-11-01 10:25:49.000000000","message":"Sure, same is true for aws. This is just a hard upper limit.","commit_id":"d19d5e5905fa4971ceeb30d71916aa0bd9baa517"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"700f9e4c204271f43f20660d0acf1d1867c2d1e3","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            \u0027Description\u0027: _(\u0027The number of success signals that must be\u0027"},{"line_number":155,"context_line":"                             \u0027 received before the stack creation process\u0027"},{"line_number":156,"context_line":"                             \u0027 continues. If the wait condition does not\u0027"},{"line_number":157,"context_line":"                             \u0027receive the specified number of success signals\u0027"},{"line_number":158,"context_line":"                             \u0027 before the Timeout period expires, the\u0027"},{"line_number":159,"context_line":"                             \u0027 Waitcondition will be marked as failed.\u0027)}"},{"line_number":160,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fj%2BQ%3D","line":157,"updated":"2013-11-01 09:54:52.000000000","message":"Missing a space","commit_id":"d19d5e5905fa4971ceeb30d71916aa0bd9baa517"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"22c9b4c971a54144dcaec5c5aac990ac282bf593","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            \u0027Description\u0027: _(\u0027The number of success signals that must be\u0027"},{"line_number":155,"context_line":"                             \u0027 received before the stack creation process\u0027"},{"line_number":156,"context_line":"                             \u0027 continues. If the wait condition does not\u0027"},{"line_number":157,"context_line":"                             \u0027receive the specified number of success signals\u0027"},{"line_number":158,"context_line":"                             \u0027 before the Timeout period expires, the\u0027"},{"line_number":159,"context_line":"                             \u0027 Waitcondition will be marked as failed.\u0027)}"},{"line_number":160,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fj6A%3D","line":157,"in_reply_to":"AAAATn%2F%2Fj%2BQ%3D","updated":"2013-11-01 10:25:49.000000000","message":"Done","commit_id":"d19d5e5905fa4971ceeb30d71916aa0bd9baa517"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0b38abdd312080dd29d8c9d971e16ef1b5151b3a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            \u0027Type\u0027: \u0027Number\u0027,"},{"line_number":141,"context_line":"            \u0027Required\u0027: True,"},{"line_number":142,"context_line":"            \u0027MinValue\u0027: \u00271\u0027,"},{"line_number":143,"context_line":"            \u0027MaxValue\u0027: \u002743200\u0027,"},{"line_number":144,"context_line":"            \u0027Description\u0027: _(\u0027The length of time (in seconds) to wait for the\u0027"},{"line_number":145,"context_line":"                             \u0027 number of signals that the Count property\u0027"},{"line_number":146,"context_line":"                             \u0027 specifies. Timeout is a minimum-bound property,\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FiqQ%3D","line":143,"updated":"2013-11-01 17:39:17.000000000","message":"shouldn\u0027t maxvalue be 43201 to match description?","commit_id":"edb4f5d1490bfd492177974bb5e0d87b202d53e5"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"bc20ae2dbd9fb77c32c6593a8f1f0df1c07787ba","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            \u0027Type\u0027: \u0027Number\u0027,"},{"line_number":141,"context_line":"            \u0027Required\u0027: True,"},{"line_number":142,"context_line":"            \u0027MinValue\u0027: \u00271\u0027,"},{"line_number":143,"context_line":"            \u0027MaxValue\u0027: \u002743200\u0027,"},{"line_number":144,"context_line":"            \u0027Description\u0027: _(\u0027The length of time (in seconds) to wait for the\u0027"},{"line_number":145,"context_line":"                             \u0027 number of signals that the Count property\u0027"},{"line_number":146,"context_line":"                             \u0027 specifies. Timeout is a minimum-bound property,\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Fhog%3D","line":143,"in_reply_to":"AAAATn%2F%2FiqQ%3D","updated":"2013-11-02 09:48:56.000000000","message":"I think it is correct:\nhttps://github.com/openstack/heat/blob/master/heat/engine/properties.py#L440\nif value \u003e max:\n  # then bad\nso if value \u003d\u003d max\n  # it\u0027s ok","commit_id":"edb4f5d1490bfd492177974bb5e0d87b202d53e5"}]}