)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"5dfca7b92aeb931d30be3b718026b072c01325c9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1248218"},{"line_number":19,"context_line":"Change-Id: Iaf8097eff6ad5ae0809d56604699dca2b08db3f4"},{"line_number":20,"context_line":"Signed-off-by: Stephen Gran \u003cstephen.gran@guardian.co.uk\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F%2FPR4%3D","line":20,"updated":"2013-11-12 13:21:23.000000000","message":"Signed-off-by is not needed, we stopped using this after it was pointed out that it doesn\u0027t really serve any purpose in OpenStack:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including external references","commit_id":"c8123a9873c5535e2498bbea7c0ca4de75c25f21"}],"heat/db/sqlalchemy/api.py":[{"author":{"_account_id":7395,"name":"Andrew Plunk","email":"andrew.plunk@rackspace.com","username":"aplunk"},"change_message_id":"cb1658a27577e4c57ddbaa7493224a727c91c695","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    result_list \u003d []"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    for res in result:"},{"line_number":140,"context_line":"        if res.redact:"},{"line_number":141,"context_line":"            res.value \u003d _decrypt(res.value)"},{"line_number":142,"context_line":"        result_list.append(res)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fc94%3D","line":140,"updated":"2013-11-05 21:20:30.000000000","message":"This will cause a decrypted value to get set in the database. This is because res is a sqlalchemy managed object. If you take a look at resource_data_get you will see an example of us returning the decrypted value rather than setting it on the managed object.","commit_id":"12cfdba378c08ab152518f317be7ee51b1d0dce7"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"ef063dce507b316a84110ad2c7277ae211bfab7b","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    result_list \u003d []"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    class resourceData(object):"},{"line_number":139,"context_line":"        def __init__(self, key, value, redact, resource_id):"},{"line_number":140,"context_line":"            self.key \u003d key"},{"line_number":141,"context_line":"            self.value \u003d value"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FcDU%3D","line":138,"updated":"2013-11-06 07:17:08.000000000","message":"Why do we need this? not models.ResourceData?","commit_id":"15e75246a053190acaf60e7e8b880bf9f5931b25"},{"author":{"_account_id":6624,"name":"Stephen Gran","email":"sgran@debian.org","username":"sgran"},"change_message_id":"d14027700960fcee1f57c084169a43f1d8e94e51","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    result_list \u003d []"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    class resourceData(object):"},{"line_number":139,"context_line":"        def __init__(self, key, value, redact, resource_id):"},{"line_number":140,"context_line":"            self.key \u003d key"},{"line_number":141,"context_line":"            self.value \u003d value"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fb98%3D","line":138,"in_reply_to":"AAAATn%2F%2FcDU%3D","updated":"2013-11-06 07:41:29.000000000","message":"We need to be able to potentially change data without modifying the underlying database entries.  This is just a dummy wrapper class that will hold the data and behave like the database entries without modifying it.  If you have a better suggestion for doing this, I\u0027m open to it.","commit_id":"15e75246a053190acaf60e7e8b880bf9f5931b25"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"5dfca7b92aeb931d30be3b718026b072c01325c9","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        value \u003d res.value"},{"line_number":147,"context_line":"        if res.redact:"},{"line_number":148,"context_line":"            value \u003d _decrypt(res.value)"},{"line_number":149,"context_line":"        item \u003d resourceData(res.key, value, res.redact, res.resource_id)"},{"line_number":150,"context_line":"        result_list.append(item)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    return result_list"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FPP8%3D","line":149,"updated":"2013-11-12 13:21:23.000000000","message":"IMO we shouldn\u0027t be returning a list of objects here, where the object definition is private to this function.  \n\nI would prefer just to use a list of dicts instead, which would be more obvious from an interface perspective, and easier in the resource consuming the data (e.g easuer to unpack the dict into a function via kwargs etc)","commit_id":"c8123a9873c5535e2498bbea7c0ca4de75c25f21"},{"author":{"_account_id":7395,"name":"Andrew Plunk","email":"andrew.plunk@rackspace.com","username":"aplunk"},"change_message_id":"fe244c83d1912fb1b9a5c2a0cb5071435fd0bb05","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    return results"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def resource_data_get_all(resource):"},{"line_number":128,"context_line":"    \"\"\"Looks up resource_data by resource.id.  Does not decrypt results."},{"line_number":129,"context_line":"    \"\"\""},{"line_number":130,"context_line":"    result \u003d (model_query(resource.context, models.ResourceData)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FMXQ%3D","line":127,"updated":"2013-11-13 05:07:10.000000000","message":"nitpick, but if res.redact \u003d\u003d True then this function does decrypt the result\u0027s values. It might be more appropriate to comment how it returns a copy of the database model object unencrypted if necessary.","commit_id":"86bc9a56891c782d1bd9dbfe25b00e716722f7d5"},{"author":{"_account_id":6624,"name":"Stephen Gran","email":"sgran@debian.org","username":"sgran"},"change_message_id":"b9c5840cbb987c15d05ea96ba1024ced62900292","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    return results"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def resource_data_get_all(resource):"},{"line_number":128,"context_line":"    \"\"\"Looks up resource_data by resource.id.  Does not decrypt results."},{"line_number":129,"context_line":"    \"\"\""},{"line_number":130,"context_line":"    result \u003d (model_query(resource.context, models.ResourceData)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FMBg%3D","line":127,"in_reply_to":"AAAATn%2F%2FMXQ%3D","updated":"2013-11-13 07:05:59.000000000","message":"Oh, yes, sorry about that.  That doc string is from an early version of this method.  When I updated the method, I forgot to update the docstring.  Will reupload.","commit_id":"86bc9a56891c782d1bd9dbfe25b00e716722f7d5"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"f1a58e24abaaac6710fdb277a360f7b10770fc97","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            \u0027redact\u0027: res.redact,"},{"line_number":148,"context_line":"            \u0027resource_id\u0027: res.resource_id"},{"line_number":149,"context_line":"        }"},{"line_number":150,"context_line":"        result_list.append(item)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    return result_list"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2FG3w%3D","line":150,"updated":"2013-11-14 11:02:50.000000000","message":"The way resource_data_set is implemented, the keys should be unique per resource (although it\u0027s not enforced by the DB, maybe we should fix that), so could this just return a dict, of key/value pairs instead of a list?\n\nThat might be slightly clearer given that the other resource_data* functions talk about key/value pairs, and it will also make things slightly cleaner in loadbalancer.py","commit_id":"cf97e9a83097eee9a4b2c6a6cd7edeb0e49ac912"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"0c2116916df772c89868107c6c6eaff89f67544e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        if res.redact:"},{"line_number":143,"context_line":"            value \u003d _decrypt(res.value)"},{"line_number":144,"context_line":"        item \u003d {"},{"line_number":145,"context_line":"            \u0027key\u0027: res.key,"},{"line_number":146,"context_line":"            \u0027value\u0027: value,"},{"line_number":147,"context_line":"            \u0027redact\u0027: res.redact,"},{"line_number":148,"context_line":"            \u0027resource_id\u0027: res.resource_id"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FFlU%3D","line":145,"updated":"2013-11-14 15:27:44.000000000","message":"If res.key is the dict key, we don\u0027t need to repeat it in the value","commit_id":"de4cf12bdb85e4cd0427fc1e19a4bd5a5b2c1b95"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"0c2116916df772c89868107c6c6eaff89f67544e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            \u0027redact\u0027: res.redact,"},{"line_number":148,"context_line":"            \u0027resource_id\u0027: res.resource_id"},{"line_number":149,"context_line":"        }"},{"line_number":150,"context_line":"        ret[res.key] \u003d item"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    return ret"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FFj0%3D","line":150,"updated":"2013-11-14 15:27:44.000000000","message":"Don\u0027t we actually want ret[res.key] \u003d value?\n\nThe caller already knows the other data, and it aligns better with resource_data_get IMO","commit_id":"de4cf12bdb85e4cd0427fc1e19a4bd5a5b2c1b95"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"9dae1ec0bb99745e6e05adf0eca2a2fbc4475a35","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        value \u003d res.value"},{"line_number":142,"context_line":"        if res.redact:"},{"line_number":143,"context_line":"            value \u003d _decrypt(value)"},{"line_number":144,"context_line":"        ret[res.key] \u003d value"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    return ret"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2FCNA%3D","line":144,"updated":"2013-11-15 11:34:40.000000000","message":"This could be simplified to:\n  if res.redact:\n    ret[res.key] \u003d _decrypt(res.value)\n  else:\n    ret[res.key] \u003d res.value","commit_id":"19396c5983808516d9ad75ee15804fd9a9ecde5f"},{"author":{"_account_id":6917,"name":"Bartosz Górski","email":"bartosz@codilime.com","username":"bartosz-gorski"},"change_message_id":"3a9f3b240814076cc321c3626bb871c490e87ec0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"              .filter_by(resource_id\u003dresource.id))"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    if not result:"},{"line_number":138,"context_line":"        raise exception.NotFound(\u0027No resource data found\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    ret \u003d {}"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FBuE%3D","line":138,"updated":"2013-11-15 14:47:02.000000000","message":"You should add translation here _(\u0027No resource data found\u0027)","commit_id":"b4115ee51ef7f2590dc256c143ed164975ac5191"},{"author":{"_account_id":6624,"name":"Stephen Gran","email":"sgran@debian.org","username":"sgran"},"change_message_id":"c99eb9814b3b3fdea66e8f16e9a9e59379fdc875","unresolved":false,"context_lines":[{"line_number":135,"context_line":"              .filter_by(resource_id\u003dresource.id))"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    if not result:"},{"line_number":138,"context_line":"        raise exception.NotFound(\u0027No resource data found\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    ret \u003d {}"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FBWY%3D","line":138,"in_reply_to":"AAAATn%2F%2FBuE%3D","updated":"2013-11-15 15:37:44.000000000","message":"Done","commit_id":"b4115ee51ef7f2590dc256c143ed164975ac5191"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"bb66ad34c4a527cf96b94a747388e6afb7df1058","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    return results"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"def resource_data_get_all(resource):"},{"line_number":130,"context_line":"    \"\"\""},{"line_number":131,"context_line":"    Looks up resource_data by resource.id.  If data is encrypted,"},{"line_number":132,"context_line":"    this method will decrypt the results."}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2B%2F%2Fs%3D","line":129,"updated":"2013-11-15 22:22:25.000000000","message":"could you please take a look at my review https://review.openstack.org/#/c/56696/1\nJust realized that I am also adding a similar method, but I don\u0027t need decryption. could you change this method something like below;\ndef resource_data_get_all(resource, decrypt\u003dTrue):\n    .....\n    .....\n    if decrypt:\n        for res in result:\n             .....\n             ......\n     return ret","commit_id":"5a33ed6d8b7044a4a48da293a515536de1526654"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"3d11119a34268b2c3a3830f2554e4411d589c427","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    return results"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"def resource_data_get_all(resource):"},{"line_number":130,"context_line":"    \"\"\""},{"line_number":131,"context_line":"    Looks up resource_data by resource.id.  If data is encrypted,"},{"line_number":132,"context_line":"    this method will decrypt the results."}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2B%2F6A%3D","line":129,"in_reply_to":"AAAATn%2F%2B%2F%2Fs%3D","updated":"2013-11-15 23:04:42.000000000","message":"Vijendar,\n\nIt may make more sense for you to improve on this function call in your usage, since it isn\u0027t something this feature needs.","commit_id":"5a33ed6d8b7044a4a48da293a515536de1526654"}],"heat/engine/resources/neutron/loadbalancer.py":[{"author":{"_account_id":7395,"name":"Andrew Plunk","email":"andrew.plunk@rackspace.com","username":"aplunk"},"change_message_id":"cb1658a27577e4c57ddbaa7493224a727c91c695","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":344,"context_line":"        if \u0027members\u0027 in prop_diff:"},{"line_number":345,"context_line":"            members \u003d set(prop_diff[\u0027members\u0027])"},{"line_number":346,"context_line":"            old_members \u003d set(self.t[\u0027Properties\u0027].get(\u0027members\u0027, []))"},{"line_number":347,"context_line":"            if old_members \u003d\u003d set([]):"},{"line_number":348,"context_line":"                db_members \u003d db_api.resource_data_get_all(self)"},{"line_number":349,"context_line":"                old_members \u003d set([res.key for res in db_members])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fc9s%3D","line":346,"updated":"2013-11-05 21:20:30.000000000","message":"From your testing was old_members always coming back as the empty set? If that is the case it might be better to not deal with it at all, and always use the values set in the database.","commit_id":"12cfdba378c08ab152518f317be7ee51b1d0dce7"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"f1a58e24abaaac6710fdb277a360f7b10770fc97","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                              db_api.resource_data_get_all(self))"},{"line_number":350,"context_line":"            client \u003d self.neutron()"},{"line_number":351,"context_line":"            for member in old_members - members:"},{"line_number":352,"context_line":"                member_id \u003d db_api.resource_data_get(self, member)"},{"line_number":353,"context_line":"                try:"},{"line_number":354,"context_line":"                    client.delete_member(member_id)"},{"line_number":355,"context_line":"                except NeutronClientException as ex:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2FG1Y%3D","line":352,"updated":"2013-11-14 11:02:50.000000000","message":"If we just got all the resource data, we don\u0027t really need to get it again here (it will probably result in another DB query, as it\u0027s a model query not a simple get by ID)","commit_id":"cf97e9a83097eee9a4b2c6a6cd7edeb0e49ac912"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"0c2116916df772c89868107c6c6eaff89f67544e","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            members \u003d set(prop_diff[\u0027members\u0027])"},{"line_number":348,"context_line":"            rd_members \u003d db_api.resource_data_get_all(self)"},{"line_number":349,"context_line":"            old_members \u003d set(rd_members[res][\u0027key\u0027] for res in"},{"line_number":350,"context_line":"                              rd_members.keys())"},{"line_number":351,"context_line":"            client \u003d self.neutron()"},{"line_number":352,"context_line":"            for member in old_members - members:"},{"line_number":353,"context_line":"                member_id \u003d rd_members[member][\u0027value\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FFi8%3D","line":350,"updated":"2013-11-14 15:27:44.000000000","message":"Isn\u0027t this just set(rd_members.keys()) ?","commit_id":"de4cf12bdb85e4cd0427fc1e19a4bd5a5b2c1b95"},{"author":{"_account_id":6917,"name":"Bartosz Górski","email":"bartosz@codilime.com","username":"bartosz-gorski"},"change_message_id":"3a9f3b240814076cc321c3626bb871c490e87ec0","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        client \u003d self.neutron()"},{"line_number":332,"context_line":"        nova_client \u003d self.nova()"},{"line_number":333,"context_line":"        protocol_port \u003d self.properties[\u0027protocol_port\u0027]"},{"line_number":334,"context_line":"        members \u003d self.properties.get(\u0027members\u0027) or []"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        for member in members:"},{"line_number":337,"context_line":"            address \u003d nova_utils.server_to_ipaddress(nova_client, member)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FBrg%3D","line":334,"updated":"2013-11-15 14:47:02.000000000","message":"what the reason is to change that?","commit_id":"b4115ee51ef7f2590dc256c143ed164975ac5191"},{"author":{"_account_id":6917,"name":"Bartosz Górski","email":"bartosz@codilime.com","username":"bartosz-gorski"},"change_message_id":"14fe98519beeca23b21268b16c647ee35d6f140f","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        client \u003d self.neutron()"},{"line_number":332,"context_line":"        nova_client \u003d self.nova()"},{"line_number":333,"context_line":"        protocol_port \u003d self.properties[\u0027protocol_port\u0027]"},{"line_number":334,"context_line":"        members \u003d self.properties.get(\u0027members\u0027) or []"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        for member in members:"},{"line_number":337,"context_line":"            address \u003d nova_utils.server_to_ipaddress(nova_client, member)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FA3w%3D","line":334,"in_reply_to":"AAAATn%2F%2FBWM%3D","updated":"2013-11-15 17:37:44.000000000","message":"I see it now. You are right.","commit_id":"b4115ee51ef7f2590dc256c143ed164975ac5191"},{"author":{"_account_id":6624,"name":"Stephen Gran","email":"sgran@debian.org","username":"sgran"},"change_message_id":"c99eb9814b3b3fdea66e8f16e9a9e59379fdc875","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        client \u003d self.neutron()"},{"line_number":332,"context_line":"        nova_client \u003d self.nova()"},{"line_number":333,"context_line":"        protocol_port \u003d self.properties[\u0027protocol_port\u0027]"},{"line_number":334,"context_line":"        members \u003d self.properties.get(\u0027members\u0027) or []"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        for member in members:"},{"line_number":337,"context_line":"            address \u003d nova_utils.server_to_ipaddress(nova_client, member)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FBWM%3D","line":334,"in_reply_to":"AAAATn%2F%2FBrg%3D","updated":"2013-11-15 15:37:44.000000000","message":"Compare:\n\nIn [1]: foo \u003d { \u0027members\u0027: None }\nIn [2]: foo.get(\u0027members\u0027, [])\nIn [3]: foo.get(\u0027members\u0027) or []\nOut[3]: []\n\nThe original was wrong, and failed when the \u0027members\u0027 property was unset.","commit_id":"b4115ee51ef7f2590dc256c143ed164975ac5191"}],"heat/tests/test_neutron_autoscaling.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"f1a58e24abaaac6710fdb277a360f7b10770fc97","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                                    environment.Environment(env))"},{"line_number":376,"context_line":"        stack2.update(update_stack)"},{"line_number":377,"context_line":"        self.assertEqual(stack2.state,"},{"line_number":378,"context_line":"                         (parser.Stack.UPDATE, parser.Stack.COMPLETE))"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        self.m.VerifyAll()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2FG00%3D","line":378,"updated":"2013-11-14 11:02:50.000000000","message":"Is just testing for UPDATE COMPLETE enough here?  I\u0027m thinking maybe we need to inspect the LB resource in the updated stack, to check the properties and resource_data are as we expect.","commit_id":"cf97e9a83097eee9a4b2c6a6cd7edeb0e49ac912"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"9dae1ec0bb99745e6e05adf0eca2a2fbc4475a35","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.m.StubOutWithMock(parser.Stack, \u0027validate\u0027)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        self.m.StubOutWithMock(instance.Instance, \u0027handle_create\u0027)"},{"line_number":136,"context_line":"        self.m.StubOutWithMock(instance.Instance, \u0027check_create_complete\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _stub_create(self, num):"},{"line_number":139,"context_line":"        parser.Stack.validate()"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2FCL0%3D","line":136,"updated":"2013-11-15 11:34:40.000000000","message":"FYI, for future patches, we\u0027re moving from mox to mock, so in general new patches should use mock instead (see a few patches landing recently converting old tests from mox to mock to see how it works)","commit_id":"19396c5983808516d9ad75ee15804fd9a9ecde5f"}],"heat/tests/test_sqlalchemy_api.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"9dae1ec0bb99745e6e05adf0eca2a2fbc4475a35","unresolved":false,"context_lines":[{"line_number":834,"context_line":"            if k \u003d\u003d \u0027test_resource_key\u0027:"},{"line_number":835,"context_line":"                self.assertEqual(\u0027foo\u0027, v)"},{"line_number":836,"context_line":"            elif k \u003d\u003d \u0027encryped_resource_key\u0027:"},{"line_number":837,"context_line":"                self.assertEqual(\u0027test_value\u0027, v)"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def test_resource_data_delete(self):"},{"line_number":840,"context_line":"        create_resource_data(self.ctx, self.resource)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2FCLI%3D","line":837,"updated":"2013-11-15 11:34:40.000000000","message":"Why do you need a loop here, couldn\u0027t you just have two assertEqual lines?\n\nself.assertEqual(\u0027foo\u0027, vals.get(\u0027test_resource_key\u0027))\nself.assertEqual(\u0027test_value\u0027, vals.get(\u0027encryped_resource_key\u0027))","commit_id":"19396c5983808516d9ad75ee15804fd9a9ecde5f"}],"heat/tests/unit/test_neutron_autoscaling.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"5dfca7b92aeb931d30be3b718026b072c01325c9","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        self.assertEqual(stack.state,"},{"line_number":339,"context_line":"                         (parser.Stack.CREATE, parser.Stack.COMPLETE))"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        logger.info(\"******\\nwin, stack create complete\\n******\")"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        stack2 \u003d parser.Stack.load(self.ctx, stack_id\u003dstack.id)"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FPOE%3D","line":341,"updated":"2013-11-12 13:21:23.000000000","message":"We generally don\u0027t put logging in tests (I guess this is from debugging?)","commit_id":"c8123a9873c5535e2498bbea7c0ca4de75c25f21"}]}
