)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"48b2fba3234a0c5b3de0aa4d9affc6cd1f62d2a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rewrite get_secgroup_uuids to avoid resource_by_refid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_secgroup_uuids has change in the following ways:"},{"line_number":10,"context_line":"* No longer attempts to find a security group name via"},{"line_number":11,"context_line":"  a resource_by_refid lookup"},{"line_number":12,"context_line":"* If the security group looks like a UUID, assume it is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2FP2A%3D","line":9,"updated":"2013-11-12 10:08:44.000000000","message":"Should be \"has changed\"","commit_id":"56ce030b0abe52ff753ec861b29234596c90a06d"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"48b2fba3234a0c5b3de0aa4d9affc6cd1f62d2a2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_secgroup_uuids has change in the following ways:"},{"line_number":10,"context_line":"* No longer attempts to find a security group name via"},{"line_number":11,"context_line":"  a resource_by_refid lookup"},{"line_number":12,"context_line":"* If the security group looks like a UUID, assume it is"},{"line_number":13,"context_line":"  a UUID for a security group that exists"},{"line_number":14,"context_line":"* Call client.list_security_groups only once, and only if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2FP18%3D","line":11,"updated":"2013-11-12 10:08:44.000000000","message":"We need to include an explanation of why that is important.","commit_id":"56ce030b0abe52ff753ec861b29234596c90a06d"}],"heat/engine/resources/neutron/neutron.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"48b2fba3234a0c5b3de0aa4d9affc6cd1f62d2a2","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        return unicode(self.resource_id)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @staticmethod"},{"line_number":144,"context_line":"    def get_secgroup_uuids(security_groups, client):"},{"line_number":145,"context_line":"        \u0027\u0027\u0027"},{"line_number":146,"context_line":"        Returns a list of security group UUIDs."},{"line_number":147,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FP04%3D","line":144,"updated":"2013-11-12 10:08:44.000000000","message":"Do we care about maintaining public method signatures? Seems like we don\u0027t, but this jumped out at me.","commit_id":"56ce030b0abe52ff753ec861b29234596c90a06d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"a0103b61b11038075ee0558e9d988e21415eafa4","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        return unicode(self.resource_id)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @staticmethod"},{"line_number":144,"context_line":"    def get_secgroup_uuids(security_groups, client):"},{"line_number":145,"context_line":"        \u0027\u0027\u0027"},{"line_number":146,"context_line":"        Returns a list of security group UUIDs."},{"line_number":147,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FNQs%3D","line":144,"in_reply_to":"AAAATn%2F%2FP04%3D","updated":"2013-11-12 21:47:47.000000000","message":"All in-tree uses were updated, and we\u0027ve given no expectation that the heat python API is stable for out of tree resource types.","commit_id":"56ce030b0abe52ff753ec861b29234596c90a06d"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"5dd534ebde39031bd705d0bfaa54e8ab4006a592","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        for sg in security_groups:"},{"line_number":154,"context_line":"            if uuidutils.is_uuid_like(sg):"},{"line_number":155,"context_line":"                seclist.append(sg)"},{"line_number":156,"context_line":"            else:"},{"line_number":157,"context_line":"                if not all_groups:"},{"line_number":158,"context_line":"                    response \u003d client.list_security_groups()"},{"line_number":159,"context_line":"                    all_groups \u003d response[\u0027security_groups\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FMsA%3D","line":156,"updated":"2013-11-13 02:48:51.000000000","message":"my coverage analysis says everything below this is not tested.","commit_id":"902154c5b1bd4222e5c0ef484a417885ae1e8991"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ed17b91085c520d395f7fb89d2205295fd4b19b4","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        for sg in security_groups:"},{"line_number":154,"context_line":"            if uuidutils.is_uuid_like(sg):"},{"line_number":155,"context_line":"                seclist.append(sg)"},{"line_number":156,"context_line":"            else:"},{"line_number":157,"context_line":"                if not all_groups:"},{"line_number":158,"context_line":"                    response \u003d client.list_security_groups()"},{"line_number":159,"context_line":"                    all_groups \u003d response[\u0027security_groups\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FJKI%3D","line":156,"in_reply_to":"AAAATn%2F%2FMsA%3D","updated":"2013-11-13 21:23:41.000000000","message":"The next change in this series gets full coverage via test_build_nics_with_security_groups","commit_id":"902154c5b1bd4222e5c0ef484a417885ae1e8991"}]}
