)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4e3971bcea389f14f228952679494a9b3c6bb7ab","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Support status added to Resource class as a static attribute."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Implements bp filter-resources-by-support"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ib3aacdb0f28b09ebeecfc3f13cf22587f8d57f03"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F%2Bzp4%3D","line":19,"updated":"2013-11-19 21:59:20.000000000","message":"Randall actually created a blueprint for this. Could you change this to bp resource-support-status\n\nfilter-resources-by-support already depends on resource-support-status","commit_id":"9f7ac92b6f22dfb51ae1637282698fc172a99c0a"}],"heat/engine/resource.py":[{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"e6e962de9b3ae0587a1db830f18d3521261c045c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            self.status \u003d self.UNKNOWN"},{"line_number":103,"context_line":"            self.message \u003d \u0027Specified status was invalid, set status to\\"},{"line_number":104,"context_line":"                            UNKNOWN\u0027"},{"line_number":105,"context_line":"            self.version \u003d None"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B1WI%3D","line":104,"updated":"2013-11-19 15:45:09.000000000","message":"minor thing, just include message text in _(\u0027\u0027) for localization/tranlation.","commit_id":"79580437ff239184a9044ec6c5aaef6f07ef5f16"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"41db9670e8c1528aa565b9c8ed60070299f1f675","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            self.status \u003d self.UNKNOWN"},{"line_number":103,"context_line":"            self.message \u003d \u0027Specified status was invalid, set status to\\"},{"line_number":104,"context_line":"                            UNKNOWN\u0027"},{"line_number":105,"context_line":"            self.version \u003d None"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B1Qg%3D","line":104,"in_reply_to":"AAAATn%2F%2B1WI%3D","updated":"2013-11-19 15:54:45.000000000","message":"Thank you for comment, done.","commit_id":"79580437ff239184a9044ec6c5aaef6f07ef5f16"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"d03a913261b96618b6debcdfe5d36888e926b9c8","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                        UNSUPPORTED) \u003d (\u0027UNKNOWN\u0027, \u0027SUPPORTED\u0027, \u0027PROTOTYPE\u0027,"},{"line_number":94,"context_line":"                                        \u0027DEPRECATED\u0027, \u0027UNSUPPORTED\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, status\u003d\u0027SUPPORTED\u0027, message\u003dNone, version\u003dNone):"},{"line_number":97,"context_line":"        if status in self.SUPPORT_STATUSES:"},{"line_number":98,"context_line":"            self.status \u003d status"},{"line_number":99,"context_line":"            self.message \u003d message"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BxuM%3D","line":96,"updated":"2013-11-20 10:47:44.000000000","message":"Default status should presumably be SupportStatus.SUPPORTED.","commit_id":"f0af5ce97bb22d37f5a2cf2e0546031e17b767f2"},{"author":{"_account_id":7896,"name":"Edmund Troche","email":"edmund.troche@us.ibm.com","username":"edmund"},"change_message_id":"3b0deccb034081ff2a4545456aab5bc1026d460a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            self.status \u003d self.UNKNOWN"},{"line_number":103,"context_line":"            self.message \u003d _(\"Specified status was invalid, set status to\\"},{"line_number":104,"context_line":"                            UNKNOWN\")"},{"line_number":105,"context_line":"            self.version \u003d None"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Brvc%3D","line":104,"updated":"2013-11-21 15:49:20.000000000","message":"I think you meant \" …, setting status to UNKNOWN\", instead of \"set\". Otherwise is hard to tell whether you are saying \"I already set the value to UNKNOWN\" vs instructing the user of this class to set the status to UNKNOWN. Maybe a better way to word it is \"Specified status is invalid, defaulting to UNKNOWN\"?","commit_id":"0d631cf37e9fd9f82004ffad2b418547a17d0fed"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ac94729d734dff56720bca03adeb349b3af94e04","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            self.status \u003d self.UNKNOWN"},{"line_number":103,"context_line":"            self.message \u003d _(\"Specified status was invalid, set status to\\"},{"line_number":104,"context_line":"                            UNKNOWN\")"},{"line_number":105,"context_line":"            self.version \u003d None"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Bqso%3D","line":104,"in_reply_to":"AAAATn%2F%2Brvc%3D","updated":"2013-11-21 19:55:09.000000000","message":"Agree with Edmund.  Since there will be amending involved, add a period to the sentence please as well:)","commit_id":"0d631cf37e9fd9f82004ffad2b418547a17d0fed"},{"author":{"_account_id":6506,"name":"Anastasia Guzikova","email":"aguzikova@mirantis.com","username":"aguzikova"},"change_message_id":"67a93e355895aa29d10c450fdac02322c93751a9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.version \u003d version"},{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            self.status \u003d self.UNKNOWN"},{"line_number":103,"context_line":"            self.message \u003d _(\"Specified status is invalid, defaulting to\\"},{"line_number":104,"context_line":"                              UNKNOWN\")"},{"line_number":105,"context_line":"            self.version \u003d None"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BAXg%3D","line":103,"updated":"2013-12-03 15:37:23.000000000","message":"in this case the message is:\n\u0027Specified status is invalid, defaulting to           UNKNOWN\u0027\n(extra tabs here)\nThe following would be better:\nself.message \u003d _(\"Specified status is invalid, defaulting to \"\n                 \"UNKNOWN\")\nor even:\nself.message \u003d _(\"Specified status is invalid, defaulting to %s\" %\n                 self.UNKNOWN)","commit_id":"885255b48a63e91af579facd7573313ae63f95e9"},{"author":{"_account_id":7714,"name":"Tim Schnell","email":"tim.schnell@rackspace.com","username":"timductive"},"change_message_id":"61d7b8100a56ed81aa12ca58f55b20f92b2cd78a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.version \u003d version"},{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            self.status \u003d self.UNKNOWN"},{"line_number":103,"context_line":"            self.message \u003d _(\"Specified status is invalid, defaulting to\\"},{"line_number":104,"context_line":"                              UNKNOWN\")"},{"line_number":105,"context_line":"            self.version \u003d None"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F9%2F8M%3D","line":103,"in_reply_to":"AAAATn%2F%2BAXg%3D","updated":"2013-12-03 16:31:02.000000000","message":"+1 on substituting self.UNKNOWN","commit_id":"885255b48a63e91af579facd7573313ae63f95e9"}],"heat/tests/test_resource.py":[{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"943949c9721c1a8a3376cfc21c5e806493062844","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"            message\u003d\u0027test_message\u0027,"},{"line_number":1115,"context_line":"            version\u003d\u0027test_version\u0027"},{"line_number":1116,"context_line":"        )"},{"line_number":1117,"context_line":"        self.assertEqual(status.status, \u0027DEPRECATED\u0027)"},{"line_number":1118,"context_line":"        self.assertEqual(status.message, \u0027test_message\u0027)"},{"line_number":1119,"context_line":"        self.assertEqual(status.version, \u0027test_version\u0027)"},{"line_number":1120,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Bqsk%3D","line":1117,"updated":"2013-11-21 19:55:12.000000000","message":"assertEqual correct usage is assertEqual(expected, observed). change the order here and also update below asserts.","commit_id":"0d631cf37e9fd9f82004ffad2b418547a17d0fed"},{"author":{"_account_id":6506,"name":"Anastasia Guzikova","email":"aguzikova@mirantis.com","username":"aguzikova"},"change_message_id":"67a93e355895aa29d10c450fdac02322c93751a9","unresolved":false,"context_lines":[{"line_number":1125,"context_line":"            version\u003d\u0027test_version\u0027"},{"line_number":1126,"context_line":"        )"},{"line_number":1127,"context_line":"        self.assertEqual(\u0027UNKNOWN\u0027, status.status)"},{"line_number":1128,"context_line":"        self.assertNotEqual(\u0027test_message\u0027, status.message)"},{"line_number":1129,"context_line":"        self.assertEqual(None, status.version)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BAVU%3D","line":1128,"updated":"2013-12-03 15:37:23.000000000","message":"According the code in heat/engine/resource.py, the message should be:\n\u0027Specified status is invalid, defaulting to UNKNOWN\u0027\nshouldn\u0027t it?","commit_id":"885255b48a63e91af579facd7573313ae63f95e9"},{"author":{"_account_id":7714,"name":"Tim Schnell","email":"tim.schnell@rackspace.com","username":"timductive"},"change_message_id":"61d7b8100a56ed81aa12ca58f55b20f92b2cd78a","unresolved":false,"context_lines":[{"line_number":1125,"context_line":"            version\u003d\u0027test_version\u0027"},{"line_number":1126,"context_line":"        )"},{"line_number":1127,"context_line":"        self.assertEqual(\u0027UNKNOWN\u0027, status.status)"},{"line_number":1128,"context_line":"        self.assertNotEqual(\u0027test_message\u0027, status.message)"},{"line_number":1129,"context_line":"        self.assertEqual(None, status.version)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F9%2F9E%3D","line":1128,"in_reply_to":"AAAATn%2F%2BAVU%3D","updated":"2013-12-03 16:31:02.000000000","message":"Yes it should which does NOT equal test_message. This is a valid assertion. :)","commit_id":"885255b48a63e91af579facd7573313ae63f95e9"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"2f43ea803d066cf97e9818eccf3138651ad5fec3","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"        self.assertEqual(\u0027UNKNOWN\u0027, status.status)"},{"line_number":1128,"context_line":"        self.assertEqual(\u0027Specified status is invalid, defaulting to UNKNOWN\u0027,"},{"line_number":1129,"context_line":"                         status.message)"},{"line_number":1130,"context_line":"        self.assertEqual(None, status.version)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F96Q0%3D","line":1130,"updated":"2013-12-04 15:54:56.000000000","message":"imo better to use assert.Is(..., None)","commit_id":"c8c82b19049daeeb68c39f2bfa68f6b37176c86c"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"7d0c183db22f4e859bf0894b64de74b95ac6b551","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"        self.assertEqual(\u0027UNKNOWN\u0027, status.status)"},{"line_number":1128,"context_line":"        self.assertEqual(\u0027Specified status is invalid, defaulting to UNKNOWN\u0027,"},{"line_number":1129,"context_line":"                         status.message)"},{"line_number":1130,"context_line":"        self.assertEqual(None, status.version)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F95m0%3D","line":1130,"in_reply_to":"AAAATn%2F96Q0%3D","updated":"2013-12-04 18:00:30.000000000","message":"assertIs and assertIsNone isn\u0027t in 2.6 IIRC and we still have to maintain backwards compatibility (for Icehouse anyway).","commit_id":"c8c82b19049daeeb68c39f2bfa68f6b37176c86c"}]}