)]}'
{"heat/engine/resources/openstack/nova/server_network_mixin.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"6f178364a9d7a59764e47ab19511f7aec6a1fd59","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        # that we have created, otherwise we can encounter deployment"},{"line_number":585,"context_line":"        # issues with duplicate internal port data attempting to be"},{"line_number":586,"context_line":"        # created in instances being deployed."},{"line_number":587,"context_line":"        self._delete_internal_ports()"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    def restore_ports_after_rollback(self, convergence):"},{"line_number":590,"context_line":"        # In case of convergence, during rollback, the previous rsrc is"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_c25a1882","line":587,"updated":"2018-04-27 18:36:07.000000000","message":"Is the problem specific to ports implicitly created by Heat? If the user specified an OS::Neutron::Port resource directly in the template, wouldn\u0027t they run into the same issue? (Nova can\u0027t tell the difference, AFAIK.)","commit_id":"43ec4261c588bcc44c87b793d25aa707299a7baf"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b99abb9ef11028e9873c1384dfc46f2719f76547","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        # that we have created, otherwise we can encounter deployment"},{"line_number":585,"context_line":"        # issues with duplicate internal port data attempting to be"},{"line_number":586,"context_line":"        # created in instances being deployed."},{"line_number":587,"context_line":"        self._delete_internal_ports()"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    def restore_ports_after_rollback(self, convergence):"},{"line_number":590,"context_line":"        # In case of convergence, during rollback, the previous rsrc is"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_59d6ed51","line":587,"in_reply_to":"9f6a8fd7_c25a1882","updated":"2018-04-29 13:33:54.000000000","message":"This is a very good point.\nDeleting implicitly created ports is not the full solution to this problem.\n\nI have put comments on the bug. I think the proper solution is to change neutron and ironic.\n\nThat being said, it might be good to land this anyway to get some relief for users who hit this issue when using implicit ports.","commit_id":"43ec4261c588bcc44c87b793d25aa707299a7baf"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"88c961a9f66a30d4672357a4dd62e85bc03c1644","unresolved":false,"context_lines":[{"line_number":580,"context_line":""},{"line_number":581,"context_line":"    def prepare_ports_for_replace(self):"},{"line_number":582,"context_line":"        self.detach_ports(self)"},{"line_number":583,"context_line":"        server \u003d self.client().servers.get(self.resource_id)"},{"line_number":584,"context_line":"        if server and server.status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":585,"context_line":"            # If we are replacing an ERROR\u0027ed node, we need to delete"},{"line_number":586,"context_line":"            # internal ports that we have created, otherwise we can"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_f31579e6","line":583,"updated":"2018-05-01 19:35:03.000000000","message":"This could return a 404, so I think we want to at least wrap this with:\n\n  with self.client_plugin().ignore_not_found:","commit_id":"24d61f0c3bbca6556396d97659c7144c02a6aa85"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"88c961a9f66a30d4672357a4dd62e85bc03c1644","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    def prepare_ports_for_replace(self):"},{"line_number":582,"context_line":"        self.detach_ports(self)"},{"line_number":583,"context_line":"        server \u003d self.client().servers.get(self.resource_id)"},{"line_number":584,"context_line":"        if server and server.status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":585,"context_line":"            # If we are replacing an ERROR\u0027ed node, we need to delete"},{"line_number":586,"context_line":"            # internal ports that we have created, otherwise we can"},{"line_number":587,"context_line":"            # encounter deployment issues with duplicate internal"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_73df293a","line":584,"updated":"2018-05-01 19:35:03.000000000","message":"An alternative might be to check the resource status (i.e. self.status \u003d\u003d self.FAILED) instead? That might also make it easier to test in I5d544ee1d56732d4669e80fddace1b02d3ab7e0e, since we could use mark-unhealthy to set the status.","commit_id":"24d61f0c3bbca6556396d97659c7144c02a6aa85"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"8e9752fbcf46d4299dfffb5c70f97ded4bca49b5","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    def prepare_ports_for_replace(self):"},{"line_number":582,"context_line":"        self.detach_ports(self)"},{"line_number":583,"context_line":"        server \u003d self.client().servers.get(self.resource_id)"},{"line_number":584,"context_line":"        if server and server.status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":585,"context_line":"            # If we are replacing an ERROR\u0027ed node, we need to delete"},{"line_number":586,"context_line":"            # internal ports that we have created, otherwise we can"},{"line_number":587,"context_line":"            # encounter deployment issues with duplicate internal"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_bd5a5e4d","line":584,"in_reply_to":"9f6a8fd7_27be4165","updated":"2018-05-02 13:57:23.000000000","message":"I think in most cases that\u0027ll be why we\u0027re replacing the server in the first place (i.e. it is in a FAILED state).\n\nThe intersection of cases where we happen to be replacing the server for another reason (e.g. change to a non-updateable property like user_data) and also the server happens to be in an ERROR state is likely to be small.","commit_id":"24d61f0c3bbca6556396d97659c7144c02a6aa85"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5054a55b78a37765fcff208405eac73535874028","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    def prepare_ports_for_replace(self):"},{"line_number":582,"context_line":"        self.detach_ports(self)"},{"line_number":583,"context_line":"        server \u003d self.client().servers.get(self.resource_id)"},{"line_number":584,"context_line":"        if server and server.status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":585,"context_line":"            # If we are replacing an ERROR\u0027ed node, we need to delete"},{"line_number":586,"context_line":"            # internal ports that we have created, otherwise we can"},{"line_number":587,"context_line":"            # encounter deployment issues with duplicate internal"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_27be4165","line":584,"in_reply_to":"9f6a8fd7_73df293a","updated":"2018-05-02 13:34:40.000000000","message":"I guess that actually makes sense as long as heat updates that.","commit_id":"24d61f0c3bbca6556396d97659c7144c02a6aa85"}]}
