)]}'
{"doc/source/ext/resources.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b156d34c86cde78ebf6d8ec02f62af5d8e7b1977","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from heat.engine import resources"},{"line_number":18,"context_line":"from heat.engine import properties"},{"line_number":19,"context_line":"from heat.engine.properties import PropertySchema"},{"line_number":20,"context_line":"from heat.openstack.common.gettextutils import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from docutils import nodes"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHo4%3D","line":19,"updated":"2013-12-02 11:57:01.000000000","message":"These kinds of imports are frowned upon in the OpenStack style guide: http://docs.openstack.org/developer/hacking/#imports\n\nI\u0027d prefer the name properties.Schema.","commit_id":"b9cc1bab09b422ec717acd844aed150b334ca63f"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"dfd39ce4e7498035b3ae2b8a3badc118f84ea679","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from heat.engine import resources"},{"line_number":18,"context_line":"from heat.engine import properties"},{"line_number":19,"context_line":"from heat.engine.properties import PropertySchema"},{"line_number":20,"context_line":"from heat.openstack.common.gettextutils import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from docutils import nodes"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHOI%3D","line":19,"in_reply_to":"AAAATn%2F%2BHo4%3D","updated":"2013-12-02 13:53:14.000000000","message":"Done","commit_id":"b9cc1bab09b422ec717acd844aed150b334ca63f"}],"heat/engine/properties.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b156d34c86cde78ebf6d8ec02f62af5d8e7b1977","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from heat.common import exception"},{"line_number":19,"context_line":"from heat.engine import parameters"},{"line_number":20,"context_line":"from heat.engine.constraints import Schema"},{"line_number":21,"context_line":"from heat.engine.constraints import InvalidSchemaError"},{"line_number":22,"context_line":"from heat.engine.constraints import Range"},{"line_number":23,"context_line":"from heat.engine.constraints import Length"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHrs%3D","line":20,"updated":"2013-12-02 11:57:01.000000000","message":"This one seems slightly dangerous to be importing in a non-namespaced way, considering that the existing PropertiesSchema class was previously referred to as properties.Schema (which is now how this superclass will appear).","commit_id":"b9cc1bab09b422ec717acd844aed150b334ca63f"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"dfd39ce4e7498035b3ae2b8a3badc118f84ea679","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from heat.common import exception"},{"line_number":19,"context_line":"from heat.engine import parameters"},{"line_number":20,"context_line":"from heat.engine.constraints import Schema"},{"line_number":21,"context_line":"from heat.engine.constraints import InvalidSchemaError"},{"line_number":22,"context_line":"from heat.engine.constraints import Range"},{"line_number":23,"context_line":"from heat.engine.constraints import Length"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHN0%3D","line":20,"in_reply_to":"AAAATn%2F%2BHrs%3D","updated":"2013-12-02 13:53:14.000000000","message":"Done. In this file, I did an import of the constraints module as \u0027constr\u0027 to avoid naming conflicts with uses of of constraints inside the code.","commit_id":"b9cc1bab09b422ec717acd844aed150b334ca63f"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b156d34c86cde78ebf6d8ec02f62af5d8e7b1977","unresolved":false,"context_lines":[{"line_number":36,"context_line":")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class PropertySchema(Schema):"},{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":"    Property Schema class for validating resource properties."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHqw%3D","line":39,"updated":"2013-12-02 11:57:01.000000000","message":"I\u0027d prefer if this could just be named \u0027Schema\u0027, then none of the places it is used need to change (it can just be referred to as properties.Schema to distinguish it from parameters.Schema).\n\n  class Schema(constraints.Schema):\n      ...\n\nThis would also have the happy side effect of fixing all the things below that say Schema.[LIST|MAP|...] instead of PropertiesSchema.[LIST|MAP|...].","commit_id":"b9cc1bab09b422ec717acd844aed150b334ca63f"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"dfd39ce4e7498035b3ae2b8a3badc118f84ea679","unresolved":false,"context_lines":[{"line_number":36,"context_line":")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class PropertySchema(Schema):"},{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":"    Property Schema class for validating resource properties."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHOE%3D","line":39,"in_reply_to":"AAAATn%2F%2BHqw%3D","updated":"2013-12-02 13:53:14.000000000","message":"Done","commit_id":"b9cc1bab09b422ec717acd844aed150b334ca63f"}]}