)]}'
{"heat/tests/test_parser.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fff103bbb80a36e21c4df245353f48490fa16dfa","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        # split then join then split then join"},{"line_number":636,"context_line":"        snippet \u003d {\u0027Fn::Join\u0027: [\u0027-\u0027, snippet]}"},{"line_number":637,"context_line":"        self.assertEqual(\u0027one-two-three\u0027,"},{"line_number":638,"context_line":"                         self.stack.resolve_runtime_data(snippet))"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    def test_join_recursive(self):"},{"line_number":641,"context_line":"        raw \u003d {\u0027Fn::Join\u0027: [\u0027\\n\u0027, [{\u0027Fn::Join\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9tDw%3D","line":638,"updated":"2013-12-06 22:58:51.000000000","message":"Interesting observation, not a negative comment...\n\nI usually think this is a nice way to write tests for recursive things, which is to go through enough levels deep explicitly to understand. Though there is value in an algorithmic approach too.\n\nHowever, I read this and got confused by what it was doing, thinking the functions we\u0027re calling might be keeping state somehow.\n\nAnyway, it might be good to clarify at the top that this is simulating 4 levels of recursive calling of split then join.","commit_id":"89884627825231f6a17298f6e7c0e2a1a833f3e2"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"defb1931c9e25df77fa845505103ed1ef3eee6b3","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        # split then join then split then join"},{"line_number":636,"context_line":"        snippet \u003d {\u0027Fn::Join\u0027: [\u0027-\u0027, snippet]}"},{"line_number":637,"context_line":"        self.assertEqual(\u0027one-two-three\u0027,"},{"line_number":638,"context_line":"                         self.stack.resolve_runtime_data(snippet))"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    def test_join_recursive(self):"},{"line_number":641,"context_line":"        raw \u003d {\u0027Fn::Join\u0027: [\u0027\\n\u0027, [{\u0027Fn::Join\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9qnM%3D","line":638,"in_reply_to":"AAAATn%2F9tDw%3D","updated":"2013-12-09 02:56:04.000000000","message":"Done","commit_id":"89884627825231f6a17298f6e7c0e2a1a833f3e2"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fff103bbb80a36e21c4df245353f48490fa16dfa","unresolved":false,"context_lines":[{"line_number":700,"context_line":"                                   \"bink\"]]}"},{"line_number":701,"context_line":"        self.assertEqual("},{"line_number":702,"context_line":"            self.stack.resolve_static_data(join),"},{"line_number":703,"context_line":"            {\"Fn::Join\": [\" \", [\"foo\", {\u0027Ref\u0027: \u0027baz\u0027}, \"bink\"]]})"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"        join \u003d {\"Fn::Join\": [\" \", [{\u0027Ref\u0027: \u0027baz\u0027}]]}"},{"line_number":706,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9tAY%3D","line":703,"updated":"2013-12-06 22:58:51.000000000","message":"Flip the order of arguments to assertEqual. It should be expected, observed.","commit_id":"89884627825231f6a17298f6e7c0e2a1a833f3e2"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d6ce2152d634a996fffecf1f09e916724c066b1d","unresolved":false,"context_lines":[{"line_number":700,"context_line":"                                   \"bink\"]]}"},{"line_number":701,"context_line":"        self.assertEqual("},{"line_number":702,"context_line":"            self.stack.resolve_static_data(join),"},{"line_number":703,"context_line":"            {\"Fn::Join\": [\" \", [\"foo\", {\u0027Ref\u0027: \u0027baz\u0027}, \"bink\"]]})"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"        join \u003d {\"Fn::Join\": [\" \", [{\u0027Ref\u0027: \u0027baz\u0027}]]}"},{"line_number":706,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9qtA%3D","line":703,"in_reply_to":"AAAATn%2F9tAY%3D","updated":"2013-12-09 01:54:37.000000000","message":"Done","commit_id":"89884627825231f6a17298f6e7c0e2a1a833f3e2"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fff103bbb80a36e21c4df245353f48490fa16dfa","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        join \u003d {\"Fn::Join\": [\" \", [{\u0027Ref\u0027: \u0027baz\u0027}]]}"},{"line_number":706,"context_line":"        self.assertEqual("},{"line_number":707,"context_line":"            self.stack.resolve_static_data(join),"},{"line_number":708,"context_line":"            {\"Fn::Join\": [\" \", [{\u0027Ref\u0027: \u0027baz\u0027}]]})"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"class StackTest(HeatTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9tAU%3D","line":708,"updated":"2013-12-06 22:58:51.000000000","message":"same on this one.","commit_id":"89884627825231f6a17298f6e7c0e2a1a833f3e2"}]}
