)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"a55ae35d11ecd86f917d480dd4ed476c91566003","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t replace (and log) the same resource entry"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to prevent repeated logs of a resource been"},{"line_number":10,"context_line":"re-registered."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iedd12d55007ee24ea6ecbe4fe7152ff65ea665b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9yX0%3D","line":9,"updated":"2013-12-05 22:16:05.000000000","message":"This sentence is a bit confusing, and I think you meant \"being\" rather than been.\n\nI suggest this alternate wording:\n\n\"Resources may be registered multiple times. This ensures that logs are only emitted the first time a resource is registered.\"","commit_id":"7a28d3e3c65f96407b39d9bfbeaf125cd607ccad"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"ae9a5ef51e54bfaf7d70f95a5ef72523f77589f4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t replace (and log) the same resource entry"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to prevent repeated logs of a resource been"},{"line_number":10,"context_line":"re-registered."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iedd12d55007ee24ea6ecbe4fe7152ff65ea665b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9yTg%3D","line":9,"in_reply_to":"AAAATn%2F9yX0%3D","updated":"2013-12-05 22:28:55.000000000","message":"ga, I should read what I write:(","commit_id":"7a28d3e3c65f96407b39d9bfbeaf125cd607ccad"}],"heat/engine/environment.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"a55ae35d11ecd86f917d480dd4ed476c91566003","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if name in registry and isinstance(registry[name], ResourceInfo):"},{"line_number":200,"context_line":"            if registry[name].value \u003d\u003d info.value:"},{"line_number":201,"context_line":"                return"},{"line_number":202,"context_line":"            details \u003d {"},{"line_number":203,"context_line":"                \u0027path\u0027: descriptive_path,"},{"line_number":204,"context_line":"                \u0027was\u0027: str(registry[name].value),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9yXw%3D","line":201,"updated":"2013-12-05 22:16:05.000000000","message":"this new behavior is untested.","commit_id":"7a28d3e3c65f96407b39d9bfbeaf125cd607ccad"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"ae9a5ef51e54bfaf7d70f95a5ef72523f77589f4","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if name in registry and isinstance(registry[name], ResourceInfo):"},{"line_number":200,"context_line":"            if registry[name].value \u003d\u003d info.value:"},{"line_number":201,"context_line":"                return"},{"line_number":202,"context_line":"            details \u003d {"},{"line_number":203,"context_line":"                \u0027path\u0027: descriptive_path,"},{"line_number":204,"context_line":"                \u0027was\u0027: str(registry[name].value),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9ySQ%3D","line":201,"in_reply_to":"AAAATn%2F9yXw%3D","updated":"2013-12-05 22:28:55.000000000","message":"I agree, just not easy to test that something didn\u0027t get logged. But I\u0027ll try add\nsome tests around this to prove I haven\u0027t broken anything.","commit_id":"7a28d3e3c65f96407b39d9bfbeaf125cd607ccad"}],"heat/tests/test_environment.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"3d3f7c603dc10b6cd204388166b81b8f529f697b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                               \u0027my_fip\u0027).value)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class EnvironmentDuplicateTest(common.HeatTestCase):"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    scenarios \u003d ["},{"line_number":117,"context_line":"        (\u0027same\u0027, dict(resource_type\u003d\u0027test.yaml\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9t98%3D","line":114,"updated":"2013-12-06 19:21:15.000000000","message":"So I think we need to update HeatTestCase to make the FakeLogger accessible by just adding self.logger \u003d to the useFixture line. Then you _can_ make sure the log message appears only once with\n\n    self.assertEquals(1, self.logger.output.index(\u0027Changing path from OS::Test::Dummy\u0027))\n\nNot sure of the exact message, but you get the idea.","commit_id":"60670b310ea78957ec68e09a48968ea3ed13cb46"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"f20680321fe31fec2bae7ad9bfb4ef80de073fc1","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        env.load(env_test)"},{"line_number":138,"context_line":"        if self.expected_equal:"},{"line_number":139,"context_line":"            # should return exactly the same object."},{"line_number":140,"context_line":"            self.assertTrue(info is env.get_resource_info(\u0027OS::Test::Dummy\u0027,"},{"line_number":141,"context_line":"                                                          \u0027my_fip\u0027))"},{"line_number":142,"context_line":"        else:"},{"line_number":143,"context_line":"            self.assertNotEqual(info,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9uyY%3D","line":140,"updated":"2013-12-06 16:12:26.000000000","message":"using assertIs looks more appropriate","commit_id":"60670b310ea78957ec68e09a48968ea3ed13cb46"}]}