)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"e5f134ec72e42f9da522fc81330eeccd000fac50","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-12-08 10:47:10 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support network name for os::nova::Server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Property \u0027network\u0027 is added a to the networks schema. It takes"},{"line_number":10,"context_line":"uuid or name. The \u0027uuid\u0027 property is deprecated."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAATn%2F9rbM%3D","line":8,"updated":"2013-12-08 09:44:24.000000000","message":"Small typos and suggestions: \n\nAdd support for network name to os::nova::Server\n\nNext line: \u0027a\u0027 is unnecessary.","commit_id":"333f4fcc610f496c09fc834f7ee8fe17021cdeba"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"325ac896e2054e3f66ca2882c386e5ec35dc6f58","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-12-08 10:47:10 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support network name for os::nova::Server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Property \u0027network\u0027 is added a to the networks schema. It takes"},{"line_number":10,"context_line":"uuid or name. The \u0027uuid\u0027 property is deprecated."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAATn%2F9o%2FA%3D","line":8,"in_reply_to":"AAAATn%2F9rbM%3D","updated":"2013-12-09 12:49:26.000000000","message":"Thanks!","commit_id":"333f4fcc610f496c09fc834f7ee8fe17021cdeba"}],"heat/engine/resources/server.py":[{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"349acdb1cff332928d882072a5bfbbb05327df8c","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        # both at once for all networks"},{"line_number":475,"context_line":"        networks \u003d self.properties.get(\u0027networks\u0027) or []"},{"line_number":476,"context_line":"        for network in networks:"},{"line_number":477,"context_line":"            if network.get(\u0027uuid\u0027) and network.get(\u0027network\u0027):"},{"line_number":478,"context_line":"                msg \u003d _(\u0027Properties \"uuid\" and \"network\" are both set \u0027"},{"line_number":479,"context_line":"                        \u0027to the network \"%s\". The \"uuid\" property is \u0027"},{"line_number":480,"context_line":"                        \u0027deprecated. Use the only \"network\" property.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F96Xw%3D","line":477,"updated":"2013-12-04 15:32:15.000000000","message":"if only \u0027uuid\u0027 is specified, should there be a logger.info message that says \u0027uuid property is being deprecated\u0027?","commit_id":"6b66d5e131e598631db67173374862c600a84189"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"f8374cc0809737d0c8d637a2724ac0c0d607195a","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        # both at once for all networks"},{"line_number":475,"context_line":"        networks \u003d self.properties.get(\u0027networks\u0027) or []"},{"line_number":476,"context_line":"        for network in networks:"},{"line_number":477,"context_line":"            if network.get(\u0027uuid\u0027) and network.get(\u0027network\u0027):"},{"line_number":478,"context_line":"                msg \u003d _(\u0027Properties \"uuid\" and \"network\" are both set \u0027"},{"line_number":479,"context_line":"                        \u0027to the network \"%s\". The \"uuid\" property is \u0027"},{"line_number":480,"context_line":"                        \u0027deprecated. Use the only \"network\" property.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F95po%3D","line":477,"in_reply_to":"AAAATn%2F96Xw%3D","updated":"2013-12-04 17:56:34.000000000","message":"It is good idea. Thank you.","commit_id":"6b66d5e131e598631db67173374862c600a84189"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"349acdb1cff332928d882072a5bfbbb05327df8c","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            if network.get(\u0027uuid\u0027) and network.get(\u0027network\u0027):"},{"line_number":478,"context_line":"                msg \u003d _(\u0027Properties \"uuid\" and \"network\" are both set \u0027"},{"line_number":479,"context_line":"                        \u0027to the network \"%s\". The \"uuid\" property is \u0027"},{"line_number":480,"context_line":"                        \u0027deprecated. Use the only \"network\" property.\u0027"},{"line_number":481,"context_line":"                        \u0027\u0027) % network[\u0027network\u0027]"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"                raise exception.StackValidationFailed(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F96b8%3D","line":480,"updated":"2013-12-04 15:32:15.000000000","message":"small nit. If you are updating the patch, change \u0027Use the only \"network\" property.\" to something like \u0027Use only \"network\" property.\"","commit_id":"6b66d5e131e598631db67173374862c600a84189"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"f8374cc0809737d0c8d637a2724ac0c0d607195a","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            if network.get(\u0027uuid\u0027) and network.get(\u0027network\u0027):"},{"line_number":478,"context_line":"                msg \u003d _(\u0027Properties \"uuid\" and \"network\" are both set \u0027"},{"line_number":479,"context_line":"                        \u0027to the network \"%s\". The \"uuid\" property is \u0027"},{"line_number":480,"context_line":"                        \u0027deprecated. Use the only \"network\" property.\u0027"},{"line_number":481,"context_line":"                        \u0027\u0027) % network[\u0027network\u0027]"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"                raise exception.StackValidationFailed(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F95pg%3D","line":480,"in_reply_to":"AAAATn%2F96b8%3D","updated":"2013-12-04 17:56:34.000000000","message":"Thanks for you nit.","commit_id":"6b66d5e131e598631db67173374862c600a84189"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"1f94b156ad77e49df9b038e794f7e4b6065c9e9d","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        # both at once for all networks"},{"line_number":477,"context_line":"        networks \u003d self.properties.get(\u0027networks\u0027) or []"},{"line_number":478,"context_line":"        for network in networks:"},{"line_number":479,"context_line":"            if network.get(\u0027uuid\u0027) and network.get(\u0027network\u0027):"},{"line_number":480,"context_line":"                msg \u003d _(\u0027Properties \"uuid\" and \"network\" are both set \u0027"},{"line_number":481,"context_line":"                        \u0027to the network \"%s\". The \"uuid\" property is \u0027"},{"line_number":482,"context_line":"                        \u0027deprecated. Use only \"network\" property.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F95ks%3D","line":479,"updated":"2013-12-04 18:10:24.000000000","message":"As long as user just provide uuid (no network), there would not be any info/warning to user. probably we should add logger.info/warn message.\n\nI think you can add else block as below:\nelif network.get(\u0027uuid\u0027):\n    logger.info(\u0027uuid is deprecated\u0027)","commit_id":"c7b8e09e1804a0c678211b358c0bb45a1c152467"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"a2d5148e82f742a33ef98fec92d8ea9d2cc82eb9","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        # both at once for all networks"},{"line_number":477,"context_line":"        networks \u003d self.properties.get(\u0027networks\u0027) or []"},{"line_number":478,"context_line":"        for network in networks:"},{"line_number":479,"context_line":"            if network.get(\u0027uuid\u0027) and network.get(\u0027network\u0027):"},{"line_number":480,"context_line":"                msg \u003d _(\u0027Properties \"uuid\" and \"network\" are both set \u0027"},{"line_number":481,"context_line":"                        \u0027to the network \"%s\". The \"uuid\" property is \u0027"},{"line_number":482,"context_line":"                        \u0027deprecated. Use only \"network\" property.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F95jM%3D","line":479,"in_reply_to":"AAAATn%2F95ks%3D","updated":"2013-12-04 18:31:46.000000000","message":"Yes. It is a right place for log message. But I think that more detailed message will be better.","commit_id":"c7b8e09e1804a0c678211b358c0bb45a1c152467"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"198832317cca3fa986e962c078a30e0734b70761","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                else:"},{"line_number":343,"context_line":"                    network \u003d self.nova().networks.find("},{"line_number":344,"context_line":"                        label\u003dnet_data[\u0027network\u0027])"},{"line_number":345,"context_line":"                    nic_info[\u0027net-id\u0027] \u003d network.id"},{"line_number":346,"context_line":"            if net_data.get(\u0027fixed_ip\u0027):"},{"line_number":347,"context_line":"                nic_info[\u0027v4-fixed-ip\u0027] \u003d net_data[\u0027fixed_ip\u0027]"},{"line_number":348,"context_line":"            if net_data.get(\u0027port\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F93iQ%3D","line":345,"updated":"2013-12-05 02:27:09.000000000","message":"Not sure whether you think below is better:\n\nlabel \u003d net_data.get(\u0027network\u0027)\nif label:\n    if uuidutils.is_uuid_like(label):\n        nic_info[\u0027net-id\u0027] \u003d label\n    else:\n        network \u003d self.nova().networks.find(label\u003dlabel)\n        nic_info[\u0027net-id\u0027] \u003d network.id","commit_id":"df361e11167e9725988be0246a2f1b5bf178ad8a"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"5aa349a36071dedd1f7e17478317930ec6fe52d2","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                else:"},{"line_number":343,"context_line":"                    network \u003d self.nova().networks.find("},{"line_number":344,"context_line":"                        label\u003dnet_data[\u0027network\u0027])"},{"line_number":345,"context_line":"                    nic_info[\u0027net-id\u0027] \u003d network.id"},{"line_number":346,"context_line":"            if net_data.get(\u0027fixed_ip\u0027):"},{"line_number":347,"context_line":"                nic_info[\u0027v4-fixed-ip\u0027] \u003d net_data[\u0027fixed_ip\u0027]"},{"line_number":348,"context_line":"            if net_data.get(\u0027port\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F92sI%3D","line":345,"in_reply_to":"AAAATn%2F93iQ%3D","updated":"2013-12-05 07:55:39.000000000","message":"Your proposition looks beter better for me. I will make this change in next patch. Thank you.","commit_id":"df361e11167e9725988be0246a2f1b5bf178ad8a"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"c92c1bd1d5548be584fb51fd968d92229cd36233","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                raise exception.StackValidationFailed(message\u003dmsg)"},{"line_number":483,"context_line":"            elif network.get(\u0027uuid\u0027):"},{"line_number":484,"context_line":"                logger.info(_(\u0027The \"uuid\" network property is \u0027"},{"line_number":485,"context_line":"                              \u0027deprecated. Use \"network\" property instead.\u0027))"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def handle_delete(self):"},{"line_number":488,"context_line":"        \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9rqY%3D","line":485,"updated":"2013-12-08 00:31:18.000000000","message":"If you can also log the network name that would be useful. Thanks!","commit_id":"bfee88d087be6dd3a27344f99742e7814711a4f5"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"21b392b3190bff31ac680f5d70d9589b0c6c28bf","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                raise exception.StackValidationFailed(message\u003dmsg)"},{"line_number":483,"context_line":"            elif network.get(\u0027uuid\u0027):"},{"line_number":484,"context_line":"                logger.info(_(\u0027The \"uuid\" network property is \u0027"},{"line_number":485,"context_line":"                              \u0027deprecated. Use \"network\" property instead.\u0027))"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def handle_delete(self):"},{"line_number":488,"context_line":"        \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9reE%3D","line":485,"in_reply_to":"AAAATn%2F9rqY%3D","updated":"2013-12-08 07:42:09.000000000","message":"It is easy. I\u0027ll add it to new patch.","commit_id":"bfee88d087be6dd3a27344f99742e7814711a4f5"},{"author":{"_account_id":7225,"name":"Serg Melikyan","email":"smelikyan@mirantis.com","username":"smelikyan"},"change_message_id":"389113a5fa45d8f02b1124416f5ffbaf69d3014b","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            if network.get(\u0027uuid\u0027) and network.get(\u0027network\u0027):"},{"line_number":471,"context_line":"                msg \u003d _(\u0027Properties \"uuid\" and \"network\" are both set \u0027"},{"line_number":472,"context_line":"                        \u0027to the network \"%(network)s\" for the server \u0027"},{"line_number":473,"context_line":"                        \u0027\"%(server)s\". The \"uuid\" property is deprecated. \u0027"},{"line_number":474,"context_line":"                        \u0027Use only \"network\" property.\u0027"},{"line_number":475,"context_line":"                        \u0027\u0027) % dict(network\u003dnetwork[\u0027network\u0027],"},{"line_number":476,"context_line":"                                   server\u003dself.name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9RfM%3D","line":473,"updated":"2013-12-13 07:55:34.000000000","message":"Is there an assumption that both properties is set to the same network?","commit_id":"02bd04c6ad479f7e916212f358ca47c05e685b98"}],"heat/tests/test_server.py":[{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"ca63ad03b9c1c5f0a1bfbd12d92b799996c856fe","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"            {\u0027network\u0027: \u0027bar\u0027},"},{"line_number":1003,"context_line":"            {\u0027fixed_ip\u0027: \u0027192.0.2.0\u0027},"},{"line_number":1004,"context_line":"            {\u0027port\u0027: \u0027aaaabbbb\u0027}"},{"line_number":1005,"context_line":"        ]))"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"    def test_server_without_ip_address(self):"},{"line_number":1008,"context_line":"        return_server \u003d self.fc.servers.list()[3]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F99CE%3D","line":1005,"updated":"2013-12-04 02:41:12.000000000","message":"From current impl `uuid\u0027 and `network\u0027 can be specified at the same time and `network\u0027 value will be used. Not sure whether it\u0027s a valid scenario. If yes, we can add test case here, if no, we can add validation to prevent it.","commit_id":"ee16e55669bbe53f19910384b20a08d66f4b6154"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"3bce4d69eafab7dfb259d85bfea81d0bb8750ee5","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"            {\u0027network\u0027: \u0027bar\u0027},"},{"line_number":1003,"context_line":"            {\u0027fixed_ip\u0027: \u0027192.0.2.0\u0027},"},{"line_number":1004,"context_line":"            {\u0027port\u0027: \u0027aaaabbbb\u0027}"},{"line_number":1005,"context_line":"        ]))"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"    def test_server_without_ip_address(self):"},{"line_number":1008,"context_line":"        return_server \u003d self.fc.servers.list()[3]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F97Eo%3D","line":1005,"in_reply_to":"AAAATn%2F99CE%3D","updated":"2013-12-04 12:54:15.000000000","message":"I add validation to prevent this situation. StackValidationFailed exception is raised if  `uuid\u0027 and `network\u0027 are specified at the same time.  Also test for this case is added.","commit_id":"ee16e55669bbe53f19910384b20a08d66f4b6154"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"635a6f196e86fa19066d313b857b21c142da7417","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        server.nova().MultipleTimes().AndReturn(self.fc)"},{"line_number":383,"context_line":"        self.m.ReplayAll()"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        self.assertRaises(exception.StackValidationFailed, server.validate)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        self.m.VerifyAll()"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F90MI%3D","line":385,"updated":"2013-12-05 16:25:31.000000000","message":"This test should check that the content of the error message matches what is expected.  For example:\n\n exc \u003d self.assertRaises(exception.StackValidationFailed, server.validate)\n self.assertIn(\"specific content of exception message\", str(exc))","commit_id":"1701a0e7155f8f8c7f82e7c8b0ac54c855d254f1"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"ae64aaff7fd7b82823e5db2c620adb101d4c702c","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        server.nova().MultipleTimes().AndReturn(self.fc)"},{"line_number":383,"context_line":"        self.m.ReplayAll()"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        self.assertRaises(exception.StackValidationFailed, server.validate)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        self.m.VerifyAll()"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F90CQ%3D","line":385,"in_reply_to":"AAAATn%2F90MI%3D","updated":"2013-12-05 16:59:29.000000000","message":"Thanks for your comment.","commit_id":"1701a0e7155f8f8c7f82e7c8b0ac54c855d254f1"},{"author":{"_account_id":9189,"name":"Anderson Mesquita","email":"andersonvom@gmail.com","username":"andersonvom"},"change_message_id":"a73975861120e133a912ab477f9cacacfd664373","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"            {\u0027fixed_ip\u0027: \u0027192.0.2.0\u0027},"},{"line_number":1002,"context_line":"            {\u0027port\u0027: \u0027aaaabbbb\u0027}"},{"line_number":1003,"context_line":"        ]))"},{"line_number":1004,"context_line":"        self.assertEqual(["},{"line_number":1005,"context_line":"            {\u0027net-id\u0027: \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027},"},{"line_number":1006,"context_line":"            {\u0027v4-fixed-ip\u0027: \u0027192.0.2.0\u0027},"},{"line_number":1007,"context_line":"            {\u0027port-id\u0027: \u0027aaaabbbb\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9xYY%3D","line":1004,"updated":"2013-12-06 05:14:39.000000000","message":"When calling _build_nics(), net-id, v4-fixed-ip and port-id are all handled separately, so this test would read MUCH better if these were being tested separately as well and not in a repeated manner: \u0027v4-fixed-ip\u0027 and \u0027port-id\u0027 get tested 3 times. \n\nYou could test all of them in a single call, and then test only the network edge cases separately, without repeating ip and port.\n\nThis would make the test smaller and the behavior more explicit/readable.","commit_id":"a367c4cfe47b9ca2260a648c55b5f187d7f8f3a5"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"8c9d1494c212832c4d2d42f8e33a95805a78de7f","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"            {\u0027fixed_ip\u0027: \u0027192.0.2.0\u0027},"},{"line_number":1002,"context_line":"            {\u0027port\u0027: \u0027aaaabbbb\u0027}"},{"line_number":1003,"context_line":"        ]))"},{"line_number":1004,"context_line":"        self.assertEqual(["},{"line_number":1005,"context_line":"            {\u0027net-id\u0027: \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027},"},{"line_number":1006,"context_line":"            {\u0027v4-fixed-ip\u0027: \u0027192.0.2.0\u0027},"},{"line_number":1007,"context_line":"            {\u0027port-id\u0027: \u0027aaaabbbb\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9vGc%3D","line":1004,"in_reply_to":"AAAATn%2F9xYY%3D","updated":"2013-12-06 15:20:26.000000000","message":"You are completely right.  Readability counts. :)","commit_id":"a367c4cfe47b9ca2260a648c55b5f187d7f8f3a5"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"e5f134ec72e42f9da522fc81330eeccd000fac50","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        (t, stack) \u003d self._setup_test_stack(stack_name)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        network_name \u003d \u0027public\u0027"},{"line_number":375,"context_line":"        # create an server with non exist image Id"},{"line_number":376,"context_line":"        t[\u0027Resources\u0027][\u0027WebServer\u0027][\u0027Properties\u0027][\u0027networks\u0027] \u003d ("},{"line_number":377,"context_line":"            [{\u0027uuid\u0027: \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027,"},{"line_number":378,"context_line":"              \u0027network\u0027: network_name}])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9rbw%3D","line":375,"updated":"2013-12-08 09:44:24.000000000","message":"Typos, should be \"create a server with non-existent image Id\"","commit_id":"333f4fcc610f496c09fc834f7ee8fe17021cdeba"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"325ac896e2054e3f66ca2882c386e5ec35dc6f58","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        (t, stack) \u003d self._setup_test_stack(stack_name)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        network_name \u003d \u0027public\u0027"},{"line_number":375,"context_line":"        # create an server with non exist image Id"},{"line_number":376,"context_line":"        t[\u0027Resources\u0027][\u0027WebServer\u0027][\u0027Properties\u0027][\u0027networks\u0027] \u003d ("},{"line_number":377,"context_line":"            [{\u0027uuid\u0027: \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027,"},{"line_number":378,"context_line":"              \u0027network\u0027: network_name}])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9o%2Bw%3D","line":375,"in_reply_to":"AAAATn%2F9rbw%3D","updated":"2013-12-09 12:49:26.000000000","message":"I will fix this comment.","commit_id":"333f4fcc610f496c09fc834f7ee8fe17021cdeba"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"e5f134ec72e42f9da522fc81330eeccd000fac50","unresolved":false,"context_lines":[{"line_number":992,"context_line":"        return_server \u003d self.fc.servers.list()[1]"},{"line_number":993,"context_line":"        server \u003d self._create_test_server(return_server,"},{"line_number":994,"context_line":"                                          \u0027test_server_create\u0027)"},{"line_number":995,"context_line":"        self.assertEqual(None, server._build_nics([]))"},{"line_number":996,"context_line":"        self.assertEqual(None, server._build_nics(None))"},{"line_number":997,"context_line":"        self.assertEqual([{\u0027port-id\u0027: \u0027aaaabbbb\u0027},"},{"line_number":998,"context_line":"                          {\u0027v4-fixed-ip\u0027: \u0027192.0.2.0\u0027}],"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9rbo%3D","line":995,"updated":"2013-12-08 09:44:24.000000000","message":"This and next line: Comparison to None should be with assertIsNone","commit_id":"333f4fcc610f496c09fc834f7ee8fe17021cdeba"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"325ac896e2054e3f66ca2882c386e5ec35dc6f58","unresolved":false,"context_lines":[{"line_number":992,"context_line":"        return_server \u003d self.fc.servers.list()[1]"},{"line_number":993,"context_line":"        server \u003d self._create_test_server(return_server,"},{"line_number":994,"context_line":"                                          \u0027test_server_create\u0027)"},{"line_number":995,"context_line":"        self.assertEqual(None, server._build_nics([]))"},{"line_number":996,"context_line":"        self.assertEqual(None, server._build_nics(None))"},{"line_number":997,"context_line":"        self.assertEqual([{\u0027port-id\u0027: \u0027aaaabbbb\u0027},"},{"line_number":998,"context_line":"                          {\u0027v4-fixed-ip\u0027: \u0027192.0.2.0\u0027}],"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9pAc%3D","line":995,"in_reply_to":"AAAATn%2F9rbo%3D","updated":"2013-12-09 12:49:26.000000000","message":"It is original code. It should be fixed in separate patch. \nIt is task for this bug:\nhttps://bugs.launchpad.net/heat/+bug/1259023","commit_id":"333f4fcc610f496c09fc834f7ee8fe17021cdeba"}]}