)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"a61009d61e87cd476d34b7f79492307e451b9070","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pablo Andres Fuente \u003cpablo.a.fuente@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-12 14:45:52 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OS::Neutron::Router needs property \u0027tenant_id\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added the tenant_id property to OS::Neutron::Router"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F868w%3D","line":7,"updated":"2013-12-18 19:11:29.000000000","message":"Please describe the change in the headline, not the problem (delete this line and the commit message is great).\n\nObligatory: https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"a1f1b4cd3c98f174c1e7afe7eeafa25020acbace"}],"heat/tests/test_neutron.py":[{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"1d693ebcdfd6242565ae282b3c1223a9a9a7616d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \"router\": {"},{"line_number":91,"context_line":"      \"Type\": \"OS::Neutron::Router\""},{"line_number":92,"context_line":"    },"},{"line_number":93,"context_line":"    \"routerTenantId\": {"},{"line_number":94,"context_line":"      \"Type\": \"OS::Neutron::Router\","},{"line_number":95,"context_line":"      \"Properties\": {"},{"line_number":96,"context_line":"        \"tenant_id\": \"3e21026f2dc94372b105808c0e721661\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9rtQ%3D","line":93,"updated":"2013-12-07 23:47:38.000000000","message":"To keep the naming consistent suggesting to change the name to something like router_tenant_id","commit_id":"c1bdd8f2c0a5df3a034c91cd44fcb055a75333f8"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"1d693ebcdfd6242565ae282b3c1223a9a9a7616d","unresolved":false,"context_lines":[{"line_number":706,"context_line":"            fakes.FakeKeystoneClient())"},{"line_number":707,"context_line":"        neutronclient.Client.create_router({"},{"line_number":708,"context_line":"            \u0027router\u0027: {"},{"line_number":709,"context_line":"                \u0027name\u0027: utils.PhysName(\u0027test_stack\u0027, \u0027router\u0027),"},{"line_number":710,"context_line":"                \u0027admin_state_up\u0027: True,"},{"line_number":711,"context_line":"            }"},{"line_number":712,"context_line":"        }).AndReturn({"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9rtE%3D","line":709,"updated":"2013-12-07 23:47:38.000000000","message":"Instead of creating the new big test function \u0027test_router_tenant_id\n\u0027, isn\u0027t that just adding \u0027tenant_id\u0027: here takes care of the required test?","commit_id":"c1bdd8f2c0a5df3a034c91cd44fcb055a75333f8"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"1d693ebcdfd6242565ae282b3c1223a9a9a7616d","unresolved":false,"context_lines":[{"line_number":797,"context_line":"        self.m.ReplayAll()"},{"line_number":798,"context_line":"        t \u003d template_format.parse(neutron_template)"},{"line_number":799,"context_line":"        stack \u003d utils.parse_stack(t)"},{"line_number":800,"context_line":"        rsrc \u003d self.create_router(\u0027router\u0027, t, stack, \u0027router\u0027)"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"        rsrc.validate()"},{"line_number":803,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9rtY%3D","line":800,"updated":"2013-12-07 23:47:38.000000000","message":"value \u0027router\u0027 is now passed twice, for better readability I would suggest to rename the new value.","commit_id":"c1bdd8f2c0a5df3a034c91cd44fcb055a75333f8"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"c9c3e693416f5cf83c70e682d76b3cec0e5a8eac","unresolved":false,"context_lines":[{"line_number":673,"context_line":"        utils.setup_dummy_db()"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def create_router(self, name, t, stack, resource_name):"},{"line_number":676,"context_line":"        rsrc \u003d router.Router(name, t[\u0027Resources\u0027][resource_name], stack)"},{"line_number":677,"context_line":"        scheduler.TaskRunner(rsrc.create)()"},{"line_number":678,"context_line":"        self.assertEqual((rsrc.CREATE, rsrc.COMPLETE), rsrc.state)"},{"line_number":679,"context_line":"        return rsrc"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9ocg%3D","line":676,"updated":"2013-12-09 14:30:30.000000000","message":"I think, that current changes is not necessary. \nAs I can see in previous patch set, they were needed for creation router with different templates.","commit_id":"1a047e5dba949ece31f836716eea31b21a1a42d1"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"c9c3e693416f5cf83c70e682d76b3cec0e5a8eac","unresolved":false,"context_lines":[{"line_number":809,"context_line":"        update_snippet \u003d {"},{"line_number":810,"context_line":"            \"Type\": \"OS::Neutron::Router\","},{"line_number":811,"context_line":"            \"Properties\": {"},{"line_number":812,"context_line":"                \"admin_state_up\": False,"},{"line_number":813,"context_line":"                \"name\": \"myrouter\""},{"line_number":814,"context_line":"            }"},{"line_number":815,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9obo%3D","line":812,"updated":"2013-12-09 14:30:30.000000000","message":"Also you could add tenat_id in current place, for checking, that it is not allowed for update.","commit_id":"1a047e5dba949ece31f836716eea31b21a1a42d1"}]}
