)]}'
{"heat/engine/parameters.py":[{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"ab6e7955a103f68187a855b36103004574f2c366","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        if isinstance(val, collections.Mapping):"},{"line_number":297,"context_line":"            try:"},{"line_number":298,"context_line":"                val \u003d json.dumps(val)"},{"line_number":299,"context_line":"                self.user_value \u003d val"},{"line_number":300,"context_line":"            except (ValueError, TypeError) as err:"},{"line_number":301,"context_line":"                message \u003d _(\u0027Value must be valid JSON\u0027)"},{"line_number":302,"context_line":"                raise ValueError(\"%s: %s\" % (message, str(err)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9iGo%3D","side":"PARENT","line":299,"updated":"2013-12-10 14:45:44.000000000","message":"It looks that apart from the validation, there is a side effect here - self.user_value is changed. But it doesn\u0027t seem to break anything.","commit_id":"a2da560ad5b622902848a2c5726703ce639ba355"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"7cf0257c5b378a6302658a6b36b87f8b5baea72c","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        if isinstance(val, collections.Mapping):"},{"line_number":297,"context_line":"            try:"},{"line_number":298,"context_line":"                val \u003d json.dumps(val)"},{"line_number":299,"context_line":"                self.user_value \u003d val"},{"line_number":300,"context_line":"            except (ValueError, TypeError) as err:"},{"line_number":301,"context_line":"                message \u003d _(\u0027Value must be valid JSON\u0027)"},{"line_number":302,"context_line":"                raise ValueError(\"%s: %s\" % (message, str(err)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9hrY%3D","side":"PARENT","line":299,"in_reply_to":"AAAATn%2F9iGo%3D","updated":"2013-12-10 15:34:33.000000000","message":"self.user_value assignment is for performance consideration. so no need dumps again and again when user call values().","commit_id":"a2da560ad5b622902848a2c5726703ce639ba355"}]}